* [PATCH] mm/vmalloc.c: Fix potential memory leak
@ 2021-01-07 12:35 Miaohe Lin
2021-01-07 13:14 ` Uladzislau Rezki
0 siblings, 1 reply; 2+ messages in thread
From: Miaohe Lin @ 2021-01-07 12:35 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, linmiaohe
In VM_MAP_PUT_PAGES case, we should put pages and free array in vfree. But
we missed to set area->nr_pages in vmap(). So we would failed to put pages
in __vunmap() because area->nr_pages = 0.
Fixes: b944afc9d64d ("mm: add a VM_MAP_PUT_PAGES flag for vmap")
Signed-off-by: Shijie Luo <luoshijie1@huawei.com>
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: <stable@vger.kernel.org>
---
mm/vmalloc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 6507a579ff88..8ab83fbecadd 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -2421,8 +2421,10 @@ void *vmap(struct page **pages, unsigned int count,
return NULL;
}
- if (flags & VM_MAP_PUT_PAGES)
+ if (flags & VM_MAP_PUT_PAGES) {
area->pages = pages;
+ area->nr_pages = count;
+ }
return area->addr;
}
EXPORT_SYMBOL(vmap);
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/vmalloc.c: Fix potential memory leak
2021-01-07 12:35 [PATCH] mm/vmalloc.c: Fix potential memory leak Miaohe Lin
@ 2021-01-07 13:14 ` Uladzislau Rezki
0 siblings, 0 replies; 2+ messages in thread
From: Uladzislau Rezki @ 2021-01-07 13:14 UTC (permalink / raw)
To: Miaohe Lin; +Cc: akpm, linux-mm, linux-kernel
> In VM_MAP_PUT_PAGES case, we should put pages and free array in vfree. But
> we missed to set area->nr_pages in vmap(). So we would failed to put pages
> in __vunmap() because area->nr_pages = 0.
>
> Fixes: b944afc9d64d ("mm: add a VM_MAP_PUT_PAGES flag for vmap")
> Signed-off-by: Shijie Luo <luoshijie1@huawei.com>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> Cc: <stable@vger.kernel.org>
> ---
> mm/vmalloc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 6507a579ff88..8ab83fbecadd 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -2421,8 +2421,10 @@ void *vmap(struct page **pages, unsigned int count,
> return NULL;
> }
>
> - if (flags & VM_MAP_PUT_PAGES)
> + if (flags & VM_MAP_PUT_PAGES) {
> area->pages = pages;
> + area->nr_pages = count;
> + }
> return area->addr;
> }
> EXPORT_SYMBOL(vmap);
> --
> 2.19.1
>
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
--
Vlad Rezki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-07 13:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 12:35 [PATCH] mm/vmalloc.c: Fix potential memory leak Miaohe Lin
2021-01-07 13:14 ` Uladzislau Rezki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.