* [OE-core][PATCH] go.bbclass: don't stage test data with sources of dependencies
@ 2021-01-07 18:02 tperrot
2021-01-07 20:43 ` [oe] " Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: tperrot @ 2021-01-07 18:02 UTC (permalink / raw)
To: openembedded-devel; +Cc: Thomas Perrot
From: Thomas Perrot <thomas.perrot@bootlin.com>
As for the sources the dependencies contain test data, ELF files and other
binaries which aren't necessary for building and which lead to unnecessary QA
warnings.
Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
---
meta/classes/go.bbclass | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/classes/go.bbclass b/meta/classes/go.bbclass
index 5b26378a4e..fa147892b0 100644
--- a/meta/classes/go.bbclass
+++ b/meta/classes/go.bbclass
@@ -116,7 +116,8 @@ go_do_install() {
install -d ${D}${libdir}/go/src/${GO_IMPORT}
tar -C ${S}/src/${GO_IMPORT} -cf - --exclude-vcs --exclude '*.test' --exclude 'testdata' . | \
tar -C ${D}${libdir}/go/src/${GO_IMPORT} --no-same-owner -xf -
- tar -C ${B} -cf - --exclude-vcs pkg | tar -C ${D}${libdir}/go --no-same-owner -xf -
+ tar -C ${B} -cf - --exclude-vcs --exclude '*.test' --exclude 'testdata' pkg | \
+ tar -C ${D}${libdir}/go --no-same-owner -xf -
if [ -n "`ls ${B}/${GO_BUILD_BINDIR}/`" ]; then
install -d ${D}${bindir}
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [oe] [OE-core][PATCH] go.bbclass: don't stage test data with sources of dependencies
2021-01-07 18:02 [OE-core][PATCH] go.bbclass: don't stage test data with sources of dependencies tperrot
@ 2021-01-07 20:43 ` Khem Raj
2021-01-08 6:21 ` Thomas Perrot
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2021-01-07 20:43 UTC (permalink / raw)
To: tperrot, openembedded-devel; +Cc: Thomas Perrot
Hi Thomas
This needs to go into openembedded-core mailing list.
On 1/7/21 10:02 AM, tperrot wrote:
> From: Thomas Perrot <thomas.perrot@bootlin.com>
>
> As for the sources the dependencies contain test data, ELF files and other
> binaries which aren't necessary for building and which lead to unnecessary QA
> warnings.
>
> Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> ---
> meta/classes/go.bbclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/go.bbclass b/meta/classes/go.bbclass
> index 5b26378a4e..fa147892b0 100644
> --- a/meta/classes/go.bbclass
> +++ b/meta/classes/go.bbclass
> @@ -116,7 +116,8 @@ go_do_install() {
> install -d ${D}${libdir}/go/src/${GO_IMPORT}
> tar -C ${S}/src/${GO_IMPORT} -cf - --exclude-vcs --exclude '*.test' --exclude 'testdata' . | \
> tar -C ${D}${libdir}/go/src/${GO_IMPORT} --no-same-owner -xf -
> - tar -C ${B} -cf - --exclude-vcs pkg | tar -C ${D}${libdir}/go --no-same-owner -xf -
> + tar -C ${B} -cf - --exclude-vcs --exclude '*.test' --exclude 'testdata' pkg | \
> + tar -C ${D}${libdir}/go --no-same-owner -xf -
>
> if [ -n "`ls ${B}/${GO_BUILD_BINDIR}/`" ]; then
> install -d ${D}${bindir}
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [oe] [OE-core][PATCH] go.bbclass: don't stage test data with sources of dependencies
2021-01-07 20:43 ` [oe] " Khem Raj
@ 2021-01-08 6:21 ` Thomas Perrot
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Perrot @ 2021-01-08 6:21 UTC (permalink / raw)
To: Khem Raj, tperrot, openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]
Hi Khem,
On Thu, 2021-01-07 at 12:43 -0800, Khem Raj wrote:
> Hi Thomas
>
> This needs to go into openembedded-core mailing list.
>
Thank you and sorry for my mistake.
Best regards,
Thomas
> On 1/7/21 10:02 AM, tperrot wrote:
> > From: Thomas Perrot <thomas.perrot@bootlin.com>
> >
> > As for the sources the dependencies contain test data, ELF files
> > and other
> > binaries which aren't necessary for building and which lead to
> > unnecessary QA
> > warnings.
> >
> > Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> > ---
> > meta/classes/go.bbclass | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/go.bbclass b/meta/classes/go.bbclass
> > index 5b26378a4e..fa147892b0 100644
> > --- a/meta/classes/go.bbclass
> > +++ b/meta/classes/go.bbclass
> > @@ -116,7 +116,8 @@ go_do_install() {
> > install -d ${D}${libdir}/go/src/${GO_IMPORT}
> > tar -C ${S}/src/${GO_IMPORT} -cf - --exclude-vcs --exclude
> > '*.test' --exclude 'testdata' . | \
> > tar -C ${D}${libdir}/go/src/${GO_IMPORT} --no-same-
> > owner -xf -
> > - tar -C ${B} -cf - --exclude-vcs pkg | tar -C
> > ${D}${libdir}/go --no-same-owner -xf -
> > + tar -C ${B} -cf - --exclude-vcs --exclude '*.test' --
> > exclude 'testdata' pkg | \
> > + tar -C ${D}${libdir}/go --no-same-owner -xf -
> >
> > if [ -n "`ls ${B}/${GO_BUILD_BINDIR}/`" ]; then
> > install -d ${D}${bindir}
> >
> >
> >
> >
> >
--
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 673 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [OE-core][PATCH] go.bbclass: don't stage test data with sources of dependencies
@ 2021-01-08 6:22 tperrot
0 siblings, 0 replies; 4+ messages in thread
From: tperrot @ 2021-01-08 6:22 UTC (permalink / raw)
To: openembedded-core; +Cc: Thomas Perrot
From: Thomas Perrot <thomas.perrot@bootlin.com>
As for the sources the dependencies contain test data, ELF files and other
binaries which aren't necessary for building and which lead to unnecessary QA
warnings.
Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
---
meta/classes/go.bbclass | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/classes/go.bbclass b/meta/classes/go.bbclass
index 5b26378a4e..fa147892b0 100644
--- a/meta/classes/go.bbclass
+++ b/meta/classes/go.bbclass
@@ -116,7 +116,8 @@ go_do_install() {
install -d ${D}${libdir}/go/src/${GO_IMPORT}
tar -C ${S}/src/${GO_IMPORT} -cf - --exclude-vcs --exclude '*.test' --exclude 'testdata' . | \
tar -C ${D}${libdir}/go/src/${GO_IMPORT} --no-same-owner -xf -
- tar -C ${B} -cf - --exclude-vcs pkg | tar -C ${D}${libdir}/go --no-same-owner -xf -
+ tar -C ${B} -cf - --exclude-vcs --exclude '*.test' --exclude 'testdata' pkg | \
+ tar -C ${D}${libdir}/go --no-same-owner -xf -
if [ -n "`ls ${B}/${GO_BUILD_BINDIR}/`" ]; then
install -d ${D}${bindir}
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-08 6:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 18:02 [OE-core][PATCH] go.bbclass: don't stage test data with sources of dependencies tperrot
2021-01-07 20:43 ` [oe] " Khem Raj
2021-01-08 6:21 ` Thomas Perrot
2021-01-08 6:22 tperrot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.