* [PATCH] dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified
@ 2021-01-08 12:28 ` Jonathan Neuschäfer
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Neuschäfer @ 2021-01-08 12:28 UTC (permalink / raw)
To: devicetree
Cc: Jonathan Neuschäfer, Avi Fishman, Tomer Maimon, Tali Perry,
Patrick Venture, Nancy Yuen, Benjamin Fair, Daniel Lezcano,
Thomas Gleixner, Rob Herring, openbmc, linux-kernel
The NPCM750 Timer/Watchdoc Controller has multiple interrupt lines,
connected to multiple timers. The driver uses timer 0 for timer
interrupts, so the interrupt line corresponding to timer 0 should be
specified in DT.
I removed the mention of "flags for falling edge", because the timer
controller uses high-level interrupts rather than falling-edge
interrupts, and whether flags should be specified is up the interrupt
controller's DT binding.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
.../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
index ea22dfe485bee..97258f1a1505b 100644
--- a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
+++ b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
@@ -6,8 +6,7 @@ timer counters.
Required properties:
- compatible : "nuvoton,npcm750-timer" for Poleg NPCM750.
- reg : Offset and length of the register set for the device.
-- interrupts : Contain the timer interrupt with flags for
- falling edge.
+- interrupts : Contain the timer interrupt of timer 0.
- clocks : phandle of timer reference clock (usually a 25 MHz clock).
Example:
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified
@ 2021-01-08 12:28 ` Jonathan Neuschäfer
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Neuschäfer @ 2021-01-08 12:28 UTC (permalink / raw)
To: devicetree
Cc: Tomer Maimon, Avi Fishman, Patrick Venture, openbmc,
Daniel Lezcano, Jonathan Neuschäfer, Tali Perry,
Rob Herring, Thomas Gleixner, linux-kernel, Benjamin Fair
The NPCM750 Timer/Watchdoc Controller has multiple interrupt lines,
connected to multiple timers. The driver uses timer 0 for timer
interrupts, so the interrupt line corresponding to timer 0 should be
specified in DT.
I removed the mention of "flags for falling edge", because the timer
controller uses high-level interrupts rather than falling-edge
interrupts, and whether flags should be specified is up the interrupt
controller's DT binding.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
.../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
index ea22dfe485bee..97258f1a1505b 100644
--- a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
+++ b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
@@ -6,8 +6,7 @@ timer counters.
Required properties:
- compatible : "nuvoton,npcm750-timer" for Poleg NPCM750.
- reg : Offset and length of the register set for the device.
-- interrupts : Contain the timer interrupt with flags for
- falling edge.
+- interrupts : Contain the timer interrupt of timer 0.
- clocks : phandle of timer reference clock (usually a 25 MHz clock).
Example:
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified
2021-01-08 12:28 ` Jonathan Neuschäfer
@ 2021-01-08 12:41 ` Jonathan Neuschäfer
-1 siblings, 0 replies; 4+ messages in thread
From: Jonathan Neuschäfer @ 2021-01-08 12:41 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: devicetree, Avi Fishman, Tomer Maimon, Tali Perry,
Patrick Venture, Nancy Yuen, Benjamin Fair, Daniel Lezcano,
Thomas Gleixner, Rob Herring, openbmc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]
On Fri, Jan 08, 2021 at 01:28:03PM +0100, Jonathan Neuschäfer wrote:
> The NPCM750 Timer/Watchdoc Controller has multiple interrupt lines,
^^^^^^^^
oops, that's a typo.
> connected to multiple timers. The driver uses timer 0 for timer
> interrupts, so the interrupt line corresponding to timer 0 should be
> specified in DT.
>
> I removed the mention of "flags for falling edge", because the timer
> controller uses high-level interrupts rather than falling-edge
> interrupts, and whether flags should be specified is up the interrupt
> controller's DT binding.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
> .../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
> index ea22dfe485bee..97258f1a1505b 100644
> --- a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
> +++ b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
> @@ -6,8 +6,7 @@ timer counters.
> Required properties:
> - compatible : "nuvoton,npcm750-timer" for Poleg NPCM750.
> - reg : Offset and length of the register set for the device.
> -- interrupts : Contain the timer interrupt with flags for
> - falling edge.
> +- interrupts : Contain the timer interrupt of timer 0.
> - clocks : phandle of timer reference clock (usually a 25 MHz clock).
>
> Example:
> --
> 2.29.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified
@ 2021-01-08 12:41 ` Jonathan Neuschäfer
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Neuschäfer @ 2021-01-08 12:41 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: devicetree, Tomer Maimon, Avi Fishman, Patrick Venture, openbmc,
Daniel Lezcano, linux-kernel, Tali Perry, Rob Herring,
Thomas Gleixner, Benjamin Fair
[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]
On Fri, Jan 08, 2021 at 01:28:03PM +0100, Jonathan Neuschäfer wrote:
> The NPCM750 Timer/Watchdoc Controller has multiple interrupt lines,
^^^^^^^^
oops, that's a typo.
> connected to multiple timers. The driver uses timer 0 for timer
> interrupts, so the interrupt line corresponding to timer 0 should be
> specified in DT.
>
> I removed the mention of "flags for falling edge", because the timer
> controller uses high-level interrupts rather than falling-edge
> interrupts, and whether flags should be specified is up the interrupt
> controller's DT binding.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
> .../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
> index ea22dfe485bee..97258f1a1505b 100644
> --- a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
> +++ b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
> @@ -6,8 +6,7 @@ timer counters.
> Required properties:
> - compatible : "nuvoton,npcm750-timer" for Poleg NPCM750.
> - reg : Offset and length of the register set for the device.
> -- interrupts : Contain the timer interrupt with flags for
> - falling edge.
> +- interrupts : Contain the timer interrupt of timer 0.
> - clocks : phandle of timer reference clock (usually a 25 MHz clock).
>
> Example:
> --
> 2.29.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-08 12:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-08 12:28 [PATCH] dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified Jonathan Neuschäfer
2021-01-08 12:28 ` Jonathan Neuschäfer
2021-01-08 12:41 ` Jonathan Neuschäfer
2021-01-08 12:41 ` Jonathan Neuschäfer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.