[PATCH 1/2] syscalls: add comments show the define file for aio

[PATCH 1/2] syscalls: add comments show the define file for aio

[yangerkun]

fs/aio.c define the syscalls for aio.

Signed-off-by: yangerkun <yangerkun@huawei.com>
---
 include/uapi/asm-generic/unistd.h       | 1 +
 tools/include/uapi/asm-generic/unistd.h | 1 +
 2 files changed, 2 insertions(+)

diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
index 728752917785..84022c87ed49 100644
--- a/include/uapi/asm-generic/unistd.h
+++ b/include/uapi/asm-generic/unistd.h
@@ -30,6 +30,7 @@
 #define __SC_COMP_3264(_nr, _32, _64, _comp) __SC_3264(_nr, _32, _64)
 #endif
 
+/* fs/aio.c */
 #define __NR_io_setup 0
 __SC_COMP(__NR_io_setup, sys_io_setup, compat_sys_io_setup)
 #define __NR_io_destroy 1
diff --git a/tools/include/uapi/asm-generic/unistd.h b/tools/include/uapi/asm-generic/unistd.h
index 728752917785..84022c87ed49 100644
--- a/tools/include/uapi/asm-generic/unistd.h
+++ b/tools/include/uapi/asm-generic/unistd.h
@@ -30,6 +30,7 @@
 #define __SC_COMP_3264(_nr, _32, _64, _comp) __SC_3264(_nr, _32, _64)
 #endif
 
+/* fs/aio.c */
 #define __NR_io_setup 0
 __SC_COMP(__NR_io_setup, sys_io_setup, compat_sys_io_setup)
 #define __NR_io_destroy 1
-- 
2.25.4

[PATCH 2/2] syscalls: fix define file comments for lookup_dcookie

[yangerkun]

The define file for lookup_dcookie is fs/dcookies.c, not fs/cookies.c

Signed-off-by: yangerkun <yangerkun@huawei.com>
---
 include/uapi/asm-generic/unistd.h       | 2 +-
 tools/include/uapi/asm-generic/unistd.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h
index 84022c87ed49..9886ff3337df 100644
--- a/include/uapi/asm-generic/unistd.h
+++ b/include/uapi/asm-generic/unistd.h
@@ -74,7 +74,7 @@ __SYSCALL(__NR_fremovexattr, sys_fremovexattr)
 #define __NR_getcwd 17
 __SYSCALL(__NR_getcwd, sys_getcwd)
 
-/* fs/cookies.c */
+/* fs/dcookies.c */
 #define __NR_lookup_dcookie 18
 __SC_COMP(__NR_lookup_dcookie, sys_lookup_dcookie, compat_sys_lookup_dcookie)
 
diff --git a/tools/include/uapi/asm-generic/unistd.h b/tools/include/uapi/asm-generic/unistd.h
index 84022c87ed49..9886ff3337df 100644
--- a/tools/include/uapi/asm-generic/unistd.h
+++ b/tools/include/uapi/asm-generic/unistd.h
@@ -74,7 +74,7 @@ __SYSCALL(__NR_fremovexattr, sys_fremovexattr)
 #define __NR_getcwd 17
 __SYSCALL(__NR_getcwd, sys_getcwd)
 
-/* fs/cookies.c */
+/* fs/dcookies.c */
 #define __NR_lookup_dcookie 18
 __SC_COMP(__NR_lookup_dcookie, sys_lookup_dcookie, compat_sys_lookup_dcookie)
 
-- 
2.25.4

Re: [PATCH 1/2] syscalls: add comments show the define file for aio

[Arnd Bergmann]

On Sat, Jan 9, 2021 at 7:58 AM yangerkun <yangerkun@huawei.com> wrote:
>
> fs/aio.c define the syscalls for aio.
>
> Signed-off-by: yangerkun <yangerkun@huawei.com>

This is obviously correct.

However, as Christoph Hellwig suggested the last time this came up
for include/linux/syscalls.h, let's maybe just remove all those comments
altogether.

What I really want to do with this file though, is to completely remove
it altogether and replace it with a syscall.tbl file as we have it in the
architectures that do not use the generic table.

If you or someone else wants to help out with that, I can point
you to the last version of the proposed patches for that from
a few years ago, and guide you through what else needs to be
done before it can get merged.

       Arnd