* [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
@ 2021-01-05 18:23 ` Christian König
0 siblings, 0 replies; 26+ messages in thread
From: Christian König @ 2021-01-05 18:23 UTC (permalink / raw)
To: bp, ray.huang; +Cc: amd-gfx, dri-devel
Drivers are not supposed to init the page pool directly any more.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
index d4328ff57757..35b715f82ed8 100644
--- a/drivers/gpu/drm/radeon/radeon_ttm.c
+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
}
rdev->mman.initialized = true;
- ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
- dma_addressing_limited(&rdev->pdev->dev));
-
r = radeon_ttm_init_vram(rdev);
if (r) {
DRM_ERROR("Failed initializing VRAM heap.\n");
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
@ 2021-01-05 18:23 ` Christian König
0 siblings, 0 replies; 26+ messages in thread
From: Christian König @ 2021-01-05 18:23 UTC (permalink / raw)
To: bp, ray.huang; +Cc: amd-gfx, dri-devel
Drivers are not supposed to init the page pool directly any more.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
index d4328ff57757..35b715f82ed8 100644
--- a/drivers/gpu/drm/radeon/radeon_ttm.c
+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
}
rdev->mman.initialized = true;
- ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
- dma_addressing_limited(&rdev->pdev->dev));
-
r = radeon_ttm_init_vram(rdev);
if (r) {
DRM_ERROR("Failed initializing VRAM heap.\n");
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 2/2] drm/ttm: unexport ttm_pool_init/fini
2021-01-05 18:23 ` Christian König
@ 2021-01-05 18:23 ` Christian König
-1 siblings, 0 replies; 26+ messages in thread
From: Christian König @ 2021-01-05 18:23 UTC (permalink / raw)
To: bp, ray.huang; +Cc: amd-gfx, dri-devel
Drivers are not supposed to use this directly any more.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/gpu/drm/ttm/ttm_pool.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c
index c81e6eb72da1..9089a047cb51 100644
--- a/drivers/gpu/drm/ttm/ttm_pool.c
+++ b/drivers/gpu/drm/ttm/ttm_pool.c
@@ -526,7 +526,6 @@ void ttm_pool_init(struct ttm_pool *pool, struct device *dev,
pool, i, j);
}
}
-EXPORT_SYMBOL(ttm_pool_init);
/**
* ttm_pool_fini - Cleanup a pool
@@ -546,7 +545,6 @@ void ttm_pool_fini(struct ttm_pool *pool)
ttm_pool_type_fini(&pool->caching[i].orders[j]);
}
}
-EXPORT_SYMBOL(ttm_pool_fini);
/* As long as pages are available make sure to release at least one */
static unsigned long ttm_pool_shrinker_scan(struct shrinker *shrink,
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 2/2] drm/ttm: unexport ttm_pool_init/fini
@ 2021-01-05 18:23 ` Christian König
0 siblings, 0 replies; 26+ messages in thread
From: Christian König @ 2021-01-05 18:23 UTC (permalink / raw)
To: bp, ray.huang; +Cc: amd-gfx, dri-devel
Drivers are not supposed to use this directly any more.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/gpu/drm/ttm/ttm_pool.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c
index c81e6eb72da1..9089a047cb51 100644
--- a/drivers/gpu/drm/ttm/ttm_pool.c
+++ b/drivers/gpu/drm/ttm/ttm_pool.c
@@ -526,7 +526,6 @@ void ttm_pool_init(struct ttm_pool *pool, struct device *dev,
pool, i, j);
}
}
-EXPORT_SYMBOL(ttm_pool_init);
/**
* ttm_pool_fini - Cleanup a pool
@@ -546,7 +545,6 @@ void ttm_pool_fini(struct ttm_pool *pool)
ttm_pool_type_fini(&pool->caching[i].orders[j]);
}
}
-EXPORT_SYMBOL(ttm_pool_fini);
/* As long as pages are available make sure to release at least one */
static unsigned long ttm_pool_shrinker_scan(struct shrinker *shrink,
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
2021-01-05 18:23 ` Christian König
@ 2021-01-06 6:35 ` Huang Rui
-1 siblings, 0 replies; 26+ messages in thread
From: Huang Rui @ 2021-01-06 6:35 UTC (permalink / raw)
To: Christian König; +Cc: bp, amd-gfx, dri-devel
On Wed, Jan 06, 2021 at 02:23:08AM +0800, Christian König wrote:
> Drivers are not supposed to init the page pool directly any more.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Series are Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index d4328ff57757..35b715f82ed8 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
> }
> rdev->mman.initialized = true;
>
> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
> - dma_addressing_limited(&rdev->pdev->dev));
> -
> r = radeon_ttm_init_vram(rdev);
> if (r) {
> DRM_ERROR("Failed initializing VRAM heap.\n");
> --
> 2.25.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
@ 2021-01-06 6:35 ` Huang Rui
0 siblings, 0 replies; 26+ messages in thread
From: Huang Rui @ 2021-01-06 6:35 UTC (permalink / raw)
To: Christian König; +Cc: bp, amd-gfx, dri-devel
On Wed, Jan 06, 2021 at 02:23:08AM +0800, Christian König wrote:
> Drivers are not supposed to init the page pool directly any more.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Series are Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index d4328ff57757..35b715f82ed8 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
> }
> rdev->mman.initialized = true;
>
> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
> - dma_addressing_limited(&rdev->pdev->dev));
> -
> r = radeon_ttm_init_vram(rdev);
> if (r) {
> DRM_ERROR("Failed initializing VRAM heap.\n");
> --
> 2.25.1
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
2021-01-05 18:23 ` Christian König
@ 2021-01-07 18:07 ` Daniel Vetter
-1 siblings, 0 replies; 26+ messages in thread
From: Daniel Vetter @ 2021-01-07 18:07 UTC (permalink / raw)
To: Christian König; +Cc: ray.huang, bp, dri-devel, amd-gfx
On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
> Drivers are not supposed to init the page pool directly any more.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Please include reported-by credits and link to the bug reports on
lore.kernel.org when merging this. Also I guess this should have a Fixes:
line?
And maybe some words on how/why stuff blows up.
-Daniel
> ---
> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index d4328ff57757..35b715f82ed8 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
> }
> rdev->mman.initialized = true;
>
> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
> - dma_addressing_limited(&rdev->pdev->dev));
> -
> r = radeon_ttm_init_vram(rdev);
> if (r) {
> DRM_ERROR("Failed initializing VRAM heap.\n");
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
@ 2021-01-07 18:07 ` Daniel Vetter
0 siblings, 0 replies; 26+ messages in thread
From: Daniel Vetter @ 2021-01-07 18:07 UTC (permalink / raw)
To: Christian König; +Cc: ray.huang, bp, dri-devel, amd-gfx
On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
> Drivers are not supposed to init the page pool directly any more.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Please include reported-by credits and link to the bug reports on
lore.kernel.org when merging this. Also I guess this should have a Fixes:
line?
And maybe some words on how/why stuff blows up.
-Daniel
> ---
> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index d4328ff57757..35b715f82ed8 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
> }
> rdev->mman.initialized = true;
>
> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
> - dma_addressing_limited(&rdev->pdev->dev));
> -
> r = radeon_ttm_init_vram(rdev);
> if (r) {
> DRM_ERROR("Failed initializing VRAM heap.\n");
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
2021-01-07 18:07 ` Daniel Vetter
@ 2021-01-07 20:08 ` Christian König
-1 siblings, 0 replies; 26+ messages in thread
From: Christian König @ 2021-01-07 20:08 UTC (permalink / raw)
To: Daniel Vetter; +Cc: ray.huang, bp, dri-devel, amd-gfx
Am 07.01.21 um 19:07 schrieb Daniel Vetter:
> On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
>> Drivers are not supposed to init the page pool directly any more.
>>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
> Please include reported-by credits and link to the bug reports on
> lore.kernel.org when merging this. Also I guess this should have a Fixes:
> line?
I'm not aware of a bug report, but the reported-by/Fixes lines are
indeed missing.
BTW: Any idea why dim add-link doesn't work?
> And maybe some words on how/why stuff blows up.
Just a typo. I've forgot to remove two lines in radeon while rebasing
and still had the symbols exported so never noticed this.
Christian.
> -Daniel
>
>> ---
>> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
>> index d4328ff57757..35b715f82ed8 100644
>> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
>> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
>> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
>> }
>> rdev->mman.initialized = true;
>>
>> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
>> - dma_addressing_limited(&rdev->pdev->dev));
>> -
>> r = radeon_ttm_init_vram(rdev);
>> if (r) {
>> DRM_ERROR("Failed initializing VRAM heap.\n");
>> --
>> 2.25.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
@ 2021-01-07 20:08 ` Christian König
0 siblings, 0 replies; 26+ messages in thread
From: Christian König @ 2021-01-07 20:08 UTC (permalink / raw)
To: Daniel Vetter; +Cc: ray.huang, bp, dri-devel, amd-gfx
Am 07.01.21 um 19:07 schrieb Daniel Vetter:
> On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
>> Drivers are not supposed to init the page pool directly any more.
>>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
> Please include reported-by credits and link to the bug reports on
> lore.kernel.org when merging this. Also I guess this should have a Fixes:
> line?
I'm not aware of a bug report, but the reported-by/Fixes lines are
indeed missing.
BTW: Any idea why dim add-link doesn't work?
> And maybe some words on how/why stuff blows up.
Just a typo. I've forgot to remove two lines in radeon while rebasing
and still had the symbols exported so never noticed this.
Christian.
> -Daniel
>
>> ---
>> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
>> index d4328ff57757..35b715f82ed8 100644
>> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
>> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
>> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
>> }
>> rdev->mman.initialized = true;
>>
>> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
>> - dma_addressing_limited(&rdev->pdev->dev));
>> -
>> r = radeon_ttm_init_vram(rdev);
>> if (r) {
>> DRM_ERROR("Failed initializing VRAM heap.\n");
>> --
>> 2.25.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
2021-01-07 20:08 ` Christian König
@ 2021-01-08 14:31 ` Daniel Vetter
-1 siblings, 0 replies; 26+ messages in thread
From: Daniel Vetter @ 2021-01-08 14:31 UTC (permalink / raw)
To: christian.koenig; +Cc: dri-devel, ray.huang, bp, amd-gfx
On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
> Am 07.01.21 um 19:07 schrieb Daniel Vetter:
> > On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
> > > Drivers are not supposed to init the page pool directly any more.
> > >
> > > Signed-off-by: Christian König <christian.koenig@amd.com>
> > Please include reported-by credits and link to the bug reports on
> > lore.kernel.org when merging this. Also I guess this should have a Fixes:
> > line?
>
> I'm not aware of a bug report, but the reported-by/Fixes lines are indeed
> missing.
This one here:
https://lore.kernel.org/dri-devel/20201231104020.GA4504@zn.tnic/
Or did I get confused, and the above is yet another bug?
> BTW: Any idea why dim add-link doesn't work?
Hm we occasionally have fun with email parsing (it's hard) and especially
python changes in how encodings are handled differently between python2
and python3. If you have a specific example I can try and take a look why
it doesn't work.
-Daniel
> > And maybe some words on how/why stuff blows up.
>
> Just a typo. I've forgot to remove two lines in radeon while rebasing and
> still had the symbols exported so never noticed this.
>
> Christian.
>
> > -Daniel
> >
> > > ---
> > > drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
> > > 1 file changed, 3 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> > > index d4328ff57757..35b715f82ed8 100644
> > > --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> > > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> > > @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
> > > }
> > > rdev->mman.initialized = true;
> > > - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
> > > - dma_addressing_limited(&rdev->pdev->dev));
> > > -
> > > r = radeon_ttm_init_vram(rdev);
> > > if (r) {
> > > DRM_ERROR("Failed initializing VRAM heap.\n");
> > > --
> > > 2.25.1
> > >
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
@ 2021-01-08 14:31 ` Daniel Vetter
0 siblings, 0 replies; 26+ messages in thread
From: Daniel Vetter @ 2021-01-08 14:31 UTC (permalink / raw)
To: christian.koenig; +Cc: dri-devel, ray.huang, bp, amd-gfx, Daniel Vetter
On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
> Am 07.01.21 um 19:07 schrieb Daniel Vetter:
> > On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
> > > Drivers are not supposed to init the page pool directly any more.
> > >
> > > Signed-off-by: Christian König <christian.koenig@amd.com>
> > Please include reported-by credits and link to the bug reports on
> > lore.kernel.org when merging this. Also I guess this should have a Fixes:
> > line?
>
> I'm not aware of a bug report, but the reported-by/Fixes lines are indeed
> missing.
This one here:
https://lore.kernel.org/dri-devel/20201231104020.GA4504@zn.tnic/
Or did I get confused, and the above is yet another bug?
> BTW: Any idea why dim add-link doesn't work?
Hm we occasionally have fun with email parsing (it's hard) and especially
python changes in how encodings are handled differently between python2
and python3. If you have a specific example I can try and take a look why
it doesn't work.
-Daniel
> > And maybe some words on how/why stuff blows up.
>
> Just a typo. I've forgot to remove two lines in radeon while rebasing and
> still had the symbols exported so never noticed this.
>
> Christian.
>
> > -Daniel
> >
> > > ---
> > > drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
> > > 1 file changed, 3 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> > > index d4328ff57757..35b715f82ed8 100644
> > > --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> > > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> > > @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
> > > }
> > > rdev->mman.initialized = true;
> > > - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
> > > - dma_addressing_limited(&rdev->pdev->dev));
> > > -
> > > r = radeon_ttm_init_vram(rdev);
> > > if (r) {
> > > DRM_ERROR("Failed initializing VRAM heap.\n");
> > > --
> > > 2.25.1
> > >
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
2021-01-08 14:31 ` Daniel Vetter
@ 2021-01-08 14:36 ` Christian König
-1 siblings, 0 replies; 26+ messages in thread
From: Christian König @ 2021-01-08 14:36 UTC (permalink / raw)
To: Daniel Vetter; +Cc: ray.huang, bp, dri-devel, amd-gfx
Am 08.01.21 um 15:31 schrieb Daniel Vetter:
> On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
>> Am 07.01.21 um 19:07 schrieb Daniel Vetter:
>>> On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
>>>> Drivers are not supposed to init the page pool directly any more.
>>>>
>>>> Signed-off-by: Christian König <christian.koenig@amd.com>
>>> Please include reported-by credits and link to the bug reports on
>>> lore.kernel.org when merging this. Also I guess this should have a Fixes:
>>> line?
>> I'm not aware of a bug report, but the reported-by/Fixes lines are indeed
>> missing.
> This one here:
>
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fdri-devel%2F20201231104020.GA4504%40zn.tnic%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C3aede203348b4f32ea3108d8b3e224ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637457131179258488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=bHVw4lj1f8g4ohVTeuKNkb0LAbLwY6N4KWortr3VtAo%3D&reserved=0
>
> Or did I get confused, and the above is yet another bug?
Yeah, but that was just reported by mail. The bug tracker I've saw was
opened after the patch was already pushed.
>
>> BTW: Any idea why dim add-link doesn't work?
> Hm we occasionally have fun with email parsing (it's hard) and especially
> python changes in how encodings are handled differently between python2
> and python3. If you have a specific example I can try and take a look why
> it doesn't work.
It just looks up and doesn't seem to do anything. I'm not familiar with
python so I can just describe the symptoms.
Christian.
> -Daniel
>
>>> And maybe some words on how/why stuff blows up.
>> Just a typo. I've forgot to remove two lines in radeon while rebasing and
>> still had the symbols exported so never noticed this.
>>
>> Christian.
>>
>>> -Daniel
>>>
>>>> ---
>>>> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
>>>> 1 file changed, 3 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
>>>> index d4328ff57757..35b715f82ed8 100644
>>>> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
>>>> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
>>>> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
>>>> }
>>>> rdev->mman.initialized = true;
>>>> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
>>>> - dma_addressing_limited(&rdev->pdev->dev));
>>>> -
>>>> r = radeon_ttm_init_vram(rdev);
>>>> if (r) {
>>>> DRM_ERROR("Failed initializing VRAM heap.\n");
>>>> --
>>>> 2.25.1
>>>>
>>>> _______________________________________________
>>>> dri-devel mailing list
>>>> dri-devel@lists.freedesktop.org
>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7Cchristian.koenig%40amd.com%7C3aede203348b4f32ea3108d8b3e224ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637457131179258488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pHzuAsJcXf5HlAfJ7wYYc%2BsizZhSLBGWXBhCyVNRCfo%3D&reserved=0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
@ 2021-01-08 14:36 ` Christian König
0 siblings, 0 replies; 26+ messages in thread
From: Christian König @ 2021-01-08 14:36 UTC (permalink / raw)
To: Daniel Vetter; +Cc: ray.huang, bp, dri-devel, amd-gfx
Am 08.01.21 um 15:31 schrieb Daniel Vetter:
> On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
>> Am 07.01.21 um 19:07 schrieb Daniel Vetter:
>>> On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
>>>> Drivers are not supposed to init the page pool directly any more.
>>>>
>>>> Signed-off-by: Christian König <christian.koenig@amd.com>
>>> Please include reported-by credits and link to the bug reports on
>>> lore.kernel.org when merging this. Also I guess this should have a Fixes:
>>> line?
>> I'm not aware of a bug report, but the reported-by/Fixes lines are indeed
>> missing.
> This one here:
>
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fdri-devel%2F20201231104020.GA4504%40zn.tnic%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C3aede203348b4f32ea3108d8b3e224ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637457131179258488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=bHVw4lj1f8g4ohVTeuKNkb0LAbLwY6N4KWortr3VtAo%3D&reserved=0
>
> Or did I get confused, and the above is yet another bug?
Yeah, but that was just reported by mail. The bug tracker I've saw was
opened after the patch was already pushed.
>
>> BTW: Any idea why dim add-link doesn't work?
> Hm we occasionally have fun with email parsing (it's hard) and especially
> python changes in how encodings are handled differently between python2
> and python3. If you have a specific example I can try and take a look why
> it doesn't work.
It just looks up and doesn't seem to do anything. I'm not familiar with
python so I can just describe the symptoms.
Christian.
> -Daniel
>
>>> And maybe some words on how/why stuff blows up.
>> Just a typo. I've forgot to remove two lines in radeon while rebasing and
>> still had the symbols exported so never noticed this.
>>
>> Christian.
>>
>>> -Daniel
>>>
>>>> ---
>>>> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
>>>> 1 file changed, 3 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
>>>> index d4328ff57757..35b715f82ed8 100644
>>>> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
>>>> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
>>>> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
>>>> }
>>>> rdev->mman.initialized = true;
>>>> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
>>>> - dma_addressing_limited(&rdev->pdev->dev));
>>>> -
>>>> r = radeon_ttm_init_vram(rdev);
>>>> if (r) {
>>>> DRM_ERROR("Failed initializing VRAM heap.\n");
>>>> --
>>>> 2.25.1
>>>>
>>>> _______________________________________________
>>>> dri-devel mailing list
>>>> dri-devel@lists.freedesktop.org
>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7Cchristian.koenig%40amd.com%7C3aede203348b4f32ea3108d8b3e224ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637457131179258488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pHzuAsJcXf5HlAfJ7wYYc%2BsizZhSLBGWXBhCyVNRCfo%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
2021-01-08 14:36 ` Christian König
@ 2021-01-08 15:53 ` Daniel Vetter
-1 siblings, 0 replies; 26+ messages in thread
From: Daniel Vetter @ 2021-01-08 15:53 UTC (permalink / raw)
To: Christian König; +Cc: Huang Rui, Borislav Petkov, dri-devel, amd-gfx list
On Fri, Jan 8, 2021 at 3:36 PM Christian König <christian.koenig@amd.com> wrote:
>
> Am 08.01.21 um 15:31 schrieb Daniel Vetter:
> > On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
> >> Am 07.01.21 um 19:07 schrieb Daniel Vetter:
> >>> On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
> >>>> Drivers are not supposed to init the page pool directly any more.
> >>>>
> >>>> Signed-off-by: Christian König <christian.koenig@amd.com>
> >>> Please include reported-by credits and link to the bug reports on
> >>> lore.kernel.org when merging this. Also I guess this should have a Fixes:
> >>> line?
> >> I'm not aware of a bug report, but the reported-by/Fixes lines are indeed
> >> missing.
> > This one here:
> >
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fdri-devel%2F20201231104020.GA4504%40zn.tnic%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C3aede203348b4f32ea3108d8b3e224ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637457131179258488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=bHVw4lj1f8g4ohVTeuKNkb0LAbLwY6N4KWortr3VtAo%3D&reserved=0
> >
> > Or did I get confused, and the above is yet another bug?
>
> Yeah, but that was just reported by mail. The bug tracker I've saw was
> opened after the patch was already pushed.
Still good to give reported-by credits for mailing list reports and
link to lore.kernel.org for the report, that's not just useful for
bugzilla reports.
> >> BTW: Any idea why dim add-link doesn't work?
> > Hm we occasionally have fun with email parsing (it's hard) and especially
> > python changes in how encodings are handled differently between python2
> > and python3. If you have a specific example I can try and take a look why
> > it doesn't work.
>
> It just looks up and doesn't seem to do anything. I'm not familiar with
> python so I can just describe the symptoms.
I meant tell me which mail (patchwork or lore) and I'll try to
reproduce and see what's maybe up.
-Daniel
>
> Christian.
>
> > -Daniel
> >
> >>> And maybe some words on how/why stuff blows up.
> >> Just a typo. I've forgot to remove two lines in radeon while rebasing and
> >> still had the symbols exported so never noticed this.
> >>
> >> Christian.
> >>
> >>> -Daniel
> >>>
> >>>> ---
> >>>> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
> >>>> 1 file changed, 3 deletions(-)
> >>>>
> >>>> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> >>>> index d4328ff57757..35b715f82ed8 100644
> >>>> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> >>>> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> >>>> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
> >>>> }
> >>>> rdev->mman.initialized = true;
> >>>> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
> >>>> - dma_addressing_limited(&rdev->pdev->dev));
> >>>> -
> >>>> r = radeon_ttm_init_vram(rdev);
> >>>> if (r) {
> >>>> DRM_ERROR("Failed initializing VRAM heap.\n");
> >>>> --
> >>>> 2.25.1
> >>>>
> >>>> _______________________________________________
> >>>> dri-devel mailing list
> >>>> dri-devel@lists.freedesktop.org
> >>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7Cchristian.koenig%40amd.com%7C3aede203348b4f32ea3108d8b3e224ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637457131179258488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pHzuAsJcXf5HlAfJ7wYYc%2BsizZhSLBGWXBhCyVNRCfo%3D&reserved=0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
@ 2021-01-08 15:53 ` Daniel Vetter
0 siblings, 0 replies; 26+ messages in thread
From: Daniel Vetter @ 2021-01-08 15:53 UTC (permalink / raw)
To: Christian König; +Cc: Huang Rui, Borislav Petkov, dri-devel, amd-gfx list
On Fri, Jan 8, 2021 at 3:36 PM Christian König <christian.koenig@amd.com> wrote:
>
> Am 08.01.21 um 15:31 schrieb Daniel Vetter:
> > On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
> >> Am 07.01.21 um 19:07 schrieb Daniel Vetter:
> >>> On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
> >>>> Drivers are not supposed to init the page pool directly any more.
> >>>>
> >>>> Signed-off-by: Christian König <christian.koenig@amd.com>
> >>> Please include reported-by credits and link to the bug reports on
> >>> lore.kernel.org when merging this. Also I guess this should have a Fixes:
> >>> line?
> >> I'm not aware of a bug report, but the reported-by/Fixes lines are indeed
> >> missing.
> > This one here:
> >
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fdri-devel%2F20201231104020.GA4504%40zn.tnic%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C3aede203348b4f32ea3108d8b3e224ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637457131179258488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=bHVw4lj1f8g4ohVTeuKNkb0LAbLwY6N4KWortr3VtAo%3D&reserved=0
> >
> > Or did I get confused, and the above is yet another bug?
>
> Yeah, but that was just reported by mail. The bug tracker I've saw was
> opened after the patch was already pushed.
Still good to give reported-by credits for mailing list reports and
link to lore.kernel.org for the report, that's not just useful for
bugzilla reports.
> >> BTW: Any idea why dim add-link doesn't work?
> > Hm we occasionally have fun with email parsing (it's hard) and especially
> > python changes in how encodings are handled differently between python2
> > and python3. If you have a specific example I can try and take a look why
> > it doesn't work.
>
> It just looks up and doesn't seem to do anything. I'm not familiar with
> python so I can just describe the symptoms.
I meant tell me which mail (patchwork or lore) and I'll try to
reproduce and see what's maybe up.
-Daniel
>
> Christian.
>
> > -Daniel
> >
> >>> And maybe some words on how/why stuff blows up.
> >> Just a typo. I've forgot to remove two lines in radeon while rebasing and
> >> still had the symbols exported so never noticed this.
> >>
> >> Christian.
> >>
> >>> -Daniel
> >>>
> >>>> ---
> >>>> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
> >>>> 1 file changed, 3 deletions(-)
> >>>>
> >>>> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> >>>> index d4328ff57757..35b715f82ed8 100644
> >>>> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> >>>> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> >>>> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
> >>>> }
> >>>> rdev->mman.initialized = true;
> >>>> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
> >>>> - dma_addressing_limited(&rdev->pdev->dev));
> >>>> -
> >>>> r = radeon_ttm_init_vram(rdev);
> >>>> if (r) {
> >>>> DRM_ERROR("Failed initializing VRAM heap.\n");
> >>>> --
> >>>> 2.25.1
> >>>>
> >>>> _______________________________________________
> >>>> dri-devel mailing list
> >>>> dri-devel@lists.freedesktop.org
> >>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7Cchristian.koenig%40amd.com%7C3aede203348b4f32ea3108d8b3e224ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637457131179258488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pHzuAsJcXf5HlAfJ7wYYc%2BsizZhSLBGWXBhCyVNRCfo%3D&reserved=0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
2021-01-05 18:23 ` Christian König
@ 2021-01-09 11:10 ` Borislav Petkov
-1 siblings, 0 replies; 26+ messages in thread
From: Borislav Petkov @ 2021-01-09 11:10 UTC (permalink / raw)
To: Christian König; +Cc: ray.huang, amd-gfx, dri-devel
On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
> Drivers are not supposed to init the page pool directly any more.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index d4328ff57757..35b715f82ed8 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
> }
> rdev->mman.initialized = true;
>
> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
> - dma_addressing_limited(&rdev->pdev->dev));
> -
> r = radeon_ttm_init_vram(rdev);
> if (r) {
> DRM_ERROR("Failed initializing VRAM heap.\n");
> --
Was finally able to test those during workstation hw maintenance so I
was able to install a new kernel and reboot.
Reported-by: Borislav Petkov <bp@suse.de>
Tested-by: Borislav Petkov <bp@suse.de>
Thanks for the fixes!
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
@ 2021-01-09 11:10 ` Borislav Petkov
0 siblings, 0 replies; 26+ messages in thread
From: Borislav Petkov @ 2021-01-09 11:10 UTC (permalink / raw)
To: Christian König; +Cc: ray.huang, amd-gfx, dri-devel
On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
> Drivers are not supposed to init the page pool directly any more.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index d4328ff57757..35b715f82ed8 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
> }
> rdev->mman.initialized = true;
>
> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
> - dma_addressing_limited(&rdev->pdev->dev));
> -
> r = radeon_ttm_init_vram(rdev);
> if (r) {
> DRM_ERROR("Failed initializing VRAM heap.\n");
> --
Was finally able to test those during workstation hw maintenance so I
was able to install a new kernel and reboot.
Reported-by: Borislav Petkov <bp@suse.de>
Tested-by: Borislav Petkov <bp@suse.de>
Thanks for the fixes!
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
2021-01-08 15:53 ` Daniel Vetter
@ 2021-01-11 10:16 ` Christian König
-1 siblings, 0 replies; 26+ messages in thread
From: Christian König @ 2021-01-11 10:16 UTC (permalink / raw)
To: Daniel Vetter, Christian König
Cc: Huang Rui, Borislav Petkov, amd-gfx list, dri-devel
Am 08.01.21 um 16:53 schrieb Daniel Vetter:
> On Fri, Jan 8, 2021 at 3:36 PM Christian König <christian.koenig@amd.com> wrote:
>> Am 08.01.21 um 15:31 schrieb Daniel Vetter:
>>> On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
>>>> Am 07.01.21 um 19:07 schrieb Daniel Vetter:
>>>>> On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
>>>>>> Drivers are not supposed to init the page pool directly any more.
>>>>>>
>>>>>> Signed-off-by: Christian König <christian.koenig@amd.com>
>>>>> Please include reported-by credits and link to the bug reports on
>>>>> lore.kernel.org when merging this. Also I guess this should have a Fixes:
>>>>> line?
>>>> I'm not aware of a bug report, but the reported-by/Fixes lines are indeed
>>>> missing.
>>> This one here:
>>>
>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fdri-devel%2F20201231104020.GA4504%40zn.tnic%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C3aede203348b4f32ea3108d8b3e224ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637457131179258488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=bHVw4lj1f8g4ohVTeuKNkb0LAbLwY6N4KWortr3VtAo%3D&reserved=0
>>>
>>> Or did I get confused, and the above is yet another bug?
>> Yeah, but that was just reported by mail. The bug tracker I've saw was
>> opened after the patch was already pushed.
> Still good to give reported-by credits for mailing list reports and
> link to lore.kernel.org for the report, that's not just useful for
> bugzilla reports.
That's indeed true, but I was distracted by the fact that drm-misc-fixes
wasn't up to date :)
Going to add that earlier next time.
>>>> BTW: Any idea why dim add-link doesn't work?
>>> Hm we occasionally have fun with email parsing (it's hard) and especially
>>> python changes in how encodings are handled differently between python2
>>> and python3. If you have a specific example I can try and take a look why
>>> it doesn't work.
>> It just looks up and doesn't seem to do anything. I'm not familiar with
>> python so I can just describe the symptoms.
> I meant tell me which mail (patchwork or lore) and I'll try to
> reproduce and see what's maybe up.
It doesn't seem to work in general. E.g. any patch I try I just don't
get any progress in over 10 Minutes.
Maybe some server is not responding?
Christian.
> -Daniel
>
>> Christian.
>>
>>> -Daniel
>>>
>>>>> And maybe some words on how/why stuff blows up.
>>>> Just a typo. I've forgot to remove two lines in radeon while rebasing and
>>>> still had the symbols exported so never noticed this.
>>>>
>>>> Christian.
>>>>
>>>>> -Daniel
>>>>>
>>>>>> ---
>>>>>> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
>>>>>> 1 file changed, 3 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
>>>>>> index d4328ff57757..35b715f82ed8 100644
>>>>>> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
>>>>>> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
>>>>>> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
>>>>>> }
>>>>>> rdev->mman.initialized = true;
>>>>>> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
>>>>>> - dma_addressing_limited(&rdev->pdev->dev));
>>>>>> -
>>>>>> r = radeon_ttm_init_vram(rdev);
>>>>>> if (r) {
>>>>>> DRM_ERROR("Failed initializing VRAM heap.\n");
>>>>>> --
>>>>>> 2.25.1
>>>>>>
>>>>>> _______________________________________________
>>>>>> dri-devel mailing list
>>>>>> dri-devel@lists.freedesktop.org
>>>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7Cchristian.koenig%40amd.com%7C3aede203348b4f32ea3108d8b3e224ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637457131179258488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pHzuAsJcXf5HlAfJ7wYYc%2BsizZhSLBGWXBhCyVNRCfo%3D&reserved=0
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
@ 2021-01-11 10:16 ` Christian König
0 siblings, 0 replies; 26+ messages in thread
From: Christian König @ 2021-01-11 10:16 UTC (permalink / raw)
To: Daniel Vetter, Christian König
Cc: Huang Rui, Borislav Petkov, amd-gfx list, dri-devel
Am 08.01.21 um 16:53 schrieb Daniel Vetter:
> On Fri, Jan 8, 2021 at 3:36 PM Christian König <christian.koenig@amd.com> wrote:
>> Am 08.01.21 um 15:31 schrieb Daniel Vetter:
>>> On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
>>>> Am 07.01.21 um 19:07 schrieb Daniel Vetter:
>>>>> On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
>>>>>> Drivers are not supposed to init the page pool directly any more.
>>>>>>
>>>>>> Signed-off-by: Christian König <christian.koenig@amd.com>
>>>>> Please include reported-by credits and link to the bug reports on
>>>>> lore.kernel.org when merging this. Also I guess this should have a Fixes:
>>>>> line?
>>>> I'm not aware of a bug report, but the reported-by/Fixes lines are indeed
>>>> missing.
>>> This one here:
>>>
>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fdri-devel%2F20201231104020.GA4504%40zn.tnic%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C3aede203348b4f32ea3108d8b3e224ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637457131179258488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=bHVw4lj1f8g4ohVTeuKNkb0LAbLwY6N4KWortr3VtAo%3D&reserved=0
>>>
>>> Or did I get confused, and the above is yet another bug?
>> Yeah, but that was just reported by mail. The bug tracker I've saw was
>> opened after the patch was already pushed.
> Still good to give reported-by credits for mailing list reports and
> link to lore.kernel.org for the report, that's not just useful for
> bugzilla reports.
That's indeed true, but I was distracted by the fact that drm-misc-fixes
wasn't up to date :)
Going to add that earlier next time.
>>>> BTW: Any idea why dim add-link doesn't work?
>>> Hm we occasionally have fun with email parsing (it's hard) and especially
>>> python changes in how encodings are handled differently between python2
>>> and python3. If you have a specific example I can try and take a look why
>>> it doesn't work.
>> It just looks up and doesn't seem to do anything. I'm not familiar with
>> python so I can just describe the symptoms.
> I meant tell me which mail (patchwork or lore) and I'll try to
> reproduce and see what's maybe up.
It doesn't seem to work in general. E.g. any patch I try I just don't
get any progress in over 10 Minutes.
Maybe some server is not responding?
Christian.
> -Daniel
>
>> Christian.
>>
>>> -Daniel
>>>
>>>>> And maybe some words on how/why stuff blows up.
>>>> Just a typo. I've forgot to remove two lines in radeon while rebasing and
>>>> still had the symbols exported so never noticed this.
>>>>
>>>> Christian.
>>>>
>>>>> -Daniel
>>>>>
>>>>>> ---
>>>>>> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
>>>>>> 1 file changed, 3 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
>>>>>> index d4328ff57757..35b715f82ed8 100644
>>>>>> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
>>>>>> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
>>>>>> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
>>>>>> }
>>>>>> rdev->mman.initialized = true;
>>>>>> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
>>>>>> - dma_addressing_limited(&rdev->pdev->dev));
>>>>>> -
>>>>>> r = radeon_ttm_init_vram(rdev);
>>>>>> if (r) {
>>>>>> DRM_ERROR("Failed initializing VRAM heap.\n");
>>>>>> --
>>>>>> 2.25.1
>>>>>>
>>>>>> _______________________________________________
>>>>>> dri-devel mailing list
>>>>>> dri-devel@lists.freedesktop.org
>>>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7Cchristian.koenig%40amd.com%7C3aede203348b4f32ea3108d8b3e224ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637457131179258488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pHzuAsJcXf5HlAfJ7wYYc%2BsizZhSLBGWXBhCyVNRCfo%3D&reserved=0
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
2021-01-11 10:16 ` Christian König
@ 2021-01-11 16:17 ` Daniel Vetter
-1 siblings, 0 replies; 26+ messages in thread
From: Daniel Vetter @ 2021-01-11 16:17 UTC (permalink / raw)
To: christian.koenig; +Cc: amd-gfx list, Huang Rui, Borislav Petkov, dri-devel
On Mon, Jan 11, 2021 at 11:16:13AM +0100, Christian König wrote:
> Am 08.01.21 um 16:53 schrieb Daniel Vetter:
> > On Fri, Jan 8, 2021 at 3:36 PM Christian König <christian.koenig@amd.com> wrote:
> > > Am 08.01.21 um 15:31 schrieb Daniel Vetter:
> > > > On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
> > > > > Am 07.01.21 um 19:07 schrieb Daniel Vetter:
> > > > > > On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
> > > > > > > Drivers are not supposed to init the page pool directly any more.
> > > > > > >
> > > > > > > Signed-off-by: Christian König <christian.koenig@amd.com>
> > > > > > Please include reported-by credits and link to the bug reports on
> > > > > > lore.kernel.org when merging this. Also I guess this should have a Fixes:
> > > > > > line?
> > > > > I'm not aware of a bug report, but the reported-by/Fixes lines are indeed
> > > > > missing.
> > > > This one here:
> > > >
> > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fdri-devel%2F20201231104020.GA4504%40zn.tnic%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C3aede203348b4f32ea3108d8b3e224ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637457131179258488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=bHVw4lj1f8g4ohVTeuKNkb0LAbLwY6N4KWortr3VtAo%3D&reserved=0
> > > >
> > > > Or did I get confused, and the above is yet another bug?
> > > Yeah, but that was just reported by mail. The bug tracker I've saw was
> > > opened after the patch was already pushed.
> > Still good to give reported-by credits for mailing list reports and
> > link to lore.kernel.org for the report, that's not just useful for
> > bugzilla reports.
>
> That's indeed true, but I was distracted by the fact that drm-misc-fixes
> wasn't up to date :)
>
> Going to add that earlier next time.
>
> > > > > BTW: Any idea why dim add-link doesn't work?
> > > > Hm we occasionally have fun with email parsing (it's hard) and especially
> > > > python changes in how encodings are handled differently between python2
> > > > and python3. If you have a specific example I can try and take a look why
> > > > it doesn't work.
> > > It just looks up and doesn't seem to do anything. I'm not familiar with
> > > python so I can just describe the symptoms.
> > I meant tell me which mail (patchwork or lore) and I'll try to
> > reproduce and see what's maybe up.
>
> It doesn't seem to work in general. E.g. any patch I try I just don't get
> any progress in over 10 Minutes.
>
> Maybe some server is not responding?
Uh dim add-link pretty similar to dim apply-patch, it takes the mbox on
stdin and does only local git stuff with it.
-Daniel
>
> Christian.
>
> > -Daniel
> >
> > > Christian.
> > >
> > > > -Daniel
> > > >
> > > > > > And maybe some words on how/why stuff blows up.
> > > > > Just a typo. I've forgot to remove two lines in radeon while rebasing and
> > > > > still had the symbols exported so never noticed this.
> > > > >
> > > > > Christian.
> > > > >
> > > > > > -Daniel
> > > > > >
> > > > > > > ---
> > > > > > > drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
> > > > > > > 1 file changed, 3 deletions(-)
> > > > > > >
> > > > > > > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> > > > > > > index d4328ff57757..35b715f82ed8 100644
> > > > > > > --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> > > > > > > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> > > > > > > @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
> > > > > > > }
> > > > > > > rdev->mman.initialized = true;
> > > > > > > - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
> > > > > > > - dma_addressing_limited(&rdev->pdev->dev));
> > > > > > > -
> > > > > > > r = radeon_ttm_init_vram(rdev);
> > > > > > > if (r) {
> > > > > > > DRM_ERROR("Failed initializing VRAM heap.\n");
> > > > > > > --
> > > > > > > 2.25.1
> > > > > > >
> > > > > > > _______________________________________________
> > > > > > > dri-devel mailing list
> > > > > > > dri-devel@lists.freedesktop.org
> > > > > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7Cchristian.koenig%40amd.com%7C3aede203348b4f32ea3108d8b3e224ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637457131179258488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pHzuAsJcXf5HlAfJ7wYYc%2BsizZhSLBGWXBhCyVNRCfo%3D&reserved=0
> >
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
@ 2021-01-11 16:17 ` Daniel Vetter
0 siblings, 0 replies; 26+ messages in thread
From: Daniel Vetter @ 2021-01-11 16:17 UTC (permalink / raw)
To: christian.koenig
Cc: amd-gfx list, Huang Rui, Borislav Petkov, dri-devel, Daniel Vetter
On Mon, Jan 11, 2021 at 11:16:13AM +0100, Christian König wrote:
> Am 08.01.21 um 16:53 schrieb Daniel Vetter:
> > On Fri, Jan 8, 2021 at 3:36 PM Christian König <christian.koenig@amd.com> wrote:
> > > Am 08.01.21 um 15:31 schrieb Daniel Vetter:
> > > > On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
> > > > > Am 07.01.21 um 19:07 schrieb Daniel Vetter:
> > > > > > On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
> > > > > > > Drivers are not supposed to init the page pool directly any more.
> > > > > > >
> > > > > > > Signed-off-by: Christian König <christian.koenig@amd.com>
> > > > > > Please include reported-by credits and link to the bug reports on
> > > > > > lore.kernel.org when merging this. Also I guess this should have a Fixes:
> > > > > > line?
> > > > > I'm not aware of a bug report, but the reported-by/Fixes lines are indeed
> > > > > missing.
> > > > This one here:
> > > >
> > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fdri-devel%2F20201231104020.GA4504%40zn.tnic%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7C3aede203348b4f32ea3108d8b3e224ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637457131179258488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=bHVw4lj1f8g4ohVTeuKNkb0LAbLwY6N4KWortr3VtAo%3D&reserved=0
> > > >
> > > > Or did I get confused, and the above is yet another bug?
> > > Yeah, but that was just reported by mail. The bug tracker I've saw was
> > > opened after the patch was already pushed.
> > Still good to give reported-by credits for mailing list reports and
> > link to lore.kernel.org for the report, that's not just useful for
> > bugzilla reports.
>
> That's indeed true, but I was distracted by the fact that drm-misc-fixes
> wasn't up to date :)
>
> Going to add that earlier next time.
>
> > > > > BTW: Any idea why dim add-link doesn't work?
> > > > Hm we occasionally have fun with email parsing (it's hard) and especially
> > > > python changes in how encodings are handled differently between python2
> > > > and python3. If you have a specific example I can try and take a look why
> > > > it doesn't work.
> > > It just looks up and doesn't seem to do anything. I'm not familiar with
> > > python so I can just describe the symptoms.
> > I meant tell me which mail (patchwork or lore) and I'll try to
> > reproduce and see what's maybe up.
>
> It doesn't seem to work in general. E.g. any patch I try I just don't get
> any progress in over 10 Minutes.
>
> Maybe some server is not responding?
Uh dim add-link pretty similar to dim apply-patch, it takes the mbox on
stdin and does only local git stuff with it.
-Daniel
>
> Christian.
>
> > -Daniel
> >
> > > Christian.
> > >
> > > > -Daniel
> > > >
> > > > > > And maybe some words on how/why stuff blows up.
> > > > > Just a typo. I've forgot to remove two lines in radeon while rebasing and
> > > > > still had the symbols exported so never noticed this.
> > > > >
> > > > > Christian.
> > > > >
> > > > > > -Daniel
> > > > > >
> > > > > > > ---
> > > > > > > drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
> > > > > > > 1 file changed, 3 deletions(-)
> > > > > > >
> > > > > > > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> > > > > > > index d4328ff57757..35b715f82ed8 100644
> > > > > > > --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> > > > > > > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> > > > > > > @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
> > > > > > > }
> > > > > > > rdev->mman.initialized = true;
> > > > > > > - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
> > > > > > > - dma_addressing_limited(&rdev->pdev->dev));
> > > > > > > -
> > > > > > > r = radeon_ttm_init_vram(rdev);
> > > > > > > if (r) {
> > > > > > > DRM_ERROR("Failed initializing VRAM heap.\n");
> > > > > > > --
> > > > > > > 2.25.1
> > > > > > >
> > > > > > > _______________________________________________
> > > > > > > dri-devel mailing list
> > > > > > > dri-devel@lists.freedesktop.org
> > > > > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7Cchristian.koenig%40amd.com%7C3aede203348b4f32ea3108d8b3e224ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637457131179258488%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=pHzuAsJcXf5HlAfJ7wYYc%2BsizZhSLBGWXBhCyVNRCfo%3D&reserved=0
> >
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
2021-01-11 16:17 ` Daniel Vetter
@ 2021-01-12 7:53 ` Christian König
-1 siblings, 0 replies; 26+ messages in thread
From: Christian König @ 2021-01-12 7:53 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Huang Rui, Borislav Petkov, amd-gfx list, dri-devel
Am 11.01.21 um 17:17 schrieb Daniel Vetter:
> On Mon, Jan 11, 2021 at 11:16:13AM +0100, Christian König wrote:
>> Am 08.01.21 um 16:53 schrieb Daniel Vetter:
>>> On Fri, Jan 8, 2021 at 3:36 PM Christian König <christian.koenig@amd.com> wrote:
>>>> Am 08.01.21 um 15:31 schrieb Daniel Vetter:
>>>>> On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
>>>>>> Am 07.01.21 um 19:07 schrieb Daniel Vetter:
>>>>>>> On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
>>>>>>>> Drivers are not supposed to init the page pool directly any more.
>>>>>>>>
>>>>>>>> Signed-off-by: Christian König <christian.koenig@amd.com>
>>>>>>> Please include reported-by credits and link to the bug reports on
>>>>>>> lore.kernel.org when merging this. Also I guess this should have a Fixes:
>>>>>>> line?
>>>>>> I'm not aware of a bug report, but the reported-by/Fixes lines are indeed
>>>>>> missing.
>>>>> This one here:
>>>>>
>>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fdri-devel%2F20201231104020.GA4504%40zn.tnic%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7Cff77249040634cf2750308d8b64c616d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637459786459556204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=m8tjDXFtsEwtcv9byq5r1sbUuqb8q%2BAn63r4aKMpcaM%3D&reserved=0
>>>>>
>>>>> Or did I get confused, and the above is yet another bug?
>>>> Yeah, but that was just reported by mail. The bug tracker I've saw was
>>>> opened after the patch was already pushed.
>>> Still good to give reported-by credits for mailing list reports and
>>> link to lore.kernel.org for the report, that's not just useful for
>>> bugzilla reports.
>> That's indeed true, but I was distracted by the fact that drm-misc-fixes
>> wasn't up to date :)
>>
>> Going to add that earlier next time.
>>
>>>>>> BTW: Any idea why dim add-link doesn't work?
>>>>> Hm we occasionally have fun with email parsing (it's hard) and especially
>>>>> python changes in how encodings are handled differently between python2
>>>>> and python3. If you have a specific example I can try and take a look why
>>>>> it doesn't work.
>>>> It just looks up and doesn't seem to do anything. I'm not familiar with
>>>> python so I can just describe the symptoms.
>>> I meant tell me which mail (patchwork or lore) and I'll try to
>>> reproduce and see what's maybe up.
>> It doesn't seem to work in general. E.g. any patch I try I just don't get
>> any progress in over 10 Minutes.
>>
>> Maybe some server is not responding?
> Uh dim add-link pretty similar to dim apply-patch, it takes the mbox on
> stdin and does only local git stuff with it.
AH! Since it was getting a branch parameter I was assuming that it looks
at patches on that branch!
Thanks for the explanation,
Christian.
> -Daniel
>
>> Christian.
>>
>>> -Daniel
>>>
>>>> Christian.
>>>>
>>>>> -Daniel
>>>>>
>>>>>>> And maybe some words on how/why stuff blows up.
>>>>>> Just a typo. I've forgot to remove two lines in radeon while rebasing and
>>>>>> still had the symbols exported so never noticed this.
>>>>>>
>>>>>> Christian.
>>>>>>
>>>>>>> -Daniel
>>>>>>>
>>>>>>>> ---
>>>>>>>> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
>>>>>>>> 1 file changed, 3 deletions(-)
>>>>>>>>
>>>>>>>> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
>>>>>>>> index d4328ff57757..35b715f82ed8 100644
>>>>>>>> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
>>>>>>>> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
>>>>>>>> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
>>>>>>>> }
>>>>>>>> rdev->mman.initialized = true;
>>>>>>>> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
>>>>>>>> - dma_addressing_limited(&rdev->pdev->dev));
>>>>>>>> -
>>>>>>>> r = radeon_ttm_init_vram(rdev);
>>>>>>>> if (r) {
>>>>>>>> DRM_ERROR("Failed initializing VRAM heap.\n");
>>>>>>>> --
>>>>>>>> 2.25.1
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> dri-devel mailing list
>>>>>>>> dri-devel@lists.freedesktop.org
>>>>>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7Cchristian.koenig%40amd.com%7Cff77249040634cf2750308d8b64c616d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637459786459556204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=nBl4CRoSoA3t%2Bd4sZ4My4L27GiCiJwRenoILGU9LbO4%3D&reserved=0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
@ 2021-01-12 7:53 ` Christian König
0 siblings, 0 replies; 26+ messages in thread
From: Christian König @ 2021-01-12 7:53 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Huang Rui, Borislav Petkov, amd-gfx list, dri-devel
Am 11.01.21 um 17:17 schrieb Daniel Vetter:
> On Mon, Jan 11, 2021 at 11:16:13AM +0100, Christian König wrote:
>> Am 08.01.21 um 16:53 schrieb Daniel Vetter:
>>> On Fri, Jan 8, 2021 at 3:36 PM Christian König <christian.koenig@amd.com> wrote:
>>>> Am 08.01.21 um 15:31 schrieb Daniel Vetter:
>>>>> On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
>>>>>> Am 07.01.21 um 19:07 schrieb Daniel Vetter:
>>>>>>> On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
>>>>>>>> Drivers are not supposed to init the page pool directly any more.
>>>>>>>>
>>>>>>>> Signed-off-by: Christian König <christian.koenig@amd.com>
>>>>>>> Please include reported-by credits and link to the bug reports on
>>>>>>> lore.kernel.org when merging this. Also I guess this should have a Fixes:
>>>>>>> line?
>>>>>> I'm not aware of a bug report, but the reported-by/Fixes lines are indeed
>>>>>> missing.
>>>>> This one here:
>>>>>
>>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fdri-devel%2F20201231104020.GA4504%40zn.tnic%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7Cff77249040634cf2750308d8b64c616d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637459786459556204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=m8tjDXFtsEwtcv9byq5r1sbUuqb8q%2BAn63r4aKMpcaM%3D&reserved=0
>>>>>
>>>>> Or did I get confused, and the above is yet another bug?
>>>> Yeah, but that was just reported by mail. The bug tracker I've saw was
>>>> opened after the patch was already pushed.
>>> Still good to give reported-by credits for mailing list reports and
>>> link to lore.kernel.org for the report, that's not just useful for
>>> bugzilla reports.
>> That's indeed true, but I was distracted by the fact that drm-misc-fixes
>> wasn't up to date :)
>>
>> Going to add that earlier next time.
>>
>>>>>> BTW: Any idea why dim add-link doesn't work?
>>>>> Hm we occasionally have fun with email parsing (it's hard) and especially
>>>>> python changes in how encodings are handled differently between python2
>>>>> and python3. If you have a specific example I can try and take a look why
>>>>> it doesn't work.
>>>> It just looks up and doesn't seem to do anything. I'm not familiar with
>>>> python so I can just describe the symptoms.
>>> I meant tell me which mail (patchwork or lore) and I'll try to
>>> reproduce and see what's maybe up.
>> It doesn't seem to work in general. E.g. any patch I try I just don't get
>> any progress in over 10 Minutes.
>>
>> Maybe some server is not responding?
> Uh dim add-link pretty similar to dim apply-patch, it takes the mbox on
> stdin and does only local git stuff with it.
AH! Since it was getting a branch parameter I was assuming that it looks
at patches on that branch!
Thanks for the explanation,
Christian.
> -Daniel
>
>> Christian.
>>
>>> -Daniel
>>>
>>>> Christian.
>>>>
>>>>> -Daniel
>>>>>
>>>>>>> And maybe some words on how/why stuff blows up.
>>>>>> Just a typo. I've forgot to remove two lines in radeon while rebasing and
>>>>>> still had the symbols exported so never noticed this.
>>>>>>
>>>>>> Christian.
>>>>>>
>>>>>>> -Daniel
>>>>>>>
>>>>>>>> ---
>>>>>>>> drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
>>>>>>>> 1 file changed, 3 deletions(-)
>>>>>>>>
>>>>>>>> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
>>>>>>>> index d4328ff57757..35b715f82ed8 100644
>>>>>>>> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
>>>>>>>> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
>>>>>>>> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
>>>>>>>> }
>>>>>>>> rdev->mman.initialized = true;
>>>>>>>> - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
>>>>>>>> - dma_addressing_limited(&rdev->pdev->dev));
>>>>>>>> -
>>>>>>>> r = radeon_ttm_init_vram(rdev);
>>>>>>>> if (r) {
>>>>>>>> DRM_ERROR("Failed initializing VRAM heap.\n");
>>>>>>>> --
>>>>>>>> 2.25.1
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> dri-devel mailing list
>>>>>>>> dri-devel@lists.freedesktop.org
>>>>>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7Cchristian.koenig%40amd.com%7Cff77249040634cf2750308d8b64c616d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637459786459556204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=nBl4CRoSoA3t%2Bd4sZ4My4L27GiCiJwRenoILGU9LbO4%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
2021-01-12 7:53 ` Christian König
@ 2021-01-12 9:16 ` Daniel Vetter
-1 siblings, 0 replies; 26+ messages in thread
From: Daniel Vetter @ 2021-01-12 9:16 UTC (permalink / raw)
To: Christian König; +Cc: amd-gfx list, Huang Rui, Borislav Petkov, dri-devel
On Tue, Jan 12, 2021 at 08:53:03AM +0100, Christian König wrote:
> Am 11.01.21 um 17:17 schrieb Daniel Vetter:
> > On Mon, Jan 11, 2021 at 11:16:13AM +0100, Christian König wrote:
> > > Am 08.01.21 um 16:53 schrieb Daniel Vetter:
> > > > On Fri, Jan 8, 2021 at 3:36 PM Christian König <christian.koenig@amd.com> wrote:
> > > > > Am 08.01.21 um 15:31 schrieb Daniel Vetter:
> > > > > > On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
> > > > > > > Am 07.01.21 um 19:07 schrieb Daniel Vetter:
> > > > > > > > On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
> > > > > > > > > Drivers are not supposed to init the page pool directly any more.
> > > > > > > > >
> > > > > > > > > Signed-off-by: Christian König <christian.koenig@amd.com>
> > > > > > > > Please include reported-by credits and link to the bug reports on
> > > > > > > > lore.kernel.org when merging this. Also I guess this should have a Fixes:
> > > > > > > > line?
> > > > > > > I'm not aware of a bug report, but the reported-by/Fixes lines are indeed
> > > > > > > missing.
> > > > > > This one here:
> > > > > >
> > > > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fdri-devel%2F20201231104020.GA4504%40zn.tnic%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7Cff77249040634cf2750308d8b64c616d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637459786459556204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=m8tjDXFtsEwtcv9byq5r1sbUuqb8q%2BAn63r4aKMpcaM%3D&reserved=0
> > > > > >
> > > > > > Or did I get confused, and the above is yet another bug?
> > > > > Yeah, but that was just reported by mail. The bug tracker I've saw was
> > > > > opened after the patch was already pushed.
> > > > Still good to give reported-by credits for mailing list reports and
> > > > link to lore.kernel.org for the report, that's not just useful for
> > > > bugzilla reports.
> > > That's indeed true, but I was distracted by the fact that drm-misc-fixes
> > > wasn't up to date :)
> > >
> > > Going to add that earlier next time.
> > >
> > > > > > > BTW: Any idea why dim add-link doesn't work?
> > > > > > Hm we occasionally have fun with email parsing (it's hard) and especially
> > > > > > python changes in how encodings are handled differently between python2
> > > > > > and python3. If you have a specific example I can try and take a look why
> > > > > > it doesn't work.
> > > > > It just looks up and doesn't seem to do anything. I'm not familiar with
> > > > > python so I can just describe the symptoms.
> > > > I meant tell me which mail (patchwork or lore) and I'll try to
> > > > reproduce and see what's maybe up.
> > > It doesn't seem to work in general. E.g. any patch I try I just don't get
> > > any progress in over 10 Minutes.
> > >
> > > Maybe some server is not responding?
> > Uh dim add-link pretty similar to dim apply-patch, it takes the mbox on
> > stdin and does only local git stuff with it.
>
> AH! Since it was getting a branch parameter I was assuming that it looks at
> patches on that branch!
Yeah the branch parameter is just so it knows where it should add the
Link: Since the link is presumably not there yet we can't fish out the
original mbox from archives anyway.
-Daniel
>
> Thanks for the explanation,
> Christian.
>
> > -Daniel
> >
> > > Christian.
> > >
> > > > -Daniel
> > > >
> > > > > Christian.
> > > > >
> > > > > > -Daniel
> > > > > >
> > > > > > > > And maybe some words on how/why stuff blows up.
> > > > > > > Just a typo. I've forgot to remove two lines in radeon while rebasing and
> > > > > > > still had the symbols exported so never noticed this.
> > > > > > >
> > > > > > > Christian.
> > > > > > >
> > > > > > > > -Daniel
> > > > > > > >
> > > > > > > > > ---
> > > > > > > > > drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
> > > > > > > > > 1 file changed, 3 deletions(-)
> > > > > > > > >
> > > > > > > > > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> > > > > > > > > index d4328ff57757..35b715f82ed8 100644
> > > > > > > > > --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> > > > > > > > > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> > > > > > > > > @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
> > > > > > > > > }
> > > > > > > > > rdev->mman.initialized = true;
> > > > > > > > > - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
> > > > > > > > > - dma_addressing_limited(&rdev->pdev->dev));
> > > > > > > > > -
> > > > > > > > > r = radeon_ttm_init_vram(rdev);
> > > > > > > > > if (r) {
> > > > > > > > > DRM_ERROR("Failed initializing VRAM heap.\n");
> > > > > > > > > --
> > > > > > > > > 2.25.1
> > > > > > > > >
> > > > > > > > > _______________________________________________
> > > > > > > > > dri-devel mailing list
> > > > > > > > > dri-devel@lists.freedesktop.org
> > > > > > > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7Cchristian.koenig%40amd.com%7Cff77249040634cf2750308d8b64c616d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637459786459556204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=nBl4CRoSoA3t%2Bd4sZ4My4L27GiCiJwRenoILGU9LbO4%3D&reserved=0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 1/2] drm/radeon: stop re-init the TTM page pool
@ 2021-01-12 9:16 ` Daniel Vetter
0 siblings, 0 replies; 26+ messages in thread
From: Daniel Vetter @ 2021-01-12 9:16 UTC (permalink / raw)
To: Christian König
Cc: amd-gfx list, Huang Rui, Borislav Petkov, dri-devel, Daniel Vetter
On Tue, Jan 12, 2021 at 08:53:03AM +0100, Christian König wrote:
> Am 11.01.21 um 17:17 schrieb Daniel Vetter:
> > On Mon, Jan 11, 2021 at 11:16:13AM +0100, Christian König wrote:
> > > Am 08.01.21 um 16:53 schrieb Daniel Vetter:
> > > > On Fri, Jan 8, 2021 at 3:36 PM Christian König <christian.koenig@amd.com> wrote:
> > > > > Am 08.01.21 um 15:31 schrieb Daniel Vetter:
> > > > > > On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
> > > > > > > Am 07.01.21 um 19:07 schrieb Daniel Vetter:
> > > > > > > > On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
> > > > > > > > > Drivers are not supposed to init the page pool directly any more.
> > > > > > > > >
> > > > > > > > > Signed-off-by: Christian König <christian.koenig@amd.com>
> > > > > > > > Please include reported-by credits and link to the bug reports on
> > > > > > > > lore.kernel.org when merging this. Also I guess this should have a Fixes:
> > > > > > > > line?
> > > > > > > I'm not aware of a bug report, but the reported-by/Fixes lines are indeed
> > > > > > > missing.
> > > > > > This one here:
> > > > > >
> > > > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fdri-devel%2F20201231104020.GA4504%40zn.tnic%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7Cff77249040634cf2750308d8b64c616d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637459786459556204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=m8tjDXFtsEwtcv9byq5r1sbUuqb8q%2BAn63r4aKMpcaM%3D&reserved=0
> > > > > >
> > > > > > Or did I get confused, and the above is yet another bug?
> > > > > Yeah, but that was just reported by mail. The bug tracker I've saw was
> > > > > opened after the patch was already pushed.
> > > > Still good to give reported-by credits for mailing list reports and
> > > > link to lore.kernel.org for the report, that's not just useful for
> > > > bugzilla reports.
> > > That's indeed true, but I was distracted by the fact that drm-misc-fixes
> > > wasn't up to date :)
> > >
> > > Going to add that earlier next time.
> > >
> > > > > > > BTW: Any idea why dim add-link doesn't work?
> > > > > > Hm we occasionally have fun with email parsing (it's hard) and especially
> > > > > > python changes in how encodings are handled differently between python2
> > > > > > and python3. If you have a specific example I can try and take a look why
> > > > > > it doesn't work.
> > > > > It just looks up and doesn't seem to do anything. I'm not familiar with
> > > > > python so I can just describe the symptoms.
> > > > I meant tell me which mail (patchwork or lore) and I'll try to
> > > > reproduce and see what's maybe up.
> > > It doesn't seem to work in general. E.g. any patch I try I just don't get
> > > any progress in over 10 Minutes.
> > >
> > > Maybe some server is not responding?
> > Uh dim add-link pretty similar to dim apply-patch, it takes the mbox on
> > stdin and does only local git stuff with it.
>
> AH! Since it was getting a branch parameter I was assuming that it looks at
> patches on that branch!
Yeah the branch parameter is just so it knows where it should add the
Link: Since the link is presumably not there yet we can't fish out the
original mbox from archives anyway.
-Daniel
>
> Thanks for the explanation,
> Christian.
>
> > -Daniel
> >
> > > Christian.
> > >
> > > > -Daniel
> > > >
> > > > > Christian.
> > > > >
> > > > > > -Daniel
> > > > > >
> > > > > > > > And maybe some words on how/why stuff blows up.
> > > > > > > Just a typo. I've forgot to remove two lines in radeon while rebasing and
> > > > > > > still had the symbols exported so never noticed this.
> > > > > > >
> > > > > > > Christian.
> > > > > > >
> > > > > > > > -Daniel
> > > > > > > >
> > > > > > > > > ---
> > > > > > > > > drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
> > > > > > > > > 1 file changed, 3 deletions(-)
> > > > > > > > >
> > > > > > > > > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> > > > > > > > > index d4328ff57757..35b715f82ed8 100644
> > > > > > > > > --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> > > > > > > > > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> > > > > > > > > @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
> > > > > > > > > }
> > > > > > > > > rdev->mman.initialized = true;
> > > > > > > > > - ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
> > > > > > > > > - dma_addressing_limited(&rdev->pdev->dev));
> > > > > > > > > -
> > > > > > > > > r = radeon_ttm_init_vram(rdev);
> > > > > > > > > if (r) {
> > > > > > > > > DRM_ERROR("Failed initializing VRAM heap.\n");
> > > > > > > > > --
> > > > > > > > > 2.25.1
> > > > > > > > >
> > > > > > > > > _______________________________________________
> > > > > > > > > dri-devel mailing list
> > > > > > > > > dri-devel@lists.freedesktop.org
> > > > > > > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7Cchristian.koenig%40amd.com%7Cff77249040634cf2750308d8b64c616d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637459786459556204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=nBl4CRoSoA3t%2Bd4sZ4My4L27GiCiJwRenoILGU9LbO4%3D&reserved=0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2021-01-12 9:16 UTC | newest]
Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-05 18:23 [PATCH 1/2] drm/radeon: stop re-init the TTM page pool Christian König
2021-01-05 18:23 ` Christian König
2021-01-05 18:23 ` [PATCH 2/2] drm/ttm: unexport ttm_pool_init/fini Christian König
2021-01-05 18:23 ` Christian König
2021-01-06 6:35 ` [PATCH 1/2] drm/radeon: stop re-init the TTM page pool Huang Rui
2021-01-06 6:35 ` Huang Rui
2021-01-07 18:07 ` Daniel Vetter
2021-01-07 18:07 ` Daniel Vetter
2021-01-07 20:08 ` Christian König
2021-01-07 20:08 ` Christian König
2021-01-08 14:31 ` Daniel Vetter
2021-01-08 14:31 ` Daniel Vetter
2021-01-08 14:36 ` Christian König
2021-01-08 14:36 ` Christian König
2021-01-08 15:53 ` Daniel Vetter
2021-01-08 15:53 ` Daniel Vetter
2021-01-11 10:16 ` Christian König
2021-01-11 10:16 ` Christian König
2021-01-11 16:17 ` Daniel Vetter
2021-01-11 16:17 ` Daniel Vetter
2021-01-12 7:53 ` Christian König
2021-01-12 7:53 ` Christian König
2021-01-12 9:16 ` Daniel Vetter
2021-01-12 9:16 ` Daniel Vetter
2021-01-09 11:10 ` Borislav Petkov
2021-01-09 11:10 ` Borislav Petkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.