All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/power/supply/axp20x_ac_power.c:381:3-10: line 381 is redundant because platform_get_irq() already prints an error
@ 2021-01-09 23:30 kernel test robot
  2021-01-09 23:30 ` [PATCH] power: supply: axp20x_ac_power: fix platform_get_irq.cocci warnings kernel test robot
  0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2021-01-09 23:30 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Samuel Holland <samuel@sholland.org>
CC: Sebastian Reichel <sre@kernel.org>
CC: "Chen-Yu Tsai" <wens@csie.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   2ff90100ace886895e4fbb2850b8d5e49d931ed6
commit: ca4c77bb43151e6569e7aae689a69b65a48c85f0 power: supply: axp20x_ac_power: Add wakeup control
date:   12 months ago
:::::: branch date: 4 hours ago
:::::: commit date: 12 months ago
config: x86_64-randconfig-c002-20210108 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/power/supply/axp20x_ac_power.c:381:3-10: line 381 is redundant because platform_get_irq() already prints an error

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42554 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] power: supply: axp20x_ac_power: fix platform_get_irq.cocci warnings
  2021-01-09 23:30 drivers/power/supply/axp20x_ac_power.c:381:3-10: line 381 is redundant because platform_get_irq() already prints an error kernel test robot
@ 2021-01-09 23:30 ` kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-01-09 23:30 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Samuel Holland <samuel@sholland.org>
CC: Sebastian Reichel <sre@kernel.org>
CC: "Chen-Yu Tsai" <wens@csie.org>
CC: linux-pm(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/power/supply/axp20x_ac_power.c:381:3-10: line 381 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: ca4c77bb4315 ("power: supply: axp20x_ac_power: Add wakeup control")
CC: Samuel Holland <samuel@sholland.org>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   2ff90100ace886895e4fbb2850b8d5e49d931ed6
commit: ca4c77bb43151e6569e7aae689a69b65a48c85f0 power: supply: axp20x_ac_power: Add wakeup control
:::::: branch date: 4 hours ago
:::::: commit date: 12 months ago

Please take the patch only if it's a positive warning. Thanks!

 axp20x_ac_power.c |    2 --
 1 file changed, 2 deletions(-)

--- a/drivers/power/supply/axp20x_ac_power.c
+++ b/drivers/power/supply/axp20x_ac_power.c
@@ -378,8 +378,6 @@ static int axp20x_ac_power_probe(struct
 	for (i = 0; i < axp_data->num_irq_names; i++) {
 		irq = platform_get_irq_byname(pdev, axp_data->irq_names[i]);
 		if (irq < 0) {
-			dev_err(&pdev->dev, "No IRQ for %s: %d\n",
-				axp_data->irq_names[i], irq);
 			return irq;
 		}
 		power->irqs[i] = regmap_irq_get_virq(axp20x->regmap_irqc, irq);

^ permalink raw reply	[flat|nested] 4+ messages in thread

* drivers/power/supply/axp20x_ac_power.c:381:3-10: line 381 is redundant because platform_get_irq() already prints an error
@ 2020-07-05 22:14 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2020-07-05 22:14 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Samuel Holland <samuel@sholland.org>
CC: Sebastian Reichel <sre@kernel.org>
CC: "Chen-Yu Tsai" <wens@csie.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   bb5a93aaf25261321db0c499cde7da6ee9d8b164
commit: ca4c77bb43151e6569e7aae689a69b65a48c85f0 power: supply: axp20x_ac_power: Add wakeup control
date:   6 months ago
:::::: branch date: 2 hours ago
:::::: commit date: 6 months ago
config: x86_64-randconfig-c002-20200705 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/power/supply/axp20x_ac_power.c:381:3-10: line 381 is redundant because platform_get_irq() already prints an error

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31998 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* drivers/power/supply/axp20x_ac_power.c:381:3-10: line 381 is redundant because platform_get_irq() already prints an error
@ 2020-06-14  7:55 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2020-06-14  7:55 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Samuel Holland <samuel@sholland.org>
CC: Sebastian Reichel <sre@kernel.org>
CC: "Chen-Yu Tsai" <wens@csie.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   96144c58abe7ff767e754b5b80995f7b8846d49b
commit: ca4c77bb43151e6569e7aae689a69b65a48c85f0 power: supply: axp20x_ac_power: Add wakeup control
date:   5 months ago
:::::: branch date: 8 hours ago
:::::: commit date: 5 months ago
config: parisc-randconfig-c003-20200614 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/power/supply/axp20x_ac_power.c:381:3-10: line 381 is redundant because platform_get_irq() already prints an error

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 19366 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-01-09 23:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-09 23:30 drivers/power/supply/axp20x_ac_power.c:381:3-10: line 381 is redundant because platform_get_irq() already prints an error kernel test robot
2021-01-09 23:30 ` [PATCH] power: supply: axp20x_ac_power: fix platform_get_irq.cocci warnings kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2020-07-05 22:14 drivers/power/supply/axp20x_ac_power.c:381:3-10: line 381 is redundant because platform_get_irq() already prints an error kernel test robot
2020-06-14  7:55 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.