All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xu Yilun <yilun.xu@intel.com>
To: Moritz Fischer <mdf@kernel.org>
Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
	gregkh@linuxfoundation.org, trix@redhat.com, lgoncalv@redhat.com,
	hao.wu@intel.com, yilun.xu@intel.com
Subject: Re: [PATCH v5 0/2] UIO support for dfl devices
Date: Mon, 11 Jan 2021 14:27:55 +0800	[thread overview]
Message-ID: <20210111062755.GB13963@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <X/tcdB0hwDLog1TW@archbook>

On Sun, Jan 10, 2021 at 11:58:44AM -0800, Moritz Fischer wrote:
> Hi Xu,
> 
> On Sat, Jan 02, 2021 at 11:13:00AM +0800, Xu Yilun wrote:
> > This patchset supports some dfl device drivers written in userspace.
> > 
> > In the patchset v1, the "driver_override" interface should be used to bind
> > the DFL UIO driver to DFL devices. But there is concern that the
> > "driver_override" interface is not OK itself.
> > 
> > In v2, we use a new matching algorithem. The "driver_override" interface
> > is abandoned, the DFL UIO driver matches any DFL device which could not be
> > handled by other DFL drivers. So the DFL UIO driver could be used for new
> > DFL devices which are not supported by kernel. The concern is the UIO may
> > not be suitable as a default/generic driver for all dfl features, such as
> > features with multiple interrupts.
> > 
> > In v4, we specify each matching device in the id_table of the UIO driver,
> > just the same as other dfl drivers do. Now the UIO driver supports Ether
> > Group feature. To support more DFL features, their feature ids should be
> > added to the driver's id_table.
> 
> I think this is what you want, yes. Instead of doing a driver override
> or such, add devices that should always be bound to UIO to a device id
> table. For those you temporarily want to bind, make sure you can unbind
> them and use 'new_id' or 'bind' in sysfs, similar to what sysfs does.

"new_id" is not generic to all bus drivers, we need to add the attr in
dfl bus driver like pci do, actually I think quite similar to
"driver_override", How do you think?

I'm glad we restarted the discussion for the temporary binding of UIO
driver.

Thanks,
Yilun

      reply	other threads:[~2021-01-11  6:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-02  3:13 [PATCH v5 0/2] UIO support for dfl devices Xu Yilun
2021-01-02  3:13 ` [PATCH v5 1/2] fpga: dfl: add the userspace I/O device support for DFL devices Xu Yilun
2021-01-04  4:16   ` Wu, Hao
2021-01-04  6:49     ` Xu Yilun
2021-01-10 20:11   ` Moritz Fischer
2021-01-11  6:16     ` Xu Yilun
2021-01-11 14:59       ` Tom Rix
2021-01-12  0:16         ` Xu Yilun
2021-01-13  1:02           ` Moritz Fischer
2021-01-02  3:13 ` [PATCH v5 2/2] Documentation: fpga: dfl: Add description for DFL UIO support Xu Yilun
2021-01-04  4:24   ` Wu, Hao
2021-01-04  6:50     ` Xu Yilun
2021-01-04 17:19   ` Russ Weight
2021-01-05  2:00     ` Xu Yilun
2021-01-10 19:58 ` [PATCH v5 0/2] UIO support for dfl devices Moritz Fischer
2021-01-11  6:27   ` Xu Yilun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210111062755.GB13963@yilunxu-OptiPlex-7050 \
    --to=yilun.xu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hao.wu@intel.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.