* [PATCH net-next] net: ks8851: Select PHYLIB and MICREL_PHY in Kconfig
@ 2021-01-11 12:50 Marek Vasut
2021-01-11 14:49 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2021-01-11 12:50 UTC (permalink / raw)
To: netdev; +Cc: Marek Vasut, Andrew Lunn, Heiner Kallweit, Lukas Wunner
The PHYLIB must be selected to provide mdiobus_*() functions, and the
MICREL_PHY is necessary too, as that is the only possible PHY attached
to the KS8851 (it is the internal PHY).
Fixes: ef3631220d2b ("net: ks8851: Register MDIO bus and the internal PHY")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Lukas Wunner <lukas@wunner.de>
---
drivers/net/ethernet/micrel/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/micrel/Kconfig b/drivers/net/ethernet/micrel/Kconfig
index 42bc014136fe..93df3049cdc0 100644
--- a/drivers/net/ethernet/micrel/Kconfig
+++ b/drivers/net/ethernet/micrel/Kconfig
@@ -31,6 +31,8 @@ config KS8851
select MII
select CRC32
select EEPROM_93CX6
+ select PHYLIB
+ select MICREL_PHY
help
SPI driver for Micrel KS8851 SPI attached network chip.
@@ -40,6 +42,8 @@ config KS8851_MLL
select MII
select CRC32
select EEPROM_93CX6
+ select PHYLIB
+ select MICREL_PHY
help
This platform driver is for Micrel KS8851 Address/data bus
multiplexed network chip.
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: ks8851: Select PHYLIB and MICREL_PHY in Kconfig
2021-01-11 12:50 [PATCH net-next] net: ks8851: Select PHYLIB and MICREL_PHY in Kconfig Marek Vasut
@ 2021-01-11 14:49 ` Andrew Lunn
2021-01-13 2:45 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2021-01-11 14:49 UTC (permalink / raw)
To: Marek Vasut; +Cc: netdev, Heiner Kallweit, Lukas Wunner
On Mon, Jan 11, 2021 at 01:50:46PM +0100, Marek Vasut wrote:
> The PHYLIB must be selected to provide mdiobus_*() functions, and the
> MICREL_PHY is necessary too, as that is the only possible PHY attached
> to the KS8851 (it is the internal PHY).
>
> Fixes: ef3631220d2b ("net: ks8851: Register MDIO bus and the internal PHY")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Heiner Kallweit <hkallweit1@gmail.com>
> Cc: Lukas Wunner <lukas@wunner.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: ks8851: Select PHYLIB and MICREL_PHY in Kconfig
2021-01-11 14:49 ` Andrew Lunn
@ 2021-01-13 2:45 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-01-13 2:45 UTC (permalink / raw)
To: Andrew Lunn, Marek Vasut; +Cc: netdev, Heiner Kallweit, Lukas Wunner
On Mon, 11 Jan 2021 15:49:33 +0100 Andrew Lunn wrote:
> On Mon, Jan 11, 2021 at 01:50:46PM +0100, Marek Vasut wrote:
> > The PHYLIB must be selected to provide mdiobus_*() functions, and the
> > MICREL_PHY is necessary too, as that is the only possible PHY attached
> > to the KS8851 (it is the internal PHY).
> >
> > Fixes: ef3631220d2b ("net: ks8851: Register MDIO bus and the internal PHY")
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Andrew Lunn <andrew@lunn.ch>
> > Cc: Heiner Kallweit <hkallweit1@gmail.com>
> > Cc: Lukas Wunner <lukas@wunner.de>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-13 2:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 12:50 [PATCH net-next] net: ks8851: Select PHYLIB and MICREL_PHY in Kconfig Marek Vasut
2021-01-11 14:49 ` Andrew Lunn
2021-01-13 2:45 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.