All of lore.kernel.org
 help / color / mirror / Atom feed
* [tobetter-linux:odroid-5.11.y 51/84] drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but dereferenced.
@ 2021-01-12  8:02 kernel test robot
  2021-01-12  8:02 ` [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings kernel test robot
  0 siblings, 1 reply; 16+ messages in thread
From: kernel test robot @ 2021-01-12  8:02 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Brian Kim <brian.kim@hardkernel.com>
CC: Dongjin Kim <tobetter@gmail.com>
CC: memeka <mihailescu2m@gmail.com>
CC: Yang Deokgyu <secugyu@gmail.com>

tree:   https://github.com/tobetter/linux odroid-5.11.y
head:   674407f50bbff11698a0f2cf5825d3e039e25b6c
commit: 0ef2ae8e0676a634333e64cf23e4ecab49efa1ca [51/84] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
:::::: branch date: 4 hours ago
:::::: commit date: 5 hours ago
config: i386-randconfig-c001-20210111 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but dereferenced.
--
>> drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by free on line 229
--
>> drivers/char/exynos-gpiomem.c:258:3-8: No need to set .owner here. The core will do it.

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37921 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
  2021-01-12  8:02 [tobetter-linux:odroid-5.11.y 51/84] drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but dereferenced kernel test robot
@ 2021-01-12  8:02 ` kernel test robot
  0 siblings, 0 replies; 16+ messages in thread
From: kernel test robot @ 2021-01-12  8:02 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Brian Kim <brian.kim@hardkernel.com>
CC: Dongjin Kim <tobetter@gmail.com>
CC: memeka <mihailescu2m@gmail.com>
CC: Yang Deokgyu <secugyu@gmail.com>

From: kernel test robot <lkp@intel.com>

drivers/char/exynos-gpiomem.c:258:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: 0ef2ae8e0676 ("ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access")
CC: Brian Kim <brian.kim@hardkernel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/tobetter/linux odroid-5.11.y
head:   674407f50bbff11698a0f2cf5825d3e039e25b6c
commit: 0ef2ae8e0676a634333e64cf23e4ecab49efa1ca [51/84] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
:::::: branch date: 4 hours ago
:::::: commit date: 5 hours ago

 exynos-gpiomem.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/char/exynos-gpiomem.c
+++ b/drivers/char/exynos-gpiomem.c
@@ -255,7 +255,6 @@ MODULE_DEVICE_TABLE(of, exynos_gpiomem_o
 static struct platform_driver exynos_gpiomem_driver = {
 	.driver			= {
 		.name		= DRIVER_NAME,
-		.owner		= THIS_MODULE,
 		.of_match_table	= exynos_gpiomem_of_match,
 	},
 	.probe			= exynos_gpiomem_probe,

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
@ 2021-11-03 16:17 ` Julia Lawall
  0 siblings, 0 replies; 16+ messages in thread
From: Julia Lawall @ 2021-11-03 16:17 UTC (permalink / raw)
  To: Brian Kim; +Cc: kbuild-all, linux-kernel, Dongjin Kim, memeka, Yang Deokgyu

From: kernel test robot <lkp@intel.com>

No need to set .owner here. The core will do it.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Brian Kim <brian.kim@hardkernel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://github.com/tobetter/linux odroid-5.15.y
head:   49f1393b8740941fa5176620b302f25ab5f786dc
commit: 61f45d975621becb00c0aef303769f10428b9cd8 [21/75] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
:::::: branch date: 4 hours ago
:::::: commit date: 6 hours ago

 exynos-gpiomem.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/char/exynos-gpiomem.c
+++ b/drivers/char/exynos-gpiomem.c
@@ -255,7 +255,6 @@ MODULE_DEVICE_TABLE(of, exynos_gpiomem_o
 static struct platform_driver exynos_gpiomem_driver = {
 	.driver			= {
 		.name		= DRIVER_NAME,
-		.owner		= THIS_MODULE,
 		.of_match_table	= exynos_gpiomem_of_match,
 	},
 	.probe			= exynos_gpiomem_probe,

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
@ 2021-11-03 16:17 ` Julia Lawall
  0 siblings, 0 replies; 16+ messages in thread
From: Julia Lawall @ 2021-11-03 16:17 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]

From: kernel test robot <lkp@intel.com>

No need to set .owner here. The core will do it.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Brian Kim <brian.kim@hardkernel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://github.com/tobetter/linux odroid-5.15.y
head:   49f1393b8740941fa5176620b302f25ab5f786dc
commit: 61f45d975621becb00c0aef303769f10428b9cd8 [21/75] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
:::::: branch date: 4 hours ago
:::::: commit date: 6 hours ago

 exynos-gpiomem.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/char/exynos-gpiomem.c
+++ b/drivers/char/exynos-gpiomem.c
@@ -255,7 +255,6 @@ MODULE_DEVICE_TABLE(of, exynos_gpiomem_o
 static struct platform_driver exynos_gpiomem_driver = {
 	.driver			= {
 		.name		= DRIVER_NAME,
-		.owner		= THIS_MODULE,
 		.of_match_table	= exynos_gpiomem_of_match,
 	},
 	.probe			= exynos_gpiomem_probe,

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
  2021-11-03 13:33 [tobetter:odroid-5.15.y 21/75] drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by free on line 229 kernel test robot
@ 2021-11-03 13:33 ` kernel test robot
  0 siblings, 0 replies; 16+ messages in thread
From: kernel test robot @ 2021-11-03 13:33 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Brian Kim <brian.kim@hardkernel.com>
CC: Dongjin Kim <tobetter@gmail.com>
CC: memeka <mihailescu2m@gmail.com>
CC: Yang Deokgyu <secugyu@gmail.com>

From: kernel test robot <lkp@intel.com>

drivers/char/exynos-gpiomem.c:258:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Brian Kim <brian.kim@hardkernel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/tobetter/linux odroid-5.15.y
head:   49f1393b8740941fa5176620b302f25ab5f786dc
commit: 61f45d975621becb00c0aef303769f10428b9cd8 [21/75] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
:::::: branch date: 4 hours ago
:::::: commit date: 6 hours ago

 exynos-gpiomem.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/char/exynos-gpiomem.c
+++ b/drivers/char/exynos-gpiomem.c
@@ -255,7 +255,6 @@ MODULE_DEVICE_TABLE(of, exynos_gpiomem_o
 static struct platform_driver exynos_gpiomem_driver = {
 	.driver			= {
 		.name		= DRIVER_NAME,
-		.owner		= THIS_MODULE,
 		.of_match_table	= exynos_gpiomem_of_match,
 	},
 	.probe			= exynos_gpiomem_probe,

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
@ 2021-08-28 11:10 ` Julia Lawall
  0 siblings, 0 replies; 16+ messages in thread
From: Julia Lawall @ 2021-08-28 11:10 UTC (permalink / raw)
  To: Brian Kim; +Cc: Dongjin Kim, Yang Deokgyu, memeka, kbuild-all, linux-kernel

From: kernel test robot <lkp@intel.com>

No need to set .owner here. The core will do it.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Brian Kim <brian.kim@hardkernel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

I also received the following warning, which you may want to look into:

drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by free
on line 229


tree:   https://github.com/tobetter/linux odroid-5.14.y
head:   62bd983c27712ddb2dccb2efe9cdc3a086daf8e0
commit: 7b9acbf68d2938b1533c176b4bdd7becdb40bfc1 [21/68] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
:::::: branch date: 14 hours ago
:::::: commit date: 14 hours ago

 exynos-gpiomem.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/char/exynos-gpiomem.c
+++ b/drivers/char/exynos-gpiomem.c
@@ -255,7 +255,6 @@ MODULE_DEVICE_TABLE(of, exynos_gpiomem_o
 static struct platform_driver exynos_gpiomem_driver = {
 	.driver			= {
 		.name		= DRIVER_NAME,
-		.owner		= THIS_MODULE,
 		.of_match_table	= exynos_gpiomem_of_match,
 	},
 	.probe			= exynos_gpiomem_probe,

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
@ 2021-08-28 11:10 ` Julia Lawall
  0 siblings, 0 replies; 16+ messages in thread
From: Julia Lawall @ 2021-08-28 11:10 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1258 bytes --]

From: kernel test robot <lkp@intel.com>

No need to set .owner here. The core will do it.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Brian Kim <brian.kim@hardkernel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

I also received the following warning, which you may want to look into:

drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by free
on line 229


tree:   https://github.com/tobetter/linux odroid-5.14.y
head:   62bd983c27712ddb2dccb2efe9cdc3a086daf8e0
commit: 7b9acbf68d2938b1533c176b4bdd7becdb40bfc1 [21/68] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
:::::: branch date: 14 hours ago
:::::: commit date: 14 hours ago

 exynos-gpiomem.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/char/exynos-gpiomem.c
+++ b/drivers/char/exynos-gpiomem.c
@@ -255,7 +255,6 @@ MODULE_DEVICE_TABLE(of, exynos_gpiomem_o
 static struct platform_driver exynos_gpiomem_driver = {
 	.driver			= {
 		.name		= DRIVER_NAME,
-		.owner		= THIS_MODULE,
 		.of_match_table	= exynos_gpiomem_of_match,
 	},
 	.probe			= exynos_gpiomem_probe,

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
  2021-08-25 17:02 [tobetter-linux:odroid-5.14.y 21/68] drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by free on line 229 kernel test robot
@ 2021-08-25 17:02 ` kernel test robot
  0 siblings, 0 replies; 16+ messages in thread
From: kernel test robot @ 2021-08-25 17:02 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Brian Kim <brian.kim@hardkernel.com>
CC: Dongjin Kim <tobetter@gmail.com>
CC: memeka <mihailescu2m@gmail.com>
CC: Yang Deokgyu <secugyu@gmail.com>

From: kernel test robot <lkp@intel.com>

drivers/char/exynos-gpiomem.c:258:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Brian Kim <brian.kim@hardkernel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/tobetter/linux odroid-5.14.y
head:   62bd983c27712ddb2dccb2efe9cdc3a086daf8e0
commit: 7b9acbf68d2938b1533c176b4bdd7becdb40bfc1 [21/68] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
:::::: branch date: 14 hours ago
:::::: commit date: 14 hours ago

 exynos-gpiomem.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/char/exynos-gpiomem.c
+++ b/drivers/char/exynos-gpiomem.c
@@ -255,7 +255,6 @@ MODULE_DEVICE_TABLE(of, exynos_gpiomem_o
 static struct platform_driver exynos_gpiomem_driver = {
 	.driver			= {
 		.name		= DRIVER_NAME,
-		.owner		= THIS_MODULE,
 		.of_match_table	= exynos_gpiomem_of_match,
 	},
 	.probe			= exynos_gpiomem_probe,

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
  2021-08-25  8:12 [tobetter-linux:odroid-5.14.y 21/68] drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by free on line 229 kernel test robot
@ 2021-08-25  8:12 ` kernel test robot
  0 siblings, 0 replies; 16+ messages in thread
From: kernel test robot @ 2021-08-25  8:12 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Brian Kim <brian.kim@hardkernel.com>
CC: Dongjin Kim <tobetter@gmail.com>
CC: memeka <mihailescu2m@gmail.com>
CC: Yang Deokgyu <secugyu@gmail.com>
CC: Arnd Bergmann <arnd@arndb.de>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Krzysztof Kozlowski <krzk@kernel.org>
CC: linux-arm-kernel(a)lists.infradead.org
CC: linux-samsung-soc(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/char/exynos-gpiomem.c:258:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Brian Kim <brian.kim@hardkernel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/tobetter/linux odroid-5.14.y
head:   62bd983c27712ddb2dccb2efe9cdc3a086daf8e0
commit: 7b9acbf68d2938b1533c176b4bdd7becdb40bfc1 [21/68] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago

 exynos-gpiomem.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/char/exynos-gpiomem.c
+++ b/drivers/char/exynos-gpiomem.c
@@ -255,7 +255,6 @@ MODULE_DEVICE_TABLE(of, exynos_gpiomem_o
 static struct platform_driver exynos_gpiomem_driver = {
 	.driver			= {
 		.name		= DRIVER_NAME,
-		.owner		= THIS_MODULE,
 		.of_match_table	= exynos_gpiomem_of_match,
 	},
 	.probe			= exynos_gpiomem_probe,

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
  2020-09-08  9:39 ` Julia Lawall
  (?)
@ 2020-09-08 10:04   ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-08 10:04 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Brian Kim, kbuild-all, Dongjin Kim, memeka, Yang Deokgyu,
	Arnd Bergmann, Greg Kroah-Hartman, Kukjin Kim, linux-arm-kernel,
	linux-samsung-soc

On Tue, Sep 08, 2020 at 11:39:51AM +0200, Julia Lawall wrote:
> No need to set .owner here. The core will do it.
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> Fixes: be904257f8a9 ("ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access")
> CC: Brian Kim <brian.kim@hardkernel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

Hi,

This is a downstream tree with certain non-upstreamable patches, so
nothing to do here for me.

Best regards,
Krzysztof

> ---
> 
> I received some other warnings about this file, but with no details:
> 
> >> drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but
> dereferenced.
> --
> >> drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by
> free on line 229
> 
> 
> tree:   https://github.com/tobetter/linux odroid-5.9.y
> head:   1118f1d60573bfbf1eb7ef079fa879a498ba4313
> commit: be904257f8a9bd689b360fa98d3ffc85bdbeb560 [53/69] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
> :::::: branch date: 4 hours ago
> :::::: commit date: 4 hours ago
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
@ 2020-09-08 10:04   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-08 10:04 UTC (permalink / raw)
  To: Julia Lawall
  Cc: linux-samsung-soc, kbuild-all, Arnd Bergmann, Greg Kroah-Hartman,
	Yang Deokgyu, Kukjin Kim, Dongjin Kim, memeka, Brian Kim,
	linux-arm-kernel

On Tue, Sep 08, 2020 at 11:39:51AM +0200, Julia Lawall wrote:
> No need to set .owner here. The core will do it.
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> Fixes: be904257f8a9 ("ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access")
> CC: Brian Kim <brian.kim@hardkernel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

Hi,

This is a downstream tree with certain non-upstreamable patches, so
nothing to do here for me.

Best regards,
Krzysztof

> ---
> 
> I received some other warnings about this file, but with no details:
> 
> >> drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but
> dereferenced.
> --
> >> drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by
> free on line 229
> 
> 
> tree:   https://github.com/tobetter/linux odroid-5.9.y
> head:   1118f1d60573bfbf1eb7ef079fa879a498ba4313
> commit: be904257f8a9bd689b360fa98d3ffc85bdbeb560 [53/69] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
> :::::: branch date: 4 hours ago
> :::::: commit date: 4 hours ago
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
@ 2020-09-08 10:04   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-08 10:04 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

On Tue, Sep 08, 2020 at 11:39:51AM +0200, Julia Lawall wrote:
> No need to set .owner here. The core will do it.
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> Fixes: be904257f8a9 ("ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access")
> CC: Brian Kim <brian.kim@hardkernel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

Hi,

This is a downstream tree with certain non-upstreamable patches, so
nothing to do here for me.

Best regards,
Krzysztof

> ---
> 
> I received some other warnings about this file, but with no details:
> 
> >> drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but
> dereferenced.
> --
> >> drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by
> free on line 229
> 
> 
> tree:   https://github.com/tobetter/linux odroid-5.9.y
> head:   1118f1d60573bfbf1eb7ef079fa879a498ba4313
> commit: be904257f8a9bd689b360fa98d3ffc85bdbeb560 [53/69] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
> :::::: branch date: 4 hours ago
> :::::: commit date: 4 hours ago
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
@ 2020-09-08  9:39 ` Julia Lawall
  0 siblings, 0 replies; 16+ messages in thread
From: Julia Lawall @ 2020-09-08  9:39 UTC (permalink / raw)
  To: Brian Kim
  Cc: kbuild-all, Dongjin Kim, memeka, Yang Deokgyu, Arnd Bergmann,
	Greg Kroah-Hartman, Kukjin Kim, Krzysztof Kozlowski,
	linux-arm-kernel, linux-samsung-soc

No need to set .owner here. The core will do it.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: be904257f8a9 ("ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access")
CC: Brian Kim <brian.kim@hardkernel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

I received some other warnings about this file, but with no details:

>> drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but
dereferenced.
--
>> drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by
free on line 229


tree:   https://github.com/tobetter/linux odroid-5.9.y
head:   1118f1d60573bfbf1eb7ef079fa879a498ba4313
commit: be904257f8a9bd689b360fa98d3ffc85bdbeb560 [53/69] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago

 exynos-gpiomem.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/char/exynos-gpiomem.c
+++ b/drivers/char/exynos-gpiomem.c
@@ -255,7 +255,6 @@ MODULE_DEVICE_TABLE(of, exynos_gpiomem_o
 static struct platform_driver exynos_gpiomem_driver = {
 	.driver			= {
 		.name		= DRIVER_NAME,
-		.owner		= THIS_MODULE,
 		.of_match_table	= exynos_gpiomem_of_match,
 	},
 	.probe			= exynos_gpiomem_probe,

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
@ 2020-09-08  9:39 ` Julia Lawall
  0 siblings, 0 replies; 16+ messages in thread
From: Julia Lawall @ 2020-09-08  9:39 UTC (permalink / raw)
  To: Brian Kim
  Cc: linux-samsung-soc, kbuild-all, Arnd Bergmann, Greg Kroah-Hartman,
	Yang Deokgyu, Krzysztof Kozlowski, Kukjin Kim, Dongjin Kim,
	memeka, linux-arm-kernel

No need to set .owner here. The core will do it.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: be904257f8a9 ("ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access")
CC: Brian Kim <brian.kim@hardkernel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

I received some other warnings about this file, but with no details:

>> drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but
dereferenced.
--
>> drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by
free on line 229


tree:   https://github.com/tobetter/linux odroid-5.9.y
head:   1118f1d60573bfbf1eb7ef079fa879a498ba4313
commit: be904257f8a9bd689b360fa98d3ffc85bdbeb560 [53/69] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago

 exynos-gpiomem.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/char/exynos-gpiomem.c
+++ b/drivers/char/exynos-gpiomem.c
@@ -255,7 +255,6 @@ MODULE_DEVICE_TABLE(of, exynos_gpiomem_o
 static struct platform_driver exynos_gpiomem_driver = {
 	.driver			= {
 		.name		= DRIVER_NAME,
-		.owner		= THIS_MODULE,
 		.of_match_table	= exynos_gpiomem_of_match,
 	},
 	.probe			= exynos_gpiomem_probe,

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
@ 2020-09-08  9:39 ` Julia Lawall
  0 siblings, 0 replies; 16+ messages in thread
From: Julia Lawall @ 2020-09-08  9:39 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

No need to set .owner here. The core will do it.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: be904257f8a9 ("ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access")
CC: Brian Kim <brian.kim@hardkernel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

I received some other warnings about this file, but with no details:

>> drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but
dereferenced.
--
>> drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by
free on line 229


tree:   https://github.com/tobetter/linux odroid-5.9.y
head:   1118f1d60573bfbf1eb7ef079fa879a498ba4313
commit: be904257f8a9bd689b360fa98d3ffc85bdbeb560 [53/69] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago

 exynos-gpiomem.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/char/exynos-gpiomem.c
+++ b/drivers/char/exynos-gpiomem.c
@@ -255,7 +255,6 @@ MODULE_DEVICE_TABLE(of, exynos_gpiomem_o
 static struct platform_driver exynos_gpiomem_driver = {
 	.driver			= {
 		.name		= DRIVER_NAME,
-		.owner		= THIS_MODULE,
 		.of_match_table	= exynos_gpiomem_of_match,
 	},
 	.probe			= exynos_gpiomem_probe,

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
  2020-09-08  6:02 [tobetter-linux:odroid-5.9.y 53/69] drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but dereferenced kernel test robot
@ 2020-09-08  6:02 ` kernel test robot
  0 siblings, 0 replies; 16+ messages in thread
From: kernel test robot @ 2020-09-08  6:02 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1641 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Brian Kim <brian.kim@hardkernel.com>
CC: Dongjin Kim <tobetter@gmail.com>
CC: memeka <mihailescu2m@gmail.com>
CC: Yang Deokgyu <secugyu@gmail.com>
CC: Arnd Bergmann <arnd@arndb.de>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Kukjin Kim <kgene@kernel.org>
CC: Krzysztof Kozlowski <krzk@kernel.org>
CC: linux-arm-kernel(a)lists.infradead.org
CC: linux-samsung-soc(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/char/exynos-gpiomem.c:258:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: be904257f8a9 ("ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access")
CC: Brian Kim <brian.kim@hardkernel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/tobetter/linux odroid-5.9.y
head:   1118f1d60573bfbf1eb7ef079fa879a498ba4313
commit: be904257f8a9bd689b360fa98d3ffc85bdbeb560 [53/69] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago

 exynos-gpiomem.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/char/exynos-gpiomem.c
+++ b/drivers/char/exynos-gpiomem.c
@@ -255,7 +255,6 @@ MODULE_DEVICE_TABLE(of, exynos_gpiomem_o
 static struct platform_driver exynos_gpiomem_driver = {
 	.driver			= {
 		.name		= DRIVER_NAME,
-		.owner		= THIS_MODULE,
 		.of_match_table	= exynos_gpiomem_of_match,
 	},
 	.probe			= exynos_gpiomem_probe,

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2021-11-03 16:17 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-12  8:02 [tobetter-linux:odroid-5.11.y 51/84] drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but dereferenced kernel test robot
2021-01-12  8:02 ` [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2021-11-03 16:17 Julia Lawall
2021-11-03 16:17 ` Julia Lawall
2021-11-03 13:33 [tobetter:odroid-5.15.y 21/75] drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by free on line 229 kernel test robot
2021-11-03 13:33 ` [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings kernel test robot
2021-08-28 11:10 Julia Lawall
2021-08-28 11:10 ` Julia Lawall
2021-08-25 17:02 [tobetter-linux:odroid-5.14.y 21/68] drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by free on line 229 kernel test robot
2021-08-25 17:02 ` [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings kernel test robot
2021-08-25  8:12 [tobetter-linux:odroid-5.14.y 21/68] drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by free on line 229 kernel test robot
2021-08-25  8:12 ` [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings kernel test robot
2020-09-08  9:39 Julia Lawall
2020-09-08  9:39 ` Julia Lawall
2020-09-08  9:39 ` Julia Lawall
2020-09-08 10:04 ` Krzysztof Kozlowski
2020-09-08 10:04   ` Krzysztof Kozlowski
2020-09-08 10:04   ` Krzysztof Kozlowski
2020-09-08  6:02 [tobetter-linux:odroid-5.9.y 53/69] drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but dereferenced kernel test robot
2020-09-08  6:02 ` [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.