* [PATCH] arm64: dts: sdm850: Add OPP tables for 2.84 and 2.96GHz
@ 2021-01-12 9:01 Shawn Guo
2021-01-12 9:05 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Shawn Guo @ 2021-01-12 9:01 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross
Cc: Rob Herring, devicetree, linux-arm-msm, Steev Klimaszewski, Shawn Guo
From: Steev Klimaszewski <steev@kali.org>
Running cpufreq-hw driver on Lenovo Yoga C630 laptop, the following
warning messages will be seen.
[ 3.415340] cpu cpu4: Voltage update failed freq=2841600
[ 3.418755] cpu cpu4: failed to update OPP for freq=2841600
[ 3.422949] cpu cpu4: Voltage update failed freq=2956800
[ 3.427086] cpu cpu4: failed to update OPP for freq=2956800
This is because the cpufreq-hw lookup table of SDM850 provides these two
set-points, but they are missing from OPP table in DT. Let's create
sdm850.dtsi to add the OPP for them, so that the warning will be gone.
Signed-off-by: Steev Klimaszewski <steev@kali.org>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
.../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 2 +-
arch/arm64/boot/dts/qcom/sdm850.dtsi | 22 +++++++++++++++++++
2 files changed, 23 insertions(+), 1 deletion(-)
create mode 100644 arch/arm64/boot/dts/qcom/sdm850.dtsi
diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index 7929665aeaee..94390ae630f3 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -13,7 +13,7 @@
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
#include <dt-bindings/sound/qcom,q6afe.h>
#include <dt-bindings/sound/qcom,q6asm.h>
-#include "sdm845.dtsi"
+#include "sdm850.dtsi"
#include "pm8998.dtsi"
/ {
diff --git a/arch/arm64/boot/dts/qcom/sdm850.dtsi b/arch/arm64/boot/dts/qcom/sdm850.dtsi
new file mode 100644
index 000000000000..8e911e9723ba
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sdm850.dtsi
@@ -0,0 +1,22 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * SDM850 SoC device tree source
+ *
+ * Copyright (c) 2020, The Linux Foundation. All rights reserved.
+ */
+
+#include "sdm845.dtsi"
+
+&cpu4_opp_table {
+
+ cpu4_opp33: opp-2841600000 {
+ opp-hz = /bits/ 64 <2841600000>;
+ opp-peak-kBps = <7216000 25497600>;
+ };
+
+ cpu4_opp34: opp-2956800000 {
+ opp-hz = /bits/ 64 <2956800000>;
+ opp-peak-kBps = <7216000 25497600>;
+ turbo-mode;
+ };
+};
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: sdm850: Add OPP tables for 2.84 and 2.96GHz
2021-01-12 9:01 [PATCH] arm64: dts: sdm850: Add OPP tables for 2.84 and 2.96GHz Shawn Guo
@ 2021-01-12 9:05 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2021-01-12 9:05 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross
Cc: Rob Herring, devicetree, linux-arm-msm, Steev Klimaszewski
On Tue, Jan 12, 2021 at 05:01:40PM +0800, Shawn Guo wrote:
> From: Steev Klimaszewski <steev@kali.org>
>
> Running cpufreq-hw driver on Lenovo Yoga C630 laptop, the following
> warning messages will be seen.
>
> [ 3.415340] cpu cpu4: Voltage update failed freq=2841600
> [ 3.418755] cpu cpu4: failed to update OPP for freq=2841600
> [ 3.422949] cpu cpu4: Voltage update failed freq=2956800
> [ 3.427086] cpu cpu4: failed to update OPP for freq=2956800
>
> This is because the cpufreq-hw lookup table of SDM850 provides these two
> set-points, but they are missing from OPP table in DT. Let's create
> sdm850.dtsi to add the OPP for them, so that the warning will be gone.
>
> Signed-off-by: Steev Klimaszewski <steev@kali.org>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Ignore this one. Some needed changes got lost.
Shawn
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-12 9:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-12 9:01 [PATCH] arm64: dts: sdm850: Add OPP tables for 2.84 and 2.96GHz Shawn Guo
2021-01-12 9:05 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.