From: "Daniel P. Berrangé" <berrange@redhat.com> To: David Gibson <david@gibson.dropbear.id.au> Cc: pasic@linux.ibm.com, brijesh.singh@amd.com, pair@us.ibm.com, dgilbert@redhat.com, qemu-devel@nongnu.org, andi.kleen@intel.com, qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, Greg Kurz <groug@kaod.org>, frankja@linux.ibm.com, thuth@redhat.com, Christian Borntraeger <borntraeger@de.ibm.com>, mdroth@linux.vnet.ibm.com, richard.henderson@linaro.org, kvm@vger.kernel.org, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Eduardo Habkost <ehabkost@redhat.com>, david@redhat.com, Cornelia Huck <cohuck@redhat.com>, mst@redhat.com, qemu-s390x@nongnu.org, pragyansri.pathi@intel.com, jun.nakajima@intel.com Subject: Re: [PATCH v6 10/13] spapr: Add PEF based confidential guest support Date: Tue, 12 Jan 2021 09:56:12 +0000 [thread overview] Message-ID: <20210112095612.GE1360503@redhat.com> (raw) In-Reply-To: <20210112044508.427338-11-david@gibson.dropbear.id.au> On Tue, Jan 12, 2021 at 03:45:05PM +1100, David Gibson wrote: > Some upcoming POWER machines have a system called PEF (Protected > Execution Facility) which uses a small ultravisor to allow guests to > run in a way that they can't be eavesdropped by the hypervisor. The > effect is roughly similar to AMD SEV, although the mechanisms are > quite different. > > Most of the work of this is done between the guest, KVM and the > ultravisor, with little need for involvement by qemu. However qemu > does need to tell KVM to allow secure VMs. > > Because the availability of secure mode is a guest visible difference > which depends on having the right hardware and firmware, we don't > enable this by default. In order to run a secure guest you need to > create a "pef-guest" object and set the confidential-guest-support > property to point to it. > > Note that this just *allows* secure guests, the architecture of PEF is > such that the guest still needs to talk to the ultravisor to enter > secure mode. Qemu has no directl way of knowing if the guest is in > secure mode, and certainly can't know until well after machine > creation time. > > To start a PEF-capable guest, use the command line options: > -object pef-guest,id=pef0 -machine confidential-guest-support=pef0 > > Signed-off-by: David Gibson <david@gibson.dropbear.id.au> > --- > docs/confidential-guest-support.txt | 2 + > docs/papr-pef.txt | 30 ++++++++ > hw/ppc/meson.build | 1 + > hw/ppc/pef.c | 115 ++++++++++++++++++++++++++++ > hw/ppc/spapr.c | 10 +++ > include/hw/ppc/pef.h | 26 +++++++ > target/ppc/kvm.c | 18 ----- > target/ppc/kvm_ppc.h | 6 -- > 8 files changed, 184 insertions(+), 24 deletions(-) > create mode 100644 docs/papr-pef.txt > create mode 100644 hw/ppc/pef.c > create mode 100644 include/hw/ppc/pef.h > > +static const TypeInfo pef_guest_info = { > + .parent = TYPE_OBJECT, > + .name = TYPE_PEF_GUEST, > + .instance_size = sizeof(PefGuestState), > + .interfaces = (InterfaceInfo[]) { > + { TYPE_CONFIDENTIAL_GUEST_SUPPORT }, > + { TYPE_USER_CREATABLE }, > + { } > + } > +}; IIUC, the earlier patch defines TYPE_CONFIDENTIAL_GUEST_SUPPORT as a object, but you're using it as an interface here. The later s390 patch uses it as a parent, which makes more sense given it is a declared as an object. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrangé" <berrange@redhat.com> To: David Gibson <david@gibson.dropbear.id.au> Cc: pair@us.ibm.com, Marcelo Tosatti <mtosatti@redhat.com>, brijesh.singh@amd.com, kvm@vger.kernel.org, david@redhat.com, qemu-devel@nongnu.org, frankja@linux.ibm.com, pragyansri.pathi@intel.com, mst@redhat.com, mdroth@linux.vnet.ibm.com, pasic@linux.ibm.com, Christian Borntraeger <borntraeger@de.ibm.com>, andi.kleen@intel.com, thuth@redhat.com, Eduardo Habkost <ehabkost@redhat.com>, richard.henderson@linaro.org, dgilbert@redhat.com, Greg Kurz <groug@kaod.org>, qemu-s390x@nongnu.org, jun.nakajima@intel.com, Cornelia Huck <cohuck@redhat.com>, qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com> Subject: Re: [PATCH v6 10/13] spapr: Add PEF based confidential guest support Date: Tue, 12 Jan 2021 09:56:12 +0000 [thread overview] Message-ID: <20210112095612.GE1360503@redhat.com> (raw) In-Reply-To: <20210112044508.427338-11-david@gibson.dropbear.id.au> On Tue, Jan 12, 2021 at 03:45:05PM +1100, David Gibson wrote: > Some upcoming POWER machines have a system called PEF (Protected > Execution Facility) which uses a small ultravisor to allow guests to > run in a way that they can't be eavesdropped by the hypervisor. The > effect is roughly similar to AMD SEV, although the mechanisms are > quite different. > > Most of the work of this is done between the guest, KVM and the > ultravisor, with little need for involvement by qemu. However qemu > does need to tell KVM to allow secure VMs. > > Because the availability of secure mode is a guest visible difference > which depends on having the right hardware and firmware, we don't > enable this by default. In order to run a secure guest you need to > create a "pef-guest" object and set the confidential-guest-support > property to point to it. > > Note that this just *allows* secure guests, the architecture of PEF is > such that the guest still needs to talk to the ultravisor to enter > secure mode. Qemu has no directl way of knowing if the guest is in > secure mode, and certainly can't know until well after machine > creation time. > > To start a PEF-capable guest, use the command line options: > -object pef-guest,id=pef0 -machine confidential-guest-support=pef0 > > Signed-off-by: David Gibson <david@gibson.dropbear.id.au> > --- > docs/confidential-guest-support.txt | 2 + > docs/papr-pef.txt | 30 ++++++++ > hw/ppc/meson.build | 1 + > hw/ppc/pef.c | 115 ++++++++++++++++++++++++++++ > hw/ppc/spapr.c | 10 +++ > include/hw/ppc/pef.h | 26 +++++++ > target/ppc/kvm.c | 18 ----- > target/ppc/kvm_ppc.h | 6 -- > 8 files changed, 184 insertions(+), 24 deletions(-) > create mode 100644 docs/papr-pef.txt > create mode 100644 hw/ppc/pef.c > create mode 100644 include/hw/ppc/pef.h > > +static const TypeInfo pef_guest_info = { > + .parent = TYPE_OBJECT, > + .name = TYPE_PEF_GUEST, > + .instance_size = sizeof(PefGuestState), > + .interfaces = (InterfaceInfo[]) { > + { TYPE_CONFIDENTIAL_GUEST_SUPPORT }, > + { TYPE_USER_CREATABLE }, > + { } > + } > +}; IIUC, the earlier patch defines TYPE_CONFIDENTIAL_GUEST_SUPPORT as a object, but you're using it as an interface here. The later s390 patch uses it as a parent, which makes more sense given it is a declared as an object. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-01-12 9:58 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-12 4:44 [PATCH v6 00/13] Generalize memory encryption models David Gibson 2021-01-12 4:44 ` David Gibson 2021-01-12 4:44 ` [PATCH v6 01/13] qom: Allow optional sugar props David Gibson 2021-01-12 4:44 ` David Gibson 2021-01-12 4:44 ` [PATCH v6 02/13] confidential guest support: Introduce new confidential guest support class David Gibson 2021-01-12 4:44 ` David Gibson 2021-01-12 9:46 ` Daniel P. Berrangé 2021-01-12 9:46 ` Daniel P. Berrangé 2021-01-13 2:09 ` David Gibson 2021-01-13 2:09 ` David Gibson 2021-01-12 4:44 ` [PATCH v6 03/13] sev: Remove false abstraction of flash encryption David Gibson 2021-01-12 4:44 ` David Gibson 2021-01-12 4:44 ` [PATCH v6 04/13] confidential guest support: Move side effect out of machine_set_memory_encryption() David Gibson 2021-01-12 4:44 ` David Gibson 2021-01-12 10:39 ` Greg Kurz 2021-01-12 4:45 ` [PATCH v6 05/13] confidential guest support: Rework the "memory-encryption" property David Gibson 2021-01-12 4:45 ` David Gibson 2021-01-12 10:59 ` Greg Kurz 2021-01-13 0:50 ` David Gibson 2021-01-13 0:50 ` David Gibson 2021-01-13 12:03 ` Dr. David Alan Gilbert 2021-01-13 12:03 ` Dr. David Alan Gilbert 2021-01-12 4:45 ` [PATCH v6 06/13] sev: Add Error ** to sev_kvm_init() David Gibson 2021-01-12 4:45 ` David Gibson 2021-01-12 4:45 ` [PATCH v6 07/13] confidential guest support: Introduce cgs "ready" flag David Gibson 2021-01-12 4:45 ` David Gibson 2021-01-12 4:45 ` [PATCH v6 08/13] confidential guest support: Move SEV initialization into arch specific code David Gibson 2021-01-12 4:45 ` David Gibson 2021-01-12 4:45 ` [PATCH v6 09/13] confidential guest support: Update documentation David Gibson 2021-01-12 4:45 ` David Gibson 2021-01-12 4:45 ` [PATCH v6 10/13] spapr: Add PEF based confidential guest support David Gibson 2021-01-12 4:45 ` David Gibson 2021-01-12 7:56 ` Christian Borntraeger 2021-01-12 7:56 ` Christian Borntraeger 2021-01-12 8:36 ` David Gibson 2021-01-12 8:36 ` David Gibson 2021-01-12 9:52 ` Daniel P. Berrangé 2021-01-12 9:52 ` Daniel P. Berrangé 2021-01-12 9:56 ` Daniel P. Berrangé [this message] 2021-01-12 9:56 ` Daniel P. Berrangé 2021-01-13 0:52 ` David Gibson 2021-01-13 0:52 ` David Gibson 2021-01-12 11:27 ` Greg Kurz 2021-01-13 0:56 ` David Gibson 2021-01-13 0:56 ` David Gibson 2021-01-12 4:45 ` [PATCH v6 11/13] spapr: PEF: prevent migration David Gibson 2021-01-12 4:45 ` David Gibson 2021-01-12 11:37 ` Greg Kurz 2021-01-12 4:45 ` [PATCH v6 12/13] confidential guest support: Alter virtio default properties for protected guests David Gibson 2021-01-12 4:45 ` David Gibson 2021-01-12 11:38 ` Greg Kurz 2021-01-12 4:45 ` [PATCH v6 13/13] s390: Recognize confidential-guest-support option David Gibson 2021-01-12 4:45 ` David Gibson 2021-01-12 8:15 ` Christian Borntraeger 2021-01-12 8:15 ` Christian Borntraeger 2021-01-12 11:36 ` Cornelia Huck 2021-01-12 11:36 ` Cornelia Huck 2021-01-12 11:48 ` Christian Borntraeger 2021-01-12 11:48 ` Christian Borntraeger 2021-01-12 11:49 ` Daniel P. Berrangé 2021-01-12 11:49 ` Daniel P. Berrangé 2021-01-13 0:57 ` David Gibson 2021-01-13 0:57 ` David Gibson 2021-01-13 6:57 ` Christian Borntraeger 2021-01-13 6:57 ` Christian Borntraeger 2021-01-13 23:56 ` David Gibson 2021-01-13 23:56 ` David Gibson 2021-01-12 9:54 ` Daniel P. Berrangé 2021-01-12 9:54 ` Daniel P. Berrangé
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210112095612.GE1360503@redhat.com \ --to=berrange@redhat.com \ --cc=andi.kleen@intel.com \ --cc=borntraeger@de.ibm.com \ --cc=brijesh.singh@amd.com \ --cc=cohuck@redhat.com \ --cc=david@gibson.dropbear.id.au \ --cc=david@redhat.com \ --cc=dgilbert@redhat.com \ --cc=ehabkost@redhat.com \ --cc=frankja@linux.ibm.com \ --cc=groug@kaod.org \ --cc=jun.nakajima@intel.com \ --cc=kvm@vger.kernel.org \ --cc=marcel.apfelbaum@gmail.com \ --cc=mdroth@linux.vnet.ibm.com \ --cc=mst@redhat.com \ --cc=mtosatti@redhat.com \ --cc=pair@us.ibm.com \ --cc=pasic@linux.ibm.com \ --cc=pbonzini@redhat.com \ --cc=pragyansri.pathi@intel.com \ --cc=qemu-devel@nongnu.org \ --cc=qemu-ppc@nongnu.org \ --cc=qemu-s390x@nongnu.org \ --cc=richard.henderson@linaro.org \ --cc=thuth@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.