From: kernel test robot <rong.a.chen@intel.com>
To: Vinod Koul <vkoul@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mark Brown <broonie@kernel.org>,
Wolfram Sang <wsa-dev@sang-engineering.com>
Cc: kbuild-all@lists.01.org, linux-arm-msm@vger.kernel.org,
Vinod Koul <vkoul@kernel.org>, Andy Gross <agross@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>
Subject: Re: [PATCH 4/7] spi: spi-geni-qcom: Add support for GPI dma
Date: Tue, 12 Jan 2021 19:02:47 +0800 [thread overview]
Message-ID: <20210112110247.GW399595@shao2-debian> (raw)
In-Reply-To: <20210111151651.1616813-5-vkoul@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 6616 bytes --]
Hi Vinod,
I love your patch! Perhaps something to improve:
[auto build test WARNING on v5.11-rc2]
[cannot apply to robh/for-next spi/for-next wsa/i2c/for-next linus/master v5.11-rc3 next-20210111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Vinod-Koul/Add-and-enable-GPI-DMA-users/20210111-232052
base: e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62
config: mips-randconfig-s031-20210111 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-208-g46a52ca4-dirty
# https://github.com/0day-ci/linux/commit/bcc874d4e76c4129ee33077e2828a311b2edcb96
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vinod-Koul/Add-and-enable-GPI-DMA-users/20210111-232052
git checkout bcc874d4e76c4129ee33077e2828a311b2edcb96
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <rong.a.chen@intel.com>
"sparse warnings: (new ones prefixed by >>)"
command-line: note: in included file:
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQUIRE redefined
builtin:0:0: sparse: this was the original definition
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_SEQ_CST redefined
builtin:0:0: sparse: this was the original definition
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQ_REL redefined
builtin:0:0: sparse: this was the original definition
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_RELEASE redefined
builtin:0:0: sparse: this was the original definition
>> drivers/spi/spi-geni-qcom.c:811:19: sparse: sparse: constant 0i is not a valid number
vim +811 drivers/spi/spi-geni-qcom.c
561de45f72bd5f9b Girish Mahadevan 2018-10-03 804
561de45f72bd5f9b Girish Mahadevan 2018-10-03 805 static int spi_geni_transfer_one(struct spi_master *spi,
561de45f72bd5f9b Girish Mahadevan 2018-10-03 806 struct spi_device *slv,
561de45f72bd5f9b Girish Mahadevan 2018-10-03 807 struct spi_transfer *xfer)
561de45f72bd5f9b Girish Mahadevan 2018-10-03 808 {
561de45f72bd5f9b Girish Mahadevan 2018-10-03 809 struct spi_geni_master *mas = spi_master_get_devdata(spi);
bcc874d4e76c4129 Vinod Koul 2021-01-11 810 unsigned long timeout, jiffies;
bcc874d4e76c4129 Vinod Koul 2021-01-11 @811 int ret = 0i, i;
561de45f72bd5f9b Girish Mahadevan 2018-10-03 812
561de45f72bd5f9b Girish Mahadevan 2018-10-03 813 /* Terminate and return success for 0 byte length transfer */
561de45f72bd5f9b Girish Mahadevan 2018-10-03 814 if (!xfer->len)
bcc874d4e76c4129 Vinod Koul 2021-01-11 815 return ret;
561de45f72bd5f9b Girish Mahadevan 2018-10-03 816
bcc874d4e76c4129 Vinod Koul 2021-01-11 817 if (mas->cur_xfer_mode == GENI_SE_FIFO) {
561de45f72bd5f9b Girish Mahadevan 2018-10-03 818 setup_fifo_xfer(xfer, mas, slv->mode, spi);
bcc874d4e76c4129 Vinod Koul 2021-01-11 819 } else {
bcc874d4e76c4129 Vinod Koul 2021-01-11 820 setup_gsi_xfer(xfer, mas, slv, spi);
bcc874d4e76c4129 Vinod Koul 2021-01-11 821 if (mas->num_xfers >= NUM_SPI_XFER ||
bcc874d4e76c4129 Vinod Koul 2021-01-11 822 (list_is_last(&xfer->transfer_list, &spi->cur_msg->transfers))) {
bcc874d4e76c4129 Vinod Koul 2021-01-11 823 for (i = 0 ; i < mas->num_tx_eot; i++) {
bcc874d4e76c4129 Vinod Koul 2021-01-11 824 jiffies = msecs_to_jiffies(SPI_XFER_TIMEOUT_MS);
bcc874d4e76c4129 Vinod Koul 2021-01-11 825 timeout = wait_for_completion_timeout(&mas->tx_cb, jiffies);
bcc874d4e76c4129 Vinod Koul 2021-01-11 826 if (timeout <= 0) {
bcc874d4e76c4129 Vinod Koul 2021-01-11 827 dev_err(mas->dev, "Tx[%d] timeout%lu\n", i, timeout);
bcc874d4e76c4129 Vinod Koul 2021-01-11 828 ret = -ETIMEDOUT;
bcc874d4e76c4129 Vinod Koul 2021-01-11 829 goto err_gsi_geni_transfer_one;
bcc874d4e76c4129 Vinod Koul 2021-01-11 830 }
bcc874d4e76c4129 Vinod Koul 2021-01-11 831 spi_finalize_current_transfer(spi);
bcc874d4e76c4129 Vinod Koul 2021-01-11 832 }
bcc874d4e76c4129 Vinod Koul 2021-01-11 833 for (i = 0 ; i < mas->num_rx_eot; i++) {
bcc874d4e76c4129 Vinod Koul 2021-01-11 834 jiffies = msecs_to_jiffies(SPI_XFER_TIMEOUT_MS);
bcc874d4e76c4129 Vinod Koul 2021-01-11 835 timeout = wait_for_completion_timeout(&mas->tx_cb, jiffies);
bcc874d4e76c4129 Vinod Koul 2021-01-11 836 if (timeout <= 0) {
bcc874d4e76c4129 Vinod Koul 2021-01-11 837 dev_err(mas->dev, "Rx[%d] timeout%lu\n", i, timeout);
bcc874d4e76c4129 Vinod Koul 2021-01-11 838 ret = -ETIMEDOUT;
bcc874d4e76c4129 Vinod Koul 2021-01-11 839 goto err_gsi_geni_transfer_one;
bcc874d4e76c4129 Vinod Koul 2021-01-11 840 }
bcc874d4e76c4129 Vinod Koul 2021-01-11 841 spi_finalize_current_transfer(spi);
bcc874d4e76c4129 Vinod Koul 2021-01-11 842 }
bcc874d4e76c4129 Vinod Koul 2021-01-11 843 if (mas->qn_err) {
bcc874d4e76c4129 Vinod Koul 2021-01-11 844 ret = -EIO;
bcc874d4e76c4129 Vinod Koul 2021-01-11 845 mas->qn_err = false;
bcc874d4e76c4129 Vinod Koul 2021-01-11 846 goto err_gsi_geni_transfer_one;
bcc874d4e76c4129 Vinod Koul 2021-01-11 847 }
bcc874d4e76c4129 Vinod Koul 2021-01-11 848 }
bcc874d4e76c4129 Vinod Koul 2021-01-11 849 }
bcc874d4e76c4129 Vinod Koul 2021-01-11 850
bcc874d4e76c4129 Vinod Koul 2021-01-11 851 return ret;
bcc874d4e76c4129 Vinod Koul 2021-01-11 852
bcc874d4e76c4129 Vinod Koul 2021-01-11 853 err_gsi_geni_transfer_one:
bcc874d4e76c4129 Vinod Koul 2021-01-11 854 dmaengine_terminate_all(mas->tx);
bcc874d4e76c4129 Vinod Koul 2021-01-11 855 return ret;
561de45f72bd5f9b Girish Mahadevan 2018-10-03 856 }
561de45f72bd5f9b Girish Mahadevan 2018-10-03 857
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40429 bytes --]
[-- Attachment #3: Type: text/plain, Size: 149 bytes --]
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <rong.a.chen@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 4/7] spi: spi-geni-qcom: Add support for GPI dma
Date: Tue, 12 Jan 2021 19:02:47 +0800 [thread overview]
Message-ID: <20210112110247.GW399595@shao2-debian> (raw)
In-Reply-To: <20210111151651.1616813-5-vkoul@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 6878 bytes --]
Hi Vinod,
I love your patch! Perhaps something to improve:
[auto build test WARNING on v5.11-rc2]
[cannot apply to robh/for-next spi/for-next wsa/i2c/for-next linus/master v5.11-rc3 next-20210111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Vinod-Koul/Add-and-enable-GPI-DMA-users/20210111-232052
base: e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62
config: mips-randconfig-s031-20210111 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-208-g46a52ca4-dirty
# https://github.com/0day-ci/linux/commit/bcc874d4e76c4129ee33077e2828a311b2edcb96
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vinod-Koul/Add-and-enable-GPI-DMA-users/20210111-232052
git checkout bcc874d4e76c4129ee33077e2828a311b2edcb96
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <rong.a.chen@intel.com>
"sparse warnings: (new ones prefixed by >>)"
command-line: note: in included file:
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQUIRE redefined
builtin:0:0: sparse: this was the original definition
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_SEQ_CST redefined
builtin:0:0: sparse: this was the original definition
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQ_REL redefined
builtin:0:0: sparse: this was the original definition
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_RELEASE redefined
builtin:0:0: sparse: this was the original definition
>> drivers/spi/spi-geni-qcom.c:811:19: sparse: sparse: constant 0i is not a valid number
vim +811 drivers/spi/spi-geni-qcom.c
561de45f72bd5f9b Girish Mahadevan 2018-10-03 804
561de45f72bd5f9b Girish Mahadevan 2018-10-03 805 static int spi_geni_transfer_one(struct spi_master *spi,
561de45f72bd5f9b Girish Mahadevan 2018-10-03 806 struct spi_device *slv,
561de45f72bd5f9b Girish Mahadevan 2018-10-03 807 struct spi_transfer *xfer)
561de45f72bd5f9b Girish Mahadevan 2018-10-03 808 {
561de45f72bd5f9b Girish Mahadevan 2018-10-03 809 struct spi_geni_master *mas = spi_master_get_devdata(spi);
bcc874d4e76c4129 Vinod Koul 2021-01-11 810 unsigned long timeout, jiffies;
bcc874d4e76c4129 Vinod Koul 2021-01-11 @811 int ret = 0i, i;
561de45f72bd5f9b Girish Mahadevan 2018-10-03 812
561de45f72bd5f9b Girish Mahadevan 2018-10-03 813 /* Terminate and return success for 0 byte length transfer */
561de45f72bd5f9b Girish Mahadevan 2018-10-03 814 if (!xfer->len)
bcc874d4e76c4129 Vinod Koul 2021-01-11 815 return ret;
561de45f72bd5f9b Girish Mahadevan 2018-10-03 816
bcc874d4e76c4129 Vinod Koul 2021-01-11 817 if (mas->cur_xfer_mode == GENI_SE_FIFO) {
561de45f72bd5f9b Girish Mahadevan 2018-10-03 818 setup_fifo_xfer(xfer, mas, slv->mode, spi);
bcc874d4e76c4129 Vinod Koul 2021-01-11 819 } else {
bcc874d4e76c4129 Vinod Koul 2021-01-11 820 setup_gsi_xfer(xfer, mas, slv, spi);
bcc874d4e76c4129 Vinod Koul 2021-01-11 821 if (mas->num_xfers >= NUM_SPI_XFER ||
bcc874d4e76c4129 Vinod Koul 2021-01-11 822 (list_is_last(&xfer->transfer_list, &spi->cur_msg->transfers))) {
bcc874d4e76c4129 Vinod Koul 2021-01-11 823 for (i = 0 ; i < mas->num_tx_eot; i++) {
bcc874d4e76c4129 Vinod Koul 2021-01-11 824 jiffies = msecs_to_jiffies(SPI_XFER_TIMEOUT_MS);
bcc874d4e76c4129 Vinod Koul 2021-01-11 825 timeout = wait_for_completion_timeout(&mas->tx_cb, jiffies);
bcc874d4e76c4129 Vinod Koul 2021-01-11 826 if (timeout <= 0) {
bcc874d4e76c4129 Vinod Koul 2021-01-11 827 dev_err(mas->dev, "Tx[%d] timeout%lu\n", i, timeout);
bcc874d4e76c4129 Vinod Koul 2021-01-11 828 ret = -ETIMEDOUT;
bcc874d4e76c4129 Vinod Koul 2021-01-11 829 goto err_gsi_geni_transfer_one;
bcc874d4e76c4129 Vinod Koul 2021-01-11 830 }
bcc874d4e76c4129 Vinod Koul 2021-01-11 831 spi_finalize_current_transfer(spi);
bcc874d4e76c4129 Vinod Koul 2021-01-11 832 }
bcc874d4e76c4129 Vinod Koul 2021-01-11 833 for (i = 0 ; i < mas->num_rx_eot; i++) {
bcc874d4e76c4129 Vinod Koul 2021-01-11 834 jiffies = msecs_to_jiffies(SPI_XFER_TIMEOUT_MS);
bcc874d4e76c4129 Vinod Koul 2021-01-11 835 timeout = wait_for_completion_timeout(&mas->tx_cb, jiffies);
bcc874d4e76c4129 Vinod Koul 2021-01-11 836 if (timeout <= 0) {
bcc874d4e76c4129 Vinod Koul 2021-01-11 837 dev_err(mas->dev, "Rx[%d] timeout%lu\n", i, timeout);
bcc874d4e76c4129 Vinod Koul 2021-01-11 838 ret = -ETIMEDOUT;
bcc874d4e76c4129 Vinod Koul 2021-01-11 839 goto err_gsi_geni_transfer_one;
bcc874d4e76c4129 Vinod Koul 2021-01-11 840 }
bcc874d4e76c4129 Vinod Koul 2021-01-11 841 spi_finalize_current_transfer(spi);
bcc874d4e76c4129 Vinod Koul 2021-01-11 842 }
bcc874d4e76c4129 Vinod Koul 2021-01-11 843 if (mas->qn_err) {
bcc874d4e76c4129 Vinod Koul 2021-01-11 844 ret = -EIO;
bcc874d4e76c4129 Vinod Koul 2021-01-11 845 mas->qn_err = false;
bcc874d4e76c4129 Vinod Koul 2021-01-11 846 goto err_gsi_geni_transfer_one;
bcc874d4e76c4129 Vinod Koul 2021-01-11 847 }
bcc874d4e76c4129 Vinod Koul 2021-01-11 848 }
bcc874d4e76c4129 Vinod Koul 2021-01-11 849 }
bcc874d4e76c4129 Vinod Koul 2021-01-11 850
bcc874d4e76c4129 Vinod Koul 2021-01-11 851 return ret;
bcc874d4e76c4129 Vinod Koul 2021-01-11 852
bcc874d4e76c4129 Vinod Koul 2021-01-11 853 err_gsi_geni_transfer_one:
bcc874d4e76c4129 Vinod Koul 2021-01-11 854 dmaengine_terminate_all(mas->tx);
bcc874d4e76c4129 Vinod Koul 2021-01-11 855 return ret;
561de45f72bd5f9b Girish Mahadevan 2018-10-03 856 }
561de45f72bd5f9b Girish Mahadevan 2018-10-03 857
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40429 bytes --]
next prev parent reply other threads:[~2021-01-12 11:04 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 15:16 [PATCH 0/7] Add and enable GPI DMA users Vinod Koul
2021-01-11 15:16 ` [PATCH 1/7] soc: qcom: geni: move GENI_IF_DISABLE_RO to common header Vinod Koul
2021-01-11 15:31 ` Bjorn Andersson
2021-01-11 15:16 ` [PATCH 2/7] soc: qcom: geni: move struct geni_wrapper to header Vinod Koul
2021-01-11 15:34 ` Bjorn Andersson
2021-01-11 17:43 ` Vinod Koul
2021-01-11 18:51 ` Bjorn Andersson
2021-01-11 15:16 ` [PATCH 3/7] soc: qcom: geni: Add support for gpi dma Vinod Koul
2021-01-11 15:40 ` Bjorn Andersson
2021-01-11 17:22 ` Vinod Koul
2021-01-13 0:01 ` Doug Anderson
2021-01-13 3:22 ` Vinod Koul
2021-01-11 15:16 ` [PATCH 4/7] spi: spi-geni-qcom: Add support for GPI dma Vinod Koul
2021-01-11 16:35 ` Mark Brown
2021-06-16 8:50 ` Vinod Koul
2021-06-16 11:35 ` Mark Brown
2021-06-16 12:02 ` Vinod Koul
2021-06-17 6:20 ` Vinod Koul
2021-01-11 17:19 ` Bjorn Andersson
2021-01-12 7:31 ` Lukas Wunner
2021-01-12 11:02 ` kernel test robot [this message]
2021-01-12 11:02 ` kernel test robot
2021-01-13 0:01 ` Doug Anderson
2021-01-13 3:24 ` Vinod Koul
2021-02-04 21:34 ` Dmitry Baryshkov
2021-01-11 15:16 ` [PATCH 5/7] i2c: qcom-geni: Add support for GPI DMA Vinod Koul
2021-01-11 18:14 ` Bjorn Andersson
2021-01-12 5:50 ` Vinod Koul
2021-01-11 15:16 ` [PATCH 6/7] arm64: dts: qcom: sdm845: Add gpi dma node Vinod Koul
2021-01-11 18:23 ` Bjorn Andersson
2021-01-12 4:21 ` Vinod Koul
2021-01-11 15:16 ` [PATCH 7/7] arm64: dts: qcom: sdm845: enable dma for spi Vinod Koul
2021-01-11 16:04 ` Konrad Dybcio
2021-01-11 17:46 ` Vinod Koul
2021-01-11 20:45 ` Konrad Dybcio
2021-01-12 4:19 ` Vinod Koul
2021-01-11 16:47 ` Doug Anderson
2021-01-11 17:56 ` Vinod Koul
2021-01-13 0:01 ` [PATCH 0/7] Add and enable GPI DMA users Doug Anderson
2021-01-13 3:03 ` Vinod Koul
2021-01-11 19:37 [PATCH 4/7] spi: spi-geni-qcom: Add support for GPI dma kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112110247.GW399595@shao2-debian \
--to=rong.a.chen@intel.com \
--cc=agross@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=sumit.semwal@linaro.org \
--cc=vkoul@kernel.org \
--cc=wsa-dev@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.