* [PATCH net v2] net: macb: Add default usrio config to default gem config
@ 2021-01-12 1:47 Atish Patra
2021-01-12 8:02 ` Nicolas Ferre
2021-01-13 2:11 ` Jakub Kicinski
0 siblings, 2 replies; 4+ messages in thread
From: Atish Patra @ 2021-01-12 1:47 UTC (permalink / raw)
To: netdev
Cc: Atish Patra, Claudiu Beznea, David S. Miller, Jakub Kicinski,
Andrew Lunn, Nicolas Ferre
There is no usrio config defined for default gem config leading to
a kernel panic devices that don't define a data. This issue can be
reprdouced with microchip polar fire soc where compatible string
is defined as "cdns,macb".
Fixes: edac63861db7 ("net: macb: Add default usrio config to default gem config")
Signed-off-by: Atish Patra <atish.patra@wdc.com>
---
Changes from v1->v2:
1. Fixed that fixes tag.
---
drivers/net/ethernet/cadence/macb_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 814a5b10141d..47ee72ab7002 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4590,6 +4590,7 @@ static const struct macb_config default_gem_config = {
.dma_burst_length = 16,
.clk_init = macb_clk_init,
.init = macb_init,
+ .usrio = &macb_default_usrio,
.jumbo_max_len = 10240,
};
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net v2] net: macb: Add default usrio config to default gem config
2021-01-12 1:47 [PATCH net v2] net: macb: Add default usrio config to default gem config Atish Patra
@ 2021-01-12 8:02 ` Nicolas Ferre
2021-01-13 2:11 ` Jakub Kicinski
1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Ferre @ 2021-01-12 8:02 UTC (permalink / raw)
To: Atish Patra, netdev
Cc: Claudiu Beznea, David S. Miller, Jakub Kicinski, Andrew Lunn
On 12/01/2021 at 02:47, Atish Patra wrote:
> There is no usrio config defined for default gem config leading to
> a kernel panic devices that don't define a data. This issue can be
> reproduced with microchip polar fire soc where compatible string
> is defined as "cdns,macb".
>
> Fixes: edac63861db7 ("net: macb: Add default usrio config to default gem config")
> Signed-off-by: Atish Patra <atish.patra@wdc.com>
Indeed.
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks! Best regards,
Nicolas
> ---
> Changes from v1->v2:
> 1. Fixed that fixes tag.
> ---
> drivers/net/ethernet/cadence/macb_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 814a5b10141d..47ee72ab7002 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4590,6 +4590,7 @@ static const struct macb_config default_gem_config = {
> .dma_burst_length = 16,
> .clk_init = macb_clk_init,
> .init = macb_init,
> + .usrio = &macb_default_usrio,
> .jumbo_max_len = 10240,
> };
>
> --
> 2.25.1
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v2] net: macb: Add default usrio config to default gem config
2021-01-12 1:47 [PATCH net v2] net: macb: Add default usrio config to default gem config Atish Patra
2021-01-12 8:02 ` Nicolas Ferre
@ 2021-01-13 2:11 ` Jakub Kicinski
2021-01-13 2:35 ` Atish Patra
1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2021-01-13 2:11 UTC (permalink / raw)
To: Atish Patra
Cc: netdev, Claudiu Beznea, David S. Miller, Andrew Lunn, Nicolas Ferre
On Mon, 11 Jan 2021 17:47:28 -0800 Atish Patra wrote:
> There is no usrio config defined for default gem config leading to
> a kernel panic devices that don't define a data. This issue can be
> reprdouced with microchip polar fire soc where compatible string
> is defined as "cdns,macb".
>
> Fixes: edac63861db7 ("net: macb: Add default usrio config to default gem config")
> Signed-off-by: Atish Patra <atish.patra@wdc.com>
> ---
> Changes from v1->v2:
> 1. Fixed that fixes tag.
Still needs a little bit of work:
Fixes tag: Fixes: edac63861db7 ("net: macb: Add default usrio config to default gem config")
Has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
Please make sure to keep Nic's Ack when reposting.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v2] net: macb: Add default usrio config to default gem config
2021-01-13 2:11 ` Jakub Kicinski
@ 2021-01-13 2:35 ` Atish Patra
0 siblings, 0 replies; 4+ messages in thread
From: Atish Patra @ 2021-01-13 2:35 UTC (permalink / raw)
To: kuba; +Cc: nicolas.ferre, claudiu.beznea, netdev, davem, andrew
On Tue, 2021-01-12 at 18:11 -0800, Jakub Kicinski wrote:
> On Mon, 11 Jan 2021 17:47:28 -0800 Atish Patra wrote:
> > There is no usrio config defined for default gem config leading to
> > a kernel panic devices that don't define a data. This issue can be
> > reprdouced with microchip polar fire soc where compatible string
> > is defined as "cdns,macb".
> >
> > Fixes: edac63861db7 ("net: macb: Add default usrio config to
> > default gem config")
> > Signed-off-by: Atish Patra <atish.patra@wdc.com>
> > ---
> > Changes from v1->v2:
> > 1. Fixed that fixes tag.
>
> Still needs a little bit of work:
>
> Fixes tag: Fixes: edac63861db7 ("net: macb: Add default usrio config
> to default gem config")
I am so sorry about this. I managed screw up my script to add Fixes tag
twice in a row :(.
> Has these problem(s):
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
>
> Please make sure to keep Nic's Ack when reposting.
Absolutely. Apologies again for the noise for this small fix.
--
Regards,
Atish
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-13 2:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-12 1:47 [PATCH net v2] net: macb: Add default usrio config to default gem config Atish Patra
2021-01-12 8:02 ` Nicolas Ferre
2021-01-13 2:11 ` Jakub Kicinski
2021-01-13 2:35 ` Atish Patra
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.