All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] CI: don't retry jobs
@ 2021-01-12 21:20 Ross Burton
  2021-01-14 19:24 ` [meta-arm] " Jon Mason
  0 siblings, 1 reply; 2+ messages in thread
From: Ross Burton @ 2021-01-12 21:20 UTC (permalink / raw)
  To: meta-arm

We can't retry jobs blindly because if a build fails with warnings we want
to fail the job.  With retries enabled the job fails, but is immediately
retried and builds quickly from sstate without any warnings.

Thus, all and any warnings are hidden.

Disabling retries. We may get occasional failures from Docker, we'll have
to see how bad they are.

Change-Id: Ib726f14a264c029fdf372fc1b8a02aca52bf5e4c
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .gitlab-ci.yml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 3ae0aa3..18f9ae1 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -8,8 +8,6 @@ stages:
 
 # Common job fragment to get a worker ready
 .setup:
-  # Retry because the runner is flakey (see https://gitlab.com/gitlab-org/gitlab-runner/-/issues/2890)
-  retry: 2
   stage: build
   variables:
     KAS_WORK_DIR: $CI_PROJECT_DIR/work
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [meta-arm] [PATCH] CI: don't retry jobs
  2021-01-12 21:20 [PATCH] CI: don't retry jobs Ross Burton
@ 2021-01-14 19:24 ` Jon Mason
  0 siblings, 0 replies; 2+ messages in thread
From: Jon Mason @ 2021-01-14 19:24 UTC (permalink / raw)
  To: Ross Burton; +Cc: meta-arm

On Tue, Jan 12, 2021 at 09:20:27PM +0000, Ross Burton wrote:
> We can't retry jobs blindly because if a build fails with warnings we want
> to fail the job.  With retries enabled the job fails, but is immediately
> retried and builds quickly from sstate without any warnings.
> 
> Thus, all and any warnings are hidden.
> 
> Disabling retries. We may get occasional failures from Docker, we'll have
> to see how bad they are.
> 
> Change-Id: Ib726f14a264c029fdf372fc1b8a02aca52bf5e4c
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---

Pulled into master.

Thanks,
Jon

>  .gitlab-ci.yml | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 3ae0aa3..18f9ae1 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -8,8 +8,6 @@ stages:
>  
>  # Common job fragment to get a worker ready
>  .setup:
> -  # Retry because the runner is flakey (see https://gitlab.com/gitlab-org/gitlab-runner/-/issues/2890)
> -  retry: 2
>    stage: build
>    variables:
>      KAS_WORK_DIR: $CI_PROJECT_DIR/work
> -- 
> 2.25.1
> 

> 
> 
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-14 19:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-12 21:20 [PATCH] CI: don't retry jobs Ross Burton
2021-01-14 19:24 ` [meta-arm] " Jon Mason

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.