Re: [PATCH net-next] udp: allow forwarding of plain (non-fraglisted) UDP GRO packets

Re: [PATCH net-next] udp: allow forwarding of plain (non-fraglisted) UDP GRO packets

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1630 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210112211536.261172-1-alobakin@pm.me>
References: <20210112211536.261172-1-alobakin@pm.me>
TO: Alexander Lobakin <alobakin@pm.me>
TO: "David S. Miller" <davem@davemloft.net>
CC: netdev(a)vger.kernel.org
TO: Jakub Kicinski <kuba@kernel.org>
CC: Eric Dumazet <edumazet@google.com>
CC: Edward Cree <ecree@solarflare.com>
CC: Willem de Bruijn <willemb@google.com>
CC: Steffen Klassert <steffen.klassert@secunet.com>
CC: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
CC: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
CC: linux-kernel(a)vger.kernel.org

Hi Alexander,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Alexander-Lobakin/udp-allow-forwarding-of-plain-non-fraglisted-UDP-GRO-packets/20210113-054212
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git c73a45965dd54a10c368191804b9de661eee1007
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
config: i386-randconfig-c001-20210112 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> net/ipv4/udp_offload.c:463:16-18: WARNING !A || A && B is equivalent to !A || B

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30195 bytes --]

[PATCH] udp: fix excluded_middle.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1907 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210112211536.261172-1-alobakin@pm.me>
References: <20210112211536.261172-1-alobakin@pm.me>
TO: Alexander Lobakin <alobakin@pm.me>
TO: "David S. Miller" <davem@davemloft.net>
CC: netdev(a)vger.kernel.org
TO: Jakub Kicinski <kuba@kernel.org>
CC: Eric Dumazet <edumazet@google.com>
CC: Edward Cree <ecree@solarflare.com>
CC: Willem de Bruijn <willemb@google.com>
CC: Steffen Klassert <steffen.klassert@secunet.com>
CC: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
CC: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

net/ipv4/udp_offload.c:463:16-18: WARNING !A || A && B is equivalent to !A || B


 Condition !A || A && B is equivalent to !A || B.

Generated by: scripts/coccinelle/misc/excluded_middle.cocci

CC: Alexander Lobakin <alobakin@pm.me>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

url:    https://github.com/0day-ci/linux/commits/Alexander-Lobakin/udp-allow-forwarding-of-plain-non-fraglisted-UDP-GRO-packets/20210113-054212
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git c73a45965dd54a10c368191804b9de661eee1007
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago

Please take the patch only if it's a positive warning. Thanks!

 udp_offload.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/ipv4/udp_offload.c
+++ b/net/ipv4/udp_offload.c
@@ -460,7 +460,7 @@ struct sk_buff *udp_gro_receive(struct l
 	if (skb->dev->features & NETIF_F_GRO_FRAGLIST)
 		NAPI_GRO_CB(skb)->is_flist = sk ? !udp_sk(sk)->gro_enabled: 1;
 
-	if (!sk || (sk && udp_sk(sk)->gro_enabled) ||
+	if (!sk || udp_sk(sk)->gro_enabled ||
 	    NAPI_GRO_CB(skb)->is_flist) {
 		pp = call_gro_receive(udp_gro_receive_segment, head, skb);
 		return pp;