* [PATCH] samples/kprobes: Add ARM support
@ 2021-01-12 15:40 Marc Koderer
2021-01-12 16:27 ` Masami Hiramatsu
2021-01-18 20:24 ` Jonathan Corbet
0 siblings, 2 replies; 3+ messages in thread
From: Marc Koderer @ 2021-01-12 15:40 UTC (permalink / raw)
To: linux-doc
Cc: Mauro Carvalho Chehab, Jonathan Corbet, Peter Zijlstra,
Alexandre Chartre, Christian Brauner, Masami Hiramatsu,
Marc Koderer
Plenty of architectures are already supported and this adds ARM
support.
Signed-off-by: Marc Koderer <marc@koderer.com>
---
samples/kprobes/kprobe_example.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
index 365905cb24b1..65a1188a8b3b 100644
--- a/samples/kprobes/kprobe_example.c
+++ b/samples/kprobes/kprobe_example.c
@@ -44,6 +44,10 @@ static int __kprobes handler_pre(struct kprobe *p, struct pt_regs *regs)
" pstate = 0x%lx\n",
p->symbol_name, p->addr, (long)regs->pc, (long)regs->pstate);
#endif
+#ifdef CONFIG_ARM
+ pr_info("<%s> pre_handler: p->addr = 0x%p, pc = 0x%lx, cpsr = 0x%lx\n",
+ p->symbol_name, p->addr, (long)regs->ARM_pc, (long)regs->ARM_cpsr);
+#endif
#ifdef CONFIG_S390
pr_info("<%s> pre_handler: p->addr, 0x%p, ip = 0x%lx, flags = 0x%lx\n",
p->symbol_name, p->addr, regs->psw.addr, regs->flags);
@@ -73,6 +77,10 @@ static void __kprobes handler_post(struct kprobe *p, struct pt_regs *regs,
pr_info("<%s> post_handler: p->addr = 0x%p, pstate = 0x%lx\n",
p->symbol_name, p->addr, (long)regs->pstate);
#endif
+#ifdef CONFIG_ARM
+ pr_info("<%s> post_handler: p->addr = 0x%p, cpsr = 0x%lx\n",
+ p->symbol_name, p->addr, (long)regs->ARM_cpsr);
+#endif
#ifdef CONFIG_S390
pr_info("<%s> pre_handler: p->addr, 0x%p, flags = 0x%lx\n",
p->symbol_name, p->addr, regs->flags);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] samples/kprobes: Add ARM support
2021-01-12 15:40 [PATCH] samples/kprobes: Add ARM support Marc Koderer
@ 2021-01-12 16:27 ` Masami Hiramatsu
2021-01-18 20:24 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2021-01-12 16:27 UTC (permalink / raw)
To: Marc Koderer
Cc: linux-doc, Mauro Carvalho Chehab, Jonathan Corbet,
Peter Zijlstra, Alexandre Chartre, Christian Brauner,
Masami Hiramatsu
On Tue, 12 Jan 2021 16:40:54 +0100
Marc Koderer <marc@koderer.com> wrote:
> Plenty of architectures are already supported and this adds ARM
> support.
>
> Signed-off-by: Marc Koderer <marc@koderer.com>
This looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you,
> ---
> samples/kprobes/kprobe_example.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
> index 365905cb24b1..65a1188a8b3b 100644
> --- a/samples/kprobes/kprobe_example.c
> +++ b/samples/kprobes/kprobe_example.c
> @@ -44,6 +44,10 @@ static int __kprobes handler_pre(struct kprobe *p, struct pt_regs *regs)
> " pstate = 0x%lx\n",
> p->symbol_name, p->addr, (long)regs->pc, (long)regs->pstate);
> #endif
> +#ifdef CONFIG_ARM
> + pr_info("<%s> pre_handler: p->addr = 0x%p, pc = 0x%lx, cpsr = 0x%lx\n",
> + p->symbol_name, p->addr, (long)regs->ARM_pc, (long)regs->ARM_cpsr);
> +#endif
> #ifdef CONFIG_S390
> pr_info("<%s> pre_handler: p->addr, 0x%p, ip = 0x%lx, flags = 0x%lx\n",
> p->symbol_name, p->addr, regs->psw.addr, regs->flags);
> @@ -73,6 +77,10 @@ static void __kprobes handler_post(struct kprobe *p, struct pt_regs *regs,
> pr_info("<%s> post_handler: p->addr = 0x%p, pstate = 0x%lx\n",
> p->symbol_name, p->addr, (long)regs->pstate);
> #endif
> +#ifdef CONFIG_ARM
> + pr_info("<%s> post_handler: p->addr = 0x%p, cpsr = 0x%lx\n",
> + p->symbol_name, p->addr, (long)regs->ARM_cpsr);
> +#endif
> #ifdef CONFIG_S390
> pr_info("<%s> pre_handler: p->addr, 0x%p, flags = 0x%lx\n",
> p->symbol_name, p->addr, regs->flags);
> --
> 2.20.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] samples/kprobes: Add ARM support
2021-01-12 15:40 [PATCH] samples/kprobes: Add ARM support Marc Koderer
2021-01-12 16:27 ` Masami Hiramatsu
@ 2021-01-18 20:24 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2021-01-18 20:24 UTC (permalink / raw)
To: Marc Koderer
Cc: linux-doc, Mauro Carvalho Chehab, Peter Zijlstra,
Alexandre Chartre, Christian Brauner, Masami Hiramatsu
On Tue, 12 Jan 2021 16:40:54 +0100
Marc Koderer <marc@koderer.com> wrote:
> Plenty of architectures are already supported and this adds ARM
> support.
>
> Signed-off-by: Marc Koderer <marc@koderer.com>
> ---
> samples/kprobes/kprobe_example.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-18 20:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-12 15:40 [PATCH] samples/kprobes: Add ARM support Marc Koderer
2021-01-12 16:27 ` Masami Hiramatsu
2021-01-18 20:24 ` Jonathan Corbet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.