[freescale-fslc:pr/213 8321/15914] drivers/spi/spi-nxp-fspi.c:1153:5: sparse: sparse: symbol 'nxp_fspi_runtime_suspend' was not declared. Should it be

[freescale-fslc:pr/213 8321/15914] drivers/spi/spi-nxp-fspi.c:1153:5: sparse: sparse: symbol 'nxp_fspi_runtime_suspend' was not declared. Should it be

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]

tree:   https://github.com/Freescale/linux-fslc pr/213
head:   9b7fddcbe334d0df744fa6ced6502d51489ac532
commit: 2c4cf9ce2fcf9581d6625025b76ae73f77dde922 [8321/15914] MLK-23644: spi: spi-nxp-fspi: enable runtime pm for fspi
config: i386-randconfig-s001-20210112 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-208-g46a52ca4-dirty
        # https://github.com/Freescale/linux-fslc/commit/2c4cf9ce2fcf9581d6625025b76ae73f77dde922
        git remote add freescale-fslc https://github.com/Freescale/linux-fslc
        git fetch --no-tags freescale-fslc pr/213
        git checkout 2c4cf9ce2fcf9581d6625025b76ae73f77dde922
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
   drivers/spi/spi-nxp-fspi.c:479:25: sparse: sparse: cast from restricted __be32
>> drivers/spi/spi-nxp-fspi.c:1153:5: sparse: sparse: symbol 'nxp_fspi_runtime_suspend' was not declared. Should it be static?
>> drivers/spi/spi-nxp-fspi.c:1162:5: sparse: sparse: symbol 'nxp_fspi_runtime_resume' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32498 bytes --]

[RFC PATCH freescale-fslc] MLK-23644: spi: spi-nxp-fspi: nxp_fspi_runtime_suspend() can be static

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]


Fixes: 2c4cf9ce2fcf ("MLK-23644: spi: spi-nxp-fspi: enable runtime pm for fspi")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 spi-nxp-fspi.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
index db9302ea92db3..bb943168f2f8d 100644
--- a/drivers/spi/spi-nxp-fspi.c
+++ b/drivers/spi/spi-nxp-fspi.c
@@ -1150,7 +1150,7 @@ static int nxp_fspi_need_reinit(struct nxp_fspi *f)
 }
 
 
-int nxp_fspi_runtime_suspend(struct device *dev)
+static int nxp_fspi_runtime_suspend(struct device *dev)
 {
 	struct nxp_fspi *f = dev_get_drvdata(dev);
 
@@ -1159,7 +1159,7 @@ int nxp_fspi_runtime_suspend(struct device *dev)
 	return 0;
 }
 
-int nxp_fspi_runtime_resume(struct device *dev)
+static int nxp_fspi_runtime_resume(struct device *dev)
 {
 	struct nxp_fspi *f = dev_get_drvdata(dev);