Re: [PATCH] blk: avoid divide-by-zero with zero granularity

From: kernel test robot <lkp@intel.com>
To: Li Feng <fengli@smartx.com>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, lifeng1519@gmail.com,
	Li Feng <fengli@smartx.com>
Subject: Re: [PATCH] blk: avoid divide-by-zero with zero granularity
Date: Wed, 13 Jan 2021 06:57:01 +0800	[thread overview]
Message-ID: <202101130600.nAzPoQgq-lkp@intel.com> (raw)
In-Reply-To: <20210112152951.154024-1-fengli@smartx.com>

[-- Attachment #1: Type: text/plain, Size: 3642 bytes --]

Hi Li,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on block/for-next]
[also build test WARNING on v5.11-rc3 next-20210112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Li-Feng/blk-avoid-divide-by-zero-with-zero-granularity/20210112-233454
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: microblaze-randconfig-c004-20210112 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/796e67f6b22f94f155669688e5e08281621b3ee6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Li-Feng/blk-avoid-divide-by-zero-with-zero-granularity/20210112-233454
        git checkout 796e67f6b22f94f155669688e5e08281621b3ee6
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/blk-cgroup.h:23,
                    from include/linux/writeback.h:14,
                    from include/linux/memcontrol.h:22,
                    from include/net/sock.h:53,
                    from include/linux/tcp.h:19,
                    from include/linux/ipv6.h:88,
                    from include/net/ipv6.h:12,
                    from include/net/inetpeer.h:16,
                    from include/net/ip_fib.h:20,
                    from include/net/switchdev.h:13,
                    from net/bridge/br.c:18:
   include/linux/blkdev.h: In function 'queue_limit_alignment_offset':
>> include/linux/blkdev.h:1492:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
    1492 |  unsigned int alignment = sector_div(sector, granularity >> SECTOR_SHIFT)
         |  ^~~~~~~~

vim +1492 include/linux/blkdev.h

c72758f33784e5e2 Martin K. Petersen 2009-05-22  1484  
e03a72e13648ac62 Martin K. Petersen 2010-01-11  1485  static inline int queue_limit_alignment_offset(struct queue_limits *lim, sector_t sector)
81744ee44ab2845c Martin K. Petersen 2009-12-29  1486  {
81744ee44ab2845c Martin K. Petersen 2009-12-29  1487  	unsigned int granularity = max(lim->physical_block_size, lim->io_min);
796e67f6b22f94f1 Li Feng            2021-01-12  1488  	granularity = granularity >> SECTOR_SHIFT;
796e67f6b22f94f1 Li Feng            2021-01-12  1489  	if (!granularity)
796e67f6b22f94f1 Li Feng            2021-01-12  1490  		return 0;
796e67f6b22f94f1 Li Feng            2021-01-12  1491  
233bde21aa43516b Bart Van Assche    2018-03-14 @1492  	unsigned int alignment = sector_div(sector, granularity >> SECTOR_SHIFT)
233bde21aa43516b Bart Van Assche    2018-03-14  1493  		<< SECTOR_SHIFT;
81744ee44ab2845c Martin K. Petersen 2009-12-29  1494  
b8839b8c55f3fdd6 Mike Snitzer       2014-10-08  1495  	return (granularity + lim->alignment_offset - alignment) % granularity;
c72758f33784e5e2 Martin K. Petersen 2009-05-22  1496  }
c72758f33784e5e2 Martin K. Petersen 2009-05-22  1497  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30584 bytes --]