All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] crypto: reduce minimum alignment of on-stack structures
Date: Wed, 13 Jan 2021 17:26:52 +1100	[thread overview]
Message-ID: <20210113062652.GA12495@gondor.apana.org.au> (raw)
In-Reply-To: <CAMj1kXE8SPE+2HazN6whvYr5anZWJJ8n4UAVyotPV1XySkk0Rg@mail.gmail.com>

On Fri, Jan 08, 2021 at 11:49:32PM +0100, Ard Biesheuvel wrote:
>
> The assumption is that ARCH_SLAB_MINALIGN should be sufficient for any
> POD type, But I guess that in order to be fully correct, the actual
> alignment of the struct type should be ARCH_SLAB_MINALIGN, and __ctx
> should just be padded out so it appears at an offset that is a
> multiple of ARCH_KMALLOC_ALIGN.

How about just leaving the skcpiher alone for now and change shash
only?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Eric Biggers <ebiggers@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] crypto: reduce minimum alignment of on-stack structures
Date: Wed, 13 Jan 2021 17:26:52 +1100	[thread overview]
Message-ID: <20210113062652.GA12495@gondor.apana.org.au> (raw)
In-Reply-To: <CAMj1kXE8SPE+2HazN6whvYr5anZWJJ8n4UAVyotPV1XySkk0Rg@mail.gmail.com>

On Fri, Jan 08, 2021 at 11:49:32PM +0100, Ard Biesheuvel wrote:
>
> The assumption is that ARCH_SLAB_MINALIGN should be sufficient for any
> POD type, But I guess that in order to be fully correct, the actual
> alignment of the struct type should be ARCH_SLAB_MINALIGN, and __ctx
> should just be padded out so it appears at an offset that is a
> multiple of ARCH_KMALLOC_ALIGN.

How about just leaving the skcpiher alone for now and change shash
only?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-13  6:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 17:17 [PATCH v2] crypto: reduce minimum alignment of on-stack structures Ard Biesheuvel
2021-01-08 17:17 ` Ard Biesheuvel
2021-01-08 21:16 ` Eric Biggers
2021-01-08 21:16   ` Eric Biggers
2021-01-08 22:49   ` Ard Biesheuvel
2021-01-08 22:49     ` Ard Biesheuvel
2021-01-13  6:26     ` Herbert Xu [this message]
2021-01-13  6:26       ` Herbert Xu
2021-01-13  8:18       ` Ard Biesheuvel
2021-01-13  8:18         ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210113062652.GA12495@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=ebiggers@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.