All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] mm/dmapool: Use might_alloc()
@ 2021-01-13 13:50 ` Daniel Vetter
  0 siblings, 0 replies; 11+ messages in thread
From: Daniel Vetter @ 2021-01-13 13:50 UTC (permalink / raw)
  To: LKML
  Cc: Intel Graphics Development, Daniel Vetter, Daniel Vetter,
	Andrew Morton, linux-mm

Now that my little helper has landed, use it more. On top of the
existing check this also uses lockdep through the fs_reclaim
annotations.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
--
v2: git add everything ... :-/
---
 mm/dmapool.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/dmapool.c b/mm/dmapool.c
index a97c97232337..f3791532fef2 100644
--- a/mm/dmapool.c
+++ b/mm/dmapool.c
@@ -28,6 +28,7 @@
 #include <linux/mutex.h>
 #include <linux/poison.h>
 #include <linux/sched.h>
+#include <linux/sched/mm.h>
 #include <linux/slab.h>
 #include <linux/stat.h>
 #include <linux/spinlock.h>
@@ -319,7 +320,7 @@ void *dma_pool_alloc(struct dma_pool *pool, gfp_t mem_flags,
 	size_t offset;
 	void *retval;
 
-	might_sleep_if(gfpflags_allow_blocking(mem_flags));
+	might_alloc(mem_flags);
 
 	spin_lock_irqsave(&pool->lock, flags);
 	list_for_each_entry(page, &pool->page_list, page_list) {
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH 1/2] mm/dmapool: Use might_alloc()
@ 2021-01-13 13:50 ` Daniel Vetter
  0 siblings, 0 replies; 11+ messages in thread
From: Daniel Vetter @ 2021-01-13 13:50 UTC (permalink / raw)
  To: LKML
  Cc: linux-mm, Daniel Vetter, Intel Graphics Development,
	Andrew Morton, Daniel Vetter

Now that my little helper has landed, use it more. On top of the
existing check this also uses lockdep through the fs_reclaim
annotations.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
--
v2: git add everything ... :-/
---
 mm/dmapool.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/dmapool.c b/mm/dmapool.c
index a97c97232337..f3791532fef2 100644
--- a/mm/dmapool.c
+++ b/mm/dmapool.c
@@ -28,6 +28,7 @@
 #include <linux/mutex.h>
 #include <linux/poison.h>
 #include <linux/sched.h>
+#include <linux/sched/mm.h>
 #include <linux/slab.h>
 #include <linux/stat.h>
 #include <linux/spinlock.h>
@@ -319,7 +320,7 @@ void *dma_pool_alloc(struct dma_pool *pool, gfp_t mem_flags,
 	size_t offset;
 	void *retval;
 
-	might_sleep_if(gfpflags_allow_blocking(mem_flags));
+	might_alloc(mem_flags);
 
 	spin_lock_irqsave(&pool->lock, flags);
 	list_for_each_entry(page, &pool->page_list, page_list) {
-- 
2.29.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [PATCH 2/2] bdi: Use might_alloc()
  2021-01-13 13:50 ` [Intel-gfx] " Daniel Vetter
@ 2021-01-13 13:50   ` Daniel Vetter
  -1 siblings, 0 replies; 11+ messages in thread
From: Daniel Vetter @ 2021-01-13 13:50 UTC (permalink / raw)
  To: LKML
  Cc: Intel Graphics Development, Daniel Vetter, Daniel Vetter,
	Andrew Morton, linux-mm

Now that my little helper has landed, use it more. On top of the
existing check this also uses lockdep through the fs_reclaim
annotations.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
--
v2: git add everything ... oops
---
 mm/backing-dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index e33797579338..5666a0056580 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -580,7 +580,7 @@ struct bdi_writeback *wb_get_create(struct backing_dev_info *bdi,
 {
 	struct bdi_writeback *wb;
 
-	might_sleep_if(gfpflags_allow_blocking(gfp));
+	might_alloc(gfp);
 
 	if (!memcg_css->parent)
 		return &bdi->wb;
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH 2/2] bdi: Use might_alloc()
@ 2021-01-13 13:50   ` Daniel Vetter
  0 siblings, 0 replies; 11+ messages in thread
From: Daniel Vetter @ 2021-01-13 13:50 UTC (permalink / raw)
  To: LKML
  Cc: linux-mm, Daniel Vetter, Intel Graphics Development,
	Andrew Morton, Daniel Vetter

Now that my little helper has landed, use it more. On top of the
existing check this also uses lockdep through the fs_reclaim
annotations.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
--
v2: git add everything ... oops
---
 mm/backing-dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index e33797579338..5666a0056580 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -580,7 +580,7 @@ struct bdi_writeback *wb_get_create(struct backing_dev_info *bdi,
 {
 	struct bdi_writeback *wb;
 
-	might_sleep_if(gfpflags_allow_blocking(gfp));
+	might_alloc(gfp);
 
 	if (!memcg_css->parent)
 		return &bdi->wb;
-- 
2.29.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] mm/dmapool: Use might_alloc()
  2021-01-13 13:50 ` [Intel-gfx] " Daniel Vetter
  (?)
  (?)
@ 2021-01-13 15:04 ` Patchwork
  -1 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-01-13 15:04 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] mm/dmapool: Use might_alloc()
URL   : https://patchwork.freedesktop.org/series/85808/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
9d86fee06af3 mm/dmapool: Use might_alloc()
-:34: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@ffwll.ch>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>'

total: 0 errors, 1 warnings, 0 checks, 15 lines checked
9d213951b7bf bdi: Use might_alloc()
-:26: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@ffwll.ch>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] mm/dmapool: Use might_alloc()
  2021-01-13 13:50 ` [Intel-gfx] " Daniel Vetter
                   ` (2 preceding siblings ...)
  (?)
@ 2021-01-13 15:35 ` Patchwork
  -1 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-01-13 15:35 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: intel-gfx


[-- Attachment #1.1: Type: text/plain, Size: 3305 bytes --]

== Series Details ==

Series: series starting with [1/2] mm/dmapool: Use might_alloc()
URL   : https://patchwork.freedesktop.org/series/85808/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9602 -> Patchwork_19334
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/index.html

Known issues
------------

  Here are the changes found in Patchwork_19334 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_cs_nop@fork-gfx0:
    - fi-tgl-y:           NOTRUN -> [SKIP][1] ([fdo#109315] / [i915#2575]) +15 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/fi-tgl-y/igt@amdgpu/amd_cs_nop@fork-gfx0.html

  * igt@gem_exec_suspend@basic-s3:
    - fi-tgl-y:           [PASS][2] -> [DMESG-WARN][3] ([i915#2411] / [i915#402])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html

  * igt@vgem_basic@sysfs:
    - fi-tgl-y:           [PASS][4] -> [DMESG-WARN][5] ([i915#402]) +1 similar issue
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/fi-tgl-y/igt@vgem_basic@sysfs.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/fi-tgl-y/igt@vgem_basic@sysfs.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_lrc:
    - fi-bsw-n3050:       [DMESG-FAIL][6] ([i915#2675]) -> [PASS][7]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html

  * igt@prime_self_import@basic-with_one_bo_two_files:
    - fi-tgl-y:           [DMESG-WARN][8] ([i915#402]) -> [PASS][9] +1 similar issue
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html

  
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2675]: https://gitlab.freedesktop.org/drm/intel/issues/2675
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402


Participating hosts (43 -> 39)
------------------------------

  Missing    (4): fi-ctg-p8600 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u 


Build changes
-------------

  * Linux: CI_DRM_9602 -> Patchwork_19334

  CI-20190529: 20190529
  CI_DRM_9602: 0e9e2e0eb03ba457a9ce479b8276be88761320ca @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5957: 2a2b3418f7458dfa1fac255cc5c71603f617690a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_19334: 9d213951b7bfd74093f10235ba412ef3f0ee1da5 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

9d213951b7bf bdi: Use might_alloc()
9d86fee06af3 mm/dmapool: Use might_alloc()

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/index.html

[-- Attachment #1.2: Type: text/html, Size: 4161 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] mm/dmapool: Use might_alloc()
  2021-01-13 13:50 ` [Intel-gfx] " Daniel Vetter
                   ` (3 preceding siblings ...)
  (?)
@ 2021-01-13 20:16 ` Patchwork
  -1 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-01-13 20:16 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: intel-gfx


[-- Attachment #1.1: Type: text/plain, Size: 24673 bytes --]

== Series Details ==

Series: series starting with [1/2] mm/dmapool: Use might_alloc()
URL   : https://patchwork.freedesktop.org/series/85808/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_9602_full -> Patchwork_19334_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_19334_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_19334_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_19334_full:

### CI changes ###

#### Possible regressions ####

  * boot:
    - shard-tglb:         ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [FAIL][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb8/boot.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb8/boot.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb8/boot.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb7/boot.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb7/boot.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb7/boot.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb6/boot.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb6/boot.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb6/boot.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb5/boot.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb5/boot.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb5/boot.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb5/boot.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb3/boot.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb3/boot.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb3/boot.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb3/boot.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb2/boot.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb2/boot.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb2/boot.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb1/boot.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb1/boot.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb1/boot.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb1/boot.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb8/boot.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb8/boot.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb8/boot.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb7/boot.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb7/boot.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb7/boot.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb7/boot.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb6/boot.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb6/boot.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb6/boot.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb6/boot.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb6/boot.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb5/boot.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb5/boot.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb5/boot.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb5/boot.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb3/boot.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb3/boot.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb3/boot.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb2/boot.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb2/boot.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb2/boot.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb1/boot.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb1/boot.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb1/boot.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb8/boot.html

  

### IGT changes ###

#### Possible regressions ####

  * igt@gem_request_retire@retire-vma-not-inactive:
    - shard-iclb:         [PASS][51] -> [INCOMPLETE][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-iclb6/igt@gem_request_retire@retire-vma-not-inactive.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-iclb1/igt@gem_request_retire@retire-vma-not-inactive.html

  * igt@kms_cursor_legacy@pipe-b-single-move:
    - shard-glk:          [PASS][53] -> [INCOMPLETE][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-glk8/igt@kms_cursor_legacy@pipe-b-single-move.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-glk7/igt@kms_cursor_legacy@pipe-b-single-move.html

  
Known issues
------------

  Here are the changes found in Patchwork_19334_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_eio@reset-stress:
    - shard-skl:          [PASS][55] -> [FAIL][56] ([i915#2771])
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-skl1/igt@gem_eio@reset-stress.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-skl4/igt@gem_eio@reset-stress.html

  * igt@gem_exec_whisper@basic-queues-forked-all:
    - shard-glk:          [PASS][57] -> [DMESG-WARN][58] ([i915#118] / [i915#95])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-glk6/igt@gem_exec_whisper@basic-queues-forked-all.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-glk2/igt@gem_exec_whisper@basic-queues-forked-all.html

  * igt@gem_huc_copy@huc-copy:
    - shard-tglb:         [PASS][59] -> [SKIP][60] ([i915#2190])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb8/igt@gem_huc_copy@huc-copy.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb6/igt@gem_huc_copy@huc-copy.html

  * igt@kms_big_fb@y-tiled-8bpp-rotate-0:
    - shard-skl:          [PASS][61] -> [DMESG-WARN][62] ([i915#1982]) +1 similar issue
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-skl10/igt@kms_big_fb@y-tiled-8bpp-rotate-0.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-skl9/igt@kms_big_fb@y-tiled-8bpp-rotate-0.html

  * igt@kms_color_chamelium@pipe-a-ctm-negative:
    - shard-skl:          NOTRUN -> [SKIP][63] ([fdo#109271] / [fdo#111827]) +1 similar issue
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-skl1/igt@kms_color_chamelium@pipe-a-ctm-negative.html

  * igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen:
    - shard-skl:          [PASS][64] -> [FAIL][65] ([i915#54]) +3 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen.html

  * igt@kms_cursor_crc@pipe-b-cursor-suspend:
    - shard-skl:          [PASS][66] -> [INCOMPLETE][67] ([i915#2405] / [i915#300])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-skl3/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html

  * igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
    - shard-tglb:         [PASS][68] -> [FAIL][69] ([i915#2346])
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb8/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb2/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html

  * igt@kms_flip@flip-vs-suspend@a-vga1:
    - shard-snb:          [PASS][70] -> [DMESG-WARN][71] ([i915#42])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-snb5/igt@kms_flip@flip-vs-suspend@a-vga1.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-snb5/igt@kms_flip@flip-vs-suspend@a-vga1.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite:
    - shard-skl:          NOTRUN -> [SKIP][72] ([fdo#109271]) +13 similar issues
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-skl9/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-blt:
    - shard-skl:          [PASS][73] -> [FAIL][74] ([i915#49])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-blt.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-blt.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [PASS][75] -> [FAIL][76] ([fdo#108145] / [i915#265]) +1 similar issue
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_properties@connector-properties-legacy:
    - shard-kbl:          [PASS][77] -> [DMESG-WARN][78] ([i915#165] / [i915#180] / [i915#78])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-kbl4/igt@kms_properties@connector-properties-legacy.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-kbl2/igt@kms_properties@connector-properties-legacy.html

  * igt@kms_psr@psr2_sprite_mmap_cpu:
    - shard-iclb:         [PASS][79] -> [SKIP][80] ([fdo#109441]) +1 similar issue
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_cpu.html

  
#### Possible fixes ####

  * igt@gem_ctx_persistence@close-replace-race:
    - shard-glk:          [TIMEOUT][81] ([i915#2918]) -> [PASS][82]
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-glk6/igt@gem_ctx_persistence@close-replace-race.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-glk2/igt@gem_ctx_persistence@close-replace-race.html

  * {igt@gem_exec_fair@basic-none-share@rcs0}:
    - shard-iclb:         [FAIL][83] ([i915#2842]) -> [PASS][84]
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-iclb1/igt@gem_exec_fair@basic-none-share@rcs0.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-iclb4/igt@gem_exec_fair@basic-none-share@rcs0.html

  * {igt@gem_exec_fair@basic-pace-share@rcs0}:
    - shard-tglb:         [FAIL][85] ([i915#2842]) -> [PASS][86]
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * {igt@gem_exec_fair@basic-pace@vcs0}:
    - shard-kbl:          [FAIL][87] ([i915#2842]) -> [PASS][88]
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-kbl2/igt@gem_exec_fair@basic-pace@vcs0.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs0.html

  * {igt@gem_exec_fair@basic-throttle@rcs0}:
    - shard-glk:          [FAIL][89] ([i915#2842]) -> [PASS][90] +1 similar issue
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-glk6/igt@gem_exec_fair@basic-throttle@rcs0.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-glk2/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_exec_whisper@basic-queues-forked:
    - shard-glk:          [DMESG-WARN][91] ([i915#118] / [i915#95]) -> [PASS][92] +1 similar issue
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-glk9/igt@gem_exec_whisper@basic-queues-forked.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-glk1/igt@gem_exec_whisper@basic-queues-forked.html

  * igt@i915_selftest@live@gt_heartbeat:
    - shard-skl:          [DMESG-FAIL][93] ([i915#2291] / [i915#541]) -> [PASS][94]
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-skl10/igt@i915_selftest@live@gt_heartbeat.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-skl9/igt@i915_selftest@live@gt_heartbeat.html

  * igt@kms_async_flips@test-time-stamp:
    - shard-tglb:         [FAIL][95] ([i915#2597]) -> [PASS][96]
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb1/igt@kms_async_flips@test-time-stamp.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb6/igt@kms_async_flips@test-time-stamp.html

  * igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen:
    - shard-skl:          [FAIL][97] ([i915#54]) -> [PASS][98] +7 similar issues
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-skl1/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-skl7/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html

  * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
    - shard-glk:          [FAIL][99] ([i915#72]) -> [PASS][100]
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-glk9/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-glk1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html

  * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
    - shard-skl:          [FAIL][101] ([i915#2346]) -> [PASS][102]
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html

  * igt@kms_flip@flip-vs-blocking-wf-vblank@c-edp1:
    - shard-skl:          [FAIL][103] ([i915#2122]) -> [PASS][104]
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-skl7/igt@kms_flip@flip-vs-blocking-wf-vblank@c-edp1.html
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-skl10/igt@kms_flip@flip-vs-blocking-wf-vblank@c-edp1.html

  * igt@kms_flip@modeset-vs-vblank-race-interruptible@b-edp1:
    - shard-skl:          [FAIL][105] ([i915#407]) -> [PASS][106]
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-skl6/igt@kms_flip@modeset-vs-vblank-race-interruptible@b-edp1.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-skl2/igt@kms_flip@modeset-vs-vblank-race-interruptible@b-edp1.html

  * igt@kms_hdr@bpc-switch-suspend:
    - shard-skl:          [FAIL][107] ([i915#1188]) -> [PASS][108] +1 similar issue
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-skl8/igt@kms_hdr@bpc-switch-suspend.html
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-skl10/igt@kms_hdr@bpc-switch-suspend.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [SKIP][109] ([fdo#109441]) -> [PASS][110] +2 similar issues
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-iclb2/igt@kms_psr@psr2_cursor_render.html

  * igt@perf@polling-parameterized:
    - shard-tglb:         [FAIL][111] ([i915#1542]) -> [PASS][112]
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb7/igt@perf@polling-parameterized.html
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb8/igt@perf@polling-parameterized.html

  
#### Warnings ####

  * igt@i915_pm_dc@dc3co-vpb-simulation:
    - shard-iclb:         [SKIP][113] -> [SKIP][114] ([i915#588])
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-iclb6/igt@i915_pm_dc@dc3co-vpb-simulation.html
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html

  * igt@i915_pm_rc6_residency@rc6-fence:
    - shard-iclb:         [WARN][115] ([i915#2681] / [i915#2684]) -> [WARN][116] ([i915#1804] / [i915#2684])
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-iclb8/igt@i915_pm_rc6_residency@rc6-fence.html
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-iclb4/igt@i915_pm_rc6_residency@rc6-fence.html

  * igt@i915_pm_rc6_residency@rc6-idle:
    - shard-iclb:         [WARN][117] ([i915#1804] / [i915#2684]) -> [WARN][118] ([i915#2684])
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-iclb7/igt@i915_pm_rc6_residency@rc6-idle.html
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html

  * igt@runner@aborted:
    - shard-kbl:          [FAIL][119] ([i915#2295]) -> ([FAIL][120], [FAIL][121]) ([i915#2295] / [i915#2426])
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-kbl7/igt@runner@aborted.html
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-kbl3/igt@runner@aborted.html
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-kbl7/igt@runner@aborted.html
    - shard-iclb:         [FAIL][122] ([i915#2295] / [i915#2724]) -> ([FAIL][123], [FAIL][124]) ([i915#2295] / [i915#2722] / [i915#2724])
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-iclb6/igt@runner@aborted.html
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-iclb1/igt@runner@aborted.html
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-iclb1/igt@runner@aborted.html
    - shard-tglb:         [FAIL][125] ([i915#2295] / [i915#2667]) -> ([FAIL][126], [FAIL][127]) ([i915#2295] / [i915#2426] / [i915#2667] / [i915#2803])
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-tglb5/igt@runner@aborted.html
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb8/igt@runner@aborted.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-tglb6/igt@runner@aborted.html
    - shard-skl:          ([FAIL][128], [FAIL][129], [FAIL][130]) ([i915#1436] / [i915#2295] / [i915#2426]) -> ([FAIL][131], [FAIL][132]) ([i915#1814] / [i915#2029] / [i915#2295])
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-skl9/igt@runner@aborted.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-skl4/igt@runner@aborted.html
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9602/shard-skl2/igt@runner@aborted.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-skl3/igt@runner@aborted.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/shard-skl3/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
  [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
  [i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
  [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
  [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
  [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
  [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
  [i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597
  [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
  [i915#2667]: https://gitlab.freedesktop.org/drm/intel/issues/2667
  [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
  [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
  [i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
  [i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724
  [i915#2771]: https://gitlab.freedesktop.org/drm/intel/issues/2771
  [i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2852]: https://gitlab.freedesktop.org/drm/intel/issues/2852
  [i915#2918]: https://gitlab.freedesktop.org/drm/intel/issues/2918
  [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
  [i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
  [i915#407]: https://gitlab.freedesktop.org/drm/intel/issues/407
  [i915#42]: https://gitlab.freedesktop.org/drm/intel/issues/42
  [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
  [i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
  [i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_9602 -> Patchwork_19334

  CI-20190529: 20190529
  CI_DRM_9602: 0e9e2e0eb03ba457a9ce479b8276be88761320ca @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5957: 2a2b3418f7458dfa1fac255cc5c71603f617690a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_19334: 9d213951b7bfd74093f10235ba412ef3f0ee1da5 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19334/index.html

[-- Attachment #1.2: Type: text/html, Size: 27726 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] bdi: Use might_alloc()
  2021-01-13 13:50   ` [Intel-gfx] " Daniel Vetter
  (?)
@ 2021-01-14  5:07     ` kernel test robot
  -1 siblings, 0 replies; 11+ messages in thread
From: kernel test robot @ 2021-01-14  5:07 UTC (permalink / raw)
  To: Daniel Vetter, LKML
  Cc: kbuild-all, Intel Graphics Development, Daniel Vetter,
	Andrew Morton, Linux Memory Management List

[-- Attachment #1: Type: text/plain, Size: 3852 bytes --]

Hi Daniel,

I love your patch! Yet something to improve:

[auto build test ERROR on mmotm/master]

url:    https://github.com/0day-ci/linux/commits/Daniel-Vetter/mm-dmapool-Use-might_alloc/20210113-215207
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: openrisc-randconfig-r011-20210113 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/95ad71591084350229e768f9c2be5350d504f896
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Daniel-Vetter/mm-dmapool-Use-might_alloc/20210113-215207
        git checkout 95ad71591084350229e768f9c2be5350d504f896
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   mm/backing-dev.c: In function 'wb_get_create':
>> mm/backing-dev.c:647:2: error: implicit declaration of function 'might_alloc'; did you mean 'might_lock'? [-Werror=implicit-function-declaration]
     647 |  might_alloc(gfp);
         |  ^~~~~~~~~~~
         |  might_lock
   cc1: some warnings being treated as errors


vim +647 mm/backing-dev.c

   616	
   617	/**
   618	 * wb_get_create - get wb for a given memcg, create if necessary
   619	 * @bdi: target bdi
   620	 * @memcg_css: cgroup_subsys_state of the target memcg (must have positive ref)
   621	 * @gfp: allocation mask to use
   622	 *
   623	 * Try to get the wb for @memcg_css on @bdi.  If it doesn't exist, try to
   624	 * create one.  The returned wb has its refcount incremented.
   625	 *
   626	 * This function uses css_get() on @memcg_css and thus expects its refcnt
   627	 * to be positive on invocation.  IOW, rcu_read_lock() protection on
   628	 * @memcg_css isn't enough.  try_get it before calling this function.
   629	 *
   630	 * A wb is keyed by its associated memcg.  As blkcg implicitly enables
   631	 * memcg on the default hierarchy, memcg association is guaranteed to be
   632	 * more specific (equal or descendant to the associated blkcg) and thus can
   633	 * identify both the memcg and blkcg associations.
   634	 *
   635	 * Because the blkcg associated with a memcg may change as blkcg is enabled
   636	 * and disabled closer to root in the hierarchy, each wb keeps track of
   637	 * both the memcg and blkcg associated with it and verifies the blkcg on
   638	 * each lookup.  On mismatch, the existing wb is discarded and a new one is
   639	 * created.
   640	 */
   641	struct bdi_writeback *wb_get_create(struct backing_dev_info *bdi,
   642					    struct cgroup_subsys_state *memcg_css,
   643					    gfp_t gfp)
   644	{
   645		struct bdi_writeback *wb;
   646	
 > 647		might_alloc(gfp);
   648	
   649		if (!memcg_css->parent)
   650			return &bdi->wb;
   651	
   652		do {
   653			rcu_read_lock();
   654			wb = radix_tree_lookup(&bdi->cgwb_tree, memcg_css->id);
   655			if (wb) {
   656				struct cgroup_subsys_state *blkcg_css;
   657	
   658				/* see whether the blkcg association has changed */
   659				blkcg_css = cgroup_get_e_css(memcg_css->cgroup,
   660							     &io_cgrp_subsys);
   661				if (unlikely(wb->blkcg_css != blkcg_css ||
   662					     !wb_tryget(wb)))
   663					wb = NULL;
   664				css_put(blkcg_css);
   665			}
   666			rcu_read_unlock();
   667		} while (!wb && !cgwb_create(bdi, memcg_css, gfp));
   668	
   669		return wb;
   670	}
   671	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 19846 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] bdi: Use might_alloc()
@ 2021-01-14  5:07     ` kernel test robot
  0 siblings, 0 replies; 11+ messages in thread
From: kernel test robot @ 2021-01-14  5:07 UTC (permalink / raw)
  To: Daniel Vetter, LKML
  Cc: Daniel Vetter, Intel Graphics Development, kbuild-all,
	Andrew Morton, Linux Memory Management List

[-- Attachment #1: Type: text/plain, Size: 3852 bytes --]

Hi Daniel,

I love your patch! Yet something to improve:

[auto build test ERROR on mmotm/master]

url:    https://github.com/0day-ci/linux/commits/Daniel-Vetter/mm-dmapool-Use-might_alloc/20210113-215207
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: openrisc-randconfig-r011-20210113 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/95ad71591084350229e768f9c2be5350d504f896
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Daniel-Vetter/mm-dmapool-Use-might_alloc/20210113-215207
        git checkout 95ad71591084350229e768f9c2be5350d504f896
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   mm/backing-dev.c: In function 'wb_get_create':
>> mm/backing-dev.c:647:2: error: implicit declaration of function 'might_alloc'; did you mean 'might_lock'? [-Werror=implicit-function-declaration]
     647 |  might_alloc(gfp);
         |  ^~~~~~~~~~~
         |  might_lock
   cc1: some warnings being treated as errors


vim +647 mm/backing-dev.c

   616	
   617	/**
   618	 * wb_get_create - get wb for a given memcg, create if necessary
   619	 * @bdi: target bdi
   620	 * @memcg_css: cgroup_subsys_state of the target memcg (must have positive ref)
   621	 * @gfp: allocation mask to use
   622	 *
   623	 * Try to get the wb for @memcg_css on @bdi.  If it doesn't exist, try to
   624	 * create one.  The returned wb has its refcount incremented.
   625	 *
   626	 * This function uses css_get() on @memcg_css and thus expects its refcnt
   627	 * to be positive on invocation.  IOW, rcu_read_lock() protection on
   628	 * @memcg_css isn't enough.  try_get it before calling this function.
   629	 *
   630	 * A wb is keyed by its associated memcg.  As blkcg implicitly enables
   631	 * memcg on the default hierarchy, memcg association is guaranteed to be
   632	 * more specific (equal or descendant to the associated blkcg) and thus can
   633	 * identify both the memcg and blkcg associations.
   634	 *
   635	 * Because the blkcg associated with a memcg may change as blkcg is enabled
   636	 * and disabled closer to root in the hierarchy, each wb keeps track of
   637	 * both the memcg and blkcg associated with it and verifies the blkcg on
   638	 * each lookup.  On mismatch, the existing wb is discarded and a new one is
   639	 * created.
   640	 */
   641	struct bdi_writeback *wb_get_create(struct backing_dev_info *bdi,
   642					    struct cgroup_subsys_state *memcg_css,
   643					    gfp_t gfp)
   644	{
   645		struct bdi_writeback *wb;
   646	
 > 647		might_alloc(gfp);
   648	
   649		if (!memcg_css->parent)
   650			return &bdi->wb;
   651	
   652		do {
   653			rcu_read_lock();
   654			wb = radix_tree_lookup(&bdi->cgwb_tree, memcg_css->id);
   655			if (wb) {
   656				struct cgroup_subsys_state *blkcg_css;
   657	
   658				/* see whether the blkcg association has changed */
   659				blkcg_css = cgroup_get_e_css(memcg_css->cgroup,
   660							     &io_cgrp_subsys);
   661				if (unlikely(wb->blkcg_css != blkcg_css ||
   662					     !wb_tryget(wb)))
   663					wb = NULL;
   664				css_put(blkcg_css);
   665			}
   666			rcu_read_unlock();
   667		} while (!wb && !cgwb_create(bdi, memcg_css, gfp));
   668	
   669		return wb;
   670	}
   671	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 19846 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] bdi: Use might_alloc()
@ 2021-01-14  5:07     ` kernel test robot
  0 siblings, 0 replies; 11+ messages in thread
From: kernel test robot @ 2021-01-14  5:07 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3949 bytes --]

Hi Daniel,

I love your patch! Yet something to improve:

[auto build test ERROR on mmotm/master]

url:    https://github.com/0day-ci/linux/commits/Daniel-Vetter/mm-dmapool-Use-might_alloc/20210113-215207
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: openrisc-randconfig-r011-20210113 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/95ad71591084350229e768f9c2be5350d504f896
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Daniel-Vetter/mm-dmapool-Use-might_alloc/20210113-215207
        git checkout 95ad71591084350229e768f9c2be5350d504f896
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   mm/backing-dev.c: In function 'wb_get_create':
>> mm/backing-dev.c:647:2: error: implicit declaration of function 'might_alloc'; did you mean 'might_lock'? [-Werror=implicit-function-declaration]
     647 |  might_alloc(gfp);
         |  ^~~~~~~~~~~
         |  might_lock
   cc1: some warnings being treated as errors


vim +647 mm/backing-dev.c

   616	
   617	/**
   618	 * wb_get_create - get wb for a given memcg, create if necessary
   619	 * @bdi: target bdi
   620	 * @memcg_css: cgroup_subsys_state of the target memcg (must have positive ref)
   621	 * @gfp: allocation mask to use
   622	 *
   623	 * Try to get the wb for @memcg_css on @bdi.  If it doesn't exist, try to
   624	 * create one.  The returned wb has its refcount incremented.
   625	 *
   626	 * This function uses css_get() on @memcg_css and thus expects its refcnt
   627	 * to be positive on invocation.  IOW, rcu_read_lock() protection on
   628	 * @memcg_css isn't enough.  try_get it before calling this function.
   629	 *
   630	 * A wb is keyed by its associated memcg.  As blkcg implicitly enables
   631	 * memcg on the default hierarchy, memcg association is guaranteed to be
   632	 * more specific (equal or descendant to the associated blkcg) and thus can
   633	 * identify both the memcg and blkcg associations.
   634	 *
   635	 * Because the blkcg associated with a memcg may change as blkcg is enabled
   636	 * and disabled closer to root in the hierarchy, each wb keeps track of
   637	 * both the memcg and blkcg associated with it and verifies the blkcg on
   638	 * each lookup.  On mismatch, the existing wb is discarded and a new one is
   639	 * created.
   640	 */
   641	struct bdi_writeback *wb_get_create(struct backing_dev_info *bdi,
   642					    struct cgroup_subsys_state *memcg_css,
   643					    gfp_t gfp)
   644	{
   645		struct bdi_writeback *wb;
   646	
 > 647		might_alloc(gfp);
   648	
   649		if (!memcg_css->parent)
   650			return &bdi->wb;
   651	
   652		do {
   653			rcu_read_lock();
   654			wb = radix_tree_lookup(&bdi->cgwb_tree, memcg_css->id);
   655			if (wb) {
   656				struct cgroup_subsys_state *blkcg_css;
   657	
   658				/* see whether the blkcg association has changed */
   659				blkcg_css = cgroup_get_e_css(memcg_css->cgroup,
   660							     &io_cgrp_subsys);
   661				if (unlikely(wb->blkcg_css != blkcg_css ||
   662					     !wb_tryget(wb)))
   663					wb = NULL;
   664				css_put(blkcg_css);
   665			}
   666			rcu_read_unlock();
   667		} while (!wb && !cgwb_create(bdi, memcg_css, gfp));
   668	
   669		return wb;
   670	}
   671	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 19846 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH 1/2] mm/dmapool: Use might_alloc()
@ 2021-01-13 13:40 Daniel Vetter
  0 siblings, 0 replies; 11+ messages in thread
From: Daniel Vetter @ 2021-01-13 13:40 UTC (permalink / raw)
  To: LKML; +Cc: Daniel Vetter, Daniel Vetter, Andrew Morton, linux-mm

Now that my little helper has landed, use it more. On top of the
existing check this also uses lockdep through the fs_reclaim
annotations.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
---
 mm/dmapool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/dmapool.c b/mm/dmapool.c
index a97c97232337..d89c6966548d 100644
--- a/mm/dmapool.c
+++ b/mm/dmapool.c
@@ -319,7 +319,7 @@ void *dma_pool_alloc(struct dma_pool *pool, gfp_t mem_flags,
 	size_t offset;
 	void *retval;
 
-	might_sleep_if(gfpflags_allow_blocking(mem_flags));
+	might_alloc(mem_flags);
 
 	spin_lock_irqsave(&pool->lock, flags);
 	list_for_each_entry(page, &pool->page_list, page_list) {
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-01-14  5:08 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-13 13:50 [PATCH 1/2] mm/dmapool: Use might_alloc() Daniel Vetter
2021-01-13 13:50 ` [Intel-gfx] " Daniel Vetter
2021-01-13 13:50 ` [PATCH 2/2] bdi: " Daniel Vetter
2021-01-13 13:50   ` [Intel-gfx] " Daniel Vetter
2021-01-14  5:07   ` kernel test robot
2021-01-14  5:07     ` kernel test robot
2021-01-14  5:07     ` [Intel-gfx] " kernel test robot
2021-01-13 15:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] mm/dmapool: " Patchwork
2021-01-13 15:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-13 20:16 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2021-01-13 13:40 [PATCH 1/2] " Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.