* [Intel-gfx] [PATCH] drm/i915/gt: Prune 'inline' from execlists
@ 2021-01-13 15:11 Chris Wilson
2021-01-13 19:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2021-01-13 15:11 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Chris Wilson
Remove the extraneous inlines. The only split by the compiler that
looked dubious was execlists_schedule_out, so push the code around
slightly to move all the work into the out-of-line function.
In a normal build, bloat-o-meter shows that only the
execlists_schedule_out is contentious:
add/remove: 1/0 grow/shrink: 0/2 up/down: 803/-1532 (-729)
Function old new delta
__execlists_schedule_out - 803 +803
execlists_submission_tasklet 6488 5766 -722
execlists_reset_csb.constprop 1587 777 -810
Total: Before=1605815, After=1605086, chg -0.05%
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jani Nikula <jani.nikula@intel.com>
---
.../drm/i915/gt/intel_execlists_submission.c | 63 +++++++++----------
1 file changed, 29 insertions(+), 34 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
index d7d5a58990bb..33c7495b12b1 100644
--- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
+++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
@@ -230,8 +230,7 @@ active_request(const struct intel_timeline * const tl, struct i915_request *rq)
return __active_request(tl, rq, 0);
}
-static inline void
-ring_set_paused(const struct intel_engine_cs *engine, int state)
+static void ring_set_paused(const struct intel_engine_cs *engine, int state)
{
/*
* We inspect HWS_PREEMPT with a semaphore inside
@@ -244,12 +243,12 @@ ring_set_paused(const struct intel_engine_cs *engine, int state)
wmb();
}
-static inline struct i915_priolist *to_priolist(struct rb_node *rb)
+static struct i915_priolist *to_priolist(struct rb_node *rb)
{
return rb_entry(rb, struct i915_priolist, node);
}
-static inline int rq_prio(const struct i915_request *rq)
+static int rq_prio(const struct i915_request *rq)
{
return READ_ONCE(rq->sched.attr.priority);
}
@@ -299,8 +298,8 @@ static int virtual_prio(const struct intel_engine_execlists *el)
return rb ? rb_entry(rb, struct ve_node, rb)->prio : INT_MIN;
}
-static inline bool need_preempt(const struct intel_engine_cs *engine,
- const struct i915_request *rq)
+static bool need_preempt(const struct intel_engine_cs *engine,
+ const struct i915_request *rq)
{
int last_prio;
@@ -351,7 +350,7 @@ static inline bool need_preempt(const struct intel_engine_cs *engine,
queue_prio(&engine->execlists)) > last_prio;
}
-__maybe_unused static inline bool
+__maybe_unused static bool
assert_priority_queue(const struct i915_request *prev,
const struct i915_request *next)
{
@@ -418,7 +417,7 @@ execlists_unwind_incomplete_requests(struct intel_engine_execlists *execlists)
return __unwind_incomplete_requests(engine);
}
-static inline void
+static void
execlists_context_status_change(struct i915_request *rq, unsigned long status)
{
/*
@@ -503,7 +502,7 @@ static void reset_active(struct i915_request *rq,
ce->lrc.lrca = lrc_update_regs(ce, engine, head);
}
-static inline struct intel_engine_cs *
+static struct intel_engine_cs *
__execlists_schedule_in(struct i915_request *rq)
{
struct intel_engine_cs * const engine = rq->engine;
@@ -549,7 +548,7 @@ __execlists_schedule_in(struct i915_request *rq)
return engine;
}
-static inline void execlists_schedule_in(struct i915_request *rq, int idx)
+static void execlists_schedule_in(struct i915_request *rq, int idx)
{
struct intel_context * const ce = rq->context;
struct intel_engine_cs *old;
@@ -608,9 +607,9 @@ static void kick_siblings(struct i915_request *rq, struct intel_context *ce)
tasklet_hi_schedule(&ve->base.execlists.tasklet);
}
-static inline void __execlists_schedule_out(struct i915_request *rq)
+static void __execlists_schedule_out(struct i915_request * const rq,
+ struct intel_context * const ce)
{
- struct intel_context * const ce = rq->context;
struct intel_engine_cs * const engine = rq->engine;
unsigned int ccid;
@@ -621,6 +620,7 @@ static inline void __execlists_schedule_out(struct i915_request *rq)
*/
CE_TRACE(ce, "schedule-out, ccid:%x\n", ce->lrc.ccid);
+ GEM_BUG_ON(ce->inflight != engine);
if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM))
lrc_check_regs(ce, engine, "after");
@@ -660,10 +660,12 @@ static inline void __execlists_schedule_out(struct i915_request *rq)
*/
if (ce->engine != engine)
kick_siblings(rq, ce);
+
+ WRITE_ONCE(ce->inflight, NULL);
+ intel_context_put(ce);
}
-static inline void
-execlists_schedule_out(struct i915_request *rq)
+static inline void execlists_schedule_out(struct i915_request *rq)
{
struct intel_context * const ce = rq->context;
@@ -671,12 +673,8 @@ execlists_schedule_out(struct i915_request *rq)
GEM_BUG_ON(!ce->inflight);
ce->inflight = ptr_dec(ce->inflight);
- if (!__intel_context_inflight_count(ce->inflight)) {
- GEM_BUG_ON(ce->inflight != rq->engine);
- __execlists_schedule_out(rq);
- WRITE_ONCE(ce->inflight, NULL);
- intel_context_put(ce);
- }
+ if (!__intel_context_inflight_count(ce->inflight))
+ __execlists_schedule_out(rq, ce);
i915_request_put(rq);
}
@@ -728,7 +726,7 @@ static u64 execlists_update_context(struct i915_request *rq)
return desc;
}
-static inline void write_desc(struct intel_engine_execlists *execlists, u64 desc, u32 port)
+static void write_desc(struct intel_engine_execlists *execlists, u64 desc, u32 port)
{
if (execlists->ctrl_reg) {
writel(lower_32_bits(desc), execlists->submit_reg + port * 2);
@@ -757,7 +755,7 @@ dump_port(char *buf, int buflen, const char *prefix, struct i915_request *rq)
return buf;
}
-static __maybe_unused void
+static __maybe_unused noinline void
trace_ports(const struct intel_engine_execlists *execlists,
const char *msg,
struct i915_request * const *ports)
@@ -774,13 +772,13 @@ trace_ports(const struct intel_engine_execlists *execlists,
dump_port(p1, sizeof(p1), ", ", ports[1]));
}
-static inline bool
+static bool
reset_in_progress(const struct intel_engine_execlists *execlists)
{
return unlikely(!__tasklet_is_enabled(&execlists->tasklet));
}
-static __maybe_unused bool
+static __maybe_unused noinline bool
assert_pending_valid(const struct intel_engine_execlists *execlists,
const char *msg)
{
@@ -1621,12 +1619,12 @@ static void execlists_dequeue_irq(struct intel_engine_cs *engine)
local_irq_enable(); /* flush irq_work (e.g. breadcrumb enabling) */
}
-static inline void clear_ports(struct i915_request **ports, int count)
+static void clear_ports(struct i915_request **ports, int count)
{
memset_p((void **)ports, NULL, count);
}
-static inline void
+static void
copy_ports(struct i915_request **dst, struct i915_request **src, int count)
{
/* A memcpy_p() would be very useful here! */
@@ -1660,8 +1658,7 @@ cancel_port_requests(struct intel_engine_execlists * const execlists,
return inactive;
}
-static inline void
-invalidate_csb_entries(const u64 *first, const u64 *last)
+static void invalidate_csb_entries(const u64 *first, const u64 *last)
{
clflush((void *)first);
clflush((void *)last);
@@ -1693,7 +1690,7 @@ invalidate_csb_entries(const u64 *first, const u64 *last)
* bits 47-57: sw context id of the lrc the GT switched away from
* bits 58-63: sw counter of the lrc the GT switched away from
*/
-static inline bool gen12_csb_parse(const u64 csb)
+static bool gen12_csb_parse(const u64 csb)
{
bool ctx_away_valid = GEN12_CSB_CTX_VALID(upper_32_bits(csb));
bool new_queue =
@@ -1720,7 +1717,7 @@ static inline bool gen12_csb_parse(const u64 csb)
return false;
}
-static inline bool gen8_csb_parse(const u64 csb)
+static bool gen8_csb_parse(const u64 csb)
{
return csb & (GEN8_CTX_STATUS_IDLE_ACTIVE | GEN8_CTX_STATUS_PREEMPTED);
}
@@ -1759,8 +1756,7 @@ wa_csb_read(const struct intel_engine_cs *engine, u64 * const csb)
return entry;
}
-static inline u64
-csb_read(const struct intel_engine_cs *engine, u64 * const csb)
+static u64 csb_read(const struct intel_engine_cs *engine, u64 * const csb)
{
u64 entry = READ_ONCE(*csb);
@@ -3180,8 +3176,7 @@ logical_ring_default_vfuncs(struct intel_engine_cs *engine)
}
}
-static inline void
-logical_ring_default_irqs(struct intel_engine_cs *engine)
+static void logical_ring_default_irqs(struct intel_engine_cs *engine)
{
unsigned int shift = 0;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Prune 'inline' from execlists
2021-01-13 15:11 [Intel-gfx] [PATCH] drm/i915/gt: Prune 'inline' from execlists Chris Wilson
@ 2021-01-13 19:39 ` Patchwork
2021-01-14 0:01 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-01-14 15:07 ` [Intel-gfx] [PATCH] " Mika Kuoppala
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2021-01-13 19:39 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2999 bytes --]
== Series Details ==
Series: drm/i915/gt: Prune 'inline' from execlists
URL : https://patchwork.freedesktop.org/series/85819/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9603 -> Patchwork_19340
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/index.html
Known issues
------------
Here are the changes found in Patchwork_19340 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@read:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#402]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/fi-tgl-y/igt@fbdev@read.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/fi-tgl-y/igt@fbdev@read.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][3] -> [FAIL][4] ([i915#1161] / [i915#262])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][5] ([i915#2291] / [i915#541]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@prime_vgem@basic-userptr:
- fi-tgl-y: [DMESG-WARN][7] ([i915#402]) -> [PASS][8] +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/fi-tgl-y/igt@prime_vgem@basic-userptr.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/fi-tgl-y/igt@prime_vgem@basic-userptr.html
[i915#1161]: https://gitlab.freedesktop.org/drm/intel/issues/1161
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
Participating hosts (43 -> 37)
------------------------------
Missing (6): fi-cml-u2 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus fi-snb-2600
Build changes
-------------
* Linux: CI_DRM_9603 -> Patchwork_19340
CI-20190529: 20190529
CI_DRM_9603: 4e758db4f1c2fd3dcfa7bf1cd33a0863978f555c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5957: 2a2b3418f7458dfa1fac255cc5c71603f617690a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19340: f886ba53f95b32de9f9351ca73ba03a78adbde81 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f886ba53f95b drm/i915/gt: Prune 'inline' from execlists
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/index.html
[-- Attachment #1.2: Type: text/html, Size: 3765 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Prune 'inline' from execlists
2021-01-13 15:11 [Intel-gfx] [PATCH] drm/i915/gt: Prune 'inline' from execlists Chris Wilson
2021-01-13 19:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2021-01-14 0:01 ` Patchwork
2021-01-14 15:07 ` [Intel-gfx] [PATCH] " Mika Kuoppala
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2021-01-14 0:01 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 25267 bytes --]
== Series Details ==
Series: drm/i915/gt: Prune 'inline' from execlists
URL : https://patchwork.freedesktop.org/series/85819/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9603_full -> Patchwork_19340_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19340_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19340_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19340_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_persistence@close-replace-race:
- shard-kbl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-kbl7/igt@gem_ctx_persistence@close-replace-race.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-kbl4/igt@gem_ctx_persistence@close-replace-race.html
* igt@i915_selftest@live:
- shard-tglb: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb5/igt@i915_selftest@live.html
* igt@kms_cursor_legacy@pipe-b-single-move:
- shard-glk: [PASS][4] -> [INCOMPLETE][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-glk2/igt@kms_cursor_legacy@pipe-b-single-move.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-glk3/igt@kms_cursor_legacy@pipe-b-single-move.html
Known issues
------------
Here are the changes found in Patchwork_19340_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_sseu@mmap-args:
- shard-tglb: NOTRUN -> [SKIP][6] ([i915#280])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb5/igt@gem_ctx_sseu@mmap-args.html
* igt@gem_exec_params@no-vebox:
- shard-skl: NOTRUN -> [SKIP][7] ([fdo#109271]) +42 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl7/igt@gem_exec_params@no-vebox.html
* igt@gem_exec_reloc@basic-many-active@vcs1:
- shard-iclb: NOTRUN -> [FAIL][8] ([i915#2389])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-iclb4/igt@gem_exec_reloc@basic-many-active@vcs1.html
* igt@gen9_exec_parse@allowed-all:
- shard-glk: [PASS][9] -> [DMESG-WARN][10] ([i915#1436] / [i915#716])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-glk7/igt@gen9_exec_parse@allowed-all.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-glk6/igt@gen9_exec_parse@allowed-all.html
* igt@gen9_exec_parse@batch-without-end:
- shard-tglb: NOTRUN -> [SKIP][11] ([fdo#112306])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb5/igt@gen9_exec_parse@batch-without-end.html
* igt@kms_big_fb@linear-64bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][12] ([fdo#111614])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb5/igt@kms_big_fb@linear-64bpp-rotate-90.html
* igt@kms_big_joiner@invalid-modeset:
- shard-skl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#2705])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl7/igt@kms_big_joiner@invalid-modeset.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic:
- shard-skl: NOTRUN -> [SKIP][14] ([fdo#109271] / [fdo#111304])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl8/igt@kms_ccs@pipe-c-crc-sprite-planes-basic.html
* igt@kms_color@pipe-a-ctm-green-to-red:
- shard-skl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-skl8/igt@kms_color@pipe-a-ctm-green-to-red.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl10/igt@kms_color@pipe-a-ctm-green-to-red.html
* igt@kms_color_chamelium@pipe-c-gamma:
- shard-skl: NOTRUN -> [SKIP][17] ([fdo#109271] / [fdo#111827]) +5 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl7/igt@kms_color_chamelium@pipe-c-gamma.html
* igt@kms_color_chamelium@pipe-d-ctm-0-25:
- shard-tglb: NOTRUN -> [SKIP][18] ([fdo#109284] / [fdo#111827])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb5/igt@kms_color_chamelium@pipe-d-ctm-0-25.html
* igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes:
- shard-glk: NOTRUN -> [SKIP][19] ([fdo#109271] / [fdo#111827]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-glk2/igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes.html
* igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding:
- shard-skl: [PASS][20] -> [FAIL][21] ([i915#54]) +8 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-skl7/igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding.html
* igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding:
- shard-skl: NOTRUN -> [FAIL][22] ([i915#54]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl7/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#2346])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-skl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#533]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl7/igt@kms_cursor_legacy@pipe-d-single-bo.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-tglb: [PASS][26] -> [FAIL][27] ([i915#79])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-tglb6/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb8/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-tglb: [PASS][28] -> [FAIL][29] ([i915#2598]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-tglb1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb7/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [PASS][30] -> [FAIL][31] ([i915#79])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-skl5/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl6/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
* igt@kms_flip@flip-vs-suspend@b-dp1:
- shard-kbl: [PASS][32] -> [DMESG-WARN][33] ([i915#180])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-kbl1/igt@kms_flip@flip-vs-suspend@b-dp1.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-kbl6/igt@kms_flip@flip-vs-suspend@b-dp1.html
* igt@kms_flip_tiling@flip-yf-tiled:
- shard-tglb: NOTRUN -> [SKIP][34] ([fdo#111615]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb5/igt@kms_flip_tiling@flip-yf-tiled.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][35] ([fdo#111825]) +11 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: NOTRUN -> [FAIL][36] ([fdo#108145] / [i915#265])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109441]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-iclb8/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@nouveau_crc@pipe-d-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][39] ([i915#2530]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb5/igt@nouveau_crc@pipe-d-ctx-flip-detection.html
* igt@prime_nv_pcopy@test3_5:
- shard-glk: NOTRUN -> [SKIP][40] ([fdo#109271]) +5 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-glk2/igt@prime_nv_pcopy@test3_5.html
* igt@prime_nv_test@i915_import_pread_pwrite:
- shard-tglb: NOTRUN -> [SKIP][41] ([fdo#109291])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb5/igt@prime_nv_test@i915_import_pread_pwrite.html
* igt@prime_vgem@sync@bcs0:
- shard-tglb: [PASS][42] -> [INCOMPLETE][43] ([i915#409])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-tglb5/igt@prime_vgem@sync@bcs0.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb8/igt@prime_vgem@sync@bcs0.html
#### Possible fixes ####
* igt@gem_exec_balancer@waits:
- shard-tglb: [INCOMPLETE][44] -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-tglb8/igt@gem_exec_balancer@waits.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb5/igt@gem_exec_balancer@waits.html
* {igt@gem_exec_fair@basic-deadline}:
- shard-kbl: [FAIL][46] ([i915#2846]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-kbl6/igt@gem_exec_fair@basic-deadline.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-kbl1/igt@gem_exec_fair@basic-deadline.html
* {igt@gem_exec_fair@basic-none-share@rcs0}:
- shard-apl: [SKIP][48] ([fdo#109271]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-apl1/igt@gem_exec_fair@basic-none-share@rcs0.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-apl4/igt@gem_exec_fair@basic-none-share@rcs0.html
* {igt@gem_exec_fair@basic-none@vecs0}:
- shard-kbl: [FAIL][50] ([i915#2842]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-kbl2/igt@gem_exec_fair@basic-none@vecs0.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-kbl7/igt@gem_exec_fair@basic-none@vecs0.html
* {igt@gem_exec_fair@basic-pace-share@rcs0}:
- shard-glk: [FAIL][52] ([i915#2842]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
* {igt@gem_exec_fair@basic-pace@rcs0}:
- shard-tglb: [FAIL][54] ([i915#2842]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-tglb6/igt@gem_exec_fair@basic-pace@rcs0.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb2/igt@gem_exec_fair@basic-pace@rcs0.html
* {igt@gem_exec_schedule@u-fairslice@rcs0}:
- shard-glk: [DMESG-WARN][56] ([i915#1610]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-glk8/igt@gem_exec_schedule@u-fairslice@rcs0.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-glk2/igt@gem_exec_schedule@u-fairslice@rcs0.html
* {igt@gem_exec_schedule@u-fairslice@vcs1}:
- shard-tglb: [DMESG-WARN][58] ([i915#2803]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-tglb5/igt@gem_exec_schedule@u-fairslice@vcs1.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb1/igt@gem_exec_schedule@u-fairslice@vcs1.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-skl: [DMESG-FAIL][60] ([i915#2291] / [i915#541]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-skl5/igt@i915_selftest@live@gt_heartbeat.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl6/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [FAIL][62] ([i915#2521]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-skl3/igt@kms_async_flips@alternate-sync-async-flip.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl10/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_atomic_transition@plane-all-modeset-transition@dp-1-pipe-b:
- shard-kbl: [DMESG-WARN][64] ([i915#62]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-kbl2/igt@kms_atomic_transition@plane-all-modeset-transition@dp-1-pipe-b.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-kbl3/igt@kms_atomic_transition@plane-all-modeset-transition@dp-1-pipe-b.html
* igt@kms_atomic_transition@plane-all-modeset-transition@dp-1-pipe-c:
- shard-kbl: [DMESG-WARN][66] ([i915#165] / [i915#180]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-kbl2/igt@kms_atomic_transition@plane-all-modeset-transition@dp-1-pipe-c.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-kbl3/igt@kms_atomic_transition@plane-all-modeset-transition@dp-1-pipe-c.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [INCOMPLETE][68] ([i915#2405] / [i915#300]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen:
- shard-skl: [FAIL][70] ([i915#54]) -> [PASS][71] +7 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl1/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [FAIL][72] ([i915#2122]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [FAIL][74] ([i915#79]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_flip@flip-vs-panning@a-edp1:
- shard-skl: [DMESG-WARN][76] ([i915#1982]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-skl9/igt@kms_flip@flip-vs-panning@a-edp1.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl2/igt@kms_flip@flip-vs-panning@a-edp1.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][78] ([i915#1188]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-skl2/igt@kms_hdr@bpc-switch-dpms.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][80] ([fdo#108145] / [i915#265]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][82] ([fdo#109441]) -> [PASS][83] +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-iclb1/igt@kms_psr@psr2_cursor_render.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-skl: [INCOMPLETE][84] ([i915#198]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-skl9/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl8/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@perf@blocking:
- shard-skl: [FAIL][86] ([i915#1542]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-skl2/igt@perf@blocking.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl4/igt@perf@blocking.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][88] ([i915#2681] / [i915#2684]) -> [WARN][89] ([i915#2684])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@runner@aborted:
- shard-kbl: [FAIL][90] ([i915#2295]) -> ([FAIL][91], [FAIL][92]) ([i915#2295] / [i915#2505])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-kbl4/igt@runner@aborted.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-kbl2/igt@runner@aborted.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-kbl6/igt@runner@aborted.html
- shard-glk: ([FAIL][93], [FAIL][94], [FAIL][95]) ([i915#2295] / [i915#2426] / [k.org#202321]) -> ([FAIL][96], [FAIL][97], [FAIL][98]) ([i915#2295] / [k.org#202321])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-glk8/igt@runner@aborted.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-glk5/igt@runner@aborted.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-glk2/igt@runner@aborted.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-glk1/igt@runner@aborted.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-glk6/igt@runner@aborted.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-glk3/igt@runner@aborted.html
- shard-tglb: ([FAIL][99], [FAIL][100]) ([i915#2295] / [i915#2426] / [i915#2667] / [i915#2803]) -> ([FAIL][101], [FAIL][102], [FAIL][103], [FAIL][104]) ([i915#2295] / [i915#2426] / [i915#2667] / [i915#2803] / [i915#409])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-tglb1/igt@runner@aborted.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-tglb5/igt@runner@aborted.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb5/igt@runner@aborted.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb5/igt@runner@aborted.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb8/igt@runner@aborted.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-tglb1/igt@runner@aborted.html
- shard-skl: [FAIL][105] ([i915#2295]) -> ([FAIL][106], [FAIL][107], [FAIL][108]) ([i915#2029] / [i915#2295] / [i915#2426])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9603/shard-skl4/igt@runner@aborted.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl4/igt@runner@aborted.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl5/igt@runner@aborted.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/shard-skl3/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112306]: https://bugs.freedesktop.org/show_bug.cgi?id=112306
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2667]: https://gitlab.freedesktop.org/drm/intel/issues/2667
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#409]: https://gitlab.freedesktop.org/drm/intel/issues/409
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9603 -> Patchwork_19340
CI-20190529: 20190529
CI_DRM_9603: 4e758db4f1c2fd3dcfa7bf1cd33a0863978f555c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5957: 2a2b3418f7458dfa1fac255cc5c71603f617690a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19340: f886ba53f95b32de9f9351ca73ba03a78adbde81 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19340/index.html
[-- Attachment #1.2: Type: text/html, Size: 29846 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Prune 'inline' from execlists
2021-01-13 15:11 [Intel-gfx] [PATCH] drm/i915/gt: Prune 'inline' from execlists Chris Wilson
2021-01-13 19:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-14 0:01 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2021-01-14 15:07 ` Mika Kuoppala
2 siblings, 0 replies; 4+ messages in thread
From: Mika Kuoppala @ 2021-01-14 15:07 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Jani Nikula, Chris Wilson
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Remove the extraneous inlines. The only split by the compiler that
> looked dubious was execlists_schedule_out, so push the code around
> slightly to move all the work into the out-of-line function.
>
> In a normal build, bloat-o-meter shows that only the
> execlists_schedule_out is contentious:
>
> add/remove: 1/0 grow/shrink: 0/2 up/down: 803/-1532 (-729)
> Function old new delta
> __execlists_schedule_out - 803 +803
> execlists_submission_tasklet 6488 5766 -722
> execlists_reset_csb.constprop 1587 777 -810
> Total: Before=1605815, After=1605086, chg -0.05%
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> .../drm/i915/gt/intel_execlists_submission.c | 63 +++++++++----------
> 1 file changed, 29 insertions(+), 34 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> index d7d5a58990bb..33c7495b12b1 100644
> --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> @@ -230,8 +230,7 @@ active_request(const struct intel_timeline * const tl, struct i915_request *rq)
> return __active_request(tl, rq, 0);
> }
>
> -static inline void
> -ring_set_paused(const struct intel_engine_cs *engine, int state)
> +static void ring_set_paused(const struct intel_engine_cs *engine, int state)
> {
> /*
> * We inspect HWS_PREEMPT with a semaphore inside
> @@ -244,12 +243,12 @@ ring_set_paused(const struct intel_engine_cs *engine, int state)
> wmb();
> }
>
> -static inline struct i915_priolist *to_priolist(struct rb_node *rb)
> +static struct i915_priolist *to_priolist(struct rb_node *rb)
> {
> return rb_entry(rb, struct i915_priolist, node);
> }
>
> -static inline int rq_prio(const struct i915_request *rq)
> +static int rq_prio(const struct i915_request *rq)
> {
> return READ_ONCE(rq->sched.attr.priority);
> }
> @@ -299,8 +298,8 @@ static int virtual_prio(const struct intel_engine_execlists *el)
> return rb ? rb_entry(rb, struct ve_node, rb)->prio : INT_MIN;
> }
>
> -static inline bool need_preempt(const struct intel_engine_cs *engine,
> - const struct i915_request *rq)
> +static bool need_preempt(const struct intel_engine_cs *engine,
> + const struct i915_request *rq)
> {
> int last_prio;
>
> @@ -351,7 +350,7 @@ static inline bool need_preempt(const struct intel_engine_cs *engine,
> queue_prio(&engine->execlists)) > last_prio;
> }
>
> -__maybe_unused static inline bool
> +__maybe_unused static bool
> assert_priority_queue(const struct i915_request *prev,
> const struct i915_request *next)
> {
> @@ -418,7 +417,7 @@ execlists_unwind_incomplete_requests(struct intel_engine_execlists *execlists)
> return __unwind_incomplete_requests(engine);
> }
>
> -static inline void
> +static void
> execlists_context_status_change(struct i915_request *rq, unsigned long status)
> {
> /*
> @@ -503,7 +502,7 @@ static void reset_active(struct i915_request *rq,
> ce->lrc.lrca = lrc_update_regs(ce, engine, head);
> }
>
> -static inline struct intel_engine_cs *
> +static struct intel_engine_cs *
> __execlists_schedule_in(struct i915_request *rq)
> {
> struct intel_engine_cs * const engine = rq->engine;
> @@ -549,7 +548,7 @@ __execlists_schedule_in(struct i915_request *rq)
> return engine;
> }
>
> -static inline void execlists_schedule_in(struct i915_request *rq, int idx)
> +static void execlists_schedule_in(struct i915_request *rq, int idx)
> {
> struct intel_context * const ce = rq->context;
> struct intel_engine_cs *old;
> @@ -608,9 +607,9 @@ static void kick_siblings(struct i915_request *rq, struct intel_context *ce)
> tasklet_hi_schedule(&ve->base.execlists.tasklet);
> }
>
> -static inline void __execlists_schedule_out(struct i915_request *rq)
> +static void __execlists_schedule_out(struct i915_request * const rq,
> + struct intel_context * const ce)
> {
> - struct intel_context * const ce = rq->context;
> struct intel_engine_cs * const engine = rq->engine;
> unsigned int ccid;
>
> @@ -621,6 +620,7 @@ static inline void __execlists_schedule_out(struct i915_request *rq)
> */
>
> CE_TRACE(ce, "schedule-out, ccid:%x\n", ce->lrc.ccid);
> + GEM_BUG_ON(ce->inflight != engine);
>
> if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM))
> lrc_check_regs(ce, engine, "after");
> @@ -660,10 +660,12 @@ static inline void __execlists_schedule_out(struct i915_request *rq)
> */
> if (ce->engine != engine)
> kick_siblings(rq, ce);
> +
> + WRITE_ONCE(ce->inflight, NULL);
> + intel_context_put(ce);
> }
>
> -static inline void
> -execlists_schedule_out(struct i915_request *rq)
> +static inline void execlists_schedule_out(struct i915_request *rq)
> {
> struct intel_context * const ce = rq->context;
>
> @@ -671,12 +673,8 @@ execlists_schedule_out(struct i915_request *rq)
>
> GEM_BUG_ON(!ce->inflight);
> ce->inflight = ptr_dec(ce->inflight);
> - if (!__intel_context_inflight_count(ce->inflight)) {
> - GEM_BUG_ON(ce->inflight != rq->engine);
> - __execlists_schedule_out(rq);
> - WRITE_ONCE(ce->inflight, NULL);
> - intel_context_put(ce);
> - }
> + if (!__intel_context_inflight_count(ce->inflight))
> + __execlists_schedule_out(rq, ce);
>
> i915_request_put(rq);
> }
> @@ -728,7 +726,7 @@ static u64 execlists_update_context(struct i915_request *rq)
> return desc;
> }
>
> -static inline void write_desc(struct intel_engine_execlists *execlists, u64 desc, u32 port)
> +static void write_desc(struct intel_engine_execlists *execlists, u64 desc, u32 port)
> {
> if (execlists->ctrl_reg) {
> writel(lower_32_bits(desc), execlists->submit_reg + port * 2);
> @@ -757,7 +755,7 @@ dump_port(char *buf, int buflen, const char *prefix, struct i915_request *rq)
> return buf;
> }
>
> -static __maybe_unused void
> +static __maybe_unused noinline void
> trace_ports(const struct intel_engine_execlists *execlists,
> const char *msg,
> struct i915_request * const *ports)
> @@ -774,13 +772,13 @@ trace_ports(const struct intel_engine_execlists *execlists,
> dump_port(p1, sizeof(p1), ", ", ports[1]));
> }
>
> -static inline bool
> +static bool
> reset_in_progress(const struct intel_engine_execlists *execlists)
> {
> return unlikely(!__tasklet_is_enabled(&execlists->tasklet));
> }
>
> -static __maybe_unused bool
> +static __maybe_unused noinline bool
> assert_pending_valid(const struct intel_engine_execlists *execlists,
> const char *msg)
> {
> @@ -1621,12 +1619,12 @@ static void execlists_dequeue_irq(struct intel_engine_cs *engine)
> local_irq_enable(); /* flush irq_work (e.g. breadcrumb enabling) */
> }
>
> -static inline void clear_ports(struct i915_request **ports, int count)
> +static void clear_ports(struct i915_request **ports, int count)
> {
> memset_p((void **)ports, NULL, count);
> }
>
> -static inline void
> +static void
> copy_ports(struct i915_request **dst, struct i915_request **src, int count)
> {
> /* A memcpy_p() would be very useful here! */
> @@ -1660,8 +1658,7 @@ cancel_port_requests(struct intel_engine_execlists * const execlists,
> return inactive;
> }
>
> -static inline void
> -invalidate_csb_entries(const u64 *first, const u64 *last)
> +static void invalidate_csb_entries(const u64 *first, const u64 *last)
> {
> clflush((void *)first);
> clflush((void *)last);
> @@ -1693,7 +1690,7 @@ invalidate_csb_entries(const u64 *first, const u64 *last)
> * bits 47-57: sw context id of the lrc the GT switched away from
> * bits 58-63: sw counter of the lrc the GT switched away from
> */
> -static inline bool gen12_csb_parse(const u64 csb)
> +static bool gen12_csb_parse(const u64 csb)
> {
> bool ctx_away_valid = GEN12_CSB_CTX_VALID(upper_32_bits(csb));
> bool new_queue =
> @@ -1720,7 +1717,7 @@ static inline bool gen12_csb_parse(const u64 csb)
> return false;
> }
>
> -static inline bool gen8_csb_parse(const u64 csb)
> +static bool gen8_csb_parse(const u64 csb)
> {
> return csb & (GEN8_CTX_STATUS_IDLE_ACTIVE | GEN8_CTX_STATUS_PREEMPTED);
> }
> @@ -1759,8 +1756,7 @@ wa_csb_read(const struct intel_engine_cs *engine, u64 * const csb)
> return entry;
> }
>
> -static inline u64
> -csb_read(const struct intel_engine_cs *engine, u64 * const csb)
> +static u64 csb_read(const struct intel_engine_cs *engine, u64 * const csb)
> {
> u64 entry = READ_ONCE(*csb);
>
> @@ -3180,8 +3176,7 @@ logical_ring_default_vfuncs(struct intel_engine_cs *engine)
> }
> }
>
> -static inline void
> -logical_ring_default_irqs(struct intel_engine_cs *engine)
> +static void logical_ring_default_irqs(struct intel_engine_cs *engine)
> {
> unsigned int shift = 0;
>
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-14 15:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-13 15:11 [Intel-gfx] [PATCH] drm/i915/gt: Prune 'inline' from execlists Chris Wilson
2021-01-13 19:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-14 0:01 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-01-14 15:07 ` [Intel-gfx] [PATCH] " Mika Kuoppala
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.