From: "Philippe Mathieu-Daudé" <f4bug@amsat.org> To: qemu-devel@nongnu.org Cc: "Thomas Huth" <thuth@redhat.com>, "Huacai Chen" <chenhuacai@kernel.org>, qemu-riscv@nongnu.org, "Stefan Weil" <sw@weilnetz.de>, "Cornelia Huck" <cohuck@redhat.com>, "Richard Henderson" <richard.henderson@linaro.org>, "Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-s390x@nongnu.org, qemu-arm@nongnu.org, "Alistair Francis" <Alistair.Francis@wdc.com>, "Palmer Dabbelt" <palmer@dabbelt.com>, "Miroslav Rezanina" <mrezanin@redhat.com>, "Aurelien Jarno" <aurelien@aurel32.net> Subject: [PATCH v2 0/6] tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements Date: Wed, 13 Jan 2021 18:24:53 +0100 [thread overview] Message-ID: <20210113172459.2481060-1-f4bug@amsat.org> (raw) Since v1: - Redo the whole change, only hoisting when variable is used 10+ times - Remove goto statement/label - Take care of the following pattern: case INDEX_op_bswap64_i64: a2 =3D TCG_REG_R0; if (a0 =3D=3D a1) { a0 =3D TCG_REG_R0; a2 =3D a1; } ... if (a0 =3D=3D 0) { tcg_out_mov(s, TCG_TYPE_REG, args[0], a0); ^^^^ take original a[0] } Attempt to fix the warning reported by Miroslav using GCC 10: https://www.mail-archive.com/qemu-devel@nongnu.org/msg771520.html Diff with v1: Key: [----] : patches are identical [####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only The flags [FC] indicate (F)unctional and (C)ontextual differences, respective= ly 001/6:[0063] [FC] 'tcg/arm: Hoist common argument loads in tcg_out_op()' 002/6:[down] 'tcg/arm: Replace goto statement by fall through comment' 003/6:[0190] [FC] 'tcg/ppc: Hoist common argument loads in tcg_out_op()' 004/6:[0136] [FC] 'tcg/s390: Hoist common argument loads in tcg_out_op()' 005/6:[----] [--] 'tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS el= ements' 006/6:[----] [--] 'tcg: Restrict tcg_out_vec_op() to arrays of TCG_MAX_OP_ARG= S elements' Philippe Mathieu-Daud=C3=A9 (6): tcg/arm: Hoist common argument loads in tcg_out_op() tcg/arm: Replace goto statement by fall through comment tcg/ppc: Hoist common argument loads in tcg_out_op() tcg/s390: Hoist common argument loads in tcg_out_op() tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements tcg: Restrict tcg_out_vec_op() to arrays of TCG_MAX_OP_ARGS elements tcg/tcg.c | 19 +-- tcg/aarch64/tcg-target.c.inc | 3 +- tcg/arm/tcg-target.c.inc | 196 +++++++++++++++---------------- tcg/i386/tcg-target.c.inc | 6 +- tcg/mips/tcg-target.c.inc | 3 +- tcg/ppc/tcg-target.c.inc | 191 ++++++++++++++---------------- tcg/riscv/tcg-target.c.inc | 3 +- tcg/s390/tcg-target.c.inc | 222 +++++++++++++++++------------------ tcg/tci/tcg-target.c.inc | 5 +- 9 files changed, 311 insertions(+), 337 deletions(-) --=20 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org> To: qemu-devel@nongnu.org Cc: "Aurelien Jarno" <aurelien@aurel32.net>, "Cornelia Huck" <cohuck@redhat.com>, qemu-arm@nongnu.org, "Alistair Francis" <Alistair.Francis@wdc.com>, "Miroslav Rezanina" <mrezanin@redhat.com>, "Thomas Huth" <thuth@redhat.com>, qemu-riscv@nongnu.org, "Huacai Chen" <chenhuacai@kernel.org>, "Stefan Weil" <sw@weilnetz.de>, "Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>, "Richard Henderson" <richard.henderson@linaro.org>, "Andrzej Zaborowski" <balrogg@gmail.com>, "Palmer Dabbelt" <palmer@dabbelt.com>, qemu-s390x@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, "Jiaxun Yang" <jiaxun.yang@flygoat.com> Subject: [PATCH v2 0/6] tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements Date: Wed, 13 Jan 2021 18:24:53 +0100 [thread overview] Message-ID: <20210113172459.2481060-1-f4bug@amsat.org> (raw) Since v1: - Redo the whole change, only hoisting when variable is used 10+ times - Remove goto statement/label - Take care of the following pattern: case INDEX_op_bswap64_i64: a2 =3D TCG_REG_R0; if (a0 =3D=3D a1) { a0 =3D TCG_REG_R0; a2 =3D a1; } ... if (a0 =3D=3D 0) { tcg_out_mov(s, TCG_TYPE_REG, args[0], a0); ^^^^ take original a[0] } Attempt to fix the warning reported by Miroslav using GCC 10: https://www.mail-archive.com/qemu-devel@nongnu.org/msg771520.html Diff with v1: Key: [----] : patches are identical [####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only The flags [FC] indicate (F)unctional and (C)ontextual differences, respective= ly 001/6:[0063] [FC] 'tcg/arm: Hoist common argument loads in tcg_out_op()' 002/6:[down] 'tcg/arm: Replace goto statement by fall through comment' 003/6:[0190] [FC] 'tcg/ppc: Hoist common argument loads in tcg_out_op()' 004/6:[0136] [FC] 'tcg/s390: Hoist common argument loads in tcg_out_op()' 005/6:[----] [--] 'tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS el= ements' 006/6:[----] [--] 'tcg: Restrict tcg_out_vec_op() to arrays of TCG_MAX_OP_ARG= S elements' Philippe Mathieu-Daud=C3=A9 (6): tcg/arm: Hoist common argument loads in tcg_out_op() tcg/arm: Replace goto statement by fall through comment tcg/ppc: Hoist common argument loads in tcg_out_op() tcg/s390: Hoist common argument loads in tcg_out_op() tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements tcg: Restrict tcg_out_vec_op() to arrays of TCG_MAX_OP_ARGS elements tcg/tcg.c | 19 +-- tcg/aarch64/tcg-target.c.inc | 3 +- tcg/arm/tcg-target.c.inc | 196 +++++++++++++++---------------- tcg/i386/tcg-target.c.inc | 6 +- tcg/mips/tcg-target.c.inc | 3 +- tcg/ppc/tcg-target.c.inc | 191 ++++++++++++++---------------- tcg/riscv/tcg-target.c.inc | 3 +- tcg/s390/tcg-target.c.inc | 222 +++++++++++++++++------------------ tcg/tci/tcg-target.c.inc | 5 +- 9 files changed, 311 insertions(+), 337 deletions(-) --=20 2.26.2
next reply other threads:[~2021-01-13 17:34 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-13 17:24 Philippe Mathieu-Daudé [this message] 2021-01-13 17:24 ` [PATCH v2 0/6] tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements Philippe Mathieu-Daudé 2021-01-13 17:24 ` [PATCH v2 1/6] tcg/arm: Hoist common argument loads in tcg_out_op() Philippe Mathieu-Daudé 2021-01-13 17:24 ` Philippe Mathieu-Daudé 2021-01-13 17:24 ` [PATCH v2 2/6] tcg/arm: Replace goto statement by fall through comment Philippe Mathieu-Daudé 2021-01-13 17:24 ` Philippe Mathieu-Daudé 2021-01-13 17:24 ` [PATCH v2 3/6] tcg/ppc: Hoist common argument loads in tcg_out_op() Philippe Mathieu-Daudé 2021-01-13 17:24 ` Philippe Mathieu-Daudé 2021-01-14 0:28 ` Richard Henderson 2021-01-14 0:28 ` Richard Henderson 2021-01-14 9:59 ` Philippe Mathieu-Daudé 2021-01-14 9:59 ` Philippe Mathieu-Daudé 2021-01-13 17:24 ` [PATCH v2 4/6] tcg/s390: " Philippe Mathieu-Daudé 2021-01-13 17:24 ` Philippe Mathieu-Daudé 2021-01-13 17:24 ` [PATCH v2 5/6] tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements Philippe Mathieu-Daudé 2021-01-13 17:24 ` Philippe Mathieu-Daudé 2021-01-13 17:24 ` [PATCH v2 6/6] tcg: Restrict tcg_out_vec_op() " Philippe Mathieu-Daudé 2021-01-13 17:24 ` Philippe Mathieu-Daudé
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210113172459.2481060-1-f4bug@amsat.org \ --to=f4bug@amsat.org \ --cc=Alistair.Francis@wdc.com \ --cc=aleksandar.rikalo@syrmia.com \ --cc=aurelien@aurel32.net \ --cc=chenhuacai@kernel.org \ --cc=cohuck@redhat.com \ --cc=mrezanin@redhat.com \ --cc=palmer@dabbelt.com \ --cc=qemu-arm@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=qemu-riscv@nongnu.org \ --cc=qemu-s390x@nongnu.org \ --cc=richard.henderson@linaro.org \ --cc=sw@weilnetz.de \ --cc=thuth@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.