All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: brijesh.singh@amd.com, pair@us.ibm.com, dgilbert@redhat.com,
	pasic@linux.ibm.com, qemu-devel@nongnu.org
Cc: cohuck@redhat.com,
	Richard Henderson <richard.henderson@linaro.org>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	borntraeger@de.ibm.com,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	mst@redhat.com, jun.nakajima@intel.com, thuth@redhat.com,
	pragyansri.pathi@intel.com, kvm@vger.kernel.org,
	Eduardo Habkost <ehabkost@redhat.com>,
	qemu-s390x@nongnu.org, qemu-ppc@nongnu.org,
	frankja@linux.ibm.com, Greg Kurz <groug@kaod.org>,
	mdroth@linux.vnet.ibm.com,
	David Gibson <david@gibson.dropbear.id.au>,
	berrange@redhat.com, andi.kleen@intel.com
Subject: [PATCH v7 11/13] spapr: PEF: prevent migration
Date: Thu, 14 Jan 2021 10:58:09 +1100	[thread overview]
Message-ID: <20210113235811.1909610-12-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20210113235811.1909610-1-david@gibson.dropbear.id.au>

We haven't yet implemented the fairly involved handshaking that will be
needed to migrate PEF protected guests.  For now, just use a migration
blocker so we get a meaningful error if someone attempts this (this is the
same approach used by AMD SEV).

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
---
 hw/ppc/pef.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/hw/ppc/pef.c b/hw/ppc/pef.c
index 02b9b3b460..d7a49ef337 100644
--- a/hw/ppc/pef.c
+++ b/hw/ppc/pef.c
@@ -42,6 +42,8 @@ struct PefGuest {
 };
 
 #ifdef CONFIG_KVM
+static Error *pef_mig_blocker;
+
 static int kvmppc_svm_init(Error **errp)
 {
     if (!kvm_check_extension(kvm_state, KVM_CAP_PPC_SECURE_GUEST)) {
@@ -58,6 +60,11 @@ static int kvmppc_svm_init(Error **errp)
         }
     }
 
+    /* add migration blocker */
+    error_setg(&pef_mig_blocker, "PEF: Migration is not implemented");
+    /* NB: This can fail if --only-migratable is used */
+    migrate_add_blocker(pef_mig_blocker, &error_fatal);
+
     return 0;
 }
 
-- 
2.29.2


WARNING: multiple messages have this Message-ID (diff)
From: David Gibson <david@gibson.dropbear.id.au>
To: brijesh.singh@amd.com, pair@us.ibm.com, dgilbert@redhat.com,
	pasic@linux.ibm.com, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, thuth@redhat.com,
	Marcelo Tosatti <mtosatti@redhat.com>,
	berrange@redhat.com, jun.nakajima@intel.com, kvm@vger.kernel.org,
	David Hildenbrand <david@redhat.com>,
	cohuck@redhat.com,
	Richard Henderson <richard.henderson@linaro.org>,
	Greg Kurz <groug@kaod.org>,
	mdroth@linux.vnet.ibm.com, borntraeger@de.ibm.com,
	qemu-s390x@nongnu.org, frankja@linux.ibm.com, mst@redhat.com,
	pragyansri.pathi@intel.com, andi.kleen@intel.com,
	Paolo Bonzini <pbonzini@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: [PATCH v7 11/13] spapr: PEF: prevent migration
Date: Thu, 14 Jan 2021 10:58:09 +1100	[thread overview]
Message-ID: <20210113235811.1909610-12-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20210113235811.1909610-1-david@gibson.dropbear.id.au>

We haven't yet implemented the fairly involved handshaking that will be
needed to migrate PEF protected guests.  For now, just use a migration
blocker so we get a meaningful error if someone attempts this (this is the
same approach used by AMD SEV).

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
---
 hw/ppc/pef.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/hw/ppc/pef.c b/hw/ppc/pef.c
index 02b9b3b460..d7a49ef337 100644
--- a/hw/ppc/pef.c
+++ b/hw/ppc/pef.c
@@ -42,6 +42,8 @@ struct PefGuest {
 };
 
 #ifdef CONFIG_KVM
+static Error *pef_mig_blocker;
+
 static int kvmppc_svm_init(Error **errp)
 {
     if (!kvm_check_extension(kvm_state, KVM_CAP_PPC_SECURE_GUEST)) {
@@ -58,6 +60,11 @@ static int kvmppc_svm_init(Error **errp)
         }
     }
 
+    /* add migration blocker */
+    error_setg(&pef_mig_blocker, "PEF: Migration is not implemented");
+    /* NB: This can fail if --only-migratable is used */
+    migrate_add_blocker(pef_mig_blocker, &error_fatal);
+
     return 0;
 }
 
-- 
2.29.2



  parent reply	other threads:[~2021-01-14  1:53 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13 23:57 [PATCH v7 00/13] Generalize memory encryption models David Gibson
2021-01-13 23:57 ` David Gibson
2021-01-13 23:57 ` [PATCH v7 01/13] qom: Allow optional sugar props David Gibson
2021-01-13 23:57   ` David Gibson
2021-01-13 23:58 ` [PATCH v7 02/13] confidential guest support: Introduce new confidential guest support class David Gibson
2021-01-13 23:58   ` David Gibson
2021-01-14  9:34   ` Daniel P. Berrangé
2021-01-14  9:34     ` Daniel P. Berrangé
2021-01-14 10:42     ` David Gibson
2021-01-14 10:42       ` David Gibson
2021-01-18 18:51   ` Dr. David Alan Gilbert
2021-01-18 18:51     ` Dr. David Alan Gilbert
2021-01-21  1:06     ` David Gibson
2021-01-21  1:06       ` David Gibson
2021-01-21  9:08       ` Dr. David Alan Gilbert
2021-01-21  9:08         ` Dr. David Alan Gilbert
2021-01-29  2:32         ` David Gibson
2021-01-29  2:32           ` David Gibson
2021-01-13 23:58 ` [PATCH v7 03/13] sev: Remove false abstraction of flash encryption David Gibson
2021-01-13 23:58   ` David Gibson
2021-01-15 12:54   ` Cornelia Huck
2021-01-15 12:54     ` Cornelia Huck
2021-01-18  2:59     ` David Gibson
2021-01-18  2:59       ` David Gibson
2021-01-13 23:58 ` [PATCH v7 04/13] confidential guest support: Move side effect out of machine_set_memory_encryption() David Gibson
2021-01-13 23:58   ` David Gibson
2021-01-15 12:56   ` Cornelia Huck
2021-01-15 12:56     ` Cornelia Huck
2021-01-13 23:58 ` [PATCH v7 05/13] confidential guest support: Rework the "memory-encryption" property David Gibson
2021-01-13 23:58   ` David Gibson
2021-01-15 13:06   ` Cornelia Huck
2021-01-15 13:06     ` Cornelia Huck
2021-01-13 23:58 ` [PATCH v7 06/13] sev: Add Error ** to sev_kvm_init() David Gibson
2021-01-13 23:58   ` David Gibson
2021-01-13 23:58 ` [PATCH v7 07/13] confidential guest support: Introduce cgs "ready" flag David Gibson
2021-01-13 23:58   ` David Gibson
2021-01-14  8:55   ` Greg Kurz
2021-01-14  8:55     ` Greg Kurz
2021-01-15 13:12   ` Cornelia Huck
2021-01-15 13:12     ` Cornelia Huck
2021-01-18 19:47   ` Dr. David Alan Gilbert
2021-01-18 19:47     ` Dr. David Alan Gilbert
2021-01-19  8:16     ` Cornelia Huck
2021-01-19  8:16       ` Cornelia Huck
2021-02-02  1:41       ` David Gibson
2021-02-02  1:41         ` David Gibson
2021-01-29  6:30     ` David Gibson
2021-01-13 23:58 ` [PATCH v7 08/13] confidential guest support: Move SEV initialization into arch specific code David Gibson
2021-01-13 23:58   ` David Gibson
2021-01-15 13:24   ` Cornelia Huck
2021-01-15 13:24     ` Cornelia Huck
2021-01-18  3:03     ` David Gibson
2021-01-18  3:03       ` David Gibson
2021-01-18  8:03       ` Cornelia Huck
2021-01-18  8:03         ` Cornelia Huck
2021-01-29  3:12         ` David Gibson
2021-01-29  3:12           ` David Gibson
2021-01-13 23:58 ` [PATCH v7 09/13] confidential guest support: Update documentation David Gibson
2021-01-13 23:58   ` David Gibson
2021-01-14 10:07   ` Greg Kurz
2021-01-14 10:07     ` Greg Kurz
2021-01-15 15:36   ` Cornelia Huck
2021-01-15 15:36     ` Cornelia Huck
2021-01-29  2:36     ` David Gibson
2021-01-29  2:36       ` David Gibson
2021-01-13 23:58 ` [PATCH v7 10/13] spapr: Add PEF based confidential guest support David Gibson
2021-01-13 23:58   ` David Gibson
2021-01-14 10:39   ` Greg Kurz
2021-01-29  6:23     ` David Gibson
2021-01-15 15:41   ` Cornelia Huck
2021-01-15 15:41     ` Cornelia Huck
2021-01-29  2:43     ` David Gibson
2021-01-29  2:43       ` David Gibson
2021-01-13 23:58 ` David Gibson [this message]
2021-01-13 23:58   ` [PATCH v7 11/13] spapr: PEF: prevent migration David Gibson
2021-01-13 23:58 ` [PATCH v7 12/13] confidential guest support: Alter virtio default properties for protected guests David Gibson
2021-01-13 23:58   ` David Gibson
2021-01-13 23:58 ` [PATCH v7 13/13] s390: Recognize confidential-guest-support option David Gibson
2021-01-13 23:58   ` David Gibson
2021-01-14  9:10   ` Christian Borntraeger
2021-01-14  9:10     ` Christian Borntraeger
2021-01-14  9:19     ` Christian Borntraeger
2021-01-14  9:19       ` Christian Borntraeger
2021-01-14  9:24       ` Christian Borntraeger
2021-01-14  9:24         ` Christian Borntraeger
2021-01-15  0:13         ` David Gibson
2021-01-15  0:13           ` David Gibson
2021-01-14 11:45     ` David Gibson
2021-01-14 11:45       ` David Gibson
2021-01-15 16:36   ` Cornelia Huck
2021-01-15 16:36     ` Cornelia Huck
2021-01-18 17:06     ` Christian Borntraeger
2021-01-18 17:06       ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210113235811.1909610-12-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=andi.kleen@intel.com \
    --cc=berrange@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=brijesh.singh@amd.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=groug@kaod.org \
    --cc=jun.nakajima@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pair@us.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=pragyansri.pathi@intel.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.