Re: [PATCH v5 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

Re: [PATCH v5 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1969 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210113172450.v5.2.I38e90f114f0311b8aa3bcfff750ba381c09dd3b6@changeid>
References: <20210113172450.v5.2.I38e90f114f0311b8aa3bcfff750ba381c09dd3b6(a)changeid>
TO: Philip Chen <philipchen@chromium.org>
TO: LKML <linux-kernel@vger.kernel.org>
TO: dmitry.torokhov(a)gmail.com
CC: dianders(a)chromium.org
CC: swboyd(a)chromium.org
CC: Philip Chen <philipchen@chromium.org>
CC: Benson Leung <bleung@chromium.org>
CC: Enric Balletbo i Serra <enric.balletbo@collabora.com>
CC: Guenter Roeck <groeck@chromium.org>
CC: Lee Jones <lee.jones@linaro.org>
CC: Rajat Jain <rajatja@google.com>

Hi Philip,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.11-rc3 next-20210113]
[cannot apply to input/next linux/master chrome-platform-linux/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Philip-Chen/dt-bindings-input-cros-ec-keyb-Add-a-new-property/20210114-094548
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 65f0d2414b7079556fbbcc070b3d1c9f9587606d
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago
config: i386-randconfig-c001-20210114 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/input/keyboard/cros_ec_keyb.c:644:60-61: WARNING opportunity for kobj_to_dev()

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33818 bytes --]

[PATCH] Input: fix kobj_to_dev.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1910 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210113172450.v5.2.I38e90f114f0311b8aa3bcfff750ba381c09dd3b6@changeid>
References: <20210113172450.v5.2.I38e90f114f0311b8aa3bcfff750ba381c09dd3b6(a)changeid>
TO: Philip Chen <philipchen@chromium.org>
TO: LKML <linux-kernel@vger.kernel.org>
TO: dmitry.torokhov(a)gmail.com
CC: dianders(a)chromium.org
CC: swboyd(a)chromium.org
CC: Philip Chen <philipchen@chromium.org>
CC: Benson Leung <bleung@chromium.org>
CC: Enric Balletbo i Serra <enric.balletbo@collabora.com>
CC: Guenter Roeck <groeck@chromium.org>
CC: Lee Jones <lee.jones@linaro.org>
CC: Rajat Jain <rajatja@google.com>

From: kernel test robot <lkp@intel.com>

drivers/input/keyboard/cros_ec_keyb.c:644:60-61: WARNING opportunity for kobj_to_dev()


 Use kobj_to_dev() instead of container_of()

Generated by: scripts/coccinelle/api/kobj_to_dev.cocci

CC: Philip Chen <philipchen@chromium.org>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

url:    https://github.com/0day-ci/linux/commits/Philip-Chen/dt-bindings-input-cros-ec-keyb-Add-a-new-property/20210114-094548
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 65f0d2414b7079556fbbcc070b3d1c9f9587606d
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago

Please take the patch only if it's a positive warning. Thanks!

 cros_ec_keyb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/input/keyboard/cros_ec_keyb.c
+++ b/drivers/input/keyboard/cros_ec_keyb.c
@@ -641,7 +641,7 @@ static umode_t cros_ec_keyb_attr_is_visi
 					    struct attribute *attr,
 					    int n)
 {
-	struct device *dev = container_of(kobj, struct device, kobj);
+	struct device *dev = kobj_to_dev(kobj);
 	struct cros_ec_keyb *ckdev = dev_get_drvdata(dev);
 
 	if (attr == &dev_attr_function_row_physmap.attr &&