* [PATCH] of: base: improve error msg in of_phandle_iterator_next()
@ 2021-01-14 10:11 Enrico Weigelt, metux IT consult
2021-01-15 17:26 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2021-01-14 10:11 UTC (permalink / raw)
To: linux-kernel; +Cc: robh+dt, frowand.list, devicetree
Also print out the phandle ID on error message, as a debug aid.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/of/base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 161a23631472..8a348f0d3c5e 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1297,8 +1297,8 @@ int of_phandle_iterator_next(struct of_phandle_iterator *it)
if (it->cells_name) {
if (!it->node) {
- pr_err("%pOF: could not find phandle\n",
- it->parent);
+ pr_err("%pOF: could not find phandle %d\n",
+ it->parent, it->phandle);
goto err;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] of: base: improve error msg in of_phandle_iterator_next()
2021-01-14 10:11 [PATCH] of: base: improve error msg in of_phandle_iterator_next() Enrico Weigelt, metux IT consult
@ 2021-01-15 17:26 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2021-01-15 17:26 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: linux-kernel, devicetree, frowand.list, robh+dt
On Thu, 14 Jan 2021 11:11:27 +0100, Enrico Weigelt, metux IT consult wrote:
> Also print out the phandle ID on error message, as a debug aid.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> drivers/of/base.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-15 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-14 10:11 [PATCH] of: base: improve error msg in of_phandle_iterator_next() Enrico Weigelt, metux IT consult
2021-01-15 17:26 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.