From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Li Feng <fengli@smartx.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
"lifeng1519@gmail.com" <lifeng1519@gmail.com>
Subject: Re: [PATCH] nvme: reject the ns when the block size is smaller than a sector
Date: Thu, 14 Jan 2021 18:43:11 +0100 [thread overview]
Message-ID: <20210114174311.GB31188@lst.de> (raw)
In-Reply-To: <87698545-de26-c0ca-01e9-4dc2ddcacc80@grimberg.me>
On Wed, Jan 13, 2021 at 02:12:59PM -0800, Sagi Grimberg wrote:
>> But this only catches a physical block size < 512 for NVMe, not any other block device.
>>
>> Please fix it for the general case in blk_queue_physical_block_size().
>
> We actually call that later and would probably be better to check here..
We had a series for that a short while ago that got lost.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: "lifeng1519@gmail.com" <lifeng1519@gmail.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
Jens Axboe <axboe@fb.com>, Li Feng <fengli@smartx.com>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: reject the ns when the block size is smaller than a sector
Date: Thu, 14 Jan 2021 18:43:11 +0100 [thread overview]
Message-ID: <20210114174311.GB31188@lst.de> (raw)
In-Reply-To: <87698545-de26-c0ca-01e9-4dc2ddcacc80@grimberg.me>
On Wed, Jan 13, 2021 at 02:12:59PM -0800, Sagi Grimberg wrote:
>> But this only catches a physical block size < 512 for NVMe, not any other block device.
>>
>> Please fix it for the general case in blk_queue_physical_block_size().
>
> We actually call that later and would probably be better to check here..
We had a series for that a short while ago that got lost.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-14 17:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 16:06 [PATCH] nvme: reject the ns when the block size is smaller than a sector Li Feng
2021-01-13 16:06 ` Li Feng
2021-01-13 16:18 ` Johannes Thumshirn
2021-01-13 16:18 ` Johannes Thumshirn
2021-01-13 22:12 ` Sagi Grimberg
2021-01-13 22:12 ` Sagi Grimberg
2021-01-14 5:17 ` Feng Li
2021-01-14 5:17 ` Feng Li
2021-01-14 17:43 ` Christoph Hellwig [this message]
2021-01-14 17:43 ` Christoph Hellwig
2021-01-14 21:13 ` Sagi Grimberg
2021-01-14 21:13 ` Sagi Grimberg
2021-01-15 3:30 ` Li Feng
2021-01-15 3:30 ` Li Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114174311.GB31188@lst.de \
--to=hch@lst.de \
--cc=Johannes.Thumshirn@wdc.com \
--cc=axboe@fb.com \
--cc=fengli@smartx.com \
--cc=kbusch@kernel.org \
--cc=lifeng1519@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.