All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Linux Doc Mailing List <linux-doc@vger.kernel.org>,
	Jonathan Corbet <corbet@lwn.net>
Cc: kbuild-all@lists.01.org, linux-media@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 11/16] scripts: kernel-doc: validate kernel-doc markup with the actual names
Date: Thu, 14 Jan 2021 18:11:51 +0800	[thread overview]
Message-ID: <202101141835.KQXTHnJC-lkp@intel.com> (raw)
In-Reply-To: <081546f141a496d6cabb99a4adc140444c705e93.1610610937.git.mchehab+huawei@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 6531 bytes --]

Hi Mauro,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20210113]
[also build test WARNING on v5.11-rc3]
[cannot apply to lwn/docs-next kees/for-next/pstore mac80211-next/master mac80211/master pza/reset/next linus/master v5.11-rc3 v5.11-rc2 v5.11-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Fix-several-bad-kernel-doc-markups/20210114-161010
base:    aa515cdce7a151dcc14b7600d33f1414c6fa32c9
config: arm64-alldefconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1e9159b3640012fc5fab8508b1c5635ac13a55e9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mauro-Carvalho-Chehab/Fix-several-bad-kernel-doc-markups/20210114-161010
        git checkout 1e9159b3640012fc5fab8508b1c5635ac13a55e9
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   kernel/seccomp.c:126: warning: Function parameter or member 'list' not described in 'seccomp_kaddfd'
   kernel/seccomp.c:390: warning: Function parameter or member 'ret' not described in 'ACTION_ONLY'
>> kernel/seccomp.c:390: warning: expecting prototype for seccomp_run_filters(). Prototype was for ACTION_ONLY() instead
   kernel/seccomp.c:553: warning: Function parameter or member 'tsk' not described in 'seccomp_filter_release'
   kernel/seccomp.c:573: warning: Function parameter or member 'flags' not described in 'seccomp_sync_threads'
--
   drivers/base/platform-msi.c:336: warning: Function parameter or member 'is_tree' not described in '__platform_msi_create_device_domain'
>> drivers/base/platform-msi.c:336: warning: expecting prototype for platform_msi_create_device_domain(). Prototype was for __platform_msi_create_device_domain() instead
--
>> drivers/iommu/iommu.c:956: warning: expecting prototype for iommu_group_for_each_dev(). Prototype was for __iommu_group_for_each_dev() instead
   drivers/iommu/iommu.c:2976: warning: Function parameter or member 'drvdata' not described in 'iommu_sva_bind_device'
--
>> kernel/irq/msi.c:534: warning: expecting prototype for __msi_domain_free_irqs(). Prototype was for msi_domain_free_irqs() instead
--
>> kernel/irq/ipi.c:264: warning: expecting prototype for ipi_send_mask(). Prototype was for __ipi_send_mask() instead


vim +390 kernel/seccomp.c

f9d480b6ffbeb336 YiFei Zhu          2020-10-11  380  
e2cfabdfd0756482 Will Drewry        2012-04-12  381  /**
285fdfc5d9959a21 Mickaël Salaün     2016-09-20  382   * seccomp_run_filters - evaluates all seccomp filters against @sd
285fdfc5d9959a21 Mickaël Salaün     2016-09-20  383   * @sd: optional seccomp data to be passed to filters
deb4de8b31bc5bf2 Kees Cook          2017-08-02  384   * @match: stores struct seccomp_filter that resulted in the return value,
deb4de8b31bc5bf2 Kees Cook          2017-08-02  385   *         unless filter returned SECCOMP_RET_ALLOW, in which case it will
deb4de8b31bc5bf2 Kees Cook          2017-08-02  386   *         be unchanged.
e2cfabdfd0756482 Will Drewry        2012-04-12  387   *
e2cfabdfd0756482 Will Drewry        2012-04-12  388   * Returns valid seccomp BPF response codes.
e2cfabdfd0756482 Will Drewry        2012-04-12  389   */
0466bdb99e8744bc Kees Cook          2017-08-11 @390  #define ACTION_ONLY(ret) ((s32)((ret) & (SECCOMP_RET_ACTION_FULL)))
deb4de8b31bc5bf2 Kees Cook          2017-08-02  391  static u32 seccomp_run_filters(const struct seccomp_data *sd,
deb4de8b31bc5bf2 Kees Cook          2017-08-02  392  			       struct seccomp_filter **match)
e2cfabdfd0756482 Will Drewry        2012-04-12  393  {
acf3b2c71ed20c53 Will Drewry        2012-04-12  394  	u32 ret = SECCOMP_RET_ALLOW;
8225d3853f34f6cf Pranith Kumar      2014-11-21  395  	/* Make sure cross-thread synced filter points somewhere sane. */
8225d3853f34f6cf Pranith Kumar      2014-11-21  396  	struct seccomp_filter *f =
506458efaf153c1e Will Deacon        2017-10-24  397  			READ_ONCE(current->seccomp.filter);
acf3b2c71ed20c53 Will Drewry        2012-04-12  398  
acf3b2c71ed20c53 Will Drewry        2012-04-12  399  	/* Ensure unexpected behavior doesn't result in failing open. */
0d42d73a37ff9102 Igor Stoppa        2018-09-05  400  	if (WARN_ON(f == NULL))
4d3b0b05aae9ee9c Kees Cook          2017-08-11  401  		return SECCOMP_RET_KILL_PROCESS;
acf3b2c71ed20c53 Will Drewry        2012-04-12  402  
f9d480b6ffbeb336 YiFei Zhu          2020-10-11  403  	if (seccomp_cache_check_allow(f, sd))
f9d480b6ffbeb336 YiFei Zhu          2020-10-11  404  		return SECCOMP_RET_ALLOW;
f9d480b6ffbeb336 YiFei Zhu          2020-10-11  405  
e2cfabdfd0756482 Will Drewry        2012-04-12  406  	/*
e2cfabdfd0756482 Will Drewry        2012-04-12  407  	 * All filters in the list are evaluated and the lowest BPF return
acf3b2c71ed20c53 Will Drewry        2012-04-12  408  	 * value always takes priority (ignoring the DATA).
e2cfabdfd0756482 Will Drewry        2012-04-12  409  	 */
3ba2530cc06eb4ae Kees Cook          2014-06-27  410  	for (; f; f = f->prev) {
3d9f773cf2876c01 David Miller       2020-02-24  411  		u32 cur_ret = bpf_prog_run_pin_on_cpu(f->prog, sd);
8f577cadf7181243 Alexei Starovoitov 2014-05-13  412  
0466bdb99e8744bc Kees Cook          2017-08-11  413  		if (ACTION_ONLY(cur_ret) < ACTION_ONLY(ret)) {
acf3b2c71ed20c53 Will Drewry        2012-04-12  414  			ret = cur_ret;
deb4de8b31bc5bf2 Kees Cook          2017-08-02  415  			*match = f;
deb4de8b31bc5bf2 Kees Cook          2017-08-02  416  		}
e2cfabdfd0756482 Will Drewry        2012-04-12  417  	}
e2cfabdfd0756482 Will Drewry        2012-04-12  418  	return ret;
e2cfabdfd0756482 Will Drewry        2012-04-12  419  }
1f41b450416e689b Kees Cook          2014-06-25  420  #endif /* CONFIG_SECCOMP_FILTER */
1f41b450416e689b Kees Cook          2014-06-25  421  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 10848 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v6 11/16] scripts: kernel-doc: validate kernel-doc markup with the actual names
Date: Thu, 14 Jan 2021 18:11:51 +0800	[thread overview]
Message-ID: <202101141835.KQXTHnJC-lkp@intel.com> (raw)
In-Reply-To: <081546f141a496d6cabb99a4adc140444c705e93.1610610937.git.mchehab+huawei@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 6630 bytes --]

Hi Mauro,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20210113]
[also build test WARNING on v5.11-rc3]
[cannot apply to lwn/docs-next kees/for-next/pstore mac80211-next/master mac80211/master pza/reset/next linus/master v5.11-rc3 v5.11-rc2 v5.11-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Fix-several-bad-kernel-doc-markups/20210114-161010
base:    aa515cdce7a151dcc14b7600d33f1414c6fa32c9
config: arm64-alldefconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1e9159b3640012fc5fab8508b1c5635ac13a55e9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mauro-Carvalho-Chehab/Fix-several-bad-kernel-doc-markups/20210114-161010
        git checkout 1e9159b3640012fc5fab8508b1c5635ac13a55e9
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   kernel/seccomp.c:126: warning: Function parameter or member 'list' not described in 'seccomp_kaddfd'
   kernel/seccomp.c:390: warning: Function parameter or member 'ret' not described in 'ACTION_ONLY'
>> kernel/seccomp.c:390: warning: expecting prototype for seccomp_run_filters(). Prototype was for ACTION_ONLY() instead
   kernel/seccomp.c:553: warning: Function parameter or member 'tsk' not described in 'seccomp_filter_release'
   kernel/seccomp.c:573: warning: Function parameter or member 'flags' not described in 'seccomp_sync_threads'
--
   drivers/base/platform-msi.c:336: warning: Function parameter or member 'is_tree' not described in '__platform_msi_create_device_domain'
>> drivers/base/platform-msi.c:336: warning: expecting prototype for platform_msi_create_device_domain(). Prototype was for __platform_msi_create_device_domain() instead
--
>> drivers/iommu/iommu.c:956: warning: expecting prototype for iommu_group_for_each_dev(). Prototype was for __iommu_group_for_each_dev() instead
   drivers/iommu/iommu.c:2976: warning: Function parameter or member 'drvdata' not described in 'iommu_sva_bind_device'
--
>> kernel/irq/msi.c:534: warning: expecting prototype for __msi_domain_free_irqs(). Prototype was for msi_domain_free_irqs() instead
--
>> kernel/irq/ipi.c:264: warning: expecting prototype for ipi_send_mask(). Prototype was for __ipi_send_mask() instead


vim +390 kernel/seccomp.c

f9d480b6ffbeb336 YiFei Zhu          2020-10-11  380  
e2cfabdfd0756482 Will Drewry        2012-04-12  381  /**
285fdfc5d9959a21 Mickaël Salaün     2016-09-20  382   * seccomp_run_filters - evaluates all seccomp filters against @sd
285fdfc5d9959a21 Mickaël Salaün     2016-09-20  383   * @sd: optional seccomp data to be passed to filters
deb4de8b31bc5bf2 Kees Cook          2017-08-02  384   * @match: stores struct seccomp_filter that resulted in the return value,
deb4de8b31bc5bf2 Kees Cook          2017-08-02  385   *         unless filter returned SECCOMP_RET_ALLOW, in which case it will
deb4de8b31bc5bf2 Kees Cook          2017-08-02  386   *         be unchanged.
e2cfabdfd0756482 Will Drewry        2012-04-12  387   *
e2cfabdfd0756482 Will Drewry        2012-04-12  388   * Returns valid seccomp BPF response codes.
e2cfabdfd0756482 Will Drewry        2012-04-12  389   */
0466bdb99e8744bc Kees Cook          2017-08-11 @390  #define ACTION_ONLY(ret) ((s32)((ret) & (SECCOMP_RET_ACTION_FULL)))
deb4de8b31bc5bf2 Kees Cook          2017-08-02  391  static u32 seccomp_run_filters(const struct seccomp_data *sd,
deb4de8b31bc5bf2 Kees Cook          2017-08-02  392  			       struct seccomp_filter **match)
e2cfabdfd0756482 Will Drewry        2012-04-12  393  {
acf3b2c71ed20c53 Will Drewry        2012-04-12  394  	u32 ret = SECCOMP_RET_ALLOW;
8225d3853f34f6cf Pranith Kumar      2014-11-21  395  	/* Make sure cross-thread synced filter points somewhere sane. */
8225d3853f34f6cf Pranith Kumar      2014-11-21  396  	struct seccomp_filter *f =
506458efaf153c1e Will Deacon        2017-10-24  397  			READ_ONCE(current->seccomp.filter);
acf3b2c71ed20c53 Will Drewry        2012-04-12  398  
acf3b2c71ed20c53 Will Drewry        2012-04-12  399  	/* Ensure unexpected behavior doesn't result in failing open. */
0d42d73a37ff9102 Igor Stoppa        2018-09-05  400  	if (WARN_ON(f == NULL))
4d3b0b05aae9ee9c Kees Cook          2017-08-11  401  		return SECCOMP_RET_KILL_PROCESS;
acf3b2c71ed20c53 Will Drewry        2012-04-12  402  
f9d480b6ffbeb336 YiFei Zhu          2020-10-11  403  	if (seccomp_cache_check_allow(f, sd))
f9d480b6ffbeb336 YiFei Zhu          2020-10-11  404  		return SECCOMP_RET_ALLOW;
f9d480b6ffbeb336 YiFei Zhu          2020-10-11  405  
e2cfabdfd0756482 Will Drewry        2012-04-12  406  	/*
e2cfabdfd0756482 Will Drewry        2012-04-12  407  	 * All filters in the list are evaluated and the lowest BPF return
acf3b2c71ed20c53 Will Drewry        2012-04-12  408  	 * value always takes priority (ignoring the DATA).
e2cfabdfd0756482 Will Drewry        2012-04-12  409  	 */
3ba2530cc06eb4ae Kees Cook          2014-06-27  410  	for (; f; f = f->prev) {
3d9f773cf2876c01 David Miller       2020-02-24  411  		u32 cur_ret = bpf_prog_run_pin_on_cpu(f->prog, sd);
8f577cadf7181243 Alexei Starovoitov 2014-05-13  412  
0466bdb99e8744bc Kees Cook          2017-08-11  413  		if (ACTION_ONLY(cur_ret) < ACTION_ONLY(ret)) {
acf3b2c71ed20c53 Will Drewry        2012-04-12  414  			ret = cur_ret;
deb4de8b31bc5bf2 Kees Cook          2017-08-02  415  			*match = f;
deb4de8b31bc5bf2 Kees Cook          2017-08-02  416  		}
e2cfabdfd0756482 Will Drewry        2012-04-12  417  	}
e2cfabdfd0756482 Will Drewry        2012-04-12  418  	return ret;
e2cfabdfd0756482 Will Drewry        2012-04-12  419  }
1f41b450416e689b Kees Cook          2014-06-25  420  #endif /* CONFIG_SECCOMP_FILTER */
1f41b450416e689b Kees Cook          2014-06-25  421  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 10848 bytes --]

  reply	other threads:[~2021-01-14 10:13 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14  8:04 [PATCH v6 00/16] Fix several bad kernel-doc markups Mauro Carvalho Chehab
2021-01-14  8:04 ` Mauro Carvalho Chehab
2021-01-14  8:04 ` [PATCH v6 01/16] parport: fix a kernel-doc markup Mauro Carvalho Chehab
2021-01-14  8:04 ` [PATCH v6 02/16] rapidio: fix kernel-doc a markup Mauro Carvalho Chehab
2021-01-14  8:04 ` [PATCH v6 03/16] fs: fix kernel-doc markups Mauro Carvalho Chehab
2021-01-14  8:04 ` [PATCH v6 04/16] pstore/zone: fix a kernel-doc markup Mauro Carvalho Chehab
2021-01-14  8:04 ` [PATCH v6 05/16] firmware: stratix10-svc: fix kernel-doc markups Mauro Carvalho Chehab
2021-01-14  8:04 ` [PATCH v6 06/16] connector: fix a kernel-doc markup Mauro Carvalho Chehab
2021-01-14  8:04 ` [PATCH v6 07/16] lib/crc7: " Mauro Carvalho Chehab
2021-01-14  8:04 ` [PATCH v6 08/16] memblock: fix kernel-doc markups Mauro Carvalho Chehab
2021-01-14  8:04 ` [PATCH v6 09/16] w1: fix a kernel-doc markup Mauro Carvalho Chehab
2021-01-14  8:04 ` [PATCH v6 10/16] selftests: kselftest_harness.h: partially fix kernel-doc markups Mauro Carvalho Chehab
2021-01-14  8:04 ` [PATCH v6 11/16] scripts: kernel-doc: validate kernel-doc markup with the actual names Mauro Carvalho Chehab
2021-01-14 10:11   ` kernel test robot [this message]
2021-01-14 10:11     ` kernel test robot
2021-01-14 10:16   ` kernel test robot
2021-01-14 10:16     ` kernel test robot
2021-01-18 20:35   ` Jonathan Corbet
2021-01-19  7:43     ` Mauro Carvalho Chehab
2021-01-14  8:04 ` [PATCH v6 12/16] net: tip: fix a couple kernel-doc markups Mauro Carvalho Chehab
2021-01-14 15:59   ` Jon Maloy
2021-01-14 18:34     ` Jakub Kicinski
2021-01-14 21:22       ` Johannes Berg
2021-01-14  8:04 ` [PATCH v6 13/16] net: cfg80211: fix a kerneldoc markup Mauro Carvalho Chehab
2021-01-14  8:04 ` [PATCH v6 14/16] reset: core: fix a kernel-doc markup Mauro Carvalho Chehab
2021-01-14  8:25   ` Philipp Zabel
2021-01-14  8:04 ` [PATCH v6 15/16] drm: drm_crc: " Mauro Carvalho Chehab
2021-01-14  8:04   ` Mauro Carvalho Chehab
2021-01-14  8:06   ` Simon Ser
2021-01-14  8:06     ` Simon Ser
2021-01-14 14:13     ` Simon Ser
2021-01-14 14:13       ` Simon Ser
2021-01-14  8:04 ` [PATCH v6 16/16] platform/surface: aggregator: " Mauro Carvalho Chehab
2021-01-14 14:53   ` Maximilian Luz
2021-01-18 18:20   ` Hans de Goede
2021-01-21 19:09 ` [PATCH v6 00/16] Fix several bad kernel-doc markups Jonathan Corbet
2021-01-21 19:09   ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202101141835.KQXTHnJC-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=corbet@lwn.net \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.