* [PATCH pci-next] PCI: dwc: put struct dw_pcie::{ep,pp} into a union to reduce its size
@ 2021-01-16 15:27 Alexander Lobakin
0 siblings, 0 replies; only message in thread
From: Alexander Lobakin @ 2021-01-16 15:27 UTC (permalink / raw)
To: Lorenzo Pieralisi, Bjorn Helgaas
Cc: Jingoo Han, Gustavo Pimentel, Rob Herring, Alexander Lobakin,
linux-pci, linux-kernel
A single dw_pcie entity can't be a root complex and an endpoint at
the same time.
We can use this to reduce the size of dw_pcie by 80, from 280 to 200
bytes (on x32, guess more on x64), by putting the related embedded
structures (struct pcie_port and struct dw_pcie_ep) into a union.
Signed-off-by: Alexander Lobakin <alobakin@pm.me>
---
drivers/pci/controller/dwc/pcie-designware.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
index 5d979953800d..924ebeaa3885 100644
--- a/drivers/pci/controller/dwc/pcie-designware.h
+++ b/drivers/pci/controller/dwc/pcie-designware.h
@@ -265,8 +265,10 @@ struct dw_pcie {
size_t atu_size;
u32 num_ib_windows;
u32 num_ob_windows;
- struct pcie_port pp;
- struct dw_pcie_ep ep;
+ union {
+ struct pcie_port pp;
+ struct dw_pcie_ep ep;
+ };
const struct dw_pcie_ops *ops;
unsigned int version;
int num_lanes;
--
2.30.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-01-16 17:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-16 15:27 [PATCH pci-next] PCI: dwc: put struct dw_pcie::{ep,pp} into a union to reduce its size Alexander Lobakin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.