From: kernel test robot <lkp@intel.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>, netdev@vger.kernel.org
Cc: kbuild-all@lists.01.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Björn Töpel" <bjorn.topel@intel.com>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jesper Dangaard Brouer" <hawk@kernel.org>
Subject: Re: [PATCH bpf-next] xsk: build skb by page
Date: Sat, 16 Jan 2021 16:15:14 +0800 [thread overview]
Message-ID: <202101161615.rxZFpeqH-lkp@intel.com> (raw)
In-Reply-To: <579fa463bba42ac71591540a1811dca41d725350.1610764948.git.xuanzhuo@linux.alibaba.com>
[-- Attachment #1: Type: text/plain, Size: 3312 bytes --]
Hi Xuan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Xuan-Zhuo/xsk-build-skb-by-page/20210116-105116
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ee139d2988e5c5945108889a7c95c751910c1877
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Xuan-Zhuo/xsk-build-skb-by-page/20210116-105116
git checkout ee139d2988e5c5945108889a7c95c751910c1877
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
net/xdp/xsk.c: In function 'xsk_build_skb':
>> net/xdp/xsk.c:497:4: error: invalid type argument of unary '*' (have 'int')
497 | *err = -ENOMEM;
| ^~~~
net/xdp/xsk.c:508:4: error: invalid type argument of unary '*' (have 'int')
508 | *err = -EINVAL;
| ^~~~
net/xdp/xsk.c:490:7: warning: variable 'addr' set but not used [-Wunused-but-set-variable]
490 | u64 addr;
| ^~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
vim +497 net/xdp/xsk.c
476
477 static struct sk_buff *xsk_build_skb(struct xdp_sock *xs,
478 struct xdp_desc *desc, int *err)
479 {
480 struct sk_buff *skb;
481
482 if (xs->dev->features & NETIF_F_SKB_NO_LINEAR) {
483 skb = xsk_build_skb_zerocopy(xs, desc);
484 if (unlikely(!skb)) {
485 *err = -ENOMEM;
486 return NULL;
487 }
488 } else {
489 char *buffer;
490 u64 addr;
491 u32 len;
492 int err;
493
494 len = desc->len;
495 skb = sock_alloc_send_skb(&xs->sk, len, 1, &err);
496 if (unlikely(!skb)) {
> 497 *err = -ENOMEM;
498 return NULL;
499 }
500
501 skb_put(skb, len);
502 addr = desc->addr;
503 buffer = xsk_buff_raw_get_data(xs->pool, desc->addr);
504 err = skb_store_bits(skb, 0, buffer, len);
505
506 if (unlikely(err)) {
507 kfree_skb(skb);
508 *err = -EINVAL;
509 return NULL;
510 }
511 }
512
513 skb->dev = xs->dev;
514 skb->priority = xs->sk.sk_priority;
515 skb->mark = xs->sk.sk_mark;
516 skb_shinfo(skb)->destructor_arg = (void *)(long)desc->addr;
517 skb->destructor = xsk_destruct_skb;
518
519 return skb;
520 }
521
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 53952 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH bpf-next] xsk: build skb by page
Date: Sat, 16 Jan 2021 16:15:14 +0800 [thread overview]
Message-ID: <202101161615.rxZFpeqH-lkp@intel.com> (raw)
In-Reply-To: <579fa463bba42ac71591540a1811dca41d725350.1610764948.git.xuanzhuo@linux.alibaba.com>
[-- Attachment #1: Type: text/plain, Size: 3410 bytes --]
Hi Xuan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Xuan-Zhuo/xsk-build-skb-by-page/20210116-105116
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ee139d2988e5c5945108889a7c95c751910c1877
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Xuan-Zhuo/xsk-build-skb-by-page/20210116-105116
git checkout ee139d2988e5c5945108889a7c95c751910c1877
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
net/xdp/xsk.c: In function 'xsk_build_skb':
>> net/xdp/xsk.c:497:4: error: invalid type argument of unary '*' (have 'int')
497 | *err = -ENOMEM;
| ^~~~
net/xdp/xsk.c:508:4: error: invalid type argument of unary '*' (have 'int')
508 | *err = -EINVAL;
| ^~~~
net/xdp/xsk.c:490:7: warning: variable 'addr' set but not used [-Wunused-but-set-variable]
490 | u64 addr;
| ^~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
vim +497 net/xdp/xsk.c
476
477 static struct sk_buff *xsk_build_skb(struct xdp_sock *xs,
478 struct xdp_desc *desc, int *err)
479 {
480 struct sk_buff *skb;
481
482 if (xs->dev->features & NETIF_F_SKB_NO_LINEAR) {
483 skb = xsk_build_skb_zerocopy(xs, desc);
484 if (unlikely(!skb)) {
485 *err = -ENOMEM;
486 return NULL;
487 }
488 } else {
489 char *buffer;
490 u64 addr;
491 u32 len;
492 int err;
493
494 len = desc->len;
495 skb = sock_alloc_send_skb(&xs->sk, len, 1, &err);
496 if (unlikely(!skb)) {
> 497 *err = -ENOMEM;
498 return NULL;
499 }
500
501 skb_put(skb, len);
502 addr = desc->addr;
503 buffer = xsk_buff_raw_get_data(xs->pool, desc->addr);
504 err = skb_store_bits(skb, 0, buffer, len);
505
506 if (unlikely(err)) {
507 kfree_skb(skb);
508 *err = -EINVAL;
509 return NULL;
510 }
511 }
512
513 skb->dev = xs->dev;
514 skb->priority = xs->sk.sk_priority;
515 skb->mark = xs->sk.sk_mark;
516 skb_shinfo(skb)->destructor_arg = (void *)(long)desc->addr;
517 skb->destructor = xsk_destruct_skb;
518
519 return skb;
520 }
521
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 53952 bytes --]
next prev parent reply other threads:[~2021-01-16 8:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 2:44 [PATCH bpf-next] xsk: build skb by page Xuan Zhuo
2021-01-16 5:24 ` kernel test robot
2021-01-16 5:24 ` kernel test robot
2021-01-16 8:15 ` kernel test robot [this message]
2021-01-16 8:15 ` kernel test robot
2021-01-17 21:55 ` John Fastabend
2021-01-17 21:55 ` John Fastabend
2021-01-18 9:25 ` Magnus Karlsson
2021-01-18 11:57 ` Michael S. Tsirkin
2021-01-18 11:57 ` Michael S. Tsirkin
2021-01-18 12:37 ` Alexander Lobakin
2021-01-18 12:40 ` Yunsheng Lin
2021-01-18 13:00 ` Alexander Lobakin
2021-01-18 14:40 ` Alexander Lobakin
2021-01-18 15:03 ` Magnus Karlsson
2021-01-18 15:10 ` Magnus Karlsson
2021-01-18 16:38 ` Alexander Lobakin
2021-01-19 7:01 ` Magnus Karlsson
2021-01-19 12:44 ` Alexander Lobakin
-- strict thread matches above, loose matches on Subject: below --
2020-12-23 8:56 Xuan Zhuo
2020-12-23 10:04 ` Magnus Karlsson
2020-12-29 8:32 ` Xuan Zhuo
2020-12-31 16:29 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202101161615.rxZFpeqH-lkp@intel.com \
--to=lkp@intel.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=daniel@iogearbox.net \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=jonathan.lemon@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.