[Buildroot] [PATCH] package/mesa3d: select EXPAT for freedreno

[Buildroot] [PATCH] package/mesa3d: select EXPAT for freedreno

[Fabio Estevam]

Select expat when building the freedreno driver to fix the
following error:

Run-time dependency expat found: NO (tried pkgconfig and cmake)
Looking for a fallback subproject for the dependency expat
Downloading expat source from https://github.com/libexpat/libexpat/releases/download/R_2_2_5/expat-2.2.5.tar.bz2
<urlopen error unknown url type: https>
A fallback URL could be specified using source_fallback_url key in the wrap file

output/build/mesa3d-20.3.2/meson.build:1366:2: ERROR: could not get https://github.com/libexpat/libexpat/releases/download/R_2_2_5/expat-2.2.5.tar.bz2 is the internet available?

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 package/mesa3d/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index 45eb62b701a7..773fbfde220e 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -119,6 +119,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_FREEDRENO
 	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
 	select BR2_PACKAGE_LIBDRM_FREEDRENO
 	select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO
+	select BR2_PACKAGE_EXPAT
 	help
 	  Mesa driver for Freedreno GPUs.
 
-- 
2.25.1

[Buildroot] [PATCH] package/mesa3d: select EXPAT for freedreno

[Peter Seiderer]

Hello Fabio,

On Sat, 16 Jan 2021 13:09:48 -0300, Fabio Estevam <festevam@gmail.com> wrote:

> Select expat when building the freedreno driver to fix the
> following error:
>
> Run-time dependency expat found: NO (tried pkgconfig and cmake)
> Looking for a fallback subproject for the dependency expat
> Downloading expat source from https://github.com/libexpat/libexpat/releases/download/R_2_2_5/expat-2.2.5.tar.bz2
> <urlopen error unknown url type: https>
> A fallback URL could be specified using source_fallback_url key in the wrap file
>
> output/build/mesa3d-20.3.2/meson.build:1366:2: ERROR: could not get https://github.com/libexpat/libexpat/releases/download/R_2_2_5/expat-2.2.5.tar.bz2 is the internet available?
>

Not 100 percent sure (and did not yet test it), but I believe this not the
right fix...., suspect the need for expat was introduced in the mesa meson
build with mesa commit 81a0f1eca24b8605b9f2506122ff90db7129c39e ([1]):


  Subject: [PATCH] meson: Only require libexpat when a part of the build needs it.

  Now that xmlconfig can be built without libexpat on Android, we can make
  android builds not require the presence of libexpat for many drivers.

  @@ -1365,7 +1368,8 @@ if dep_thread.found() and host_machine.system() != 'windows'
     endif
   endif
   if host_machine.system() != 'windows'
  -  dep_expat = dependency('expat', fallback : ['expat', 'expat_dep'])
  +  dep_expat = dependency('expat', fallback : ['expat', 'expat_dep'],
  +                         required: not with_platform_android or with_any_broadcom or with_any_intel)
   else
     dep_expat = null_dep
   endif

Leading to an mandatory expat dependency in case 'not android'..., just not
matching the commit description..., the right required line would be:

	required: with_any_broadcom or with_any_intel)

Not your fault, but maybe worth to check it out (or ask upstream)?

Regards,
Peter

[1] https://github.com/mesa3d/mesa/commit/81a0f1eca24b8605b9f2506122ff90db7129c39e


> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  package/mesa3d/Config.in | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
> index 45eb62b701a7..773fbfde220e 100644
> --- a/package/mesa3d/Config.in
> +++ b/package/mesa3d/Config.in
> @@ -119,6 +119,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_FREEDRENO
>  	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
>  	select BR2_PACKAGE_LIBDRM_FREEDRENO
>  	select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO
> +	select BR2_PACKAGE_EXPAT
>  	help
>  	  Mesa driver for Freedreno GPUs.
>

[Buildroot] [PATCH] package/mesa3d: select EXPAT for freedreno

[Yann E. MORIN]

Fabio, All,

On 2021-01-16 13:09 -0300, Fabio Estevam spake thusly:
> Select expat when building the freedreno driver to fix the
> following error:
> 
> Run-time dependency expat found: NO (tried pkgconfig and cmake)
> Looking for a fallback subproject for the dependency expat
> Downloading expat source from https://github.com/libexpat/libexpat/releases/download/R_2_2_5/expat-2.2.5.tar.bz2
> <urlopen error unknown url type: https>
> A fallback URL could be specified using source_fallback_url key in the wrap file
> 
> output/build/mesa3d-20.3.2/meson.build:1366:2: ERROR: could not get https://github.com/libexpat/libexpat/releases/download/R_2_2_5/expat-2.2.5.tar.bz2 is the internet available?

Right when you sent this patch, we were discussing the exact same error
with Titouan, but about the virgl driver.

> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Applied to master, but with the following changes:

  - make it a generic fix, not tied to freedreno, reported by Fabio
  - rewrite commit log to explain the root cause
  - also reported about virgl, by Titouan

Please look at the new commit log I pushed for further details, and how
I eventually tweaked the file.

I'll try to push a fix upstream, so maybe next time we bump, we can
further relax the dependency by reverting the patch I applied.

Regards,
Yann E. MORIN.

> ---
>  package/mesa3d/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
> index 45eb62b701a7..773fbfde220e 100644
> --- a/package/mesa3d/Config.in
> +++ b/package/mesa3d/Config.in
> @@ -119,6 +119,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_FREEDRENO
>  	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
>  	select BR2_PACKAGE_LIBDRM_FREEDRENO
>  	select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO
> +	select BR2_PACKAGE_EXPAT
>  	help
>  	  Mesa driver for Freedreno GPUs.
>  
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] package/mesa3d: select EXPAT for freedreno

[Yann E. MORIN]

Peter, All,

On 2021-01-16 17:55 +0100, Peter Seiderer spake thusly:
> On Sat, 16 Jan 2021 13:09:48 -0300, Fabio Estevam <festevam@gmail.com> wrote:
> > Select expat when building the freedreno driver to fix the
> > following error:
> >
> > Run-time dependency expat found: NO (tried pkgconfig and cmake)
> > Looking for a fallback subproject for the dependency expat
> > Downloading expat source from https://github.com/libexpat/libexpat/releases/download/R_2_2_5/expat-2.2.5.tar.bz2
> > <urlopen error unknown url type: https>
> > A fallback URL could be specified using source_fallback_url key in the wrap file
> >
> > output/build/mesa3d-20.3.2/meson.build:1366:2: ERROR: could not get https://github.com/libexpat/libexpat/releases/download/R_2_2_5/expat-2.2.5.tar.bz2 is the internet available?
> >
> 
> Not 100 percent sure (and did not yet test it), but I believe this not the
> right fix...., suspect the need for expat was introduced in the mesa meson
> build with mesa commit 81a0f1eca24b8605b9f2506122ff90db7129c39e ([1]):

Yes, we've been discussing this on IRC with Titouan...

> Leading to an mandatory expat dependency in case 'not android'..., just not
> matching the commit description..., the right required line would be:
> 
> 	required: with_any_broadcom or with_any_intel)

This is the patch I am currently testing and was about to submit
upstream in a few minutes... Nice that someone else thinks it would be a
could fix. ;-)

> Not your fault, but maybe worth to check it out (or ask upstream)?

I'm taking care of that.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] package/mesa3d: select EXPAT for freedreno

[Yann E. MORIN]

Peter, All,

On 2021-01-16 18:27 +0100, Yann E. MORIN spake thusly:
> On 2021-01-16 17:55 +0100, Peter Seiderer spake thusly:
> > On Sat, 16 Jan 2021 13:09:48 -0300, Fabio Estevam <festevam@gmail.com> wrote:
> > > Select expat when building the freedreno driver to fix the
> > > following error:
[--SNIP--]
> > Not your fault, but maybe worth to check it out (or ask upstream)?
> I'm taking care of that.

MR opened:

    https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8536

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] package/mesa3d: select EXPAT for freedreno

[Fabio Estevam]

Hi Yann,

On Sat, Jan 16, 2021 at 2:25 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:

> Please look at the new commit log I pushed for further details, and how
> I eventually tweaked the file.
>
> I'll try to push a fix upstream, so maybe next time we bump, we can
> further relax the dependency by reverting the patch I applied.

Thanks for taking care of it. Appreciate it.

Cheers