All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/kodi-pvr-zattoo: fix json dependency
@ 2021-01-15 18:15 Bernd Kuhls
  2021-01-16 21:38 ` Thomas Petazzoni
  2021-01-18 21:26 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Bernd Kuhls @ 2021-01-15 18:15 UTC (permalink / raw)
  To: buildroot

Package depends on rapidjson, not rapidxml:
https://github.com/rbuehlma/pvr.zattoo/blob/Leia/CMakeLists.txt#L10

The bug was previously not noticed because kodi depends on rapidjson
https://github.com/xbmc/xbmc/blob/Leia/CMakeLists.txt#L133
and kodi-platform depends on kodi
https://github.com/xbmc/kodi-platform/blob/master/CMakeLists.txt#L8

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/kodi-pvr-zattoo/Config.in          | 2 +-
 package/kodi-pvr-zattoo/kodi-pvr-zattoo.mk | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/kodi-pvr-zattoo/Config.in b/package/kodi-pvr-zattoo/Config.in
index ab7ff70034..5dfadcadd1 100644
--- a/package/kodi-pvr-zattoo/Config.in
+++ b/package/kodi-pvr-zattoo/Config.in
@@ -2,7 +2,7 @@ config BR2_PACKAGE_KODI_PVR_ZATTOO
 	bool "kodi-pvr-zattoo"
 	select BR2_PACKAGE_KODI_PLATFORM
 	select BR2_PACKAGE_LIBPLATFORM
-	select BR2_PACKAGE_RAPIDXML
+	select BR2_PACKAGE_RAPIDJSON
 	select BR2_PACKAGE_TINYXML2
 	help
 	  Kodi PVR-Addon for Zattoo
diff --git a/package/kodi-pvr-zattoo/kodi-pvr-zattoo.mk b/package/kodi-pvr-zattoo/kodi-pvr-zattoo.mk
index 7afe92e87c..78fc01f195 100644
--- a/package/kodi-pvr-zattoo/kodi-pvr-zattoo.mk
+++ b/package/kodi-pvr-zattoo/kodi-pvr-zattoo.mk
@@ -8,6 +8,6 @@ KODI_PVR_ZATTOO_VERSION = 18.1.21-Leia
 KODI_PVR_ZATTOO_SITE = $(call github,rbuehlma,pvr.zattoo,$(KODI_PVR_ZATTOO_VERSION))
 KODI_PVR_ZATTOO_LICENSE = GPL-2.0+
 KODI_PVR_ZATTOO_LICENSE_FILES = debian/copyright
-KODI_PVR_ZATTOO_DEPENDENCIES = kodi-platform libplatform rapidxml tinyxml2
+KODI_PVR_ZATTOO_DEPENDENCIES = kodi-platform libplatform rapidjson tinyxml2
 
 $(eval $(cmake-package))
-- 
2.29.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/kodi-pvr-zattoo: fix json dependency
  2021-01-15 18:15 [Buildroot] [PATCH 1/1] package/kodi-pvr-zattoo: fix json dependency Bernd Kuhls
@ 2021-01-16 21:38 ` Thomas Petazzoni
  2021-01-18 21:26 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2021-01-16 21:38 UTC (permalink / raw)
  To: buildroot

On Fri, 15 Jan 2021 19:15:29 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> Package depends on rapidjson, not rapidxml:
> https://github.com/rbuehlma/pvr.zattoo/blob/Leia/CMakeLists.txt#L10
> 
> The bug was previously not noticed because kodi depends on rapidjson
> https://github.com/xbmc/xbmc/blob/Leia/CMakeLists.txt#L133
> and kodi-platform depends on kodi
> https://github.com/xbmc/kodi-platform/blob/master/CMakeLists.txt#L8
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/kodi-pvr-zattoo/Config.in          | 2 +-
>  package/kodi-pvr-zattoo/kodi-pvr-zattoo.mk | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/kodi-pvr-zattoo: fix json dependency
  2021-01-15 18:15 [Buildroot] [PATCH 1/1] package/kodi-pvr-zattoo: fix json dependency Bernd Kuhls
  2021-01-16 21:38 ` Thomas Petazzoni
@ 2021-01-18 21:26 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-01-18 21:26 UTC (permalink / raw)
  To: buildroot

>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:

 > Package depends on rapidjson, not rapidxml:
 > https://github.com/rbuehlma/pvr.zattoo/blob/Leia/CMakeLists.txt#L10

 > The bug was previously not noticed because kodi depends on rapidjson
 > https://github.com/xbmc/xbmc/blob/Leia/CMakeLists.txt#L133
 > and kodi-platform depends on kodi
 > https://github.com/xbmc/kodi-platform/blob/master/CMakeLists.txt#L8

 > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Committed to 2020.11.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-18 21:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 18:15 [Buildroot] [PATCH 1/1] package/kodi-pvr-zattoo: fix json dependency Bernd Kuhls
2021-01-16 21:38 ` Thomas Petazzoni
2021-01-18 21:26 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.