* [PATCH 0/6] further clean up Hisilicon-related errors detected by DT schema on arm64
@ 2021-01-18 3:16 ` Zhen Lei
0 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-01-18 3:16 UTC (permalink / raw)
To: Wei Xu, Rob Herring, devicetree, linux-arm-kernel; +Cc: Zhen Lei
I've solved all the errors that can be fixed this time. The rest will require
more time and energy to analyze in depth.
Zhen Lei (6):
arm64: dts: hisilicon: separate each group of data in the property
"ranges"
arm64: dts: hisilicon: place clock-names "bus" before "core"
arm64: dts: hisilicon: normalize the node name of the module thermal
arm64: dts: hisilicon: normalize the node name of the localbus
arm64: dts: hisilicon: avoid irrelevant nodes being mistakenly
identified as PHY nodes
arm64: dts: hisilicon: delete unused property smmu-cb-memtype
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 6 +++---
arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 8 ++++----
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 8 ++++----
arch/arm64/boot/dts/hisilicon/hip05.dtsi | 2 +-
arch/arm64/boot/dts/hisilicon/hip06.dtsi | 6 ++----
arch/arm64/boot/dts/hisilicon/hip07.dtsi | 9 ++-------
6 files changed, 16 insertions(+), 23 deletions(-)
--
1.8.3
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 0/6] further clean up Hisilicon-related errors detected by DT schema on arm64
@ 2021-01-18 3:16 ` Zhen Lei
0 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-01-18 3:16 UTC (permalink / raw)
To: Wei Xu, Rob Herring, devicetree, linux-arm-kernel; +Cc: Zhen Lei
I've solved all the errors that can be fixed this time. The rest will require
more time and energy to analyze in depth.
Zhen Lei (6):
arm64: dts: hisilicon: separate each group of data in the property
"ranges"
arm64: dts: hisilicon: place clock-names "bus" before "core"
arm64: dts: hisilicon: normalize the node name of the module thermal
arm64: dts: hisilicon: normalize the node name of the localbus
arm64: dts: hisilicon: avoid irrelevant nodes being mistakenly
identified as PHY nodes
arm64: dts: hisilicon: delete unused property smmu-cb-memtype
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 6 +++---
arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 8 ++++----
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 8 ++++----
arch/arm64/boot/dts/hisilicon/hip05.dtsi | 2 +-
arch/arm64/boot/dts/hisilicon/hip06.dtsi | 6 ++----
arch/arm64/boot/dts/hisilicon/hip07.dtsi | 9 ++-------
6 files changed, 16 insertions(+), 23 deletions(-)
--
1.8.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/6] arm64: dts: hisilicon: separate each group of data in the property "ranges"
2021-01-18 3:16 ` Zhen Lei
@ 2021-01-18 3:16 ` Zhen Lei
-1 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-01-18 3:16 UTC (permalink / raw)
To: Wei Xu, Rob Herring, devicetree, linux-arm-kernel; +Cc: Zhen Lei
Do not write the "ranges" of multiple groups of data into a uint32 array,
use <> to separate them. Otherwise, the errors similar to the following
will be reported:
soc: pcie@a0090000:ranges: [[33554432, 0, 2986344448, 0, 2986344448, 0, \
100597760, 16777216, 0, 0, 0, 3086942208, 0, 65536]] is not valid under \
any of the given schemas (Possible causes of the failure):
soc: pcie@a0090000:ranges: [[33554432, 0, 2986344448, 0, 2986344448, 0, \
100597760, 16777216, 0, 0, 0, 3086942208, 0, 65536]] is not of type 'boolean'
soc: pcie@a0090000:ranges:0: [33554432, 0, 2986344448, 0, 2986344448, 0, \
100597760, 16777216, 0, 0, 0, 3086942208, 0, 65536] is too long
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 4 ++--
arch/arm64/boot/dts/hisilicon/hip06.dtsi | 5 ++---
arch/arm64/boot/dts/hisilicon/hip07.dtsi | 4 ++--
3 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
index 81d09434c5c610d..16e11fde3ed9020 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
@@ -565,8 +565,8 @@
device_type = "pci";
bus-range = <0x00 0xff>;
num-lanes = <1>;
- ranges = <0x81000000 0x0 0x00000000 0x4f00000 0x0 0x100000
- 0x82000000 0x0 0x3000000 0x3000000 0x0 0x01f00000>;
+ ranges = <0x81000000 0x0 0x00000000 0x4f00000 0x0 0x100000>,
+ <0x82000000 0x0 0x3000000 0x3000000 0x0 0x01f00000>;
interrupts = <GIC_SPI 128 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "msi";
#interrupt-cells = <1>;
diff --git a/arch/arm64/boot/dts/hisilicon/hip06.dtsi b/arch/arm64/boot/dts/hisilicon/hip06.dtsi
index 7980709e21ff020..78050d67a78645b 100644
--- a/arch/arm64/boot/dts/hisilicon/hip06.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip06.dtsi
@@ -737,9 +737,8 @@
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- ranges = <0x02000000 0 0xb2000000 0x0 0xb2000000 0
- 0x5ff0000 0x01000000 0 0 0 0xb7ff0000
- 0 0x10000>;
+ ranges = <0x02000000 0 0xb2000000 0x0 0xb2000000 0 0x5ff0000>,
+ <0x01000000 0 0 0 0xb7ff0000 0 0x10000>;
#interrupt-cells = <1>;
interrupt-map-mask = <0xf800 0 0 7>;
interrupt-map = <0x0 0 0 1 &mbigen_pcie0 650 4
diff --git a/arch/arm64/boot/dts/hisilicon/hip07.dtsi b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
index 7832d9cdec21c93..f477f442c275561 100644
--- a/arch/arm64/boot/dts/hisilicon/hip07.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
@@ -1708,8 +1708,8 @@
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- ranges = <0x02000000 0 0xa8000000 0 0xa8000000 0 0x77f0000
- 0x01000000 0 0 0 0xaf7f0000 0 0x10000>;
+ ranges = <0x02000000 0 0xa8000000 0 0xa8000000 0 0x77f0000>,
+ <0x01000000 0 0 0 0xaf7f0000 0 0x10000>;
#interrupt-cells = <1>;
interrupt-map-mask = <0xf800 0 0 7>;
interrupt-map = <0x0 0 0 1 &mbigen_pcie2_a 671 4
--
1.8.3
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 1/6] arm64: dts: hisilicon: separate each group of data in the property "ranges"
@ 2021-01-18 3:16 ` Zhen Lei
0 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-01-18 3:16 UTC (permalink / raw)
To: Wei Xu, Rob Herring, devicetree, linux-arm-kernel; +Cc: Zhen Lei
Do not write the "ranges" of multiple groups of data into a uint32 array,
use <> to separate them. Otherwise, the errors similar to the following
will be reported:
soc: pcie@a0090000:ranges: [[33554432, 0, 2986344448, 0, 2986344448, 0, \
100597760, 16777216, 0, 0, 0, 3086942208, 0, 65536]] is not valid under \
any of the given schemas (Possible causes of the failure):
soc: pcie@a0090000:ranges: [[33554432, 0, 2986344448, 0, 2986344448, 0, \
100597760, 16777216, 0, 0, 0, 3086942208, 0, 65536]] is not of type 'boolean'
soc: pcie@a0090000:ranges:0: [33554432, 0, 2986344448, 0, 2986344448, 0, \
100597760, 16777216, 0, 0, 0, 3086942208, 0, 65536] is too long
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 4 ++--
arch/arm64/boot/dts/hisilicon/hip06.dtsi | 5 ++---
arch/arm64/boot/dts/hisilicon/hip07.dtsi | 4 ++--
3 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
index 81d09434c5c610d..16e11fde3ed9020 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
@@ -565,8 +565,8 @@
device_type = "pci";
bus-range = <0x00 0xff>;
num-lanes = <1>;
- ranges = <0x81000000 0x0 0x00000000 0x4f00000 0x0 0x100000
- 0x82000000 0x0 0x3000000 0x3000000 0x0 0x01f00000>;
+ ranges = <0x81000000 0x0 0x00000000 0x4f00000 0x0 0x100000>,
+ <0x82000000 0x0 0x3000000 0x3000000 0x0 0x01f00000>;
interrupts = <GIC_SPI 128 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "msi";
#interrupt-cells = <1>;
diff --git a/arch/arm64/boot/dts/hisilicon/hip06.dtsi b/arch/arm64/boot/dts/hisilicon/hip06.dtsi
index 7980709e21ff020..78050d67a78645b 100644
--- a/arch/arm64/boot/dts/hisilicon/hip06.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip06.dtsi
@@ -737,9 +737,8 @@
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- ranges = <0x02000000 0 0xb2000000 0x0 0xb2000000 0
- 0x5ff0000 0x01000000 0 0 0 0xb7ff0000
- 0 0x10000>;
+ ranges = <0x02000000 0 0xb2000000 0x0 0xb2000000 0 0x5ff0000>,
+ <0x01000000 0 0 0 0xb7ff0000 0 0x10000>;
#interrupt-cells = <1>;
interrupt-map-mask = <0xf800 0 0 7>;
interrupt-map = <0x0 0 0 1 &mbigen_pcie0 650 4
diff --git a/arch/arm64/boot/dts/hisilicon/hip07.dtsi b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
index 7832d9cdec21c93..f477f442c275561 100644
--- a/arch/arm64/boot/dts/hisilicon/hip07.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
@@ -1708,8 +1708,8 @@
#size-cells = <2>;
device_type = "pci";
dma-coherent;
- ranges = <0x02000000 0 0xa8000000 0 0xa8000000 0 0x77f0000
- 0x01000000 0 0 0 0xaf7f0000 0 0x10000>;
+ ranges = <0x02000000 0 0xa8000000 0 0xa8000000 0 0x77f0000>,
+ <0x01000000 0 0 0 0xaf7f0000 0 0x10000>;
#interrupt-cells = <1>;
interrupt-map-mask = <0xf800 0 0 7>;
interrupt-map = <0x0 0 0 1 &mbigen_pcie2_a 671 4
--
1.8.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/6] arm64: dts: hisilicon: place clock-names "bus" before "core"
2021-01-18 3:16 ` Zhen Lei
@ 2021-01-18 3:16 ` Zhen Lei
-1 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-01-18 3:16 UTC (permalink / raw)
To: Wei Xu, Rob Herring, devicetree, linux-arm-kernel; +Cc: Zhen Lei
Look at the clock-names schema defined in arm,mali-utgard.yaml:
clock-names:
items:
- const: bus
- const: core
The "bus" needs to be placed before the "core".
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index c6580c9f068ebf7..f9953303a3f44dc 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -1053,7 +1053,7 @@
"ppmmu3";
clocks = <&media_ctrl HI6220_G3D_CLK>,
<&media_ctrl HI6220_G3D_PCLK>;
- clock-names = "core", "bus";
+ clock-names = "bus", "core";
assigned-clocks = <&media_ctrl HI6220_G3D_CLK>,
<&media_ctrl HI6220_G3D_PCLK>;
assigned-clock-rates = <500000000>, <144000000>;
--
1.8.3
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/6] arm64: dts: hisilicon: place clock-names "bus" before "core"
@ 2021-01-18 3:16 ` Zhen Lei
0 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-01-18 3:16 UTC (permalink / raw)
To: Wei Xu, Rob Herring, devicetree, linux-arm-kernel; +Cc: Zhen Lei
Look at the clock-names schema defined in arm,mali-utgard.yaml:
clock-names:
items:
- const: bus
- const: core
The "bus" needs to be placed before the "core".
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index c6580c9f068ebf7..f9953303a3f44dc 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -1053,7 +1053,7 @@
"ppmmu3";
clocks = <&media_ctrl HI6220_G3D_CLK>,
<&media_ctrl HI6220_G3D_PCLK>;
- clock-names = "core", "bus";
+ clock-names = "bus", "core";
assigned-clocks = <&media_ctrl HI6220_G3D_CLK>,
<&media_ctrl HI6220_G3D_PCLK>;
assigned-clock-rates = <500000000>, <144000000>;
--
1.8.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 3/6] arm64: dts: hisilicon: normalize the node name of the module thermal
2021-01-18 3:16 ` Zhen Lei
@ 2021-01-18 3:16 ` Zhen Lei
-1 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-01-18 3:16 UTC (permalink / raw)
To: Wei Xu, Rob Herring, devicetree, linux-arm-kernel; +Cc: Zhen Lei
1. Change the node name of the thermal zone to match
'^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', add suffix "-thermal".
2. Change the node name of the trip point to match
'^[a-zA-Z][a-zA-Z0-9\\-_]{0,63}$', delete character "@".
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 6 +++---
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
index bfb1375426d2b58..8b8d3d07b67fe84 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
@@ -1113,7 +1113,7 @@
thermal-zones {
- cls0: cls0 {
+ cls0: cls0-thermal {
polling-delay = <1000>;
polling-delay-passive = <100>;
sustainable-power = <4500>;
@@ -1122,13 +1122,13 @@
thermal-sensors = <&tsensor 1>;
trips {
- threshold: trip-point@0 {
+ threshold: trip-point0 {
temperature = <65000>;
hysteresis = <1000>;
type = "passive";
};
- target: trip-point@1 {
+ target: trip-point1 {
temperature = <75000>;
hysteresis = <1000>;
type = "passive";
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index f9953303a3f44dc..d426c6c8722b307 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -872,7 +872,7 @@
thermal-zones {
- cls0: cls0 {
+ cls0: cls0-thermal {
polling-delay = <1000>;
polling-delay-passive = <100>;
sustainable-power = <3326>;
@@ -881,13 +881,13 @@
thermal-sensors = <&tsensor 2>;
trips {
- threshold: trip-point@0 {
+ threshold: trip-point0 {
temperature = <65000>;
hysteresis = <0>;
type = "passive";
};
- target: trip-point@1 {
+ target: trip-point1 {
temperature = <75000>;
hysteresis = <0>;
type = "passive";
--
1.8.3
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 3/6] arm64: dts: hisilicon: normalize the node name of the module thermal
@ 2021-01-18 3:16 ` Zhen Lei
0 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-01-18 3:16 UTC (permalink / raw)
To: Wei Xu, Rob Herring, devicetree, linux-arm-kernel; +Cc: Zhen Lei
1. Change the node name of the thermal zone to match
'^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', add suffix "-thermal".
2. Change the node name of the trip point to match
'^[a-zA-Z][a-zA-Z0-9\\-_]{0,63}$', delete character "@".
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 6 +++---
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
index bfb1375426d2b58..8b8d3d07b67fe84 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
@@ -1113,7 +1113,7 @@
thermal-zones {
- cls0: cls0 {
+ cls0: cls0-thermal {
polling-delay = <1000>;
polling-delay-passive = <100>;
sustainable-power = <4500>;
@@ -1122,13 +1122,13 @@
thermal-sensors = <&tsensor 1>;
trips {
- threshold: trip-point@0 {
+ threshold: trip-point0 {
temperature = <65000>;
hysteresis = <1000>;
type = "passive";
};
- target: trip-point@1 {
+ target: trip-point1 {
temperature = <75000>;
hysteresis = <1000>;
type = "passive";
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index f9953303a3f44dc..d426c6c8722b307 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -872,7 +872,7 @@
thermal-zones {
- cls0: cls0 {
+ cls0: cls0-thermal {
polling-delay = <1000>;
polling-delay-passive = <100>;
sustainable-power = <3326>;
@@ -881,13 +881,13 @@
thermal-sensors = <&tsensor 2>;
trips {
- threshold: trip-point@0 {
+ threshold: trip-point0 {
temperature = <65000>;
hysteresis = <0>;
type = "passive";
};
- target: trip-point@1 {
+ target: trip-point1 {
temperature = <75000>;
hysteresis = <0>;
type = "passive";
--
1.8.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 4/6] arm64: dts: hisilicon: normalize the node name of the localbus
2021-01-18 3:16 ` Zhen Lei
@ 2021-01-18 3:16 ` Zhen Lei
-1 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-01-18 3:16 UTC (permalink / raw)
To: Wei Xu, Rob Herring, devicetree, linux-arm-kernel; +Cc: Zhen Lei
Change the node name of the localbus to match
'^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'. This error
is detected by simple-bus.yaml.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hip05.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hip05.dtsi b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
index 405acaa3e9ddab7..4aed8d440b3aa5a 100644
--- a/arch/arm64/boot/dts/hisilicon/hip05.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
@@ -318,7 +318,7 @@
status = "disabled";
};
- lbc: localbus@80380000 {
+ lbc: local-bus@80380000 {
compatible = "hisilicon,hisi-localbus", "simple-bus";
reg = <0x0 0x80380000 0x0 0x10000>;
status = "disabled";
--
1.8.3
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 4/6] arm64: dts: hisilicon: normalize the node name of the localbus
@ 2021-01-18 3:16 ` Zhen Lei
0 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-01-18 3:16 UTC (permalink / raw)
To: Wei Xu, Rob Herring, devicetree, linux-arm-kernel; +Cc: Zhen Lei
Change the node name of the localbus to match
'^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'. This error
is detected by simple-bus.yaml.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hip05.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hip05.dtsi b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
index 405acaa3e9ddab7..4aed8d440b3aa5a 100644
--- a/arch/arm64/boot/dts/hisilicon/hip05.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
@@ -318,7 +318,7 @@
status = "disabled";
};
- lbc: localbus@80380000 {
+ lbc: local-bus@80380000 {
compatible = "hisilicon,hisi-localbus", "simple-bus";
reg = <0x0 0x80380000 0x0 0x10000>;
status = "disabled";
--
1.8.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 5/6] arm64: dts: hisilicon: avoid irrelevant nodes being mistakenly identified as PHY nodes
2021-01-18 3:16 ` Zhen Lei
@ 2021-01-18 3:16 ` Zhen Lei
-1 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-01-18 3:16 UTC (permalink / raw)
To: Wei Xu, Rob Herring, devicetree, linux-arm-kernel; +Cc: Zhen Lei
Currently, the names of several nodes incorrectly match common PHY
provider schema. And the phy-provider.yaml requires them must have
property "#phy-cells". As a result, false positives similar to the
following are reported:
usb2-phy@120: '#phy-cells' is a required property
Change their names slightly so that they do not match pattern:
"^(|usb-|usb2-|usb3-|pci-|pcie-|sata-)phy(@[0-9a-f,]+)*$".
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
index 16e11fde3ed9020..a83b9d4f172e350 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
@@ -113,7 +113,7 @@
#size-cells = <1>;
ranges = <0x0 0x8a20000 0x1000>;
- usb2_phy1: usb2-phy@120 {
+ usb2_phy1: usb2_phy@120 {
compatible = "hisilicon,hi3798cv200-usb2-phy";
reg = <0x120 0x4>;
clocks = <&crg HISTB_USB2_PHY1_REF_CLK>;
@@ -134,7 +134,7 @@
};
};
- usb2_phy2: usb2-phy@124 {
+ usb2_phy2: usb2_phy@124 {
compatible = "hisilicon,hi3798cv200-usb2-phy";
reg = <0x124 0x4>;
clocks = <&crg HISTB_USB2_PHY2_REF_CLK>;
--
1.8.3
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 5/6] arm64: dts: hisilicon: avoid irrelevant nodes being mistakenly identified as PHY nodes
@ 2021-01-18 3:16 ` Zhen Lei
0 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-01-18 3:16 UTC (permalink / raw)
To: Wei Xu, Rob Herring, devicetree, linux-arm-kernel; +Cc: Zhen Lei
Currently, the names of several nodes incorrectly match common PHY
provider schema. And the phy-provider.yaml requires them must have
property "#phy-cells". As a result, false positives similar to the
following are reported:
usb2-phy@120: '#phy-cells' is a required property
Change their names slightly so that they do not match pattern:
"^(|usb-|usb2-|usb3-|pci-|pcie-|sata-)phy(@[0-9a-f,]+)*$".
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
index 16e11fde3ed9020..a83b9d4f172e350 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
@@ -113,7 +113,7 @@
#size-cells = <1>;
ranges = <0x0 0x8a20000 0x1000>;
- usb2_phy1: usb2-phy@120 {
+ usb2_phy1: usb2_phy@120 {
compatible = "hisilicon,hi3798cv200-usb2-phy";
reg = <0x120 0x4>;
clocks = <&crg HISTB_USB2_PHY1_REF_CLK>;
@@ -134,7 +134,7 @@
};
};
- usb2_phy2: usb2-phy@124 {
+ usb2_phy2: usb2_phy@124 {
compatible = "hisilicon,hi3798cv200-usb2-phy";
reg = <0x124 0x4>;
clocks = <&crg HISTB_USB2_PHY2_REF_CLK>;
--
1.8.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 6/6] arm64: dts: hisilicon: delete unused property smmu-cb-memtype
2021-01-18 3:16 ` Zhen Lei
@ 2021-01-18 3:16 ` Zhen Lei
-1 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-01-18 3:16 UTC (permalink / raw)
To: Wei Xu, Rob Herring, devicetree, linux-arm-kernel; +Cc: Zhen Lei
The "smmu-cb-memtype" is a private property developed by the Hisilicon
driver in the early stage and is not used now. So delete it.
Otherwise, below YAML check warnings are reported:
arch/arm64/boot/dts/hisilicon/hip06-d03.dt.yaml: iommu@a0040000: \
'smmu-cb-memtype' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/hisilicon/hip07-d05.dt.yaml: iommu@a0040000: \
'smmu-cb-memtype' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hip06.dtsi | 1 -
arch/arm64/boot/dts/hisilicon/hip07.dtsi | 5 -----
2 files changed, 6 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hip06.dtsi b/arch/arm64/boot/dts/hisilicon/hip06.dtsi
index 78050d67a78645b..7deca5f763d5037 100644
--- a/arch/arm64/boot/dts/hisilicon/hip06.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip06.dtsi
@@ -335,7 +335,6 @@
reg = <0x0 0xa0040000 0x0 0x20000>;
#iommu-cells = <1>;
dma-coherent;
- smmu-cb-memtype = <0x0 0x1>;
hisilicon,broken-prefetch-cmd;
status = "disabled";
};
diff --git a/arch/arm64/boot/dts/hisilicon/hip07.dtsi b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
index f477f442c275561..2172d807118143c 100644
--- a/arch/arm64/boot/dts/hisilicon/hip07.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
@@ -1166,7 +1166,6 @@
reg = <0x0 0xa0040000 0x0 0x20000>;
#iommu-cells = <1>;
dma-coherent;
- smmu-cb-memtype = <0x0 0x1>;
hisilicon,broken-prefetch-cmd;
status = "disabled";
};
@@ -1181,7 +1180,6 @@
#iommu-cells = <1>;
dma-coherent;
hisilicon,broken-prefetch-cmd;
- /* smmu-cb-memtype = <0x0 0x1>;*/
};
p0_smmu_alg_b: iommu@8d0040000 {
compatible = "arm,smmu-v3";
@@ -1194,7 +1192,6 @@
#iommu-cells = <1>;
dma-coherent;
hisilicon,broken-prefetch-cmd;
- /* smmu-cb-memtype = <0x0 0x1>;*/
};
p1_smmu_alg_a: iommu@400d0040000 {
compatible = "arm,smmu-v3";
@@ -1207,7 +1204,6 @@
#iommu-cells = <1>;
dma-coherent;
hisilicon,broken-prefetch-cmd;
- /* smmu-cb-memtype = <0x0 0x1>;*/
};
p1_smmu_alg_b: iommu@408d0040000 {
compatible = "arm,smmu-v3";
@@ -1220,7 +1216,6 @@
#iommu-cells = <1>;
dma-coherent;
hisilicon,broken-prefetch-cmd;
- /* smmu-cb-memtype = <0x0 0x1>;*/
};
soc {
--
1.8.3
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 6/6] arm64: dts: hisilicon: delete unused property smmu-cb-memtype
@ 2021-01-18 3:16 ` Zhen Lei
0 siblings, 0 replies; 16+ messages in thread
From: Zhen Lei @ 2021-01-18 3:16 UTC (permalink / raw)
To: Wei Xu, Rob Herring, devicetree, linux-arm-kernel; +Cc: Zhen Lei
The "smmu-cb-memtype" is a private property developed by the Hisilicon
driver in the early stage and is not used now. So delete it.
Otherwise, below YAML check warnings are reported:
arch/arm64/boot/dts/hisilicon/hip06-d03.dt.yaml: iommu@a0040000: \
'smmu-cb-memtype' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/hisilicon/hip07-d05.dt.yaml: iommu@a0040000: \
'smmu-cb-memtype' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
arch/arm64/boot/dts/hisilicon/hip06.dtsi | 1 -
arch/arm64/boot/dts/hisilicon/hip07.dtsi | 5 -----
2 files changed, 6 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hip06.dtsi b/arch/arm64/boot/dts/hisilicon/hip06.dtsi
index 78050d67a78645b..7deca5f763d5037 100644
--- a/arch/arm64/boot/dts/hisilicon/hip06.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip06.dtsi
@@ -335,7 +335,6 @@
reg = <0x0 0xa0040000 0x0 0x20000>;
#iommu-cells = <1>;
dma-coherent;
- smmu-cb-memtype = <0x0 0x1>;
hisilicon,broken-prefetch-cmd;
status = "disabled";
};
diff --git a/arch/arm64/boot/dts/hisilicon/hip07.dtsi b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
index f477f442c275561..2172d807118143c 100644
--- a/arch/arm64/boot/dts/hisilicon/hip07.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
@@ -1166,7 +1166,6 @@
reg = <0x0 0xa0040000 0x0 0x20000>;
#iommu-cells = <1>;
dma-coherent;
- smmu-cb-memtype = <0x0 0x1>;
hisilicon,broken-prefetch-cmd;
status = "disabled";
};
@@ -1181,7 +1180,6 @@
#iommu-cells = <1>;
dma-coherent;
hisilicon,broken-prefetch-cmd;
- /* smmu-cb-memtype = <0x0 0x1>;*/
};
p0_smmu_alg_b: iommu@8d0040000 {
compatible = "arm,smmu-v3";
@@ -1194,7 +1192,6 @@
#iommu-cells = <1>;
dma-coherent;
hisilicon,broken-prefetch-cmd;
- /* smmu-cb-memtype = <0x0 0x1>;*/
};
p1_smmu_alg_a: iommu@400d0040000 {
compatible = "arm,smmu-v3";
@@ -1207,7 +1204,6 @@
#iommu-cells = <1>;
dma-coherent;
hisilicon,broken-prefetch-cmd;
- /* smmu-cb-memtype = <0x0 0x1>;*/
};
p1_smmu_alg_b: iommu@408d0040000 {
compatible = "arm,smmu-v3";
@@ -1220,7 +1216,6 @@
#iommu-cells = <1>;
dma-coherent;
hisilicon,broken-prefetch-cmd;
- /* smmu-cb-memtype = <0x0 0x1>;*/
};
soc {
--
1.8.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 0/6] further clean up Hisilicon-related errors detected by DT schema on arm64
2021-01-18 3:16 ` Zhen Lei
@ 2021-01-26 8:56 ` Wei Xu
-1 siblings, 0 replies; 16+ messages in thread
From: Wei Xu @ 2021-01-26 8:56 UTC (permalink / raw)
To: Zhen Lei, Rob Herring, devicetree, linux-arm-kernel
Hi Zhen Lei,
On 2021/1/18 11:16, Zhen Lei wrote:
> I've solved all the errors that can be fixed this time. The rest will require
> more time and energy to analyze in depth.
>
> Zhen Lei (6):
> arm64: dts: hisilicon: separate each group of data in the property
> "ranges"
> arm64: dts: hisilicon: place clock-names "bus" before "core"
> arm64: dts: hisilicon: normalize the node name of the module thermal
> arm64: dts: hisilicon: normalize the node name of the localbus
> arm64: dts: hisilicon: avoid irrelevant nodes being mistakenly
> identified as PHY nodes
> arm64: dts: hisilicon: delete unused property smmu-cb-memtype
>
> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 6 +++---
> arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 8 ++++----
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 8 ++++----
> arch/arm64/boot/dts/hisilicon/hip05.dtsi | 2 +-
> arch/arm64/boot/dts/hisilicon/hip06.dtsi | 6 ++----
> arch/arm64/boot/dts/hisilicon/hip07.dtsi | 9 ++-------
> 6 files changed, 16 insertions(+), 23 deletions(-)
>
Thanks!
Series applied to the hisilicon arm64 dt tree.
Best Regards,
Wei
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/6] further clean up Hisilicon-related errors detected by DT schema on arm64
@ 2021-01-26 8:56 ` Wei Xu
0 siblings, 0 replies; 16+ messages in thread
From: Wei Xu @ 2021-01-26 8:56 UTC (permalink / raw)
To: Zhen Lei, Rob Herring, devicetree, linux-arm-kernel
Hi Zhen Lei,
On 2021/1/18 11:16, Zhen Lei wrote:
> I've solved all the errors that can be fixed this time. The rest will require
> more time and energy to analyze in depth.
>
> Zhen Lei (6):
> arm64: dts: hisilicon: separate each group of data in the property
> "ranges"
> arm64: dts: hisilicon: place clock-names "bus" before "core"
> arm64: dts: hisilicon: normalize the node name of the module thermal
> arm64: dts: hisilicon: normalize the node name of the localbus
> arm64: dts: hisilicon: avoid irrelevant nodes being mistakenly
> identified as PHY nodes
> arm64: dts: hisilicon: delete unused property smmu-cb-memtype
>
> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 6 +++---
> arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 8 ++++----
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 8 ++++----
> arch/arm64/boot/dts/hisilicon/hip05.dtsi | 2 +-
> arch/arm64/boot/dts/hisilicon/hip06.dtsi | 6 ++----
> arch/arm64/boot/dts/hisilicon/hip07.dtsi | 9 ++-------
> 6 files changed, 16 insertions(+), 23 deletions(-)
>
Thanks!
Series applied to the hisilicon arm64 dt tree.
Best Regards,
Wei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2021-01-26 17:09 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18 3:16 [PATCH 0/6] further clean up Hisilicon-related errors detected by DT schema on arm64 Zhen Lei
2021-01-18 3:16 ` Zhen Lei
2021-01-18 3:16 ` [PATCH 1/6] arm64: dts: hisilicon: separate each group of data in the property "ranges" Zhen Lei
2021-01-18 3:16 ` Zhen Lei
2021-01-18 3:16 ` [PATCH 2/6] arm64: dts: hisilicon: place clock-names "bus" before "core" Zhen Lei
2021-01-18 3:16 ` Zhen Lei
2021-01-18 3:16 ` [PATCH 3/6] arm64: dts: hisilicon: normalize the node name of the module thermal Zhen Lei
2021-01-18 3:16 ` Zhen Lei
2021-01-18 3:16 ` [PATCH 4/6] arm64: dts: hisilicon: normalize the node name of the localbus Zhen Lei
2021-01-18 3:16 ` Zhen Lei
2021-01-18 3:16 ` [PATCH 5/6] arm64: dts: hisilicon: avoid irrelevant nodes being mistakenly identified as PHY nodes Zhen Lei
2021-01-18 3:16 ` Zhen Lei
2021-01-18 3:16 ` [PATCH 6/6] arm64: dts: hisilicon: delete unused property smmu-cb-memtype Zhen Lei
2021-01-18 3:16 ` Zhen Lei
2021-01-26 8:56 ` [PATCH 0/6] further clean up Hisilicon-related errors detected by DT schema on arm64 Wei Xu
2021-01-26 8:56 ` Wei Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.