* [PATCH 1/2] allow PrivateKey and PresharedKey to be files too
[not found] <20210118100802.8568-1-mjt@tls.msk.ru>
@ 2021-01-18 10:08 ` Michael Tokarev
2021-01-18 10:08 ` [PATCH 2/2] recognize and ignore commands used by wg-quick Michael Tokarev
1 sibling, 0 replies; 2+ messages in thread
From: Michael Tokarev @ 2021-01-18 10:08 UTC (permalink / raw)
To: wireguard; +Cc: Michael Tokarev
In the config file, allow specifying PrivateKey and PresharedKey as files,
not only directly. This way the config file can be made readable since
the only security-sensitive part there is the keys which can now be
stored separately.
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
src/config.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/src/config.c b/src/config.c
index e0b4b7c..b4280e5 100644
--- a/src/config.c
+++ b/src/config.c
@@ -157,6 +157,16 @@ out:
return ret;
}
+static inline bool parse_key_or_file(uint8_t key[static WG_KEY_LEN], const char *value)
+{
+ if (value[0] == '/' && (strlen(value) != WG_KEY_LEN_BASE64 - 1 || value[WG_KEY_LEN_BASE64 - 2] != '=')) {
+ return parse_keyfile(key, value);
+ }
+ else {
+ return parse_key(key, value);
+ }
+}
+
static inline bool parse_ip(struct wgallowedip *allowedip, const char *value)
{
allowedip->family = AF_UNSPEC;
@@ -447,7 +457,7 @@ static bool process_line(struct config_ctx *ctx, const char *line)
else if (key_match("FwMark"))
ret = parse_fwmark(&ctx->device->fwmark, &ctx->device->flags, value);
else if (key_match("PrivateKey")) {
- ret = parse_key(ctx->device->private_key, value);
+ ret = parse_key_or_file(ctx->device->private_key, value);
if (ret)
ctx->device->flags |= WGDEVICE_HAS_PRIVATE_KEY;
} else
@@ -464,7 +474,7 @@ static bool process_line(struct config_ctx *ctx, const char *line)
else if (key_match("PersistentKeepalive"))
ret = parse_persistent_keepalive(&ctx->last_peer->persistent_keepalive_interval, &ctx->last_peer->flags, value);
else if (key_match("PresharedKey")) {
- ret = parse_key(ctx->last_peer->preshared_key, value);
+ ret = parse_key_or_file(ctx->last_peer->preshared_key, value);
if (ret)
ctx->last_peer->flags |= WGPEER_HAS_PRESHARED_KEY;
} else
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] recognize and ignore commands used by wg-quick
[not found] <20210118100802.8568-1-mjt@tls.msk.ru>
2021-01-18 10:08 ` [PATCH 1/2] allow PrivateKey and PresharedKey to be files too Michael Tokarev
@ 2021-01-18 10:08 ` Michael Tokarev
1 sibling, 0 replies; 2+ messages in thread
From: Michael Tokarev @ 2021-01-18 10:08 UTC (permalink / raw)
To: wireguard; +Cc: Michael Tokarev
When reading the config file, recognize and ignore commands in the [Interface] section
which are used by wg-qukck. This way wg-quick config file can be read by wg too directly
so there's no need to filter it out by wg-quick and it's easy to reload configuration too.
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
src/config.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/config.c b/src/config.c
index b4280e5..0095556 100644
--- a/src/config.c
+++ b/src/config.c
@@ -460,6 +460,10 @@ static bool process_line(struct config_ctx *ctx, const char *line)
ret = parse_key_or_file(ctx->device->private_key, value);
if (ret)
ctx->device->flags |= WGDEVICE_HAS_PRIVATE_KEY;
+ } else if (key_match("Address") || key_match("DNS") || key_match("MTU") || key_match("Table") ||
+ key_match("PreUp") || key_match("PostUp") || key_match("PreDown") || key_match("PostDown") ||
+ key_match("SaveConfig")) {
+ /* ignore commands used by wg-quick */
} else
goto error;
} else if (ctx->is_peer_section) {
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-21 13:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210118100802.8568-1-mjt@tls.msk.ru>
2021-01-18 10:08 ` [PATCH 1/2] allow PrivateKey and PresharedKey to be files too Michael Tokarev
2021-01-18 10:08 ` [PATCH 2/2] recognize and ignore commands used by wg-quick Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.