From: Will Deacon <will@kernel.org>
To: Adrian Huang <adrianhuang0701@gmail.com>
Cc: Adrian Huang <ahuang12@lenovo.com>, iommu@lists.linux-foundation.org
Subject: Re: [RESEND PATCH 1/1] iommu/amd: Remove unnecessary assignment
Date: Mon, 18 Jan 2021 11:25:08 +0000 [thread overview]
Message-ID: <20210118112508.GB16500@willie-the-truck> (raw)
In-Reply-To: <20201210021330.2022-1-adrianhuang0701@gmail.com>
On Thu, Dec 10, 2020 at 10:13:30AM +0800, Adrian Huang wrote:
> From: Adrian Huang <ahuang12@lenovo.com>
>
> From: Adrian Huang <ahuang12@lenovo.com>
>
> The values of local variables are assigned after local variables
> are declared, so no need to assign the initial value during the
> variable declaration.
>
> And, no need to assign NULL for the local variable 'ivrs_base'
> after invoking acpi_put_table().
>
> Signed-off-by: Adrian Huang <ahuang12@lenovo.com>
> ---
> drivers/iommu/amd/init.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Acked-by: Will Deacon <will@kernel.org>
Will
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-01-18 11:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 2:13 [RESEND PATCH 1/1] iommu/amd: Remove unnecessary assignment Adrian Huang
2021-01-18 11:25 ` Will Deacon [this message]
2021-01-27 11:31 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118112508.GB16500@willie-the-truck \
--to=will@kernel.org \
--cc=adrianhuang0701@gmail.com \
--cc=ahuang12@lenovo.com \
--cc=iommu@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.