* [RESEND PATCH] net: core: devlink: use right genl user_ptr when handling port param get/set
@ 2021-01-18 17:39 Vadym Kochan
2021-01-18 21:48 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Vadym Kochan @ 2021-01-18 17:39 UTC (permalink / raw)
To: Jiri Pirko, David S. Miller, Jakub Kicinski, netdev
Cc: Oleksandr Mazur, Vadym Kochan
From: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Fix incorrect user_ptr dereferencing when handling port param get/set:
idx [0] stores the 'struct devlink' pointer;
idx [1] stores the 'struct devlink_port' pointer;
Fixes: f4601dee25d5 ("devlink: Add port param get command")
Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
---
1) Fixed plvision.com -> plvision.eu
net/core/devlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index ee828e4b1007..738d4344d679 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -4146,7 +4146,7 @@ static int devlink_nl_cmd_port_param_get_dumpit(struct sk_buff *msg,
static int devlink_nl_cmd_port_param_get_doit(struct sk_buff *skb,
struct genl_info *info)
{
- struct devlink_port *devlink_port = info->user_ptr[0];
+ struct devlink_port *devlink_port = info->user_ptr[1];
struct devlink_param_item *param_item;
struct sk_buff *msg;
int err;
@@ -4175,7 +4175,7 @@ static int devlink_nl_cmd_port_param_get_doit(struct sk_buff *skb,
static int devlink_nl_cmd_port_param_set_doit(struct sk_buff *skb,
struct genl_info *info)
{
- struct devlink_port *devlink_port = info->user_ptr[0];
+ struct devlink_port *devlink_port = info->user_ptr[1];
return __devlink_nl_cmd_param_set_doit(devlink_port->devlink,
devlink_port->index,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH] net: core: devlink: use right genl user_ptr when handling port param get/set
2021-01-18 17:39 [RESEND PATCH] net: core: devlink: use right genl user_ptr when handling port param get/set Vadym Kochan
@ 2021-01-18 21:48 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2021-01-18 21:48 UTC (permalink / raw)
To: Vadym Kochan; +Cc: Jiri Pirko, David S. Miller, netdev, Oleksandr Mazur
On Mon, 18 Jan 2021 19:39:54 +0200 Vadym Kochan wrote:
> From: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
>
> Fix incorrect user_ptr dereferencing when handling port param get/set:
>
> idx [0] stores the 'struct devlink' pointer;
> idx [1] stores the 'struct devlink_port' pointer;
>
> Fixes: f4601dee25d5 ("devlink: Add port param get command")
> Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
> Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
> ---
> 1) Fixed plvision.com -> plvision.eu
LGTM, but the fixes tag is wrong:
Fixes: 637989b5d77e ("devlink: Always use user_ptr[0] for devlink and simplify post_doit")
right?
> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index ee828e4b1007..738d4344d679 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -4146,7 +4146,7 @@ static int devlink_nl_cmd_port_param_get_dumpit(struct sk_buff *msg,
> static int devlink_nl_cmd_port_param_get_doit(struct sk_buff *skb,
> struct genl_info *info)
> {
> - struct devlink_port *devlink_port = info->user_ptr[0];
> + struct devlink_port *devlink_port = info->user_ptr[1];
> struct devlink_param_item *param_item;
> struct sk_buff *msg;
> int err;
> @@ -4175,7 +4175,7 @@ static int devlink_nl_cmd_port_param_get_doit(struct sk_buff *skb,
> static int devlink_nl_cmd_port_param_set_doit(struct sk_buff *skb,
> struct genl_info *info)
> {
> - struct devlink_port *devlink_port = info->user_ptr[0];
> + struct devlink_port *devlink_port = info->user_ptr[1];
>
> return __devlink_nl_cmd_param_set_doit(devlink_port->devlink,
> devlink_port->index,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-18 21:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18 17:39 [RESEND PATCH] net: core: devlink: use right genl user_ptr when handling port param get/set Vadym Kochan
2021-01-18 21:48 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.