From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: kernel test robot <lkp@intel.com>, daire.mcnamara@microchip.com
Cc: bhelgaas@google.com, robh@kernel.org, linux-pci@vger.kernel.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
kbuild-all@lists.01.org, david.abdurachmanov@gmail.com,
cyril.jean@microchip.com, ben.dooks@codethink.co.uk
Subject: Re: [PATCH v19 3/4] PCI: microchip: Add host driver for Microchip PCIe controller
Date: Mon, 18 Jan 2021 16:45:17 +0000 [thread overview]
Message-ID: <20210118164517.GB16417@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <202012291014.UP1fULPL-lkp@intel.com>
On Tue, Dec 29, 2020 at 10:21:23AM +0800, kernel test robot wrote:
> Hi,
>
> Thank you for the patch! Perhaps something to improve:
Can you fix it up promptly and resend please ?
Thanks,
Lorenzo
> [auto build test WARNING on 3650b228f83adda7e5ee532e2b90429c03f7b9ec]
>
> url: https://github.com/0day-ci/linux/commits/daire-mcnamara-microchip-com/PCI-microchip-Add-host-driver-for-Microchip-PCIe-controller/20201224-174858
> base: 3650b228f83adda7e5ee532e2b90429c03f7b9ec
> config: mips-allyesconfig (attached as .config)
> compiler: mips-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/05ba26bb79a9904585ed68019beec93a5258b0f3
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review daire-mcnamara-microchip-com/PCI-microchip-Add-host-driver-for-Microchip-PCIe-controller/20201224-174858
> git checkout 05ba26bb79a9904585ed68019beec93a5258b0f3
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> drivers/pci/controller/pcie-microchip-host.c: In function 'mc_msi_bottom_irq_ack':
> >> drivers/pci/controller/pcie-microchip-host.c:436:17: warning: variable 'msi' set but not used [-Wunused-but-set-variable]
> 436 | struct mc_msi *msi;
> | ^~~
>
>
> vim +/msi +436 drivers/pci/controller/pcie-microchip-host.c
>
> 431
> 432 static void mc_msi_bottom_irq_ack(struct irq_data *data)
> 433 {
> 434 struct mc_port *port = irq_data_get_irq_chip_data(data);
> 435 void __iomem *bridge_base_addr;
> > 436 struct mc_msi *msi;
> 437 u32 bitpos = data->hwirq;
> 438 unsigned long status;
> 439
> 440 bridge_base_addr = port->axi_base_addr + MC_PCIE_BRIDGE_ADDR;
> 441 msi = &port->msi;
> 442
> 443 writel_relaxed(BIT(bitpos), bridge_base_addr + ISTATUS_MSI);
> 444 status = readl_relaxed(bridge_base_addr + ISTATUS_MSI);
> 445 if (!status)
> 446 writel_relaxed(BIT(PM_MSI_INT_MSI_SHIFT), bridge_base_addr + ISTATUS_LOCAL);
> 447 }
> 448
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v19 3/4] PCI: microchip: Add host driver for Microchip PCIe controller
Date: Mon, 18 Jan 2021 16:45:17 +0000 [thread overview]
Message-ID: <20210118164517.GB16417@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <202012291014.UP1fULPL-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2655 bytes --]
On Tue, Dec 29, 2020 at 10:21:23AM +0800, kernel test robot wrote:
> Hi,
>
> Thank you for the patch! Perhaps something to improve:
Can you fix it up promptly and resend please ?
Thanks,
Lorenzo
> [auto build test WARNING on 3650b228f83adda7e5ee532e2b90429c03f7b9ec]
>
> url: https://github.com/0day-ci/linux/commits/daire-mcnamara-microchip-com/PCI-microchip-Add-host-driver-for-Microchip-PCIe-controller/20201224-174858
> base: 3650b228f83adda7e5ee532e2b90429c03f7b9ec
> config: mips-allyesconfig (attached as .config)
> compiler: mips-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/05ba26bb79a9904585ed68019beec93a5258b0f3
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review daire-mcnamara-microchip-com/PCI-microchip-Add-host-driver-for-Microchip-PCIe-controller/20201224-174858
> git checkout 05ba26bb79a9904585ed68019beec93a5258b0f3
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> drivers/pci/controller/pcie-microchip-host.c: In function 'mc_msi_bottom_irq_ack':
> >> drivers/pci/controller/pcie-microchip-host.c:436:17: warning: variable 'msi' set but not used [-Wunused-but-set-variable]
> 436 | struct mc_msi *msi;
> | ^~~
>
>
> vim +/msi +436 drivers/pci/controller/pcie-microchip-host.c
>
> 431
> 432 static void mc_msi_bottom_irq_ack(struct irq_data *data)
> 433 {
> 434 struct mc_port *port = irq_data_get_irq_chip_data(data);
> 435 void __iomem *bridge_base_addr;
> > 436 struct mc_msi *msi;
> 437 u32 bitpos = data->hwirq;
> 438 unsigned long status;
> 439
> 440 bridge_base_addr = port->axi_base_addr + MC_PCIE_BRIDGE_ADDR;
> 441 msi = &port->msi;
> 442
> 443 writel_relaxed(BIT(bitpos), bridge_base_addr + ISTATUS_MSI);
> 444 status = readl_relaxed(bridge_base_addr + ISTATUS_MSI);
> 445 if (!status)
> 446 writel_relaxed(BIT(PM_MSI_INT_MSI_SHIFT), bridge_base_addr + ISTATUS_LOCAL);
> 447 }
> 448
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-01-18 16:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 9:44 [PATCH v19 0/4] PCI: microchip: Add host driver for Microchip PCIe controller daire.mcnamara
2020-12-24 9:44 ` [PATCH v19 1/4] PCI: Call platform_set_drvdata earlier in devm_pci_alloc_host_bridge daire.mcnamara
2020-12-24 9:44 ` [PATCH v19 2/4] dt-bindings: PCI: microchip: Add Microchip PolarFire host binding daire.mcnamara
2020-12-26 17:04 ` Aurelien Jarno
2020-12-24 9:44 ` [PATCH v19 3/4] PCI: microchip: Add host driver for Microchip PCIe controller daire.mcnamara
2020-12-29 2:21 ` kernel test robot
2020-12-29 2:21 ` kernel test robot
2021-01-18 16:45 ` Lorenzo Pieralisi [this message]
2021-01-18 16:45 ` Lorenzo Pieralisi
2021-01-18 16:43 ` Lorenzo Pieralisi
2020-12-24 9:45 ` [PATCH v19 4/4] MAINTAINERS: Add Daire McNamara as maintainer for the Microchip PCIe driver daire.mcnamara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118164517.GB16417@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=ben.dooks@codethink.co.uk \
--cc=bhelgaas@google.com \
--cc=cyril.jean@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=david.abdurachmanov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.