From: Viresh Kumar <viresh.kumar@linaro.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Ionela Voinescu <ionela.voinescu@arm.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Andy Gross <agross@kernel.org>,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] cpufreq: qcom-hw: add missing devm_release_mem_region() call
Date: Tue, 19 Jan 2021 09:06:12 +0530 [thread overview]
Message-ID: <20210119033612.2inqiq77dioqisq6@vireshk-i7> (raw)
In-Reply-To: <20210118121710.GD2479@dragon>
On 18-01-21, 20:17, Shawn Guo wrote:
> On Wed, Jan 13, 2021 at 10:36:51AM +0530, Viresh Kumar wrote:
> > On 12-01-21, 22:59, Bjorn Andersson wrote:
> > > But that said, why are the ioremap done at init and not at probe time?
> >
> > These are some hardware registers per cpufreq policy I believe, and so
> > they did it from policy init instead.
> >
> > And yes I agree that we shouldn't use devm_ from init() for the cases
> > where we need to put the resources in exit() as well. But things like
> > devm_kzalloc() are fine there.
>
> I'm not sure why devm_kzalloc() is fine there. IIUIC, the memory
> allocated by devm_kzalloc() in init() is not freed up from exit(), as
> &pdev->dev is alive across init/exit cycles and will not trigger devres
> auto free-up.
Yes, but reallocating it again if ->init() get called again isn't a bug and will
only block a part of memory for sometime, i.e. until the time driver isn't
removed.
Though it is better I think to get rid of it as well.
--
viresh
prev parent reply other threads:[~2021-01-19 3:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 9:52 [PATCH] cpufreq: qcom-hw: add missing devm_release_mem_region() call Shawn Guo
2021-01-12 10:14 ` Viresh Kumar
2021-01-12 11:19 ` Shawn Guo
2021-01-12 12:19 ` Ionela Voinescu
2021-01-12 14:44 ` Bjorn Andersson
2021-01-13 4:31 ` Viresh Kumar
2021-01-13 4:59 ` Bjorn Andersson
2021-01-13 5:06 ` Viresh Kumar
2021-01-13 22:12 ` AngeloGioacchino Del Regno
2021-01-14 4:58 ` Viresh Kumar
2021-01-14 5:21 ` Bjorn Andersson
2021-01-18 6:43 ` Viresh Kumar
2021-01-18 6:54 ` Shawn Guo
2021-01-18 11:03 ` Ionela Voinescu
2021-01-18 12:17 ` Shawn Guo
2021-01-19 3:36 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119033612.2inqiq77dioqisq6@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.