From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Ionela Voinescu <ionela.voinescu@arm.com>,
Shawn Guo <shawn.guo@linaro.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Andy Gross <agross@kernel.org>,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] cpufreq: qcom-hw: add missing devm_release_mem_region() call
Date: Wed, 13 Jan 2021 23:21:13 -0600 [thread overview]
Message-ID: <X//UyenFTDwoD0C5@builder.lan> (raw)
In-Reply-To: <cbd4fb28-24b8-9aa7-fe5f-24571ef6258d@somainline.org>
On Wed 13 Jan 16:12 CST 2021, AngeloGioacchino Del Regno wrote:
> Il 13/01/21 06:06, Viresh Kumar ha scritto:
> > On 12-01-21, 22:59, Bjorn Andersson wrote:
> > > But that said, why are the ioremap done at init and not at probe time?
> >
> > These are some hardware registers per cpufreq policy I believe, and so
> > they did it from policy init instead.
> >
> > And yes I agree that we shouldn't use devm_ from init() for the cases
> > where we need to put the resources in exit() as well. But things like
> > devm_kzalloc() are fine there.
> >
> > Ionela, since you were the first one to post a patch about this, can
> > you send a fix for this by dropping the devm_ thing altogether for the
> > ioremap thing ? Mark it suggested by Bjorn. Thanks.
> >
>
> Sorry, are you sure that the eventual fix shouldn't be rebased on top of my
> change (12014503) [1] that is enabling CPU scaling for all of the platforms
> that aren't getting the OSM set-up entirely by the TZ/bootloader?
> It's a pretty big series, that I've rebased 3 times already...
>
I hear you and I love the work you're doing, so I am definitely trying
to find time to review your patches properly.
Regarding the size of the series, my suggestion is that you have shown
the whole picture, so going forward it's better to split it up in
individual series based on how they will be merged by different
maintainers.
Thank you,
Bjorn
> [1]: https://patchwork.kernel.org/project/linux-arm-msm/patch/20210112182052.481888-15-angelogioacchino.delregno@somainline.org/
next prev parent reply other threads:[~2021-01-14 5:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 9:52 [PATCH] cpufreq: qcom-hw: add missing devm_release_mem_region() call Shawn Guo
2021-01-12 10:14 ` Viresh Kumar
2021-01-12 11:19 ` Shawn Guo
2021-01-12 12:19 ` Ionela Voinescu
2021-01-12 14:44 ` Bjorn Andersson
2021-01-13 4:31 ` Viresh Kumar
2021-01-13 4:59 ` Bjorn Andersson
2021-01-13 5:06 ` Viresh Kumar
2021-01-13 22:12 ` AngeloGioacchino Del Regno
2021-01-14 4:58 ` Viresh Kumar
2021-01-14 5:21 ` Bjorn Andersson [this message]
2021-01-18 6:43 ` Viresh Kumar
2021-01-18 6:54 ` Shawn Guo
2021-01-18 11:03 ` Ionela Voinescu
2021-01-18 12:17 ` Shawn Guo
2021-01-19 3:36 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X//UyenFTDwoD0C5@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shawn.guo@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.