* [drm-intel:drm-intel-next 8/19] drivers/gpu/drm/i915/display/intel_hdcp.c:817 _intel_hdcp_disable() error: uninitialized symbol 'ret'.
@ 2021-01-19 6:59 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2021-01-19 6:59 UTC (permalink / raw)
To: kbuild, Anshuman Gupta; +Cc: kbuild-all, lkp, intel-gfx, dri-devel, Uma Shankar
[-- Attachment #1: Type: text/plain, Size: 5286 bytes --]
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next
head: d5a0d4b9380a499cc140c7ee04ec80e15a8d49e5
commit: 2a743b7b8a8be8c8fc7c130c304c1243f6bbe9b7 [8/19] drm/i915/hdcp: Configure HDCP1.4 MST steram encryption status
config: x86_64-randconfig-m001-20210115 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/i915/display/intel_hdcp.c:817 _intel_hdcp_disable() error: uninitialized symbol 'ret'.
vim +/ret +817 drivers/gpu/drm/i915/display/intel_hdcp.c
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 788 static int _intel_hdcp_disable(struct intel_connector *connector)
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 789 {
7801f3b792b0fd drivers/gpu/drm/i915/display/intel_hdcp.c Lucas De Marchi 2020-06-30 790 struct intel_digital_port *dig_port = intel_attached_dig_port(connector);
486bba4524e00c drivers/gpu/drm/i915/display/intel_hdcp.c Ville Syrjälä 2019-12-04 791 struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
486bba4524e00c drivers/gpu/drm/i915/display/intel_hdcp.c Ville Syrjälä 2019-12-04 792 struct intel_hdcp *hdcp = &connector->hdcp;
7801f3b792b0fd drivers/gpu/drm/i915/display/intel_hdcp.c Lucas De Marchi 2020-06-30 793 enum port port = dig_port->base.port;
692059318c0fc6 drivers/gpu/drm/i915/display/intel_hdcp.c Ramalingam C 2019-08-28 794 enum transcoder cpu_transcoder = hdcp->cpu_transcoder;
2cc0c7b520bf8e drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 795 u32 repeater_ctl;
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 796 int ret;
^^^^^^^
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 797
65833c463886fa drivers/gpu/drm/i915/display/intel_hdcp.c Wambui Karuga 2020-01-22 798 drm_dbg_kms(&dev_priv->drm, "[%s:%d] HDCP is being disabled...\n",
cb340bf37173d6 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2018-02-03 799 connector->base.name, connector->base.base.id);
cb340bf37173d6 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2018-02-03 800
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 801 if (hdcp->shim->stream_encryption) {
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 802 ret = hdcp->shim->stream_encryption(connector, false);
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 803 if (ret) {
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 804 drm_err(&dev_priv->drm, "[%s:%d] Failed to disable HDCP 1.4 stream enc\n",
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 805 connector->base.name, connector->base.base.id);
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 806 return ret;
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 807 }
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 808 drm_dbg_kms(&dev_priv->drm, "HDCP 1.4 transcoder: %s stream encryption disabled\n",
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 809 transcoder_name(hdcp->stream_transcoder));
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 810 }
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 811
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 812 /*
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 813 * If there are other connectors on this port using HDCP, don't disable it
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 814 * until it disabled HDCP encryption for all connectors in MST topology.
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 815 */
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 816 if (dig_port->num_hdcp_streams > 0)
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 @817 return ret;
Presumably an error code was intended instead of an unintialized variable.
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 818
09d56393c1d8d5 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2019-02-16 819 hdcp->hdcp_encrypted = false;
667944ad77f197 drivers/gpu/drm/i915/display/intel_hdcp.c Jani Nikula 2020-01-27 820 intel_de_write(dev_priv, HDCP_CONF(dev_priv, cpu_transcoder, port), 0);
692059318c0fc6 drivers/gpu/drm/i915/display/intel_hdcp.c Ramalingam C 2019-08-28 821 if (intel_de_wait_for_clear(dev_priv,
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34082 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] [drm-intel:drm-intel-next 8/19] drivers/gpu/drm/i915/display/intel_hdcp.c:817 _intel_hdcp_disable() error: uninitialized symbol 'ret'.
@ 2021-01-19 6:59 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2021-01-19 6:59 UTC (permalink / raw)
To: kbuild, Anshuman Gupta; +Cc: kbuild-all, intel-gfx, dri-devel
[-- Attachment #1: Type: text/plain, Size: 5286 bytes --]
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next
head: d5a0d4b9380a499cc140c7ee04ec80e15a8d49e5
commit: 2a743b7b8a8be8c8fc7c130c304c1243f6bbe9b7 [8/19] drm/i915/hdcp: Configure HDCP1.4 MST steram encryption status
config: x86_64-randconfig-m001-20210115 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/i915/display/intel_hdcp.c:817 _intel_hdcp_disable() error: uninitialized symbol 'ret'.
vim +/ret +817 drivers/gpu/drm/i915/display/intel_hdcp.c
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 788 static int _intel_hdcp_disable(struct intel_connector *connector)
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 789 {
7801f3b792b0fd drivers/gpu/drm/i915/display/intel_hdcp.c Lucas De Marchi 2020-06-30 790 struct intel_digital_port *dig_port = intel_attached_dig_port(connector);
486bba4524e00c drivers/gpu/drm/i915/display/intel_hdcp.c Ville Syrjälä 2019-12-04 791 struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
486bba4524e00c drivers/gpu/drm/i915/display/intel_hdcp.c Ville Syrjälä 2019-12-04 792 struct intel_hdcp *hdcp = &connector->hdcp;
7801f3b792b0fd drivers/gpu/drm/i915/display/intel_hdcp.c Lucas De Marchi 2020-06-30 793 enum port port = dig_port->base.port;
692059318c0fc6 drivers/gpu/drm/i915/display/intel_hdcp.c Ramalingam C 2019-08-28 794 enum transcoder cpu_transcoder = hdcp->cpu_transcoder;
2cc0c7b520bf8e drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 795 u32 repeater_ctl;
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 796 int ret;
^^^^^^^
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 797
65833c463886fa drivers/gpu/drm/i915/display/intel_hdcp.c Wambui Karuga 2020-01-22 798 drm_dbg_kms(&dev_priv->drm, "[%s:%d] HDCP is being disabled...\n",
cb340bf37173d6 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2018-02-03 799 connector->base.name, connector->base.base.id);
cb340bf37173d6 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2018-02-03 800
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 801 if (hdcp->shim->stream_encryption) {
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 802 ret = hdcp->shim->stream_encryption(connector, false);
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 803 if (ret) {
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 804 drm_err(&dev_priv->drm, "[%s:%d] Failed to disable HDCP 1.4 stream enc\n",
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 805 connector->base.name, connector->base.base.id);
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 806 return ret;
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 807 }
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 808 drm_dbg_kms(&dev_priv->drm, "HDCP 1.4 transcoder: %s stream encryption disabled\n",
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 809 transcoder_name(hdcp->stream_transcoder));
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 810 }
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 811
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 812 /*
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 813 * If there are other connectors on this port using HDCP, don't disable it
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 814 * until it disabled HDCP encryption for all connectors in MST topology.
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 815 */
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 816 if (dig_port->num_hdcp_streams > 0)
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 @817 return ret;
Presumably an error code was intended instead of an unintialized variable.
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 818
09d56393c1d8d5 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2019-02-16 819 hdcp->hdcp_encrypted = false;
667944ad77f197 drivers/gpu/drm/i915/display/intel_hdcp.c Jani Nikula 2020-01-27 820 intel_de_write(dev_priv, HDCP_CONF(dev_priv, cpu_transcoder, port), 0);
692059318c0fc6 drivers/gpu/drm/i915/display/intel_hdcp.c Ramalingam C 2019-08-28 821 if (intel_de_wait_for_clear(dev_priv,
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34082 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [drm-intel:drm-intel-next 8/19] drivers/gpu/drm/i915/display/intel_hdcp.c:817 _intel_hdcp_disable() error: uninitialized symbol 'ret'.
@ 2021-01-19 6:59 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2021-01-19 6:59 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 5350 bytes --]
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next
head: d5a0d4b9380a499cc140c7ee04ec80e15a8d49e5
commit: 2a743b7b8a8be8c8fc7c130c304c1243f6bbe9b7 [8/19] drm/i915/hdcp: Configure HDCP1.4 MST steram encryption status
config: x86_64-randconfig-m001-20210115 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/i915/display/intel_hdcp.c:817 _intel_hdcp_disable() error: uninitialized symbol 'ret'.
vim +/ret +817 drivers/gpu/drm/i915/display/intel_hdcp.c
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 788 static int _intel_hdcp_disable(struct intel_connector *connector)
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 789 {
7801f3b792b0fd drivers/gpu/drm/i915/display/intel_hdcp.c Lucas De Marchi 2020-06-30 790 struct intel_digital_port *dig_port = intel_attached_dig_port(connector);
486bba4524e00c drivers/gpu/drm/i915/display/intel_hdcp.c Ville Syrjälä 2019-12-04 791 struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
486bba4524e00c drivers/gpu/drm/i915/display/intel_hdcp.c Ville Syrjälä 2019-12-04 792 struct intel_hdcp *hdcp = &connector->hdcp;
7801f3b792b0fd drivers/gpu/drm/i915/display/intel_hdcp.c Lucas De Marchi 2020-06-30 793 enum port port = dig_port->base.port;
692059318c0fc6 drivers/gpu/drm/i915/display/intel_hdcp.c Ramalingam C 2019-08-28 794 enum transcoder cpu_transcoder = hdcp->cpu_transcoder;
2cc0c7b520bf8e drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 795 u32 repeater_ctl;
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 796 int ret;
^^^^^^^
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 797
65833c463886fa drivers/gpu/drm/i915/display/intel_hdcp.c Wambui Karuga 2020-01-22 798 drm_dbg_kms(&dev_priv->drm, "[%s:%d] HDCP is being disabled...\n",
cb340bf37173d6 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2018-02-03 799 connector->base.name, connector->base.base.id);
cb340bf37173d6 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2018-02-03 800
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 801 if (hdcp->shim->stream_encryption) {
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 802 ret = hdcp->shim->stream_encryption(connector, false);
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 803 if (ret) {
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 804 drm_err(&dev_priv->drm, "[%s:%d] Failed to disable HDCP 1.4 stream enc\n",
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 805 connector->base.name, connector->base.base.id);
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 806 return ret;
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 807 }
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 808 drm_dbg_kms(&dev_priv->drm, "HDCP 1.4 transcoder: %s stream encryption disabled\n",
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 809 transcoder_name(hdcp->stream_transcoder));
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 810 }
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 811
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 812 /*
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 813 * If there are other connectors on this port using HDCP, don't disable it
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 814 * until it disabled HDCP encryption for all connectors in MST topology.
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 815 */
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 816 if (dig_port->num_hdcp_streams > 0)
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 @817 return ret;
Presumably an error code was intended instead of an unintialized variable.
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 818
09d56393c1d8d5 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2019-02-16 819 hdcp->hdcp_encrypted = false;
667944ad77f197 drivers/gpu/drm/i915/display/intel_hdcp.c Jani Nikula 2020-01-27 820 intel_de_write(dev_priv, HDCP_CONF(dev_priv, cpu_transcoder, port), 0);
692059318c0fc6 drivers/gpu/drm/i915/display/intel_hdcp.c Ramalingam C 2019-08-28 821 if (intel_de_wait_for_clear(dev_priv,
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34082 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [drm-intel:drm-intel-next 8/19] drivers/gpu/drm/i915/display/intel_hdcp.c:817 _intel_hdcp_disable() error: uninitialized symbol 'ret'.
@ 2021-01-19 6:59 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2021-01-19 6:59 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 5350 bytes --]
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next
head: d5a0d4b9380a499cc140c7ee04ec80e15a8d49e5
commit: 2a743b7b8a8be8c8fc7c130c304c1243f6bbe9b7 [8/19] drm/i915/hdcp: Configure HDCP1.4 MST steram encryption status
config: x86_64-randconfig-m001-20210115 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/i915/display/intel_hdcp.c:817 _intel_hdcp_disable() error: uninitialized symbol 'ret'.
vim +/ret +817 drivers/gpu/drm/i915/display/intel_hdcp.c
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 788 static int _intel_hdcp_disable(struct intel_connector *connector)
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 789 {
7801f3b792b0fd drivers/gpu/drm/i915/display/intel_hdcp.c Lucas De Marchi 2020-06-30 790 struct intel_digital_port *dig_port = intel_attached_dig_port(connector);
486bba4524e00c drivers/gpu/drm/i915/display/intel_hdcp.c Ville Syrjälä 2019-12-04 791 struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
486bba4524e00c drivers/gpu/drm/i915/display/intel_hdcp.c Ville Syrjälä 2019-12-04 792 struct intel_hdcp *hdcp = &connector->hdcp;
7801f3b792b0fd drivers/gpu/drm/i915/display/intel_hdcp.c Lucas De Marchi 2020-06-30 793 enum port port = dig_port->base.port;
692059318c0fc6 drivers/gpu/drm/i915/display/intel_hdcp.c Ramalingam C 2019-08-28 794 enum transcoder cpu_transcoder = hdcp->cpu_transcoder;
2cc0c7b520bf8e drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 795 u32 repeater_ctl;
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 796 int ret;
^^^^^^^
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 797
65833c463886fa drivers/gpu/drm/i915/display/intel_hdcp.c Wambui Karuga 2020-01-22 798 drm_dbg_kms(&dev_priv->drm, "[%s:%d] HDCP is being disabled...\n",
cb340bf37173d6 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2018-02-03 799 connector->base.name, connector->base.base.id);
cb340bf37173d6 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2018-02-03 800
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 801 if (hdcp->shim->stream_encryption) {
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 802 ret = hdcp->shim->stream_encryption(connector, false);
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 803 if (ret) {
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 804 drm_err(&dev_priv->drm, "[%s:%d] Failed to disable HDCP 1.4 stream enc\n",
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 805 connector->base.name, connector->base.base.id);
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 806 return ret;
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 807 }
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 808 drm_dbg_kms(&dev_priv->drm, "HDCP 1.4 transcoder: %s stream encryption disabled\n",
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 809 transcoder_name(hdcp->stream_transcoder));
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 810 }
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 811
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 812 /*
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 813 * If there are other connectors on this port using HDCP, don't disable it
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 814 * until it disabled HDCP encryption for all connectors in MST topology.
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 815 */
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 816 if (dig_port->num_hdcp_streams > 0)
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 @817 return ret;
Presumably an error code was intended instead of an unintialized variable.
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 818
09d56393c1d8d5 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2019-02-16 819 hdcp->hdcp_encrypted = false;
667944ad77f197 drivers/gpu/drm/i915/display/intel_hdcp.c Jani Nikula 2020-01-27 820 intel_de_write(dev_priv, HDCP_CONF(dev_priv, cpu_transcoder, port), 0);
692059318c0fc6 drivers/gpu/drm/i915/display/intel_hdcp.c Ramalingam C 2019-08-28 821 if (intel_de_wait_for_clear(dev_priv,
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34082 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [drm-intel:drm-intel-next 8/19] drivers/gpu/drm/i915/display/intel_hdcp.c:817 _intel_hdcp_disable() error: uninitialized symbol 'ret'.
@ 2021-01-15 9:20 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2021-01-15 9:20 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 8488 bytes --]
CC: kbuild-all(a)lists.01.org
CC: intel-gfx(a)lists.freedesktop.org
CC: dri-devel(a)lists.freedesktop.org
TO: Anshuman Gupta <anshuman.gupta@intel.com>
CC: Uma Shankar <uma.shankar@intel.com>
CC: Ramalingam C <ramalingam.c@intel.com>
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next
head: d5a0d4b9380a499cc140c7ee04ec80e15a8d49e5
commit: 2a743b7b8a8be8c8fc7c130c304c1243f6bbe9b7 [8/19] drm/i915/hdcp: Configure HDCP1.4 MST steram encryption status
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: x86_64-randconfig-m001-20210115 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/i915/display/intel_hdcp.c:817 _intel_hdcp_disable() error: uninitialized symbol 'ret'.
vim +/ret +817 drivers/gpu/drm/i915/display/intel_hdcp.c
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 787
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 788 static int _intel_hdcp_disable(struct intel_connector *connector)
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 789 {
7801f3b792b0fd drivers/gpu/drm/i915/display/intel_hdcp.c Lucas De Marchi 2020-06-30 790 struct intel_digital_port *dig_port = intel_attached_dig_port(connector);
486bba4524e00c drivers/gpu/drm/i915/display/intel_hdcp.c Ville Syrjälä 2019-12-04 791 struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
486bba4524e00c drivers/gpu/drm/i915/display/intel_hdcp.c Ville Syrjälä 2019-12-04 792 struct intel_hdcp *hdcp = &connector->hdcp;
7801f3b792b0fd drivers/gpu/drm/i915/display/intel_hdcp.c Lucas De Marchi 2020-06-30 793 enum port port = dig_port->base.port;
692059318c0fc6 drivers/gpu/drm/i915/display/intel_hdcp.c Ramalingam C 2019-08-28 794 enum transcoder cpu_transcoder = hdcp->cpu_transcoder;
2cc0c7b520bf8e drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 795 u32 repeater_ctl;
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 796 int ret;
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 797
65833c463886fa drivers/gpu/drm/i915/display/intel_hdcp.c Wambui Karuga 2020-01-22 798 drm_dbg_kms(&dev_priv->drm, "[%s:%d] HDCP is being disabled...\n",
cb340bf37173d6 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2018-02-03 799 connector->base.name, connector->base.base.id);
cb340bf37173d6 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2018-02-03 800
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 801 if (hdcp->shim->stream_encryption) {
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 802 ret = hdcp->shim->stream_encryption(connector, false);
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 803 if (ret) {
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 804 drm_err(&dev_priv->drm, "[%s:%d] Failed to disable HDCP 1.4 stream enc\n",
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 805 connector->base.name, connector->base.base.id);
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 806 return ret;
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 807 }
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 808 drm_dbg_kms(&dev_priv->drm, "HDCP 1.4 transcoder: %s stream encryption disabled\n",
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 809 transcoder_name(hdcp->stream_transcoder));
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 810 }
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 811
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 812 /*
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 813 * If there are other connectors on this port using HDCP, don't disable it
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 814 * until it disabled HDCP encryption for all connectors in MST topology.
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 815 */
2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 816 if (dig_port->num_hdcp_streams > 0)
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 @817 return ret;
36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 818
09d56393c1d8d5 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2019-02-16 819 hdcp->hdcp_encrypted = false;
667944ad77f197 drivers/gpu/drm/i915/display/intel_hdcp.c Jani Nikula 2020-01-27 820 intel_de_write(dev_priv, HDCP_CONF(dev_priv, cpu_transcoder, port), 0);
692059318c0fc6 drivers/gpu/drm/i915/display/intel_hdcp.c Ramalingam C 2019-08-28 821 if (intel_de_wait_for_clear(dev_priv,
692059318c0fc6 drivers/gpu/drm/i915/display/intel_hdcp.c Ramalingam C 2019-08-28 822 HDCP_STATUS(dev_priv, cpu_transcoder, port),
fbf652bdb4b249 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 823 ~0, HDCP_ENCRYPT_STATUS_CHANGE_TIMEOUT_MS)) {
65833c463886fa drivers/gpu/drm/i915/display/intel_hdcp.c Wambui Karuga 2020-01-22 824 drm_err(&dev_priv->drm,
65833c463886fa drivers/gpu/drm/i915/display/intel_hdcp.c Wambui Karuga 2020-01-22 825 "Failed to disable HDCP, timeout clearing status\n");
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 826 return -ETIMEDOUT;
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 827 }
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 828
2cc0c7b520bf8e drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 829 repeater_ctl = intel_hdcp_get_repeater_ctl(dev_priv, cpu_transcoder,
2cc0c7b520bf8e drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 830 port);
2cc0c7b520bf8e drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 831 intel_de_write(dev_priv, HDCP_REP_CTL,
2cc0c7b520bf8e drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 832 intel_de_read(dev_priv, HDCP_REP_CTL) & ~repeater_ctl);
2cc0c7b520bf8e drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 833
0b9c9290d1d182 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 834 ret = hdcp->shim->toggle_signalling(dig_port, cpu_transcoder, false);
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 835 if (ret) {
65833c463886fa drivers/gpu/drm/i915/display/intel_hdcp.c Wambui Karuga 2020-01-22 836 drm_err(&dev_priv->drm, "Failed to disable HDCP signalling\n");
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 837 return ret;
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 838 }
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 839
65833c463886fa drivers/gpu/drm/i915/display/intel_hdcp.c Wambui Karuga 2020-01-22 840 drm_dbg_kms(&dev_priv->drm, "HDCP is disabled\n");
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 841 return 0;
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 842 }
ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 843
:::::: The code at line 817 was first introduced by commit
:::::: 36e5e7042b202025f8643538c2d591cab1f24b72 drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it
:::::: TO: Sean Paul <seanpaul@chromium.org>
:::::: CC: Ramalingam C <ramalingam.c@intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34082 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-19 7:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-19 6:59 [drm-intel:drm-intel-next 8/19] drivers/gpu/drm/i915/display/intel_hdcp.c:817 _intel_hdcp_disable() error: uninitialized symbol 'ret' Dan Carpenter
2021-01-19 6:59 ` Dan Carpenter
2021-01-19 6:59 ` Dan Carpenter
2021-01-19 6:59 ` [Intel-gfx] " Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2021-01-15 9:20 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.