From: Richard Palethorpe <rpalethorpe@suse.com> To: ltp@lists.linux.it Cc: linux-can@vger.kernel.org, Oliver Hartkopp <socketcan@hartkopp.net>, Richard Palethorpe <rpalethorpe@suse.com> Subject: [PATCH v2 5/6] can: Remove obsolete test wrapper script Date: Tue, 19 Jan 2021 09:31:42 +0000 [thread overview] Message-ID: <20210119093143.17222-6-rpalethorpe@suse.com> (raw) In-Reply-To: <20210119093143.17222-1-rpalethorpe@suse.com> Functionality moved into can_common.h and the test executables. Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com> --- testcases/network/can/Makefile | 2 - .../can/filter-tests/00_Descriptions.txt | 1 + testcases/network/can/filter-tests/INSTALL | 3 +- testcases/network/can/filter-tests/Makefile | 2 - .../network/can/filter-tests/can_run_tests.sh | 106 ------------------ 5 files changed, 3 insertions(+), 111 deletions(-) delete mode 100755 testcases/network/can/filter-tests/can_run_tests.sh diff --git a/testcases/network/can/Makefile b/testcases/network/can/Makefile index 31744534a..a69f6be87 100644 --- a/testcases/network/can/Makefile +++ b/testcases/network/can/Makefile @@ -22,6 +22,4 @@ top_srcdir ?= ../../.. include $(top_srcdir)/include/mk/env_pre.mk -INSTALL_TARGETS := *.sh - include $(top_srcdir)/include/mk/generic_trunk_target.mk diff --git a/testcases/network/can/filter-tests/00_Descriptions.txt b/testcases/network/can/filter-tests/00_Descriptions.txt index 89610982c..55d213456 100644 --- a/testcases/network/can/filter-tests/00_Descriptions.txt +++ b/testcases/network/can/filter-tests/00_Descriptions.txt @@ -5,5 +5,6 @@ information on the CAN network protocol family PF_CAN is contained in <Kernel/Documentation/networking/can.txt>. For any issue(s) with CAN tests please write to: +<ltp@lists.linux.it> <socketcan-users@lists.berlios.de>, Oliver Hartkopp <oliver.hartkopp@volkswagen.de>, diff --git a/testcases/network/can/filter-tests/INSTALL b/testcases/network/can/filter-tests/INSTALL index e549aed0f..7d62d65fe 100644 --- a/testcases/network/can/filter-tests/INSTALL +++ b/testcases/network/can/filter-tests/INSTALL @@ -12,7 +12,8 @@ enable CAN protocol, please see ltp/README file. $ make 2) To Run the tests from this directory, do: -$ ./run_ltp-can_tests.sh +$ ./can_filter +$ ./can_rcv_own_msgs 3) To let LTP run the tests from $LTPROOT, execute: $ ./runltp -f can diff --git a/testcases/network/can/filter-tests/Makefile b/testcases/network/can/filter-tests/Makefile index 6a9474164..29aaa3240 100644 --- a/testcases/network/can/filter-tests/Makefile +++ b/testcases/network/can/filter-tests/Makefile @@ -23,6 +23,4 @@ include $(top_srcdir)/include/mk/testcases.mk CPPFLAGS += -DETH_P_CAN=0x000C -DPF_CAN=29 -DAF_CAN=PF_CAN -INSTALL_TARGETS := *.sh - include $(top_srcdir)/include/mk/generic_leaf_target.mk diff --git a/testcases/network/can/filter-tests/can_run_tests.sh b/testcases/network/can/filter-tests/can_run_tests.sh deleted file mode 100755 index 762d90eca..000000000 --- a/testcases/network/can/filter-tests/can_run_tests.sh +++ /dev/null @@ -1,106 +0,0 @@ -#!/bin/sh -################################################################################ -## Copyright (c) Oliver Hartkopp <oliver.hartkopp@volkswagen.de>, 2011 ## -## Copyright (c) International Business Machines Corp., 2009 ## -## ## -## This program is free software; you can redistribute it and#or modify ## -## it under the terms of the GNU General Public License as published by ## -## the Free Software Foundation; either version 2 of the License, or ## -## (at your option) any later version. ## -## ## -## This program is distributed in the hope that it will be useful, but ## -## WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY ## -## or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License ## -## for more details. ## -## ## -## You should have received a copy of the GNU General Public License ## -## along with this program; if not, write to the Free Software Foundation, ## -## Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA ## -## ## -################################################################################ - -TCID="$1" -TST_TOTAL=1 -export TST_COUNT - -. test.sh - -setup() -{ - tst_require_root - - # load needed CAN networklayer modules - modprobe can - ret=$? - if [ $ret -ne 0 ]; then - tst_brkm TCONF "modprobe can failed: ret - $ret" - fi - - modprobe can_raw - ret=$? - if [ $ret -ne 0 ]; then - tst_brkm TCONF "modprobe can_raw failed: ret - $ret" - fi - - # ensure the vcan driver to perform the ECHO on driver level - modprobe -r vcan - ret=$? - if [ $ret -ne 0 ]; then - tst_brkm TCONF "modprobe -r vcan failed: ret - $ret" - fi - - modprobe vcan echo=1 - ret=$? - if [ $ret -ne 0 ]; then - tst_brkm TCONF "modprobe vcan echo=1 failed: ret - $ret" - fi - - VCAN=vcan0 - - # create virtual CAN device - ip link add dev $VCAN type vcan - ret=$? - if [ $ret -ne 0 ]; then - tst_brkm TBROK \ - "ip link add dev $VCAN type vcan failed: ret - $ret" - fi - - ip link set dev $VCAN up - ret=$? - if [ $ret -ne 0 ]; then - tst_brkm TBROK "ip link set dev $VCAN up failed: ret - $ret" - fi - - # check precondition for CAN frame flow test - HAS_ECHO=`ip link show $VCAN | grep -c ECHO` - if [ $HAS_ECHO -ne 1 ]; then - tst_brkm TBROK "ECHO is not 1" - fi -} - -cleanup() -{ - ip link set dev $VCAN down - ip link del dev $VCAN - modprobe -r vcan - modprobe -r can_raw - modprobe -r can -} - -if [ $# -ne 1 ]; then - tst_brkm TBROK "Usage: $0 [can_filter | can_rcv_own_msgs]" -fi - -setup -TST_CLEANUP=cleanup - -"$1" "$VCAN" -ret=$? -case "$ret" in -0) tst_resm TPASS "Test $1 PASS";; -1) tst_resm TFAIL "Test $1 FAIL";; -32) tst_resm TCONF "$1 is not appropriate for configuration flag";; -*) tst_resm TBROK "Invalid resm type $ret";; -esac - -tst_exit -- 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Richard Palethorpe <rpalethorpe@suse.com> To: ltp@lists.linux.it Subject: [LTP] [PATCH v2 5/6] can: Remove obsolete test wrapper script Date: Tue, 19 Jan 2021 09:31:42 +0000 [thread overview] Message-ID: <20210119093143.17222-6-rpalethorpe@suse.com> (raw) In-Reply-To: <20210119093143.17222-1-rpalethorpe@suse.com> Functionality moved into can_common.h and the test executables. Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com> --- testcases/network/can/Makefile | 2 - .../can/filter-tests/00_Descriptions.txt | 1 + testcases/network/can/filter-tests/INSTALL | 3 +- testcases/network/can/filter-tests/Makefile | 2 - .../network/can/filter-tests/can_run_tests.sh | 106 ------------------ 5 files changed, 3 insertions(+), 111 deletions(-) delete mode 100755 testcases/network/can/filter-tests/can_run_tests.sh diff --git a/testcases/network/can/Makefile b/testcases/network/can/Makefile index 31744534a..a69f6be87 100644 --- a/testcases/network/can/Makefile +++ b/testcases/network/can/Makefile @@ -22,6 +22,4 @@ top_srcdir ?= ../../.. include $(top_srcdir)/include/mk/env_pre.mk -INSTALL_TARGETS := *.sh - include $(top_srcdir)/include/mk/generic_trunk_target.mk diff --git a/testcases/network/can/filter-tests/00_Descriptions.txt b/testcases/network/can/filter-tests/00_Descriptions.txt index 89610982c..55d213456 100644 --- a/testcases/network/can/filter-tests/00_Descriptions.txt +++ b/testcases/network/can/filter-tests/00_Descriptions.txt @@ -5,5 +5,6 @@ information on the CAN network protocol family PF_CAN is contained in <Kernel/Documentation/networking/can.txt>. For any issue(s) with CAN tests please write to: +<ltp@lists.linux.it> <socketcan-users@lists.berlios.de>, Oliver Hartkopp <oliver.hartkopp@volkswagen.de>, diff --git a/testcases/network/can/filter-tests/INSTALL b/testcases/network/can/filter-tests/INSTALL index e549aed0f..7d62d65fe 100644 --- a/testcases/network/can/filter-tests/INSTALL +++ b/testcases/network/can/filter-tests/INSTALL @@ -12,7 +12,8 @@ enable CAN protocol, please see ltp/README file. $ make 2) To Run the tests from this directory, do: -$ ./run_ltp-can_tests.sh +$ ./can_filter +$ ./can_rcv_own_msgs 3) To let LTP run the tests from $LTPROOT, execute: $ ./runltp -f can diff --git a/testcases/network/can/filter-tests/Makefile b/testcases/network/can/filter-tests/Makefile index 6a9474164..29aaa3240 100644 --- a/testcases/network/can/filter-tests/Makefile +++ b/testcases/network/can/filter-tests/Makefile @@ -23,6 +23,4 @@ include $(top_srcdir)/include/mk/testcases.mk CPPFLAGS += -DETH_P_CAN=0x000C -DPF_CAN=29 -DAF_CAN=PF_CAN -INSTALL_TARGETS := *.sh - include $(top_srcdir)/include/mk/generic_leaf_target.mk diff --git a/testcases/network/can/filter-tests/can_run_tests.sh b/testcases/network/can/filter-tests/can_run_tests.sh deleted file mode 100755 index 762d90eca..000000000 --- a/testcases/network/can/filter-tests/can_run_tests.sh +++ /dev/null @@ -1,106 +0,0 @@ -#!/bin/sh -################################################################################ -## Copyright (c) Oliver Hartkopp <oliver.hartkopp@volkswagen.de>, 2011 ## -## Copyright (c) International Business Machines Corp., 2009 ## -## ## -## This program is free software; you can redistribute it and#or modify ## -## it under the terms of the GNU General Public License as published by ## -## the Free Software Foundation; either version 2 of the License, or ## -## (at your option) any later version. ## -## ## -## This program is distributed in the hope that it will be useful, but ## -## WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY ## -## or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License ## -## for more details. ## -## ## -## You should have received a copy of the GNU General Public License ## -## along with this program; if not, write to the Free Software Foundation, ## -## Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA ## -## ## -################################################################################ - -TCID="$1" -TST_TOTAL=1 -export TST_COUNT - -. test.sh - -setup() -{ - tst_require_root - - # load needed CAN networklayer modules - modprobe can - ret=$? - if [ $ret -ne 0 ]; then - tst_brkm TCONF "modprobe can failed: ret - $ret" - fi - - modprobe can_raw - ret=$? - if [ $ret -ne 0 ]; then - tst_brkm TCONF "modprobe can_raw failed: ret - $ret" - fi - - # ensure the vcan driver to perform the ECHO on driver level - modprobe -r vcan - ret=$? - if [ $ret -ne 0 ]; then - tst_brkm TCONF "modprobe -r vcan failed: ret - $ret" - fi - - modprobe vcan echo=1 - ret=$? - if [ $ret -ne 0 ]; then - tst_brkm TCONF "modprobe vcan echo=1 failed: ret - $ret" - fi - - VCAN=vcan0 - - # create virtual CAN device - ip link add dev $VCAN type vcan - ret=$? - if [ $ret -ne 0 ]; then - tst_brkm TBROK \ - "ip link add dev $VCAN type vcan failed: ret - $ret" - fi - - ip link set dev $VCAN up - ret=$? - if [ $ret -ne 0 ]; then - tst_brkm TBROK "ip link set dev $VCAN up failed: ret - $ret" - fi - - # check precondition for CAN frame flow test - HAS_ECHO=`ip link show $VCAN | grep -c ECHO` - if [ $HAS_ECHO -ne 1 ]; then - tst_brkm TBROK "ECHO is not 1" - fi -} - -cleanup() -{ - ip link set dev $VCAN down - ip link del dev $VCAN - modprobe -r vcan - modprobe -r can_raw - modprobe -r can -} - -if [ $# -ne 1 ]; then - tst_brkm TBROK "Usage: $0 [can_filter | can_rcv_own_msgs]" -fi - -setup -TST_CLEANUP=cleanup - -"$1" "$VCAN" -ret=$? -case "$ret" in -0) tst_resm TPASS "Test $1 PASS";; -1) tst_resm TFAIL "Test $1 FAIL";; -32) tst_resm TCONF "$1 is not appropriate for configuration flag";; -*) tst_resm TBROK "Invalid resm type $ret";; -esac - -tst_exit -- 2.29.2
next prev parent reply other threads:[~2021-01-19 14:39 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-19 9:31 [PATCH v2 0/6] Convert CAN tests to new LTP API Richard Palethorpe 2021-01-19 9:31 ` [LTP] " Richard Palethorpe 2021-01-19 9:31 ` [PATCH v2 1/6] API: Add FILE_SCANF to new lib Richard Palethorpe 2021-01-19 9:31 ` [LTP] " Richard Palethorpe 2021-01-19 9:31 ` [PATCH v2 2/6] can: Add can_common.h for vcan device setup Richard Palethorpe 2021-01-19 9:31 ` [LTP] " Richard Palethorpe 2021-01-19 18:05 ` Petr Vorel 2021-01-19 18:05 ` Petr Vorel 2021-01-19 9:31 ` [PATCH v2 3/6] can_filter: Convert to new library Richard Palethorpe 2021-01-19 9:31 ` [LTP] " Richard Palethorpe 2021-01-19 9:31 ` [PATCH v2 4/6] can_recv_own_msgs: " Richard Palethorpe 2021-01-19 9:31 ` [LTP] " Richard Palethorpe 2021-01-19 14:53 ` Marc Kleine-Budde 2021-01-19 14:53 ` [LTP] " Marc Kleine-Budde 2021-01-19 15:06 ` Cyril Hrubis 2021-01-19 15:06 ` Cyril Hrubis 2021-01-19 15:09 ` Marc Kleine-Budde 2021-01-19 15:09 ` Marc Kleine-Budde 2021-01-19 16:34 ` Richard Palethorpe 2021-01-19 16:34 ` Richard Palethorpe 2021-01-19 16:39 ` Marc Kleine-Budde 2021-01-19 16:39 ` Marc Kleine-Budde 2021-01-19 21:34 ` Oliver Hartkopp 2021-01-19 21:34 ` Oliver Hartkopp 2021-01-19 9:31 ` Richard Palethorpe [this message] 2021-01-19 9:31 ` [LTP] [PATCH v2 5/6] can: Remove obsolete test wrapper script Richard Palethorpe 2021-01-19 9:31 ` [PATCH v2 6/6] can: Update contact details Richard Palethorpe 2021-01-19 9:31 ` [LTP] " Richard Palethorpe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210119093143.17222-6-rpalethorpe@suse.com \ --to=rpalethorpe@suse.com \ --cc=linux-can@vger.kernel.org \ --cc=ltp@lists.linux.it \ --cc=socketcan@hartkopp.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.