From: Stafford Horne <shorne@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Karol Gugala <kgugala@antmicro.com>,
Mateusz Holenko <mholenko@antmicro.com>,
Gabriel Somlo <gsomlo@gmail.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] drivers/soc/litex: Add restart handler
Date: Wed, 20 Jan 2021 06:34:44 +0900 [thread overview]
Message-ID: <20210119213444.GL2002709@lianli.shorne-pla.net> (raw)
In-Reply-To: <20210119080938.1832733-1-geert@linux-m68k.org>
On Tue, Jan 19, 2021 at 09:09:38AM +0100, Geert Uytterhoeven wrote:
> Let the LiteX SoC Controller register a restart handler, which resets
> the LiteX SoC by writing 1 to CSR_CTRL_RESET_ADDR.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thanks, this looks good to me, queued to my linux-next branch.
-Stafford
> @@ -66,8 +71,19 @@ static int litex_check_csr_access(void __iomem *reg_addr)
>
> struct litex_soc_ctrl_device {
> void __iomem *base;
> + struct notifier_block reset_nb;
> };
>
> +static int litex_reset_handler(struct notifier_block *this, unsigned long mode,
> + void *cmd)
> +{
> + struct litex_soc_ctrl_device *soc_ctrl_dev =
> + container_of(this, struct litex_soc_ctrl_device, reset_nb);
Nice.
> + litex_write32(soc_ctrl_dev->base + RESET_REG_OFF, RESET_REG_VALUE);
> + return NOTIFY_DONE;
> +}
> +
WARNING: multiple messages have this Message-ID (diff)
From: Stafford Horne <shorne@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Gabriel Somlo <gsomlo@gmail.com>,
linux-riscv@lists.infradead.org,
Mateusz Holenko <mholenko@antmicro.com>,
Karol Gugala <kgugala@antmicro.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] drivers/soc/litex: Add restart handler
Date: Wed, 20 Jan 2021 06:34:44 +0900 [thread overview]
Message-ID: <20210119213444.GL2002709@lianli.shorne-pla.net> (raw)
In-Reply-To: <20210119080938.1832733-1-geert@linux-m68k.org>
On Tue, Jan 19, 2021 at 09:09:38AM +0100, Geert Uytterhoeven wrote:
> Let the LiteX SoC Controller register a restart handler, which resets
> the LiteX SoC by writing 1 to CSR_CTRL_RESET_ADDR.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thanks, this looks good to me, queued to my linux-next branch.
-Stafford
> @@ -66,8 +71,19 @@ static int litex_check_csr_access(void __iomem *reg_addr)
>
> struct litex_soc_ctrl_device {
> void __iomem *base;
> + struct notifier_block reset_nb;
> };
>
> +static int litex_reset_handler(struct notifier_block *this, unsigned long mode,
> + void *cmd)
> +{
> + struct litex_soc_ctrl_device *soc_ctrl_dev =
> + container_of(this, struct litex_soc_ctrl_device, reset_nb);
Nice.
> + litex_write32(soc_ctrl_dev->base + RESET_REG_OFF, RESET_REG_VALUE);
> + return NOTIFY_DONE;
> +}
> +
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-01-19 21:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 8:09 [PATCH v4] drivers/soc/litex: Add restart handler Geert Uytterhoeven
2021-01-19 8:09 ` Geert Uytterhoeven
2021-01-19 8:17 ` Anup Patel
2021-01-19 8:17 ` Anup Patel
2021-01-20 8:21 ` Geert Uytterhoeven
2021-01-20 8:21 ` Geert Uytterhoeven
2021-01-19 21:34 ` Stafford Horne [this message]
2021-01-19 21:34 ` Stafford Horne
2021-01-19 22:11 ` Stafford Horne
2021-01-19 22:11 ` Stafford Horne
2021-01-20 8:20 ` Geert Uytterhoeven
2021-01-20 8:20 ` Geert Uytterhoeven
2021-01-20 13:06 ` Stafford Horne
2021-01-20 13:06 ` Stafford Horne
2021-01-20 21:46 ` Joel Stanley
2021-01-20 21:46 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119213444.GL2002709@lianli.shorne-pla.net \
--to=shorne@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gsomlo@gmail.com \
--cc=kgugala@antmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mholenko@antmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.