[PATCH] Add Google RE2 library

[PATCH] Add Google RE2 library

[Clément Péron]

Add Google RE2 regular expression library.

This is used in new version of gRPC.

Signed-off-by: Clément Péron <peron.clem@gmail.com>
---

Hi,

This is my first contribution to meta-openembedded.

I would like to bump gRPC to new version but re2 library is required.

I'm not sure if i should call the package re2 or libre2.

Regards,
Clement

 .../libre2/libre2_2020.11.01.bb               | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 meta-oe/recipes-support/libre2/libre2_2020.11.01.bb

diff --git a/meta-oe/recipes-support/libre2/libre2_2020.11.01.bb b/meta-oe/recipes-support/libre2/libre2_2020.11.01.bb
new file mode 100644
index 000000000000..7c07b332dfff
--- /dev/null
+++ b/meta-oe/recipes-support/libre2/libre2_2020.11.01.bb
@@ -0,0 +1,23 @@
+DESCRIPTION = "A regular expression library"
+HOMEPAGE = "https://github.com/google/re2/"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=3b5c31eb512bdf3cb11ffd5713963760"
+
+SRCREV = "166dbbeb3b0ab7e733b278e8f42a84f6882b8a25"
+
+SRC_URI = "git://github.com/google/re2.git;branch=master"
+
+S = "${WORKDIR}/git"
+
+inherit cmake
+
+EXTRA_OECMAKE += " \
+	-DBUILD_SHARED_LIBS=ON \
+	-DRE2_BUILD_TESTING=OFF \
+"
+
+# Don't include so files in dev package
+FILES_${PN} = "${libdir}"
+FILES_${PN}-dev = "${includedir} ${libdir}/cmake/re2/*.cmake"
+
+BBCLASSEXTEND = "native nativesdk"
-- 
2.25.1

Re: [oe] [PATCH] Add Google RE2 library

[Paul Barker]

On Wed, 20 Jan 2021 at 09:18, Clément Péron <peron.clem@gmail.com> wrote:
>
> Add Google RE2 regular expression library.
>
> This is used in new version of gRPC.
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
>
> Hi,
>
> This is my first contribution to meta-openembedded.
>
> I would like to bump gRPC to new version but re2 library is required.
>
> I'm not sure if i should call the package re2 or libre2.

Hi Clément,

I'd use "re2" if that's the upstream name of the project.

You should also modify the commit summary to follow the format shown
in https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines.
So it'd be something like "re2: Add recipe for Google RE2 library".

Thanks,

--
Paul Barker
Konsulko Group

Re: [oe] [PATCH] Add Google RE2 library

[Clément Péron]

Hi Paul,

On Wed, 20 Jan 2021 at 11:23, Paul Barker <pbarker@konsulko.com> wrote:
>
> On Wed, 20 Jan 2021 at 09:18, Clément Péron <peron.clem@gmail.com> wrote:
> >
> > Add Google RE2 regular expression library.
> >
> > This is used in new version of gRPC.
> >
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> >
> > Hi,
> >
> > This is my first contribution to meta-openembedded.
> >
> > I would like to bump gRPC to new version but re2 library is required.
> >
> > I'm not sure if i should call the package re2 or libre2.
>
> Hi Clément,
>
> I'd use "re2" if that's the upstream name of the project.
>
> You should also modify the commit summary to follow the format shown
> in https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines.
> So it'd be something like "re2: Add recipe for Google RE2 library".

Thanks for the review, I will send a v2,
Regards,
Clement

>
> Thanks,
>
> --
> Paul Barker
> Konsulko Group