All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Kir Kolyshkin <kolyshkin@gmail.com>
Cc: linux-doc@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH 04/10] docs/scheduler/sched-bwc: add proper ref
Date: Wed, 20 Jan 2021 10:43:01 -0700	[thread overview]
Message-ID: <20210120104301.2aeda8f9@lwn.net> (raw)
In-Reply-To: <20210120001824.385168-5-kolyshkin@gmail.com>

On Tue, 19 Jan 2021 16:18:18 -0800
Kir Kolyshkin <kolyshkin@gmail.com> wrote:

> Add a proper reference instead of just using the file name.
> 
> Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
> ---
>  Documentation/scheduler/sched-bwc.rst      | 3 ++-
>  Documentation/scheduler/sched-rt-group.rst | 2 ++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/scheduler/sched-bwc.rst b/Documentation/scheduler/sched-bwc.rst
> index a44860d33ffc..dcec7440c222 100644
> --- a/Documentation/scheduler/sched-bwc.rst
> +++ b/Documentation/scheduler/sched-bwc.rst
> @@ -4,7 +4,8 @@ CFS Bandwidth Control
>  
>  .. note::
>     This document only discusses CPU bandwidth control for SCHED_NORMAL.
> -   The SCHED_RT case is covered in Documentation/scheduler/sched-rt-group.rst
> +   The SCHED_RT case is covered in
> +   :ref:`Documentation/scheduler/sched-rt-group.rst <sched-rt-group>`.
>  
>  CFS bandwidth control is a CONFIG_FAIR_GROUP_SCHED extension which allows the
>  specification of the maximum CPU bandwidth available to a group or hierarchy.
> diff --git a/Documentation/scheduler/sched-rt-group.rst b/Documentation/scheduler/sched-rt-group.rst
> index 655a096ec8fb..a3b4aa51c271 100644
> --- a/Documentation/scheduler/sched-rt-group.rst
> +++ b/Documentation/scheduler/sched-rt-group.rst
> @@ -1,3 +1,5 @@
> +.. _sched-rt-group:
> +

So why do you need to do this?  The build system in recent kernels will
generate that reference automatically without the extra markup.

Thanks,

jon

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Corbet <corbet-T1hC0tSOHrs@public.gmane.org>
To: Kir Kolyshkin <kolyshkin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 04/10] docs/scheduler/sched-bwc: add proper ref
Date: Wed, 20 Jan 2021 10:43:01 -0700	[thread overview]
Message-ID: <20210120104301.2aeda8f9@lwn.net> (raw)
In-Reply-To: <20210120001824.385168-5-kolyshkin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Tue, 19 Jan 2021 16:18:18 -0800
Kir Kolyshkin <kolyshkin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> Add a proper reference instead of just using the file name.
> 
> Signed-off-by: Kir Kolyshkin <kolyshkin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  Documentation/scheduler/sched-bwc.rst      | 3 ++-
>  Documentation/scheduler/sched-rt-group.rst | 2 ++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/scheduler/sched-bwc.rst b/Documentation/scheduler/sched-bwc.rst
> index a44860d33ffc..dcec7440c222 100644
> --- a/Documentation/scheduler/sched-bwc.rst
> +++ b/Documentation/scheduler/sched-bwc.rst
> @@ -4,7 +4,8 @@ CFS Bandwidth Control
>  
>  .. note::
>     This document only discusses CPU bandwidth control for SCHED_NORMAL.
> -   The SCHED_RT case is covered in Documentation/scheduler/sched-rt-group.rst
> +   The SCHED_RT case is covered in
> +   :ref:`Documentation/scheduler/sched-rt-group.rst <sched-rt-group>`.
>  
>  CFS bandwidth control is a CONFIG_FAIR_GROUP_SCHED extension which allows the
>  specification of the maximum CPU bandwidth available to a group or hierarchy.
> diff --git a/Documentation/scheduler/sched-rt-group.rst b/Documentation/scheduler/sched-rt-group.rst
> index 655a096ec8fb..a3b4aa51c271 100644
> --- a/Documentation/scheduler/sched-rt-group.rst
> +++ b/Documentation/scheduler/sched-rt-group.rst
> @@ -1,3 +1,5 @@
> +.. _sched-rt-group:
> +

So why do you need to do this?  The build system in recent kernels will
generate that reference automatically without the extra markup.

Thanks,

jon

  reply	other threads:[~2021-01-20 17:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  0:18 [PATCH 00/10] docs: cgroup nits and fixes Kir Kolyshkin
2021-01-20  0:18 ` Kir Kolyshkin
2021-01-20  0:18 ` [PATCH 01/10] docs/scheduler/sched-bwc: formatting fix Kir Kolyshkin
2021-01-20  0:18   ` Kir Kolyshkin
2021-01-20  0:18 ` [PATCH 02/10] docs/scheduler/sched-design-CFS: " Kir Kolyshkin
2021-01-20  0:18 ` [PATCH 03/10] docs/scheduler/sched-bwc: fix note rendering Kir Kolyshkin
2021-01-20  0:18 ` [PATCH 04/10] docs/scheduler/sched-bwc: add proper ref Kir Kolyshkin
2021-01-20  0:18   ` Kir Kolyshkin
2021-01-20 17:43   ` Jonathan Corbet [this message]
2021-01-20 17:43     ` Jonathan Corbet
2021-01-20  0:18 ` [PATCH 05/10] docs/scheduler/sched-bwc: note/link cgroup v2 Kir Kolyshkin
2021-01-20  0:18   ` Kir Kolyshkin
2021-01-20  0:18 ` [PATCH 06/10] docs/admin-guide: cgroup-v2: typos and spaces Kir Kolyshkin
2021-01-20  0:18   ` Kir Kolyshkin
2021-01-20  0:18 ` [PATCH 07/10] docs/admin-guide: cgroup-v2: fix cgroup.type rendering Kir Kolyshkin
2021-01-20  0:18 ` [PATCH 08/10] doc/admin-guide/cgroup-v2: use tables Kir Kolyshkin
2021-01-20  0:18 ` [PATCH 09/10] docs/admin-guide/cgroup-v2: nit Kir Kolyshkin
2021-01-20  0:18   ` Kir Kolyshkin
2021-01-20  0:18 ` [PATCH 10/10] docs/admin-guide/cgroup-v2: fix mount opt rendering Kir Kolyshkin
2021-01-20  0:18   ` Kir Kolyshkin
2021-01-20 16:43 ` [PATCH 00/10] docs: cgroup nits and fixes Tejun Heo
2021-01-20 16:43   ` Tejun Heo
2021-01-21 18:42   ` Jonathan Corbet
2021-01-21 18:42     ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210120104301.2aeda8f9@lwn.net \
    --to=corbet@lwn.net \
    --cc=cgroups@vger.kernel.org \
    --cc=kolyshkin@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.