All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] powerpc: Fix build error in paravirt.h
@ 2021-01-20 13:28 ` Michal Suchanek
  0 siblings, 0 replies; 4+ messages in thread
From: Michal Suchanek @ 2021-01-20 13:28 UTC (permalink / raw)
  To: linuxppc-dev
  Cc: Michal Suchanek, Juergen Gross, Deep Shah, VMware, Inc.,
	Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Waiman Long, Srikar Dronamraju, virtualization, linux-kernel

./arch/powerpc/include/asm/paravirt.h:83:44: error: implicit declaration
of function 'smp_processor_id'; did you mean 'raw_smp_processor_id'?

smp_processor_id is defined in linux/smp.h but it is not included.

The build error happens only when the patch is applied to 5.3 kernel but
it only works by chance in mainline.

Fixes: ca3f969dcb11 ("powerpc/paravirt: Use is_kvm_guest() in vcpu_is_preempted()")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 arch/powerpc/include/asm/paravirt.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/include/asm/paravirt.h b/arch/powerpc/include/asm/paravirt.h
index edc08f04aef7..5d1726bb28e7 100644
--- a/arch/powerpc/include/asm/paravirt.h
+++ b/arch/powerpc/include/asm/paravirt.h
@@ -10,6 +10,7 @@
 #endif
 
 #ifdef CONFIG_PPC_SPLPAR
+#include <linux/smp.h>
 #include <asm/kvm_guest.h>
 #include <asm/cputhreads.h>
 
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] powerpc: Fix build error in paravirt.h
@ 2021-01-20 13:28 ` Michal Suchanek
  0 siblings, 0 replies; 4+ messages in thread
From: Michal Suchanek @ 2021-01-20 13:28 UTC (permalink / raw)
  To: linuxppc-dev
  Cc: Juergen Gross, Srikar Dronamraju, Deep Shah, VMware, Inc.,
	linux-kernel, virtualization, Paul Mackerras, Waiman Long,
	Michal Suchanek

./arch/powerpc/include/asm/paravirt.h:83:44: error: implicit declaration
of function 'smp_processor_id'; did you mean 'raw_smp_processor_id'?

smp_processor_id is defined in linux/smp.h but it is not included.

The build error happens only when the patch is applied to 5.3 kernel but
it only works by chance in mainline.

Fixes: ca3f969dcb11 ("powerpc/paravirt: Use is_kvm_guest() in vcpu_is_preempted()")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 arch/powerpc/include/asm/paravirt.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/include/asm/paravirt.h b/arch/powerpc/include/asm/paravirt.h
index edc08f04aef7..5d1726bb28e7 100644
--- a/arch/powerpc/include/asm/paravirt.h
+++ b/arch/powerpc/include/asm/paravirt.h
@@ -10,6 +10,7 @@
 #endif
 
 #ifdef CONFIG_PPC_SPLPAR
+#include <linux/smp.h>
 #include <asm/kvm_guest.h>
 #include <asm/cputhreads.h>
 
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] powerpc: Fix build error in paravirt.h
  2021-01-20 13:28 ` Michal Suchanek
@ 2021-02-03 11:40   ` Michael Ellerman
  -1 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2021-02-03 11:40 UTC (permalink / raw)
  To: linuxppc-dev, Michal Suchanek
  Cc: Deep Shah, Juergen Gross, VMware, Inc.,
	linux-kernel, Srikar Dronamraju, virtualization, Waiman Long,
	Paul Mackerras

On Wed, 20 Jan 2021 14:28:38 +0100, Michal Suchanek wrote:
> ./arch/powerpc/include/asm/paravirt.h:83:44: error: implicit declaration
> of function 'smp_processor_id'; did you mean 'raw_smp_processor_id'?
> 
> smp_processor_id is defined in linux/smp.h but it is not included.
> 
> The build error happens only when the patch is applied to 5.3 kernel but
> it only works by chance in mainline.

Applied to powerpc/next.

[1/1] powerpc: Fix build error in paravirt.h
      https://git.kernel.org/powerpc/c/9899a56f1eca964cd0de21008a9fa1523a571231

cheers

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] powerpc: Fix build error in paravirt.h
@ 2021-02-03 11:40   ` Michael Ellerman
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2021-02-03 11:40 UTC (permalink / raw)
  To: linuxppc-dev, Michal Suchanek
  Cc: Juergen Gross, Srikar Dronamraju, Deep Shah, VMware, Inc.,
	linux-kernel, virtualization, Paul Mackerras, Waiman Long

On Wed, 20 Jan 2021 14:28:38 +0100, Michal Suchanek wrote:
> ./arch/powerpc/include/asm/paravirt.h:83:44: error: implicit declaration
> of function 'smp_processor_id'; did you mean 'raw_smp_processor_id'?
> 
> smp_processor_id is defined in linux/smp.h but it is not included.
> 
> The build error happens only when the patch is applied to 5.3 kernel but
> it only works by chance in mainline.

Applied to powerpc/next.

[1/1] powerpc: Fix build error in paravirt.h
      https://git.kernel.org/powerpc/c/9899a56f1eca964cd0de21008a9fa1523a571231

cheers

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-03 12:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-20 13:28 [PATCH] powerpc: Fix build error in paravirt.h Michal Suchanek
2021-01-20 13:28 ` Michal Suchanek
2021-02-03 11:40 ` Michael Ellerman
2021-02-03 11:40   ` Michael Ellerman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.