[block:for-5.12/io_uring 28/34] fs/file.c:738:5: warning: no previous prototype for function '__close_fd_get_file'

[block:for-5.12/io_uring 28/34] fs/file.c:738:5: warning: no previous prototype for function '__close_fd_get_file'

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2747 bytes --]

Hi Jens,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-5.12/io_uring
head:   ddebaa7f62a202b40378a5a71d1a51737277d773
commit: 5af393d9a934d576bb13e45eac17ed5c1129a2f6 [28/34] fs: provide locked helper variant of close_fd_get_file()
config: x86_64-randconfig-a002-20210120 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 22b68440e1647e16b5ee24b924986207173c02d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?id=5af393d9a934d576bb13e45eac17ed5c1129a2f6
        git remote add block https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
        git fetch --no-tags block for-5.12/io_uring
        git checkout 5af393d9a934d576bb13e45eac17ed5c1129a2f6
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> fs/file.c:738:5: warning: no previous prototype for function '__close_fd_get_file' [-Wmissing-prototypes]
   int __close_fd_get_file(unsigned int fd, struct file **res)
       ^
   fs/file.c:738:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __close_fd_get_file(unsigned int fd, struct file **res)
   ^
   static 
   1 warning generated.


vim +/__close_fd_get_file +738 fs/file.c

   733	
   734	/*
   735	 * See close_fd_get_file() below, this variant assumes current->files->file_lock
   736	 * is held.
   737	 */
 > 738	int __close_fd_get_file(unsigned int fd, struct file **res)
   739	{
   740		struct files_struct *files = current->files;
   741		struct file *file;
   742		struct fdtable *fdt;
   743	
   744		fdt = files_fdtable(files);
   745		if (fd >= fdt->max_fds)
   746			goto out_err;
   747		file = fdt->fd[fd];
   748		if (!file)
   749			goto out_err;
   750		rcu_assign_pointer(fdt->fd[fd], NULL);
   751		__put_unused_fd(files, fd);
   752		get_file(file);
   753		*res = file;
   754		return 0;
   755	out_err:
   756		*res = NULL;
   757		return -ENOENT;
   758	}
   759	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41675 bytes --]