All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <p.yadav@ti.com>
To: u-boot@lists.denx.de
Subject: [PATCH 0/2] Console/stdio use after free
Date: Thu, 21 Jan 2021 00:29:38 +0530	[thread overview]
Message-ID: <20210120185936.lz3czug3ku6xhmit@ti.com> (raw)
In-Reply-To: <CAPnjgZ2M74u8FiM8t0X8WmkrGOQr_CLk5efS7fd3n+m9vSzTVA@mail.gmail.com>

On 20/01/21 07:18AM, Simon Glass wrote:
> Hi Nicolas,
> 
> On Wed, 20 Jan 2021 at 07:04, Nicolas Saenz Julienne
> <nsaenzjulienne@suse.de> wrote:
> >
> > With today's master, 70c2525c0d3c ('IOMUX: Stop dropped consoles')
> > introduces a use after free in usb_kbd_remove():
> >
> > - usbkbd's stdio device is de-registered with stdio_deregister_dev(),
> >   the struct stdio_dev is freed.
> >
> > - iomux_doenv() is called, usbkbd removed from the console list, and
> >   console_stop() is called on the struct stdio_dev pointer that no
> >   longer exists.
> >
> > This series mitigates this by making sure the pointer is really a stdio
> > device prior performing the stop operation. It's not ideal, but I
> > couldn't figure out a nicer way to fix this.
> 
> Your 'from' address is coming through as just your email. Could you
> please update it to include your name as well?

From shows the full name on my email client. For everybody apart from 
Nicholas it shows just the email, but for Nicholas I can see full name 
in both From and Cc.

Maybe something wrong with your email client settings.
 
> Regards,
> Simon

-- 
Regards,
Pratyush Yadav
Texas Instruments India

  parent reply	other threads:[~2021-01-20 18:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 14:04 [PATCH 0/2] Console/stdio use after free Nicolas Saenz Julienne
2021-01-20 14:04 ` [PATCH 1/2] stdio: Introduce stdio_valid() Nicolas Saenz Julienne
2021-01-24  2:03   ` Simon Glass
2021-01-25 16:34     ` Nicolas Saenz Julienne
2021-01-27 20:13       ` Tom Rini
2021-01-20 14:04 ` [PATCH 2/2] console: Don't start/stop console if stdio device invalid Nicolas Saenz Julienne
2021-01-24  2:03   ` Simon Glass
2021-01-20 14:18 ` [PATCH 0/2] Console/stdio use after free Simon Glass
2021-01-20 14:44   ` Nicolas Saenz Julienne
2021-01-20 14:59     ` Simon Glass
2021-01-20 18:59   ` Pratyush Yadav [this message]
2021-01-20 19:54     ` Simon Glass
2021-01-20 15:57 ` Andy Shevchenko
2021-01-25 16:31   ` Nicolas Saenz Julienne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210120185936.lz3czug3ku6xhmit@ti.com \
    --to=p.yadav@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.