All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Pawel Dembicki <paweldembicki@gmail.com>, netdev@vger.kernel.org
Cc: kbuild-all@lists.01.org, Linus Wallej <linus.walleij@linaro.org>,
	Pawel Dembicki <paweldembicki@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dsa: vsc73xx: add support for vlan filtering
Date: Wed, 20 Jan 2021 23:04:25 +0800	[thread overview]
Message-ID: <202101202242.tVSnpX8b-lkp@intel.com> (raw)
In-Reply-To: <20210120063019.1989081-1-paweldembicki@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 6064 bytes --]

Hi Pawel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net/master]
[also build test WARNING on net-next/master ipvs/master linus/master v5.11-rc4 next-20210120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Pawel-Dembicki/dsa-vsc73xx-add-support-for-vlan-filtering/20210120-161228
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 8e4052c32d6b4b39c1e13c652c7e33748d447409
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1b3778a3f0b1d668f4fa289c82997ebbd2145178
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Pawel-Dembicki/dsa-vsc73xx-add-support-for-vlan-filtering/20210120-161228
        git checkout 1b3778a3f0b1d668f4fa289c82997ebbd2145178
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/net/dsa/vitesse-vsc73xx-core.c: In function 'vsc73xx_port_set_vlan_unaware':
>> drivers/net/dsa/vitesse-vsc73xx-core.c:686:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709535231' to '4294950911' [-Woverflow]
     686 |        ~VSC73XX_MAC_CFG_VLAN_AWR);
   drivers/net/dsa/vitesse-vsc73xx-core.c:689:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709518847' to '4294934527' [-Woverflow]
     689 |        ~VSC73XX_MAC_CFG_VLAN_DBLAWR);
   drivers/net/dsa/vitesse-vsc73xx-core.c:698:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551613' to '4294967293' [-Woverflow]
     698 |        ~VSC73XX_CAT_DROP_TAGGED_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c:701:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551611' to '4294967291' [-Woverflow]
     701 |        ~VSC73XX_CAT_DROP_UNTAGGED_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c: In function 'vsc73xx_port_set_vlan_aware':
   drivers/net/dsa/vitesse-vsc73xx-core.c:716:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709518847' to '4294934527' [-Woverflow]
     716 |        ~VSC73XX_MAC_CFG_VLAN_DBLAWR);
   drivers/net/dsa/vitesse-vsc73xx-core.c:719:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551359' to '4294967039' [-Woverflow]
     719 |        ~VSC73XX_CAT_VLAN_MISC_VLAN_TCI_IGNORE_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c:722:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551487' to '4294967167' [-Woverflow]
     722 |        ~VSC73XX_CAT_VLAN_MISC_VLAN_KEEP_TAG_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c:725:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551613' to '4294967293' [-Woverflow]
     725 |        ~VSC73XX_CAT_DROP_TAGGED_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c:734:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551607' to '4294967287' [-Woverflow]
     734 |        ~VSC73XX_TXUPDCFG_TX_UNTAGGED_VID_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c: In function 'vsc73xx_port_vlan_add':
   drivers/net/dsa/vitesse-vsc73xx-core.c:811:9: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551611' to '4294967291' [-Woverflow]
     811 |         ~VSC73XX_CAT_DROP_UNTAGGED_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c: In function 'vsc73xx_port_vlan_del':
   drivers/net/dsa/vitesse-vsc73xx-core.c:848:9: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551607' to '4294967287' [-Woverflow]
     848 |         ~VSC73XX_TXUPDCFG_TX_UNTAGGED_VID_ENA);


vim +686 drivers/net/dsa/vitesse-vsc73xx-core.c

   678	
   679	static int vsc73xx_port_set_vlan_unaware(struct dsa_switch *ds, int port)
   680	{
   681		struct vsc73xx *vsc = ds->priv;
   682		int ret;
   683	
   684		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_MAC_CFG,
   685				    VSC73XX_MAC_CFG_VLAN_AWR,
 > 686				    ~VSC73XX_MAC_CFG_VLAN_AWR);
   687		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_MAC_CFG,
   688				    VSC73XX_MAC_CFG_VLAN_DBLAWR,
   689				    ~VSC73XX_MAC_CFG_VLAN_DBLAWR);
   690		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_CAT_VLAN_MISC,
   691				    VSC73XX_CAT_VLAN_MISC_VLAN_TCI_IGNORE_ENA,
   692				    VSC73XX_CAT_VLAN_MISC_VLAN_TCI_IGNORE_ENA);
   693		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_CAT_VLAN_MISC,
   694				    VSC73XX_CAT_VLAN_MISC_VLAN_KEEP_TAG_ENA,
   695				    VSC73XX_CAT_VLAN_MISC_VLAN_KEEP_TAG_ENA);
   696		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_CAT_DROP,
   697				    VSC73XX_CAT_DROP_TAGGED_ENA,
   698				    ~VSC73XX_CAT_DROP_TAGGED_ENA);
   699		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_CAT_DROP,
   700				    VSC73XX_CAT_DROP_UNTAGGED_ENA,
   701				    ~VSC73XX_CAT_DROP_UNTAGGED_ENA);
   702	
   703		ret = vsc73xx_port_update_vlan_table(ds, port, 0, 4095, 0);
   704		return ret;
   705	}
   706	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 72481 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] dsa: vsc73xx: add support for vlan filtering
Date: Wed, 20 Jan 2021 23:04:25 +0800	[thread overview]
Message-ID: <202101202242.tVSnpX8b-lkp@intel.com> (raw)
In-Reply-To: <20210120063019.1989081-1-paweldembicki@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 6158 bytes --]

Hi Pawel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net/master]
[also build test WARNING on net-next/master ipvs/master linus/master v5.11-rc4 next-20210120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Pawel-Dembicki/dsa-vsc73xx-add-support-for-vlan-filtering/20210120-161228
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 8e4052c32d6b4b39c1e13c652c7e33748d447409
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1b3778a3f0b1d668f4fa289c82997ebbd2145178
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Pawel-Dembicki/dsa-vsc73xx-add-support-for-vlan-filtering/20210120-161228
        git checkout 1b3778a3f0b1d668f4fa289c82997ebbd2145178
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/net/dsa/vitesse-vsc73xx-core.c: In function 'vsc73xx_port_set_vlan_unaware':
>> drivers/net/dsa/vitesse-vsc73xx-core.c:686:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709535231' to '4294950911' [-Woverflow]
     686 |        ~VSC73XX_MAC_CFG_VLAN_AWR);
   drivers/net/dsa/vitesse-vsc73xx-core.c:689:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709518847' to '4294934527' [-Woverflow]
     689 |        ~VSC73XX_MAC_CFG_VLAN_DBLAWR);
   drivers/net/dsa/vitesse-vsc73xx-core.c:698:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551613' to '4294967293' [-Woverflow]
     698 |        ~VSC73XX_CAT_DROP_TAGGED_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c:701:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551611' to '4294967291' [-Woverflow]
     701 |        ~VSC73XX_CAT_DROP_UNTAGGED_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c: In function 'vsc73xx_port_set_vlan_aware':
   drivers/net/dsa/vitesse-vsc73xx-core.c:716:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709518847' to '4294934527' [-Woverflow]
     716 |        ~VSC73XX_MAC_CFG_VLAN_DBLAWR);
   drivers/net/dsa/vitesse-vsc73xx-core.c:719:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551359' to '4294967039' [-Woverflow]
     719 |        ~VSC73XX_CAT_VLAN_MISC_VLAN_TCI_IGNORE_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c:722:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551487' to '4294967167' [-Woverflow]
     722 |        ~VSC73XX_CAT_VLAN_MISC_VLAN_KEEP_TAG_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c:725:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551613' to '4294967293' [-Woverflow]
     725 |        ~VSC73XX_CAT_DROP_TAGGED_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c:734:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551607' to '4294967287' [-Woverflow]
     734 |        ~VSC73XX_TXUPDCFG_TX_UNTAGGED_VID_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c: In function 'vsc73xx_port_vlan_add':
   drivers/net/dsa/vitesse-vsc73xx-core.c:811:9: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551611' to '4294967291' [-Woverflow]
     811 |         ~VSC73XX_CAT_DROP_UNTAGGED_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c: In function 'vsc73xx_port_vlan_del':
   drivers/net/dsa/vitesse-vsc73xx-core.c:848:9: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551607' to '4294967287' [-Woverflow]
     848 |         ~VSC73XX_TXUPDCFG_TX_UNTAGGED_VID_ENA);


vim +686 drivers/net/dsa/vitesse-vsc73xx-core.c

   678	
   679	static int vsc73xx_port_set_vlan_unaware(struct dsa_switch *ds, int port)
   680	{
   681		struct vsc73xx *vsc = ds->priv;
   682		int ret;
   683	
   684		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_MAC_CFG,
   685				    VSC73XX_MAC_CFG_VLAN_AWR,
 > 686				    ~VSC73XX_MAC_CFG_VLAN_AWR);
   687		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_MAC_CFG,
   688				    VSC73XX_MAC_CFG_VLAN_DBLAWR,
   689				    ~VSC73XX_MAC_CFG_VLAN_DBLAWR);
   690		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_CAT_VLAN_MISC,
   691				    VSC73XX_CAT_VLAN_MISC_VLAN_TCI_IGNORE_ENA,
   692				    VSC73XX_CAT_VLAN_MISC_VLAN_TCI_IGNORE_ENA);
   693		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_CAT_VLAN_MISC,
   694				    VSC73XX_CAT_VLAN_MISC_VLAN_KEEP_TAG_ENA,
   695				    VSC73XX_CAT_VLAN_MISC_VLAN_KEEP_TAG_ENA);
   696		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_CAT_DROP,
   697				    VSC73XX_CAT_DROP_TAGGED_ENA,
   698				    ~VSC73XX_CAT_DROP_TAGGED_ENA);
   699		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_CAT_DROP,
   700				    VSC73XX_CAT_DROP_UNTAGGED_ENA,
   701				    ~VSC73XX_CAT_DROP_UNTAGGED_ENA);
   702	
   703		ret = vsc73xx_port_update_vlan_table(ds, port, 0, 4095, 0);
   704		return ret;
   705	}
   706	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 72481 bytes --]

  reply	other threads:[~2021-01-20 15:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  6:30 [PATCH] dsa: vsc73xx: add support for vlan filtering Pawel Dembicki
2021-01-20 15:04 ` kernel test robot [this message]
2021-01-20 15:04   ` kernel test robot
2021-01-21 22:45 ` Vladimir Oltean
2021-01-24 23:19   ` Linus Walleij
2021-01-24 23:45     ` Vladimir Oltean
2021-01-25 13:25       ` Linus Walleij
2021-01-25  7:17   ` Paweł Dembicki
2021-01-28  0:37     ` Vladimir Oltean
2021-07-27 11:57       ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202101202242.tVSnpX8b-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kuba@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=paweldembicki@gmail.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.