All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] drm/vmwgfx: Make sure we unpin no longer needed buffers
@ 2021-01-20 17:50 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-01-20 17:50 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 7655 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210119193102.505691-1-zackr@vmware.com>
References: <20210119193102.505691-1-zackr@vmware.com>
TO: Zack Rusin <zackr@vmware.com>
TO: dri-devel(a)lists.freedesktop.org
CC: Martin Krastev <krastevm@vmware.com>
CC: Roland Scheidegger <sroland@vmware.com>

Hi Zack,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master v5.11-rc4 next-20210120]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Zack-Rusin/drm-vmwgfx-Make-sure-we-unpin-no-longer-needed-buffers/20210120-143229
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago
config: x86_64-randconfig-m031-20210120 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/gpu/drm/vmwgfx/vmwgfx_mob.c:649 vmw_mob_bind() error: we previously assumed 'mob->pt_bo' could be null (see line 619)

Old smatch warnings:
include/drm/ttm/ttm_bo_driver.h:466 ttm_bo_reserve() warn: inconsistent returns '*bo->base.resv'.

vim +649 drivers/gpu/drm/vmwgfx/vmwgfx_mob.c

3530bdc35e99c382 Thomas Hellstrom  2012-11-21  578  
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  579  /*
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  580   * vmw_mob_bind - Make a mob visible to the device after first
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  581   *                populating it if necessary.
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  582   *
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  583   * @dev_priv:       Pointer to a device private.
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  584   * @mob:            Pointer to the mob we're making visible.
0fd53cfb09108c33 Thomas Hellstrom  2013-10-24  585   * @data_addr:      Array of DMA addresses to the data pages of the underlying
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  586   *                  buffer object.
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  587   * @num_data_pages: Number of data pages of the underlying buffer
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  588   *                  object.
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  589   * @mob_id:         Device id of the mob to bind
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  590   *
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  591   * This function is intended to be interfaced with the ttm_tt backend
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  592   * code.
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  593   */
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  594  int vmw_mob_bind(struct vmw_private *dev_priv,
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  595  		 struct vmw_mob *mob,
0fd53cfb09108c33 Thomas Hellstrom  2013-10-24  596  		 const struct vmw_sg_table *vsgt,
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  597  		 unsigned long num_data_pages,
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  598  		 int32_t mob_id)
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  599  {
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  600  	int ret;
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  601  	bool pt_set_up = false;
0fd53cfb09108c33 Thomas Hellstrom  2013-10-24  602  	struct vmw_piter data_iter;
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  603  	struct {
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  604  		SVGA3dCmdHeader header;
3e894a6259964618 Thomas Hellstrom  2014-01-20  605  		SVGA3dCmdDefineGBMob64 body;
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  606  	} *cmd;
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  607  
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  608  	mob->id = mob_id;
0fd53cfb09108c33 Thomas Hellstrom  2013-10-24  609  	vmw_piter_start(&data_iter, vsgt, 0);
0fd53cfb09108c33 Thomas Hellstrom  2013-10-24  610  	if (unlikely(!vmw_piter_next(&data_iter)))
0fd53cfb09108c33 Thomas Hellstrom  2013-10-24  611  		return 0;
0fd53cfb09108c33 Thomas Hellstrom  2013-10-24  612  
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  613  	if (likely(num_data_pages == 1)) {
f2a0dcb1aa23eea8 Thomas Hellstrom  2014-01-15  614  		mob->pt_level = VMW_MOBFMT_PTDEPTH_0;
0fd53cfb09108c33 Thomas Hellstrom  2013-10-24  615  		mob->pt_root_page = vmw_piter_dma_addr(&data_iter);
0fd53cfb09108c33 Thomas Hellstrom  2013-10-24  616  	} else if (vsgt->num_regions == 1) {
0fd53cfb09108c33 Thomas Hellstrom  2013-10-24  617  		mob->pt_level = SVGA3D_MOBFMT_RANGE;
0fd53cfb09108c33 Thomas Hellstrom  2013-10-24  618  		mob->pt_root_page = vmw_piter_dma_addr(&data_iter);
3530bdc35e99c382 Thomas Hellstrom  2012-11-21 @619  	} else if (unlikely(mob->pt_bo == NULL)) {
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  620  		ret = vmw_mob_pt_populate(dev_priv, mob);
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  621  		if (unlikely(ret != 0))
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  622  			return ret;
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  623  
0fd53cfb09108c33 Thomas Hellstrom  2013-10-24  624  		vmw_mob_pt_setup(mob, data_iter, num_data_pages);
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  625  		pt_set_up = true;
f2a0dcb1aa23eea8 Thomas Hellstrom  2014-01-15  626  		mob->pt_level += VMW_MOBFMT_PTDEPTH_1 - SVGA3D_MOBFMT_PTDEPTH_1;
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  627  	}
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  628  
153b3d5b037eeb01 Thomas Hellstrom  2015-06-25  629  	vmw_fifo_resource_inc(dev_priv);
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  630  
11c454196610ae25 Deepak Rawat      2019-02-14  631  	cmd = VMW_FIFO_RESERVE(dev_priv, sizeof(*cmd));
11c454196610ae25 Deepak Rawat      2019-02-14  632  	if (unlikely(cmd == NULL))
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  633  		goto out_no_cmd_space;
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  634  
3e894a6259964618 Thomas Hellstrom  2014-01-20  635  	cmd->header.id = SVGA_3D_CMD_DEFINE_GB_MOB64;
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  636  	cmd->header.size = sizeof(cmd->body);
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  637  	cmd->body.mobid = mob_id;
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  638  	cmd->body.ptDepth = mob->pt_level;
b9eb1a6174e58eb8 Thomas Hellstrom  2015-04-02  639  	cmd->body.base = mob->pt_root_page >> PAGE_SHIFT;
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  640  	cmd->body.sizeInBytes = num_data_pages * PAGE_SIZE;
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  641  
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  642  	vmw_fifo_commit(dev_priv, sizeof(*cmd));
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  643  
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  644  	return 0;
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  645  
3530bdc35e99c382 Thomas Hellstrom  2012-11-21  646  out_no_cmd_space:
153b3d5b037eeb01 Thomas Hellstrom  2015-06-25  647  	vmw_fifo_resource_dec(dev_priv);
6034d9d48e62a0bf Thomas Zimmermann 2019-01-25  648  	if (pt_set_up) {
acaabaa177a5df6a Zack Rusin        2021-01-19 @649  		ttm_bo_unpin(mob->pt_bo);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35639 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/vmwgfx: Make sure we unpin no longer needed buffers
  2021-01-19 19:35 ` Daniel Vetter
@ 2021-01-19 19:36   ` Daniel Vetter
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2021-01-19 19:36 UTC (permalink / raw)
  To: Zack Rusin; +Cc: Martin Krastev, Roland Scheidegger, dri-devel

On Tue, Jan 19, 2021 at 8:35 PM Daniel Vetter <daniel@ffwll.ch> wrote:
>
> On Tue, Jan 19, 2021 at 8:31 PM Zack Rusin <zackr@vmware.com> wrote:
> >
> > We were not correctly unpinning no longer needed buffers. In particular
> > vmw_buffer_object, which is internally often pinned on creation wasn't
> > unpinned on destruction and none of the internal MOB buffers were
> > unpinned before being put back. Technically this existed for a
> > long time but 57fcd550eb15bce14a7154736379dfd4ed60ae81 introduced

Also this one should be replaced by the output of dim cite <sha1>, but
I think dim doesn't check for these.
-Daniel

> > a WARN_ON which was filling up the kernel logs rather quickly.
> >
> > Quite frankly internal usage of vmw_buffer_object and in general
> > pinning needs to be refactored in vmwgfx but for now this makes
> > it work.
> >
> > Signed-off-by: Zack Rusin <zackr@vmware.com>
> > Reviewed-by: Martin Krastev <krastevm@vmware.com>
> > Reviewed-by: Roland Scheidegger <sroland@vmware.com>
> > Fixes: 57fcd550eb15bce14a7154736379dfd4ed60ae81
>
> dim will balk on this (or should at least)
>
> $ dim fixes <sha1>
>
> should give you the recommend thing.
> -Daniel
>
> > ---
> >  drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 ++
> >  drivers/gpu/drm/vmwgfx/vmwgfx_mob.c | 4 ++++
> >  2 files changed, 6 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
> > index b45becbb00f8..73225ab691e6 100644
> > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
> > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
> > @@ -1554,6 +1554,8 @@ static inline void vmw_bo_unreference(struct vmw_buffer_object **buf)
> >
> >         *buf = NULL;
> >         if (tmp_buf != NULL) {
> > +               if (tmp_buf->base.pin_count > 0)
> > +                       ttm_bo_unpin(&tmp_buf->base);
> >                 ttm_bo_put(&tmp_buf->base);
> >         }
> >  }
> > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_mob.c b/drivers/gpu/drm/vmwgfx/vmwgfx_mob.c
> > index 7f95ed6aa224..3c6e69f36767 100644
> > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_mob.c
> > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_mob.c
> > @@ -277,6 +277,7 @@ static int vmw_otable_batch_setup(struct vmw_private *dev_priv,
> >                                                  &batch->otables[i]);
> >         }
> >
> > +       ttm_bo_unpin(batch->otable_bo);
> >         ttm_bo_put(batch->otable_bo);
> >         batch->otable_bo = NULL;
> >         return ret;
> > @@ -342,6 +343,7 @@ static void vmw_otable_batch_takedown(struct vmw_private *dev_priv,
> >         vmw_bo_fence_single(bo, NULL);
> >         ttm_bo_unreserve(bo);
> >
> > +       ttm_bo_unpin(batch->otable_bo);
> >         ttm_bo_put(batch->otable_bo);
> >         batch->otable_bo = NULL;
> >  }
> > @@ -528,6 +530,7 @@ static void vmw_mob_pt_setup(struct vmw_mob *mob,
> >  void vmw_mob_destroy(struct vmw_mob *mob)
> >  {
> >         if (mob->pt_bo) {
> > +               ttm_bo_unpin(mob->pt_bo);
> >                 ttm_bo_put(mob->pt_bo);
> >                 mob->pt_bo = NULL;
> >         }
> > @@ -643,6 +646,7 @@ int vmw_mob_bind(struct vmw_private *dev_priv,
> >  out_no_cmd_space:
> >         vmw_fifo_resource_dec(dev_priv);
> >         if (pt_set_up) {
> > +               ttm_bo_unpin(mob->pt_bo);
> >                 ttm_bo_put(mob->pt_bo);
> >                 mob->pt_bo = NULL;
> >         }
> > --
> > 2.27.0
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch



-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/vmwgfx: Make sure we unpin no longer needed buffers
  2021-01-19 19:31 Zack Rusin
@ 2021-01-19 19:35 ` Daniel Vetter
  2021-01-19 19:36   ` Daniel Vetter
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2021-01-19 19:35 UTC (permalink / raw)
  To: Zack Rusin; +Cc: Martin Krastev, Roland Scheidegger, dri-devel

On Tue, Jan 19, 2021 at 8:31 PM Zack Rusin <zackr@vmware.com> wrote:
>
> We were not correctly unpinning no longer needed buffers. In particular
> vmw_buffer_object, which is internally often pinned on creation wasn't
> unpinned on destruction and none of the internal MOB buffers were
> unpinned before being put back. Technically this existed for a
> long time but 57fcd550eb15bce14a7154736379dfd4ed60ae81 introduced
> a WARN_ON which was filling up the kernel logs rather quickly.
>
> Quite frankly internal usage of vmw_buffer_object and in general
> pinning needs to be refactored in vmwgfx but for now this makes
> it work.
>
> Signed-off-by: Zack Rusin <zackr@vmware.com>
> Reviewed-by: Martin Krastev <krastevm@vmware.com>
> Reviewed-by: Roland Scheidegger <sroland@vmware.com>
> Fixes: 57fcd550eb15bce14a7154736379dfd4ed60ae81

dim will balk on this (or should at least)

$ dim fixes <sha1>

should give you the recommend thing.
-Daniel

> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 ++
>  drivers/gpu/drm/vmwgfx/vmwgfx_mob.c | 4 ++++
>  2 files changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
> index b45becbb00f8..73225ab691e6 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
> @@ -1554,6 +1554,8 @@ static inline void vmw_bo_unreference(struct vmw_buffer_object **buf)
>
>         *buf = NULL;
>         if (tmp_buf != NULL) {
> +               if (tmp_buf->base.pin_count > 0)
> +                       ttm_bo_unpin(&tmp_buf->base);
>                 ttm_bo_put(&tmp_buf->base);
>         }
>  }
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_mob.c b/drivers/gpu/drm/vmwgfx/vmwgfx_mob.c
> index 7f95ed6aa224..3c6e69f36767 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_mob.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_mob.c
> @@ -277,6 +277,7 @@ static int vmw_otable_batch_setup(struct vmw_private *dev_priv,
>                                                  &batch->otables[i]);
>         }
>
> +       ttm_bo_unpin(batch->otable_bo);
>         ttm_bo_put(batch->otable_bo);
>         batch->otable_bo = NULL;
>         return ret;
> @@ -342,6 +343,7 @@ static void vmw_otable_batch_takedown(struct vmw_private *dev_priv,
>         vmw_bo_fence_single(bo, NULL);
>         ttm_bo_unreserve(bo);
>
> +       ttm_bo_unpin(batch->otable_bo);
>         ttm_bo_put(batch->otable_bo);
>         batch->otable_bo = NULL;
>  }
> @@ -528,6 +530,7 @@ static void vmw_mob_pt_setup(struct vmw_mob *mob,
>  void vmw_mob_destroy(struct vmw_mob *mob)
>  {
>         if (mob->pt_bo) {
> +               ttm_bo_unpin(mob->pt_bo);
>                 ttm_bo_put(mob->pt_bo);
>                 mob->pt_bo = NULL;
>         }
> @@ -643,6 +646,7 @@ int vmw_mob_bind(struct vmw_private *dev_priv,
>  out_no_cmd_space:
>         vmw_fifo_resource_dec(dev_priv);
>         if (pt_set_up) {
> +               ttm_bo_unpin(mob->pt_bo);
>                 ttm_bo_put(mob->pt_bo);
>                 mob->pt_bo = NULL;
>         }
> --
> 2.27.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel



-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] drm/vmwgfx: Make sure we unpin no longer needed buffers
@ 2021-01-19 19:31 Zack Rusin
  2021-01-19 19:35 ` Daniel Vetter
  0 siblings, 1 reply; 4+ messages in thread
From: Zack Rusin @ 2021-01-19 19:31 UTC (permalink / raw)
  To: dri-devel; +Cc: Martin Krastev, Roland Scheidegger

We were not correctly unpinning no longer needed buffers. In particular
vmw_buffer_object, which is internally often pinned on creation wasn't
unpinned on destruction and none of the internal MOB buffers were
unpinned before being put back. Technically this existed for a
long time but 57fcd550eb15bce14a7154736379dfd4ed60ae81 introduced
a WARN_ON which was filling up the kernel logs rather quickly.

Quite frankly internal usage of vmw_buffer_object and in general
pinning needs to be refactored in vmwgfx but for now this makes
it work.

Signed-off-by: Zack Rusin <zackr@vmware.com>
Reviewed-by: Martin Krastev <krastevm@vmware.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Fixes: 57fcd550eb15bce14a7154736379dfd4ed60ae81
---
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 ++
 drivers/gpu/drm/vmwgfx/vmwgfx_mob.c | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
index b45becbb00f8..73225ab691e6 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
@@ -1554,6 +1554,8 @@ static inline void vmw_bo_unreference(struct vmw_buffer_object **buf)
 
 	*buf = NULL;
 	if (tmp_buf != NULL) {
+		if (tmp_buf->base.pin_count > 0)
+			ttm_bo_unpin(&tmp_buf->base);
 		ttm_bo_put(&tmp_buf->base);
 	}
 }
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_mob.c b/drivers/gpu/drm/vmwgfx/vmwgfx_mob.c
index 7f95ed6aa224..3c6e69f36767 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_mob.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_mob.c
@@ -277,6 +277,7 @@ static int vmw_otable_batch_setup(struct vmw_private *dev_priv,
 						 &batch->otables[i]);
 	}
 
+	ttm_bo_unpin(batch->otable_bo);
 	ttm_bo_put(batch->otable_bo);
 	batch->otable_bo = NULL;
 	return ret;
@@ -342,6 +343,7 @@ static void vmw_otable_batch_takedown(struct vmw_private *dev_priv,
 	vmw_bo_fence_single(bo, NULL);
 	ttm_bo_unreserve(bo);
 
+	ttm_bo_unpin(batch->otable_bo);
 	ttm_bo_put(batch->otable_bo);
 	batch->otable_bo = NULL;
 }
@@ -528,6 +530,7 @@ static void vmw_mob_pt_setup(struct vmw_mob *mob,
 void vmw_mob_destroy(struct vmw_mob *mob)
 {
 	if (mob->pt_bo) {
+		ttm_bo_unpin(mob->pt_bo);
 		ttm_bo_put(mob->pt_bo);
 		mob->pt_bo = NULL;
 	}
@@ -643,6 +646,7 @@ int vmw_mob_bind(struct vmw_private *dev_priv,
 out_no_cmd_space:
 	vmw_fifo_resource_dec(dev_priv);
 	if (pt_set_up) {
+		ttm_bo_unpin(mob->pt_bo);
 		ttm_bo_put(mob->pt_bo);
 		mob->pt_bo = NULL;
 	}
-- 
2.27.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-01-20 17:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-20 17:50 [PATCH] drm/vmwgfx: Make sure we unpin no longer needed buffers kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2021-01-19 19:31 Zack Rusin
2021-01-19 19:35 ` Daniel Vetter
2021-01-19 19:36   ` Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.