* [PATCH] memory: ti-aemif: Drop child node when jumping out loop
@ 2021-01-21 9:03 Pan Bian
2021-01-25 19:20 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Pan Bian @ 2021-01-21 9:03 UTC (permalink / raw)
To: Santosh Shilimkar, Krzysztof Kozlowski, Greg Kroah-Hartman,
Murali Karicheri, Ivan Khoronzhuk
Cc: linux-kernel, Pan Bian
Call of_node_put() to decrement the reference count of the child node
child_np when jumping out of the loop body of
for_each_available_child_of_node(), which is a macro that increments and
decrements the reference count of child node. If the loop is broken, the
reference of the child node should be dropped manually.
Fixes: 5a7c81547c1d ("memory: ti-aemif: introduce AEMIF driver")
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/memory/ti-aemif.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/memory/ti-aemif.c b/drivers/memory/ti-aemif.c
index 159a16f5e7d6..51d20c2ccb75 100644
--- a/drivers/memory/ti-aemif.c
+++ b/drivers/memory/ti-aemif.c
@@ -378,8 +378,10 @@ static int aemif_probe(struct platform_device *pdev)
*/
for_each_available_child_of_node(np, child_np) {
ret = of_aemif_parse_abus_config(pdev, child_np);
- if (ret < 0)
+ if (ret < 0) {
+ of_node_put(child_np);
goto error;
+ }
}
} else if (pdata && pdata->num_abus_data > 0) {
for (i = 0; i < pdata->num_abus_data; i++, aemif->num_cs++) {
@@ -405,8 +407,10 @@ static int aemif_probe(struct platform_device *pdev)
for_each_available_child_of_node(np, child_np) {
ret = of_platform_populate(child_np, NULL,
dev_lookup, dev);
- if (ret < 0)
+ if (ret < 0) {
+ of_node_put(child_np);
goto error;
+ }
}
} else if (pdata) {
for (i = 0; i < pdata->num_sub_devices; i++) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] memory: ti-aemif: Drop child node when jumping out loop
2021-01-21 9:03 [PATCH] memory: ti-aemif: Drop child node when jumping out loop Pan Bian
@ 2021-01-25 19:20 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-01-25 19:20 UTC (permalink / raw)
To: Pan Bian
Cc: Santosh Shilimkar, Greg Kroah-Hartman, Murali Karicheri,
Ivan Khoronzhuk, linux-kernel
On Thu, Jan 21, 2021 at 01:03:59AM -0800, Pan Bian wrote:
> Call of_node_put() to decrement the reference count of the child node
> child_np when jumping out of the loop body of
> for_each_available_child_of_node(), which is a macro that increments and
> decrements the reference count of child node. If the loop is broken, the
> reference of the child node should be dropped manually.
>
> Fixes: 5a7c81547c1d ("memory: ti-aemif: introduce AEMIF driver")
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
> drivers/memory/ti-aemif.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-25 19:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 9:03 [PATCH] memory: ti-aemif: Drop child node when jumping out loop Pan Bian
2021-01-25 19:20 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.