* [LTP] [PATCH 1/1] configure.ac: More descriptive NUMA error message
@ 2021-01-21 10:22 Petr Vorel
2021-01-21 15:35 ` Enji Cooper
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2021-01-21 10:22 UTC (permalink / raw)
To: ltp
Some people were confused and searched for libnuma.so.2,
which does not exist.
Required is libnuma.so.1, but with LIBNUMA_API_VERSION >= 2.
The API version is tighten to libnuma version in git, but that has
nothing to do with library soname version, which is still 1.0.0.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index e44e25cc6..521a2e835 100644
--- a/configure.ac
+++ b/configure.ac
@@ -347,7 +347,7 @@ LTP_CHECK_SYSCALL_FCNTL
if test "x$with_numa" = xyes; then
LTP_CHECK_SYSCALL_NUMA
- numa_error_msg="test requires libnuma >= 2 and it's development packages"
+ numa_error_msg="test requires libnuma1 with LIBNUMA_API_VERSION >= 2 and it's development packages"
else
numa_error_msg="NUMA support was disabled during build"
fi
--
2.30.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH 1/1] configure.ac: More descriptive NUMA error message
2021-01-21 10:22 [LTP] [PATCH 1/1] configure.ac: More descriptive NUMA error message Petr Vorel
@ 2021-01-21 15:35 ` Enji Cooper
2021-01-21 16:31 ` Cyril Hrubis
0 siblings, 1 reply; 3+ messages in thread
From: Enji Cooper @ 2021-01-21 15:35 UTC (permalink / raw)
To: ltp
Typo: ?it?s? should be ?its?. Otherwise, ship it!
Reviewed-by: Enji Cooper <yaneurabeya@gmail.com>
> On Jan 21, 2021, at 02:23, Petr Vorel <pvorel@suse.cz> wrote:
>
> ?Some people were confused and searched for libnuma.so.2,
> which does not exist.
>
> Required is libnuma.so.1, but with LIBNUMA_API_VERSION >= 2.
> The API version is tighten to libnuma version in git, but that has
> nothing to do with library soname version, which is still 1.0.0.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index e44e25cc6..521a2e835 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -347,7 +347,7 @@ LTP_CHECK_SYSCALL_FCNTL
>
> if test "x$with_numa" = xyes; then
> LTP_CHECK_SYSCALL_NUMA
> - numa_error_msg="test requires libnuma >= 2 and it's development packages"
> + numa_error_msg="test requires libnuma1 with LIBNUMA_API_VERSION >= 2 and it's development packages"
> else
> numa_error_msg="NUMA support was disabled during build"
> fi
> --
> 2.30.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
* [LTP] [PATCH 1/1] configure.ac: More descriptive NUMA error message
2021-01-21 15:35 ` Enji Cooper
@ 2021-01-21 16:31 ` Cyril Hrubis
0 siblings, 0 replies; 3+ messages in thread
From: Cyril Hrubis @ 2021-01-21 16:31 UTC (permalink / raw)
To: ltp
Hi!
In the end we pushed slightly different message:
https://github.com/linux-test-project/ltp/commit/2faab87c57be093114652d5dd684c33c7015dddc
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-21 16:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 10:22 [LTP] [PATCH 1/1] configure.ac: More descriptive NUMA error message Petr Vorel
2021-01-21 15:35 ` Enji Cooper
2021-01-21 16:31 ` Cyril Hrubis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.